Skip to content

docs(cron): accept keeping a server whose start-up sign-in failed - #17121

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
unstablebrainiac:docs/cron-signin-failure-tradeoff
Oct 6, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
unstablebrainiac:docs/cron-signin-failure-tradeoff

Conversation

@unstablebrainiac

@unstablebrainiac unstablebrainiac commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The cron spec says whether keeping a script cron's MCP server after a failed start-up sign-in is accepted, as the #16905 approval asked.

Since #16905, a call the MCP server answers with a tool error keeps the run's server. That includes a server whose start-up sign-in failed and that reports the failure as a tool error: it stays for the rest of the run instead of being restarted. The approval on #16905 asked: "say in the spec whether you accept it."

Why it matters

Without the sentence, a reader of the spec cannot tell whether this failure mode is known and chosen, or an oversight.

Not a goal

  • Changing when a kept server is stopped or replaced. The sentences describe what the code already does.
  • Retrying a failed sign-in from KiroCrew.

What changed (motivation → approach → change)

The "Script-mode MCP server lifetime" bullet in docs/system-specs/modules/learn-cron-dashboard.md gains three sentences: keeping such a server is accepted. The server's own retry rules decide when it signs in again. A server that never retries fails only until the run ends, because the next run starts fresh servers. Restarting it after each such error would sign in again at once, which is the repeated sign-in that keeping servers avoids.

The Slack server behind #16659 recovers within the run: after a failed sign-in it fails calls fast until a cooldown passes (Slack's Retry-After, capped at five minutes), then signs in again on the next call.

Backwards compatibility

Compatible: documentation only, no code changes.

Removes nothing: one spec bullet gains three sentences.

Tests

N/A, documentation only. The behaviour the sentences describe is already pinned by test_a_tool_error_keeps_its_server_for_the_next_call in test/test_cron_script.py. The docs tests that read this spec pass (480 tests in the six test files that name it).

Manual verification

N/A, documentation only: the sentences restate tested behaviour and add no new claim about the code.

Related Issues

Refs #16659

Follow-up to #16905: the Design note its approval asked to answer in the spec.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@unstablebrainiac
unstablebrainiac requested a review from a team as a code owner October 5, 2026 19:48
@github-actions github-actions Bot added readiness: checking Automated validation is still running fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed d4f9794b51996cbd491623939fbd57ff8d5ae9c8 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] d4f9794

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed d4f9794b51996cbd491623939fbd57ff8d5ae9c8 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] d4f9794

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of d4f9794b51996cbd491623939fbd57ff8d5ae9c8 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] d4f9794

Description read

[DESCRIPTION-READ] 8c70a5cdcd760f4c099619d6a7396b46ed7de2a91343131f3cffc24c2cca93dd

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@unstablebrainiac
unstablebrainiac force-pushed the docs/cron-signin-failure-tradeoff branch from 056affe to 7da8bb1 Compare October 5, 2026 23:11
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 5, 2026
@unstablebrainiac
unstablebrainiac force-pushed the docs/cron-signin-failure-tradeoff branch from 7da8bb1 to c652118 Compare October 6, 2026 01:11
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 6, 2026
…accepted

A server whose start-up sign-in failed and that reports it as a tool error is kept for the rest of the run since kirodotdev#16905. The spec now says that this is accepted and why: the server's own retry rules decide when it signs in again, the next run starts fresh servers, and restarting it after each error would sign in again at once.

Refs kirodotdev#16659
@unstablebrainiac
unstablebrainiac force-pushed the docs/cron-signin-failure-tradeoff branch from c652118 to d4f9794 Compare October 6, 2026 02:06
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 6, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving (crew-pr-reviewer). One spec sentence group in learn-cron-dashboard.md. It states that keeping a script cron's MCP server after a failed start-up sign-in is accepted, and why. That answers the question the #16905 approval asked. Docs only. CI is green and the base is main.

@iamwhatever
iamwhatever merged commit 4f67fb6 into kirodotdev:main Oct 6, 2026
113 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants