Repository navigation
fix(prepare-pr): print each whole-design lane's punchline - #17128
unstablebrainiac wants to merge 1 commit into
Conversation
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS A maintainer must clear Sensitive Change Review for the two new [DESIGN-REVIEWED] 0405bcc Description read[DESCRIPTION-READ] 035f9568b3ac3ff0550a1b66915802f28489323c48274bc6ef6fb11f38612140 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that the exit‑0 path really skips What this change shipsInventory (7 items) — 7 justifiedIntent: a FIX. An agent running kirocrew-prepare-pr should see each whole-design lane's punchline, including the one ask a PASS carries, without a maintainer passing it on (#17103).
[FIRST-PRINCIPLES-REVIEWED] 0405bcc Description read[DESCRIPTION-READ] d903b209fbac8add86d429343a6d4d1dc863f2d10d9c5aa274f23ada5ea59ff0 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
24261e8 to
b7a00c2
Compare
b7a00c2 to
c15c3db
Compare
The Design, First Principles and UX lanes write one bold punchline under their verdict line. On a PASS it is the one thing a human should still verify before merge, and no item section carries it, so pr_findings.py and pr_status.py never showed it. Both now print it, skipping 'Nothing to check.'. Exit codes do not change. Closes kirodotdev#17103
c15c3db to
0405bcc
Compare
|
Reviewed, not approving (crew-pr-reviewer). This touches |
|
@iamwhatever No file in the repo names a security owner: The posture change adds two entries to |
|
Reviewed on the maintainers' behalf (sweep 2026-10-06): diff read in full, no regression (redact moved verbatim, exit codes unchanged, CI consumer path unaffected). Because this fork PR touches |
Problem / Motivation
Goal: An agent driving kirocrew-prepare-pr sees each whole-design lane's punchline, so a PASS lane's one ask reaches it instead of reading as nothing to do.
The Design, First Principles and UX lanes write one bold punchline right under their verdict line. On a PASS it is the one thing a human should still verify before merge, or
Nothing to check.. No item section carries it, and neitherpr_findings.pynorpr_status.pyprinted it, so a PASS lane read as having nothing to say. On #16661 and #16905 the approving maintainer had to ask for the PASS punchline in the approval (#17103).Why it matters
SKILL.md says a PASS must still be answered, but the loop never saw the ask. The point then reached the author only through a maintainer, after the PR was otherwise done.
Not a goal
span=id or adding it to the disposition universe.--reviewerspin lists among the marker rows.What changed (motivation → approach → change)
Both scripts now print the punchline of every whole-design lane stamped for the current head, and skip
Nothing to check..pr_findings.pyDESIGN: verdict=PASS, then the "no items" linepunchline: <sentence>under the verdict, and a line saying a PASS punchline still needs an answerpr_status.py--reviewers gpt,opusWhole-design punchlinesblock printed every cycle: one line per lane with its verdict, or(none to check on this head)when no lane has a punchlinelane_punchlinein_review_contract.pyreads the punchline the way the lane workflows' own CONCERNS digest does: the first text after the verdict line. It takes the whole paragraph, so a wrapped punchline survives, and strips one enclosing bold pair. A heading or a stamp in that place means the lane wrote none.design_lane_punchlinesapplies it to the lanes_fresh_design_bodiesalready selects, so freshness and lane identity followdesign_lane_verdictsexactly.pr_status.pyreads the lane bodies itself rather than the marker rows, because a pinned fleet lists no whole-design lane there. It prints the text through the sameredactandsanitizeaspr_findings.py, and labels the block untrusted. For that,redactand its patterns move byte for byte frompr_findings.pyinto_review_contract.py, both scripts bind that one definition, andtest/test_redaction_mirror_parity.pypins the patterns in their new home. SKILL.md names the printed punchline where it says a PASS must still be answered, and its two exit-0 steps now say to answer the punchlines before Phase 4.docs/ci/ci-and-reviews.mdrecords the reader beside the lane output contract.src/kiro_crew/security_posture.pylists_review_contract.pyandpr_status.pybesidepr_findings.pyinNON_EGRESS_REDACTION_MODULES, because its omission test requires every module that calls a redactor to be classified. That file is on #16862's sensitive-path list, so the Sensitive Change Review check cannot pass from this fork.Backwards compatibility
Compatible: both scripts only add output lines. On #16034, #16039, #16661, #16905 and #16952 both scripts exit with the same code as on main, and no existing line changes.
Reader: src/kiro_crew/builtin_skills/kirocrew-dev/kirocrew-prepare-pr/scripts/pr_findings.py:redact -- chat -- the definition moves to
_review_contract.pybyte for byte andpr_findings.pybindsredact = _review_contract.redact, so its call sites are unchanged;test_prepare_pr_findings.py::TestCredentialRedaction. No other code on main importspr_findings.py.Tests
test_lane_punchline_reads_the_paragraph_under_the_verdict(8 cases) intest/test_prepare_pr_findings.py: a bold line, an unbolded line, a wrapped paragraph, the rest of the verdict line skipped, inner bold kept as written, a heading, a stamp, and nothing at all.test_a_pass_lane_prints_its_punchline_as_its_one_ask,test_a_concerns_punchline_prints_without_the_pass_hintandtest_nothing_to_check_prints_no_punchline: whatpr_findings.pyprints in each case.test_only_a_lane_stamped_for_the_head_contributes_a_punchline: a stale stamp contributes nothing.test_a_pinned_fleet_still_prints_the_whole_design_punchlinesintest/test_prepare_pr_status.py: under--reviewers GPT,OPUSthe block shows the Design PASS punchline and the exit code stays 0.test_a_pinned_fleet_redacts_a_token_in_a_whole_design_punchlineandtest_a_token_in_a_punchline_is_redacted: a GitHub token in a punchline prints as[REDACTED]in each script.design_lane_punchlinesandredactin both entry points, andtest/test_redaction_mirror_parity.pyreads the patterns from_review_contract.py.test/test_security_posture.py::TestOmissionDetectionpasses with the two new entries and fails, naming the module, when either is removed.Each of 17 single breaks of the change turns at least one of these red: an empty reader, the
Nothing to check.filter dropped, bold never stripped, one line instead of the paragraph, a heading or a stamp read as the punchline, the verdict line's own tail read, the inner-bold guard dropped, a blank line ending the paragraph early,pr_findings.pyprinting nothing, the PASS hint on every lane or on none,pr_status.pyreading only the pinned marker rows, the block removed, either script printing the punchline unredacted, andpr_status.pybinding a no-op redactor.Manual verification
Ran both scripts from this branch and from main against #16034, #16039, #16661, #16905 and #16952.
pr_findings.py 16905now prints the Design and First Principles PASS punchlines the #16905 approval asked about.pr_status.py 16034 --reviewers gpt,opusprints the Design PASS and First Principles CONCERNS punchlines. Exit codes matched main on all five, and the only output difference was the added lines.Related Issues
Closes #17103
Pattern harvest
Not generalizable: the verdict line, the punchline and the item sections are the whole lane output contract, and with this change each one has a reader in
_review_contract.py.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)