Repository navigation
feat(chat): reserve the chat pane in every view and cue clipped board lanes - #17136
Conversation
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that a maintainer accepts the list-view chat-pane reserve: it reverses #14870's choice that the list views reserve only the nav rail, and the test that pinned that choice is rewritten. [DESIGN-REVIEWED] 1c8d8bb Description read[DESCRIPTION-READ] c32f7802e222bb36b4fd07e54a298e68632668c19072a0acd20899ab1bbf6217 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS No first-time reader has looked at the board edge fade or the narrower list-view sidebar. Every state is shown in screenshots, but this fork review can't go higher than CONCERNS without that read. Watch
[UX-REVIEWED] 1c8d8bb Description read[DESCRIPTION-READ] c5bdaab0b7aaa67b51142c332e3733c00a18c5361d6db2efce29f45d012c45b5 That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check one thing before merge: the list views now reserve the chat pane's minimum, which reverses #14870's pin "the list views reserve only the nav rail, as the drawer's own clamp does". What this change shipsInventory (5 items) — 5 justifiedIntent: let list view on a narrow window keep the chat pane at its 320 px minimum, and show that board lanes continue past a clipped edge. This is an ADDITION (two small behaviour changes).
[FIRST-PRINCIPLES-REVIEWED] 1c8d8bb Description read[DESCRIPTION-READ] 5a878822c7e9da1bfd8c8089e09349ea63ebc23df42041d84fafc2d8fd162459 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
b10f615 to
5eb6830
Compare
5eb6830 to
b0ac45b
Compare
|
Dispositions for the reviews of b10f615 and 5eb6830. New head b0ac45b (still #14870's commit plus one). Design, First Principles, UX, GPT and Opus on b10f615, the source hunks were missing: fixed on 5eb6830. All five were right: b10f615 carried only the new test and the screenshots. 5eb6830 added the UX on 5eb6830, a light-theme fade reads as a greyed-out lane: fixed on b0ac45b. Each fade now carries a small chevron chip ( UX, the list-view evidence gap: the description now has a list-view frame per theme at 1200 px with a saved 1400: the sidebar paints at 644 px (1200 - 236 - 320). UX, cold read: a blind read is a maintainer-run step that the author cannot do from a fork. Design PASS note, the First Principles PASS note, #14870's commit rides along: yes, by design while #14870 is open. Once it merges this PR shows only the second commit. |
b0ac45b to
af34fbe
Compare
|
Dispositions for the UX review of b0ac45b. New head af34fbe. UX Watch 1, the chevron chip looks like a button but does nothing: fixed with the second option you gave. The border, the elevated fill and the shadow are gone, so each cue draws a bare UX Watch 2, confusion with the "Older Sessions" chevron: settled by the same change. The cue's chevron is a muted glyph inside a fade, at the strip's edge. UX, cold read: a blind read is a maintainer-run step that the author cannot do from a fork. Backend Tests (Windows) (1) on b0ac45b: |
af34fbe to
4c1f0b8
Compare
|
Disposition for the UX review of ff3aa42. New head 592629a. UX Watch, "faded lane controls are still clickable": fixed with the suggested smallest fix. The fade stays pointer-transparent, so the strip still scrolls, drags and drops under it. Each lane header control (new folder, edit tags, add lane, delete lane) that overlaps an active fade band is now marked The logic is in the new The summary's other point, that no first-time reader has looked at the fade, is the blind read the same-repo lane runs; a fork head cannot trigger it, so it waits on a maintainer, as answered on 5215f38. |
592629a to
599e247
Compare
599e247 to
ab7d40b
Compare
|
Dispositions for the First Principles and UX reviews of 599e247. New head ab7d40b (one commit). First Principles item 3, "oversized": accepted, subtraction applied. The lane fade is now the session tab strip's cue, UX Watch, "controls inside the fade do nothing when clicked": fixed by the same change. No control is disabled under the fade any more, and the 24 px band is narrow enough that the controls it overlaps stay legible, so nothing that looks clickable ignores a click. Frames 1 to 4 still show the earlier 64 px band; they are being recaptured on this head. CI on 599e247: |
ab7d40b to
81903f0
Compare
|
New head 81903f0: same code as ab7d40b, with frames 1 to 4 recaptured on the 24 px fade, as the earlier disposition promised. Each recaptured frame asserts that the strip is clipped ( |
|
Dispositions for the Design, First Principles and UX reviews of 81903f0. No code change; the description is corrected. Design "Phantom description", First Principles item 5, UX Watch 1: accepted, fixed in the description. The stale sentences came from the earlier 64 px design that the ab7d40b subtraction removed. On keyboard focus under the band: the band is 24 px, the same as the session tab strip's cue, and it does not cover a lane's UX Watch 2, "the cue is faint": no change. The cue matches the session tab strip's, so a reader meets one edge cue across the app. The review rates it low severity and narrow-window only, and says the cue works where text is clipped. A lane whose edge falls in empty card space still has its header clipped at the strip edge, since every lane carries a header row. |
81903f0 to
6fded08
Compare
|
ai-review-disposition target=ux head=1cfc5e36e83c4c1646796719b21140798caa1026 Watch 2 (the edge cue is faint): fixed on 1cfc5e3. The earlier reply held parity with the session tab strip, but that parity does not hold here. The tab strip's tabs sit on
Watch 1 (focus under the band): no change. The existing reply still applies: the band is 24 px, the controls under it stay legible and take clicks, and the strip scrolls natively. |
|
ai-review-disposition target=ux head=66d5224b61be5f84c862bdd709aa83a88b5eb5e6 UX Review on Watch 1: the light-theme fade is subtle, and no cold reader has seen it. No change on this head, following the lane's own remedy: raise the alpha only if a blind read shows a cold reader misses the cue.
Watch 2: a saved list-view width paints narrower on a small window, with no sign it was capped. This is the PR's Goal, and no change is made.
|
|
Rebased onto main UX Watch on
On the new head: |
… lanes The sidebar paint leaves the chat pane its CHAT_PANE_MIN_W minimum in the list views too, not only in board view, so every view beside a chat pane shares one paint rule. The mobile drawer and the sessions embed still reserve no chat pane (fillsHost). The board's lane strip paints an edge fade on any edge that hides lanes (useScrollEdges, the session tab strip's measurement), so a lane clipped by a narrow window reads as more to scroll to. The fade is a 24 px band, the session tab strip's width, pointer-transparent and aria-hidden, so the lane controls it overlaps stay legible and clickable. It fades from the foreground colour at 15 percent alpha, not from the page background: the lanes are cards, and in light theme the card and the page background are both near white, so a fade from the background shows nothing over them. The feature map's Sessions row describes both.
|
UX Review on Watch 2: the fade also tints the gaps outside the cards. Fixed with the lane's smallest step. Both cues are now
Watch 1: no first-time reader has seen the fade. Held, as in the earlier reply. The fade is the session tab strip's cue at the same width, and the clipped lane's own cut-off content is a second sign. The blind read the lane asks for runs only when a maintainer pushes this branch to this repository, so that step needs a maintainer. If a cold reader misses the cue, raising the alpha is a one-token change. On this head: |
|
UX Review on Watch 1: the light-theme fade is faint and no first-time reader has seen it. Held, as in the earlier reply. The fade is the session tab strip's cue at the same width, and the cut-off lane is a second sign. The first-time read this lane asks for runs only when a maintainer pushes the branch to this repository, so that step is a maintainer's. If that read misses the cue, raising the alpha is a one-token change. Watch 2: list view gets narrower on narrow windows. Intended, and it is the first item of this PR's Goal: on a 1200 px window a saved 1400 now paints at 644 px so the chat pane keeps its 320 px minimum, where it used to paint at 964 px and leave the chat pane nothing. The saved width is kept and a wider window paints it again. That is the line under No new head for this reply: every other check on |
|
Reviewed, not approving (crew-pr-reviewer). This is a layout behaviour change in every view. A maintainer or design owner should accept it. |
iamwhatever
left a comment
There was a problem hiding this comment.
Approving after a deeper pass (crew-pr-reviewer). The list views now keep the chat pane's 320 px minimum, as board view already does. A narrow window no longer gives the chat pane 0 px, and the lane strip shows an edge fade when lanes are clipped. It is layout only, and Design and First Principles lanes PASS. Non-blocking UX note: the light-theme fade is faint, so a quick check on a real light theme would help. CI is green and the base is main.
Follow-up to #14870.
#14870 has merged, and this branch is rebased onto main, so the diff holds only this PR's change: the chat-pane reserve in every view and the board lane-strip edge cue. A maintainer asked during #14870's review for these two changes to be judged on their own.
Problem / Motivation
Goal: Two board and sidebar changes that #14870 does not need for its own Goal (a board-view sidebar wider than 1400 px):
CHAT_PANE_MIN_Wminimum, as board view does on feat(chat): let the board-view sidebar grow past 1400px on wide windows #14870. On feat(chat): let the board-view sidebar grow past 1400px on wide windows #14870 the list views reserve only the nav rail, so on a 1200 px window a saved 1400 paints at 1200 - 236 = 964 px in list view and the chat pane gets 0 px past its minimum; board view on the same window paints 644 px beside a 320 px chat pane. Here both views paint 644 px.Why it matters
A narrow window in list view should not take the chat pane below the minimum the side panel and the drawer already hold it to elsewhere. On the board, a clipped lane reads as the end of the board, so a user does not know to scroll.
Not a goal
bg, so their fade frombgshows; this strip's lanes arebg-card, which is why its fade starts from the foreground instead.Screenshots / video
Committed under
temp-screenshots/14853-board-strip-edge-cue/, since a fork cannot attach media from the CLI. Captured from the repo's isolated sidebar capture entry (website/capture/lane-folder-hide.html, the realChatSidebar, four fixture sessions, three state lanes that each hold every fixture session, API answered byscripts/lib/stub-dashboard-api.mjs, vite dev server on 127.0.0.1) at a 1200 px viewport, with a headless Chromium that asserted each state before the shot. Frames 1 to 4 were captured from this head's code (the 24 px fade fromtext-strongat 15 percent alpha, inset to the strip'sp-2padding), each asserting that the strip is clipped, that only the expected edge carries a cue, that the cue is 24 px wide, pointer-transparent and holds no control, and that its top meets the first card's top and its bottom stays inside the strip's padding. In the enlarged crops the gutter row above the cards stays flat across the cue's width (dark 30 to 31, light 248 to 250), so the cue shades only the clipped lane. The enlarged right-edge frames were checked by pixel across the last 60 device px of a row in empty card space: light theme runs 255 down to 223 (it ran 255 to 254 with the earlier fade frombg), dark theme runs 30 up to 59 (it ran 30 down to 23); the list-view frames (5) are fromaf34fbe85, whose list-view paint this head keeps unchanged. Board frames have the sidebar at 520 px: stripscrollWidth692,clientWidth518, one lane step 228 px (a 220 px lane plus the 8 px gap).column-strip-cue-rightpresent, left absent). The band shades the clipped lane toward the edge, and its header and titles stay legible under it.scrollLeft174): the fade moves to the left edge where the first lane is now clipped, and the right edge is clear.mc-sidebar-widthof 1400: the sidebar paints at 644 px (1200 - 236 px nav rail - 320 px chat pane minimum). The dashed box marks the 556 px left for the nav rail and the chat pane; the capture entry renders the sidebar alone, so that box is drawn over the frame, not part of the app.What changed (motivation → approach → change)
sidebarRoomWidthroom feat(chat): let the board-view sidebar grow past 1400px on wide windows #14870 uses for board view; the cue is theuseScrollEdgeshook the session tab strip already uses.chat-sidebar/resize.ts:chatMinisCHAT_PANE_MIN_Win every view beside a chat pane (fillsHosthosts still reserve none).ChatPagealready seats the drawer at the width the sidebar reports it paints at, so it needs no change.ChatSidebar.tsx: thecolumn-stripscroller is measured withuseScrollEdges(scroll events, a box observer, a re-measure when the column count changes), and each edge that hides lanes gets a pointer-transparent,aria-hiddenfade. The fade is the session tab strip's 24 px band (w-6), so the lane controls it overlaps stay legible and take clicks. It starts fromtext-strongat 15 percent alpha (from-text-strong/15 to-transparent), not frombgasSessionTabStrip.tsxdoes: the lanes arebg-card, and in light themebg-cardandbgare both near white, so a fade frombgshows nothing over them. The foreground contrasts with the card in every theme. The cue is fade-only, as the other scroll strips' cues are: the strip scrolls natively, and an arrow there would look like the follow-up bar's scroll buttons while a click on it fell through to the row underneath. The strip has no scroll padding and no control is disabled under the fade.chat/sidebarWidth.ts: theclampSidebarWidthdoc says every view beside a chat pane leaves it its minimum.docs/feature-map/README.md: the Sessions row describes the chat-pane reserve in every view beside a chat pane and the board lane strip's edge fade.Backwards compatibility
Compatible: no stored key or format changes. A saved list-view width on a narrow window paints narrower than on #14870 (beside a minimum chat pane) and stays saved, so a wider window paints it again.
Tests
website/src/test/ChatSidebar.resizeTouch.test.tsx: at 1200 px a saved 1400 and a saved 1401 paint at 1200 - rail - 320 in list view and in board view, and in both viewsaria-valuemaxand a drag pushed far right stop at the smaller of 1400 and that room. The list-view case fails on main before this change, where the list views reserve only the rail.website/src/test/ChatSidebar.boardStripEdgeCue.test.tsx(new): no cue while every lane fits; a right cue only while a lane is clipped past the right edge; a left cue only once the strip is scrolled to its end; both cues arearia-hiddenand pointer-transparent, and the right one is 24 px wide (w-6) and draws no arrow or control; both fade from the foreground token, not frombg; a fourth lane that overflows the strip with no scroll or resize event marks the right edge. The edge cases fail without the cue, the new-lane case fails without the column-count re-measure, the left-cue case fails without itspointer-events-none, and the colour assertions fail with the fade frombg.Run locally on this head (on main f6d32b5):
npx tsc -b,npx eslinton the changed files,check-phantom-classes,check-theme-colors,check-restyle-ratchetandscripts/check_feature_map.pyclean; vitest undersrc/test/ChatSidebar*: 110 files, 1140 tests passed, including the new cue-inset case for both edges, which fails without the inset. The earlier rebase onto 0d885e6 resolved one conflict, this PR's sentence in the feature map's Sessions row, kept unchanged beside main's new row-model pointer. On the same commit on main 397f4be the same vitest set passed (109 files, 1138 tests). On the same commit before that (on main 3343351):npx eslinton the changed files,check-phantom-classes,check-theme-colorsandcheck-restyle-ratchet: clean; vitest undersrc/test/ChatSidebar*,src/test/ChatPage*,clampSidebarWidthandsidePanelFillWidth: 192 files, 2106 tests passed.integration/ChatSidebarTags.integration.test.tsx(clicks the lane edit control): 27 passed.scripts/check_feature_map.pyagainst origin/main: passes. The board-column Playwright specs (session-tags-folders,session-tags-e2e, which prime a stored 1400 on an 1800 px viewport, so the strip paints at the 1244 px room) ran and passed in CI's Playwright suite on head 4c1f0b8, whose paint this head keeps (job; the harness fails on any skipped spec).Manual verification
The 1200 px capture runs above, in light and dark theme, were the manual check: each asserted the clipped strip, the cue on the right edge only, that the cue is a fade with no arrow or control, and, once the strip was scrolled to its end, the cue on the left edge only.
Related Issues
Part of #14853
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); one commitContribution License Agreement