Repository navigation
Conversation
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS With the key off, check that the picker's two same-name What this change shipsInventory (3 items) — 3 justifiedIntent: let someone pick a crewmate that has its own memory from the chat picker when a shared template has the same name. This is a FIX.
The base test comment said "both are the same binding". The description quotes that claim and refutes it. Its rebuttal matches the base code: [FIRST-PRINCIPLES-REVIEWED] 49b6e20 Description read[DESCRIPTION-READ] 0f9845aacc0f2499d0ecd1f9e0ec53fe6a2d869efdd3d30f20bee4ea578b2bf3 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the picker's two same-name [DESIGN-REVIEWED] 49b6e20 Description read[DESCRIPTION-READ] 2863ebea668392154e9a7898f863adc2ead87952b62d30c22a924689e99cf8c2 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The picker now lists two rows both called "grain", and the only thing separating them is the group headers. No first-time reader has checked whether that's enough. Watch
[UX-REVIEWED] 49b6e20 Description read[DESCRIPTION-READ] aaef15ca05406e33431a5374ad23f446881c91058ebbb6c3a18569303c396f32 That sha256 names everything this verdict read: the PR description, plus the 4 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
c6e5ef1 to
4d7e3ff
Compare
4d7e3ff to
0d24888
Compare
|
For the UX evidence gap: I can capture the picker state this review asks for — config key off, a crewmate with its own memory beside a same-name template, both group headers visible, the template row highlighted for a bound session — as a still from the built SPA using the repository's gateway-free fixture helpers. Say the word and I will attach it here, or drop it under temp-screenshots/ as the lane prefers. On the watch item: the two same-name rows are the intended state of this PR, and the roster avatar plus the group header are the only existing cues. If the capture shows that is not enough to tell the rows apart, I will follow with a small label change rather than argue it. |
0d24888 to
cf71649
Compare
withoutCoveredCrewmates withheld a crewmate whenever a template of the same name was listed, on the premise that picking the template is the same binding. It is not: a template pick binds the shared default store, so the crewmate's own memory became unreachable from the picker and every pick of that name ran on shared memory. Cover only a crewmate with no memory of its own that runs a listed template. Screenshot evidence:  Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
cf71649 to
49b6e20
Compare
|
Automated verification report — kirocrew-steward. The picker repair remains unpublished while the required build gate is red on main. The PR worktree at Their regenerated index previews are byte-identical (SHA-256 The focused picker/Mate verification passed 16 tests. No generated index change, gate override, or source push was made for this inherited failure. Existing index maintenance PRs #18753 and #18803 address earlier staleness; neither has yet been verified to cover the current Topic tags omission. Next: wait for a current-main index repair, rebase, and rerun the unchanged build gate and remaining prepare-pr checks. |
|
Thank you @Premshay for finding and fixing this. Your change has landed in a main-repo PR, #19304, ported onto current main (the conflict was with the Closing this PR in favour of #19304. Your branch is left untouched. |
Problem / Motivation
Goal: a crewmate with its own memory can be picked from the chat agent picker even when a shared template of the same name is installed.
With
dashboard.crewmates_in_agent_pickeroff (the default),withoutCoveredCrewmateswithholds a crewmate whenever a template of the same name is listed. Its comment says picking that template is the identical binding. It is not: a template pick sendsagent_kind: "template", and the session binds the shareddefaultstore with no member identity.Why it matters
When an install has a crewmate
grain(own memory store) and a shared templategrain.json, the picker offers only the template. Every session opened from the picker under that name runs on shared memory: it cannot recall the crewmate's lessons, and anything it saves lands in the shared store. Nothing in the UI shows this. We found four working sessions in this state, by reading each one's execution context (selection_kind='template',member_id=None, storedefault).Not a goal
dashboard.crewmates_in_agent_picker.What changed
withoutCoveredCrewmatescovers a crewmate only when it has no memory of its own (memory_store === 'default') and runs a listed template. That is the one case where a template pick is the same binding (the built-indefaultcrew).crew-mode.mdand the feature map describe the narrower rule.Backwards compatibility
Compatible. A crewmate that was withheld only because of a shared name now appears under Crewmates. The folded name-only
agentslist, the request contract and the config key are unchanged.Tests
useAgents.hideCrewmates.test.tsx:reviewermember (own memory) now stays beside thereviewertemplate.useAgentsandAgentDropdownListsuites.tsc --noEmitanddocs-lintpass.Pattern harvest
A name collision between a crewmate and a shared template is not proof the bindings are identical: a template pick binds the shared
defaultstore with no member identity, while a crewmate pick binds the member's own memory. Picker coverage checks must compare the binding, not the name.Screenshot evidence: