Repository navigation
Conversation
First Principles Review (Opus 5.5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The search miss now carries a number, Not justified as shipped
What this change shipsInventory (3 items) — 2 justifiedIntent: when an agent has a mapped skill scope, a
[FIRST-PRINCIPLES-REVIEWED] e751494 Description read[DESCRIPTION-READ] 1e02f2768a75c7158e8d9f6fd3040f333523bfd1a8df88232be4422f2fc97be9 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS
Watch
[DESIGN-REVIEWED] e751494 Description read[DESCRIPTION-READ] 6712e05a38050a93d8523b46e158d4554c3dc31f55ebc16609d66a2ca170f890 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed Review detailsOne advisory finding; nothing blocks the merge. FINDING — src/kiro_crew/dashboard/handlers/prompts.py:2380 — [OPUS-REVIEWED] e751494 |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
A session whose agent maps skill:// resources searches only those, but a miss read 'No skills matched', which agents took to mean the skill is not installed. The gateway route now returns scope_size for a mapped scope, and the tool names it in the no-match message. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
6a7ea55 to
e751494
Compare
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
|
Thank you @Premshay for this fix and the clear write-up. Your commit now lands through #19299, a branch on the main repository so CI could run with repository permissions. It is the same change, rebased onto current main, with you kept as the commit author (plus a Closing this one in favour of #19299. Your branch is left untouched. |
Problem / Motivation
Goal: when
skill_searchfinds nothing in an agent's mapped skill scope, the message says so, instead of reading as "this skill is not installed".A session whose agent declares
skill://resources searches only those (session_skill_globs). A miss returned:babysitwas installed. It was simply outside the agent's mapping. Agents read the message as "the skill does not exist" and either gave up or tried more keywords, none of which can match.Why it matters
The message is the only signal the agent gets, and it points the wrong way: "try broader keywords" cannot succeed for a skill outside the mapping. One session searched for
babysitthree times and got the same message each time, with the skill installed throughout.Not a goal
test_unmapped_custom_agent_still_gets_nothingis untouched.What changed (motivation → approach → change)
api_skillssearch and list responses carryscope_size: the number of mappedskill://resources, ornullwhen the session is unscoped.skill_searchnames that scope on a miss: No skills matched 'babysit' among the 3 skill(s) mapped to this agent. Search covers only the agent's skill:// resources, so an installed skill outside them is not found; browse action='list' to see the mapped set.Backwards compatibility
Compatible.
scope_sizeis an added response field. Unscoped sessions and the CLI path get the old message.Tests
test_mcp_core_coverage.py::TestSkillSearch::test_no_matches_in_a_mapped_scope_names_the_scope.test_gateway_list_and_exact_read_share_the_session_mappingassertsscope_sizefor a 3-skill mapping and for a cleared one (0).Pattern harvest
When a scoped
skill_searchor list comes back empty, the message must name the scope it searched (how manyskill://resources were mapped) and point at the one action that can still succeed (action='list'), instead of suggesting broader keywords that can never match outside the mapping.