Skip to content

fix(sidebar): keep a pinned folder header in place when it collapses - #17581

Merged
iamwhatever merged 2 commits into
kirodotdev:mainfrom
jeeshofone:fix/17529-sticky-folder-collapse
Oct 8, 2026
Merged

iamwhatever merged 2 commits into
kirodotdev:mainfrom
jeeshofone:fix/17529-sticky-folder-collapse

Conversation

@jeeshofone

@jeeshofone jeeshofone commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Collapsing a list-view folder whose header is pinned at the top of the sessions list leaves the collapsed header where it was, with the next folder or session directly below it.

In the list view, scroll into a folder until its header is pinned and its first sessions have scrolled off, then collapse it. The collapsed header vanishes above the top of the list and every row below jumps up by however far you had scrolled into the folder.

Why it matters

Anyone with a folder taller than the sidebar hits this every time they collapse it from the pinned header, which is the natural place to click. The list jumps to an unrelated spot and the folder they just closed is off screen.

Not a goal

  • The board view: its folder headers are not sticky, so it is unaffected.
  • Expanding a folder, or collapse paths outside the list view's header and left-edge line.
  • Any change to the collapse animation's shape or timing. FolderBody changes only in how it stops the closed rows painting (below).

What changed (motivation → approach → change)

Symptom A collapsed folder's header lands above the lane, and the rows below jump up.
Root cause The header is position: sticky inside its folder block. Collapsing shrinks the block to the header alone but leaves the lane's scrollTop alone, so the header falls back to the block's natural top, which has scrolled above the lane.
Change In the commit that marks the folder collapsed, before that frame paints, the lane scrolls up by the measured gap between the header's painted top and its block's top. The folder body's rows are hidden in that same frame.

The new website/src/pages/chat-sidebar/stickyCollapse.ts holds that one rule (holdPinnedHeaderThroughCollapse). After the scroll the block's top sits where the header was painted, so the header does not move and the body closes underneath it. Because the gap is measured, the same rule works for a nested header pinned below its parents and for a header that the end of its block is already pushing up. A header at its natural place (gap 0) leaves the lane untouched.

When the scroll runs matters as much as how far. The scroll brings the folder's first rows under the header, so it must land in the same frame that hides them. The click only arms the hold (useHoldPinnedHeaderOnCollapse), and a layout effect runs it on the first commit that shows the folder collapsed. That is the commit in which FolderBody hides its rows. Where the header was painted is read at the click, and the block's top in that commit. With motion on the body still has its open height in that commit; under prefers-reduced-motion the transition is zeroed, the body is already closed and the header has fallen to the block's top. The block's own top does not move as its body closes, so the distance is the same either way. Scrolling in the click handler painted the folder's first rows under the header until the optimistic collapse reached React, which is the row swap the UX review predicted.

Moving the scroll was not enough on its own. FolderBody hid its closed rows with visibility: hidden, which is inherited, and the row controls transition all over 150ms, so each one carried the inherited value through its own transition and the rows kept painting for the whole close. That affects every folder collapse, pinned or not. website/src/components/FolderBody.tsx now also sets opacity: 0 on its box: opacity is not inherited, so the rows stop painting at once. visibility: hidden stays for hit testing and the accessibility tree, and the rows stay mounted for keyboard navigation.

In website/src/pages/ChatSidebar.tsx both list-view toggles, the header button and the left-edge FolderRail (website/src/components/FolderRail.tsx), now go through one toggleListFolderCollapse handler. That handler arms the hold only when the folder is collapsing (an expand disarms it), then calls the existing toggleCollapse. FolderRail's onToggle now receives the click event, so the handler can find the folder block from the pressed control. The board view's rail ignores the argument.

docs/feature-map/README.md lists the new helper on the Session folders row as an internal piece with no new entry point.

Backwards compatibility

Compatible: the only interface change adds an event argument to FolderRail's onToggle, and both existing callers still type-check (the board caller ignores it).

Removes nothing: the change adds a scroll adjustment in the collapse commit and an opacity value on a closed folder body, and takes no path, key or behaviour away.

Tests

  • website/src/test/ChatSidebar.stickyFolderCollapse.test.tsx renders the real sidebar with a stubbed pinned geometry: the lane scrolled 500px and the block's top 300px above the painted header. It checks that collapsing from the header, and from the left-edge line, moves scrollTop to 200. It also checks that a header at its natural place and an expand both leave scrollTop unchanged. On origin/main a1974e2 the two collapse cases fail with expected 500 to be 200. A further case checks that the click itself does not scroll and that the one scrollTop write happens while the folder body is already aria-hidden; it fails on the previous head d9ce38a (expected 200 to be 500). The file's framer-motion mock now returns one component per tag, so the lane is not remounted on every commit.
  • The same file has a reduced-motion case: once the folder renders collapsed the header measures at the block's top, as it does when the transition is zeroed, and the lane still moves 500 -> 200. It fails on e628621 (expected 500 to be 200).
  • website/src/test/stickyCollapse.test.ts also covers the hook: it holds on the first commit that shows the armed folder collapsed and only once, it uses the header position read at the arm when the collapsed commit measures the header at the block's top (fails on e628621), an arm older than HOLD_ARM_TTL_MS (a collapse that never rendered) is dropped, an expand before the collapse renders disarms it, and disarm cancels a pending hold.
  • website/src/test/ChatSidebar.collapsedFolderGhostHeight.test.tsx pins that a closed FolderBody box carries opacity: 0 as well as visibility: hidden. jsdom runs no transitions, so this pins only the style; the filmstrips below show the painting.
  • website/src/test/ChatSidebar.ownerComposition.test.ts lists the new owner hook in the facade's pinned call order.
  • website/src/test/stickyCollapse.test.ts covers the geometry rule: a nested header pinned one row down, a header being pushed off by its block's end, sub-pixel and missing-element no-ops, and reading only the block's own header, never a nested folder's.
  • On this head (on main 6765454): npx tsc -b clean, eslint on the changed files, check-phantom-classes, check-theme-colors, check-restyle-ratchet and scripts/check_feature_map.py clean; vitest under src/test/ChatSidebar*, stickyCollapse, FolderBody and FolderRail: 111 files, 1149 tests passed. The earlier rebase onto 0d885e6 resolved one conflict, the facade's pinned call order, where main removed useFlatLane and the new hook keeps its place before useBoardFolderCollapse.
  • Determinism (before the rebase): the four files passed with --sequence.shuffle (26 tests). vitest related for FolderBody.tsx, stickyCollapse.ts and ChatSidebar.tsx passed: 309 files, 4412 tests. tsc -p tsconfig.app.json, the production build and eslint on the changed files are clean.

Manual verification

I ran the built SPA in headless Chromium at 1400x900 against the stub dashboard API, with two folders of 40 sessions each. I scrolled the lane 400px, 1200px and 30px into the first folder and clicked its pinned header. With the fix the header stayed at y=125 (its pinned position) every time, and the second folder's header landed directly below it at y=159. With the rule disabled, the same 400px run put the header at y=-271 and the second folder's header at y=125.

Under prefers-reduced-motion: reduce (the browser context's reducedMotion), the same 400px run keeps the header at y=125 with this head; e628621 put it at y=-271, the same as main. A nested folder pinned one row below its parent stays at y=157 with this head, with motion on and off; e628621 moved it to y=109 under reduced motion.

One accepted trade-off: after a collapse the header is the top row, so an expand right after opens the folder from its header, not at the scroll position inside it that the person had before the collapse.

For the motion, website/scripts/capture-sticky-folder-collapse.mjs records the same collapse (lane scrolled 400px into "alpha folder") in headless Chromium against the stub API. It writes a video and a filmstrip of every compositor frame from about 120ms before the collapse commits to 450ms after it, cropped to the top of the lane. I ran it against a build of the previous head and a build of this head.

Screenshots / video

Pinned header before the click (lane scrolled 400px into "alpha folder"):

pinned before click

After collapsing with the rule disabled: "alpha folder" is gone above the lane and "beta folder" has jumped to the top:

collapse on main

After collapsing with this change: "alpha folder" stays as the top row and "beta folder" sits directly below it:

collapse with fix

Filmstrip of the collapse on the previous head (scroll in the click handler, rows hidden by visibility alone). From about -13ms to 286ms the rows under the header are "alpha session 0, 1, 2", sessions that were not on screen before the click, and only then does the space close:

collapse on the previous head, frame by frame

Filmstrip of the collapse with this change. "alpha session 8, 9, 10" stay until the collapse commits, the header never moves, and the space under it is empty while the folder body closes over the shared 150 ms track. The strip crops the top of the lane, and alpha's body (40 rows) is far taller than the lane, so "beta folder" reaches the crop only in the last frames of the close, landing under the header at about 300 ms:

collapse with this change, frame by frame

Filmstrip of the same collapse under prefers-reduced-motion (capture-sticky-folder-collapse.mjs ... reduce). The body closes at once, "alpha folder" stays as the top row and "beta folder" sits directly below it:

collapse under reduced motion with this change, frame by frame

Recordings of the runs: temp-screenshots/17529-sticky-folder-collapse/4-collapse-previous-head.webm, temp-screenshots/17529-sticky-folder-collapse/5-collapse-with-fix.webm and temp-screenshots/17529-sticky-folder-collapse/6-collapse-reduced-motion-with-fix.webm.

Related Issues

Closes #17529

Pattern harvest

Not generalizable: this is the only list surface whose rows are sticky inside a collapsible block. The board view's folder headers are not sticky, and other collapsibles do not pin their header.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@jeeshofone
jeeshofone requested a review from a team as a code owner October 7, 2026 01:31
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 7, 2026
@jeeshofone
jeeshofone force-pushed the fix/17529-sticky-folder-collapse branch from f1d1c48 to d9ce38a Compare October 7, 2026 02:57
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 622e740c2effc22550d24defcbf51490bcd9bba6 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check the crew-group collapse (chat-sidebar/CrewGroups.tsx) and the board column. The new opacity: 0 in the shared FolderBody hides their rows at once too, and only folder collapses were recorded.

[DESIGN-REVIEWED] 622e740

Description read

[DESCRIPTION-READ] 4fbe99bd48af2d0af010fa69be2fadd28bd1fd09d1d55cda3e75b0cb3af63f0f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 622e740c2effc22550d24defcbf51490bcd9bba6 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check before merge: FolderBody's new opacity: 0 also applies to its other three callers (board column, CrewGroups.tsx:100, DesignTweakPage.tsx:400), not only list-view folders.

What this change ships

Inventory (6 items) — 6 justified

Intent: a person who collapses a folder from its pinned list-view header keeps that header where it was on screen, instead of the list jumping. This is a FIX.

  1. Collapsing a pinned list-view folder from its header keeps the header in place — justified
  2. Collapsing from the left-edge connector line does the same — justified
  3. A closed folder's rows stop painting at once during every collapse, in all four FolderBody callers — justified
  4. FolderRail's onToggle now receives the click event; the board view ignores it — justified
  5. Feature-map Session folders row lists stickyCollapse.ts — justified
  6. Committed capture script plus nine media files under temp-screenshots/ — justified

[FIRST-PRINCIPLES-REVIEWED] 622e740

Description read

[DESCRIPTION-READ] c6c0a0ca35965781332e3f49d40881bf5db6fd7e38abc87de457368d44be459c

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 622e740c2effc22550d24defcbf51490bcd9bba6 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 622e740

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — 🟡 CONCERNS

UX-level review of 622e740c2effc22550d24defcbf51490bcd9bba6 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

A tall pinned folder's collapse leaves the lane blank below its header for about 250 ms before the next folder appears.

Watch

  • Blank lane during a tall folder's close. In 5-collapse-with-fix-filmstrip.png, the rows disappear at 42 ms. From 42 to about 281 ms the frames show only "alpha folder" over an empty sidebar. "beta folder" appears at 297 ms. The cause is the new opacity: open ? 1 : 0, which stops the rows painting at once, while the body's track still shrinks from 40 rows' height. That track sits below the viewport until its last few frames, so nothing visible rises to meet the header during most of the close. The user sees an empty sidebar for about a quarter second on every collapse of a folder taller than the lane. That is mild friction but it happens every time, and the FolderBody change affects every folder collapse, not only pinned ones. Smallest fix: give a tall body a short or capped close duration, or start the close from the visible part of the track, so the next folder rises into view right away. That would touch the animation's timing, which the PR lists under "Not a goal", so a human should decide whether this blank is acceptable.
  • No first-time reader has seen it. The header click and the left-edge line now behave differently, and recordings 4, 5 and 6 cover that change. No new label or control was added, but this lane has no blind read, so how the change reads to a new user is unknown.

[UX-REVIEWED] 622e740

Description read

[DESCRIPTION-READ] 31283bb02661863f5f7f7d4e5a23aa8948384b9fa7113d8ebb17dcd23b37bbff

That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 622e740c2effc22550d24defcbf51490bcd9bba6 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 622e740

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 7, 2026
@jeeshofone
jeeshofone force-pushed the fix/17529-sticky-folder-collapse branch from d9ce38a to ba90618 Compare October 7, 2026 05:40
@jeeshofone

Copy link
Copy Markdown
Contributor Author

ai-review-disposition target=ux head=ba9061897

UX Review BLOCK on d9ce38a ("the visible session rows probably jump just before the folder closes"): fixed on ba90618.

The prediction was right, and recording it showed a second cause the stills hid:

  1. The scroll ran in the click handler. The optimistic collapse reaches React a few ticks after the click, so the lane had already moved and the folder's first rows were painted under the header for those frames. Now the click only arms the hold. A layout effect (useHoldPinnedHeaderOnCollapse in website/src/pages/chat-sidebar/stickyCollapse.ts) runs the scroll on the first commit that shows the folder collapsed, before that frame paints.
  2. The closed rows kept painting for the whole close. FolderBody hid them with visibility: hidden. That value is inherited, and the row controls transition all over 150ms, so each control carried it through its own transition. This happened on every folder collapse, pinned or not. FolderBody now also sets opacity: 0 on its box. opacity is not inherited, so the rows stop painting at once. visibility: hidden stays for hit testing and the accessibility tree, and the rows stay mounted for keyboard navigation.

Evidence, committed under temp-screenshots/17529-sticky-folder-collapse/ and linked in the description. Both runs use the same headless capture (website/scripts/capture-sticky-folder-collapse.mjs, lane scrolled 400px into the folder), against a build of each head:

  • 4-collapse-previous-head-filmstrip.png and .webm: from about -13ms to 286ms after the commit, the rows under the header are "alpha session 0, 1, 2", which were not on screen before the click.
  • 5-collapse-with-fix-filmstrip.png and .webm: "alpha session 8, 9, 10" stay until the commit. The header does not move, the space under it is empty while the folder closes, and "beta folder" rises to meet it.

Tests: ChatSidebar.stickyFolderCollapse.test.tsx adds a case where the click itself must not scroll and the one scrollTop write must happen while the body is already aria-hidden. It fails on d9ce38a. stickyCollapse.test.ts covers the hook (holds once on the collapsed commit, drops an arm that never rendered, disarm). ChatSidebar.collapsedFolderGhostHeight.test.tsx pins opacity: 0 on a closed body.

Backend Tests (Windows) (7) on d9ce38a: test_runtime_cleanup_windows.py::test_a_child_exiting_259_reads_as_exited_and_its_drain_finishes[True], "helper did not attach". That test races its own helper. The race is tracked in #17354 and fixed by #17356, which is still open. This PR changes no Python and does not touch that file. I will rebase onto main once #17356 merges.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 7, 2026
@jeeshofone
jeeshofone force-pushed the fix/17529-sticky-folder-collapse branch from ba90618 to e628621 Compare October 7, 2026 08:35
@jeeshofone

Copy link
Copy Markdown
Contributor Author

Rebased onto main 0d885e681 to clear the merge conflict. New head e6286213e.

The conflict was one list: the facade's pinned hook call order in website/src/test/ChatSidebar.ownerComposition.test.ts. Main's sidebar row-model refactor removed useFlatLane from it, and this PR adds useHoldPinnedHeaderOnCollapse before useBoardFolderCollapse. The resolved list is main's list with that one hook inserted. git range-diff shows no other change to the commit, and the conflict forced no logic change.

On the new head: npx tsc -b clean; eslint on the changed files, check-phantom-classes, check-theme-colors, check-restyle-ratchet and scripts/check_feature_map.py clean; vitest under src/test/ChatSidebar* and stickyCollapse: 111 files, 1146 tests passed.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 7, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 7, 2026
iamwhatever
iamwhatever previously approved these changes Oct 7, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[operator: iamwhatever]

Approving at 2ea61ea. Thanks for the careful write-up and the filmstrips.

What I checked:

  • Diff read in full: stickyCollapse.ts, the one toggleListFolderCollapse path for both list-view toggles (header button and FolderRail), the FolderBody opacity addition. Board view still calls toggleColumnCollapse and ignores the new rail argument; FolderBody is unchanged while open (opacity: 1).
  • Arm/disarm logic: expand disarms, a dropped optimistic update times out, a removed folder clears the arm, a detached block is a no-op, scrollTop clamps at 0.
  • Tests: ChatSidebar.stickyFolderCollapse, stickyCollapse, ChatSidebar.collapsedFolderGhostHeight, ChatSidebar.ownerComposition — 4 files, 29 tests pass locally. Removing the armHold call fails the 4 collapse cases, so the suite guards the fix.
  • Real browser: built this head and ran scripts/capture-sticky-folder-collapse.mjs in headless Chromium. Header top 125.14 -> 125.14 px with motion on, and 125.14 -> 125.14 px under prefers-reduced-motion.
  • All PR checks green on this head.

No blocking findings.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 7, 2026
In the list view a folder header is sticky inside its folder block. When
the block's top had scrolled off the lane, collapsing the folder shrank
the block to the header alone without moving the lane, so the header
fell to the block's natural top above the lane and every row below
jumped up.

In the commit that marks the folder collapsed, before that frame paints,
the lane scrolls up by the measured distance between the header's
painted top and its block's top. The block's top lands where the header
was pinned, so the header does not move and the body closes underneath
it. Both list-view toggles (the header and the left-edge line) go
through one handler; expanding is unchanged. The header's painted top is
read at the click and the block's top in that commit: under
prefers-reduced-motion the body has already closed by then and the header
has fallen to the block's top, while the block's own top has not moved, so
the distance is the same with or without the transition.

The scroll brings the folder's first rows under the header, so they
must already be hidden. FolderBody hid its closed rows with an inherited
visibility: hidden, which a row control transitioning all carries
through its own 150ms transition, so the rows kept painting for the
whole close. FolderBody now also sets opacity: 0 on its box, which is
not inherited and hides them at once, on every collapse.

Closes kirodotdev#17529
@jeeshofone
jeeshofone force-pushed the fix/17529-sticky-folder-collapse branch from 2ea61ea to e73898a Compare October 7, 2026 21:45
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision labels Oct 7, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor

I ran this branch against one more layout from #17529 and the header still moves there: a folder near the end of the list, with nothing below it to fill the space.

Steps, in Chromium on a build of e73898a: seed a 12-session folder, then a 24-session folder A, then a 4-session folder B, and nothing after B. Scroll to the middle of A so its header is pinned, then collapse A from its header toggle. Once the body is gone the list is shorter than the scroll position, so the browser clamps scrollTop and the whole list slides down. A's header goes from 40px to 80px below the top of the lane, and part of the earlier folder comes back into view above it. With a long folder below A, this branch keeps the header in place, so it's only the near-end case.

For that case I have a follow-up that holds a scroll floor through the collapse. It's a zero-height anchor at the top of the lane with a 1px absolutely positioned marker, placed so the scroll height can't drop below the anchored position. The marker moves up as the user scrolls up and is removed once the content alone reaches it. I'll open it on top of this PR once this lands, rather than as a competing fix, since your commit-timing and opacity changes are worth keeping.

@jeeshofone

Copy link
Copy Markdown
Contributor Author

e73898a18 is 2ea61eaf1 rebased onto main to clear the conflict with #17450 in docs/feature-map/README.md. Main's restructured rows are kept as they are, and the one stickyCollapse.ts entry in the Session folders row is re-applied. git range-diff shows the commit's own lines unchanged. The code, tests and evidence are the same as at 2ea61eaf1.

UX Review, Watch 1 (the pane is blank under the header for about 250 ms): this is the item already answered on a867cb71e and 2ea61eaf1, and the reply stands. The blank space is the shared FolderBody close running on a body taller than the lane. Changing that close would change the collapse animation of every FolderBody caller, which is outside this fix. The description already says what the filmstrip shows.

UX Review, Watch 2 (no cold read): that read runs only when a maintainer pushes the branch to this repository, so it is a maintainer step.

@Pearcekieser thanks for the near-end layout. It matches how the hold works: the lane scrolls once, before the body closes. When nothing below the folder fills the space, the scroll height then drops under the scroll position and the browser clamps scrollTop, so the list slides down. A scroll floor held through the close is the right shape for that, and stacking it on top of this PR works for me.

Backend Tests (3.12, 2/6) and Windows (2/6) fail on two tests outside this diff (it changes no Python). Both also fail on bare origin/main 167076a40: test_session_control_doc (remote_target_unsupported) is #17902 / #17900 with fix PR #17903, and test_http_server_bind_ratchet (16 vs 15) is #17908 with fix PRs #17906, #17907 and #17909. Once one of each pair merges, I'll rebase onto main and push again.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 7, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 8, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving on 622e740c2.

  • e73898a18 is 2ea61eaf1 rebased onto main. The PR patch is byte-identical (code, tests, evidence); the docs row only re-applies to main's restructured feature-map.
  • 622e740c2 merges main to pick up #17909. The earlier Backend reds were test_http_server_bind_ratchet and test_session_control_doc, both main-side and outside this diff.
  • UX Watch 1 (blank lane during a tall folder's close): accepted as answered. It is the shared FolderBody close timing, out of scope here.

Prior review stands: collapsed header stays the top row within 1px, reduced motion and nested folders covered; expand and board view unchanged.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Oct 8, 2026
@iamwhatever
iamwhatever merged commit 6234d00 into kirodotdev:main Oct 8, 2026
150 of 151 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 8, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor

Follow-up for the near-end case discussed above is up as #18130. It adds only the scroll floor on top of this PR's helper, with the Chromium Playwright cases and before/after clips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sessions sidebar: collapsing a partly scrolled-off folder makes the list jump

3 participants