Repository navigation
Conversation
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS A prefilled card says "your crewmate will confirm this job with you" before any job appears, and the blind reader asked "what job?" Watch
Suggestions
[UX-REVIEWED] 860deb0 Description read[DESCRIPTION-READ] 8aaea58174f474fbdd09fc77a93e8bf94f94928dc6f5d3cb4b82ac27ca092ef1 That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK product-shape change without accepted RFC: this PR removes the guided four-step create flow, which accepted Not justified as shipped
What this change shipsInventory (7 items) — 4 justifiedIntent: a person creates any crewmate from the one New crewmate card and agrees a schedule with the crewmate in chat. ADDITION, with a capability removed.
Blockers
[FIRST-PRINCIPLES-REVIEWED] 860deb0 Description read[DESCRIPTION-READ] a86e3acb0b87094ea3f21934ae90da85ecc8df714e7dbd5b5bbc4aa9bdafda70 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The description promises a schedule "is never created without a yes", but only a sentence in the greeting prompt backs that, and nobody has run it against a live agent. Watch
[DESIGN-REVIEWED] 860deb0 Description read[DESCRIPTION-READ] d52014f4878cf66ba4e94d6203e64fd791f904d7015195da8c897fe68fd93e34 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsRe-opening a dirty New crewmate card keeps the draft the user just confirmed discarding. FINDING — website/src/pages/members/MembersPage.tsx:1194 — At md and up, the roster's "+" stays visible while the card is open. Say the card was opened from "+" and the user typed a name. Picking "+" → New crewmate again runs [OPUS-REVIEWED] 860deb0 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
d64c97f to
b081792
Compare
d212678 to
bbc1dc4
Compare
fa19512 to
f883469
Compare
The guided goal, name and schedule chapter is removed. Captain's create proposals, create links and the crewmate.create guide open the New crewmate card prefilled with the name and goal. The crewmate asks its goal in its first greeting and offers a schedule only when the person agrees.
f883469 to
860deb0
Compare
bbc1dc4 to
3f4a0bc
Compare
Problem / Motivation
Goal: A person creates a crewmate in one place, the New crewmate card, and sets up any schedule by talking to the crewmate afterwards.
On the base branch there are two create flows. The New crewmate card (look, name, Advanced settings) is behind "+", and a separate guided chapter,
MeetCrewmatesFlow(goal → name → schedule → ready), opens from Captain's create proposals, create links and thecrewmate.createguide. Both ask for a goal, they look and behave differently, and the guided one asks for a schedule before the person has said a word to the crewmate.Why it matters
Two flows for the same job make people learn two surfaces and give guides and Captain two targets to keep in sync. A schedule picked before the crewmate understands the job is a guess; asking in the first conversation, once the goal is clear, produces a schedule that fits the work and is never created without a yes.
Not a goal
crewmates_onboardedfield (it stays for compatibility).rfc-crewmates-launch.md(an amendment must land on the base first; see the review note below).What changed (motivation → approach → change)
Goal → one create surface → every former door of the guided chapter now opens the card, and the schedule question moves into the crewmate's first greeting.
MeetCrewmatesFlow.tsx,useMeetCrewmatesGate.tsand their tests, theSTART_MEET_CREWMATES_EVENT/CREWMATES_PAGE_ENTERED_EVENTevents, the creation receipt, and the deadcomponents.meetCrewmatesFlow.*strings in every locale.hasNoCrewmatesmoves torosterFilter.tswith its test./members?create=1&name=&goal=, clicked in chat or opened as a deep link) and thecrewmate.createguide open the card in place, prefilled: the name in Name, the goal in "What it looks after" with Advanced settings unfolded so it is visible. The chat stays mounted and its draft is kept; closing the card returns to it. An untouched card is replaced by a newer proposal; an edited one asks its own leave guard first.crewmate.createis a singlecreatestep on the card's Create button.captain_greeting.py).crew-mode.md,config.md,crew-members.mdand the feature map describe the single card.verify-assistant-guide.mjs,verify-crewmate-assistant.mjs) drive the card instead of the removed chapter.Backwards compatibility
Compatible: every URL and guide that opened the guided chapter still works and opens the card; no API or stored field changes.
Reader: website/src/pages/members/MembersPage.tsx:openGuided -- crew page -- replaced by the prefilled card open;
MembersPage.test.tsxandNewCrewmateDialog.guided.test.tsxpin the create link, the deep link and the guide doorReader: src/kiro_crew/guide_catalog.py:crewmate.create -- chat (Captain guides) -- now one
createstep;test_guide_*pin itReader: website/src/components/MeetCrewmatesFlow.tsx:scheduleFor -- none -- no caller outside the removed file
Reader: website/src/hooks/useMeetCrewmatesGate.ts:hasNoCrewmates -- crew page -- moved to
rosterFilter.ts, test moved with itTests
MembersPage.test.tsx("create links open the New crewmate card"): a create link opens the card prefilled with the name and the goal in an unfolded Advanced settings, without remounting the chat; an empty link opens it folded and empty; a deep link is stripped after reading; malformed escapes do not throw; a prefilled Create sendsfirst_greeting: trueand opens the new crewmate; the rules for a newer proposal replacing the card.NewCrewmateDialog.test.tsx(+5) andNewCrewmateDialog.guided.test.tsx(new, 4): the guided door's request headers and lifecycle; an unguided door never touches the guide.test/test_captain_greeting.py: a kickoff carrying a goal still starts with the full kickoff and stays a hidden gateway turn with no transcript row.test_guide_routes.py: frontend and backend agree thatcrewmate.createis one commit step; guide prefill length caps fit the card's fields.GuideLayer.test.tsxandtest_guide_runs.pymove their generic multi-step fixtures tomcp.open_add.initialDraftcomparison, the guided headers, the refused callback, the draft kept on link click, passinginitialDraft, the goal kickoff prefix, the single-step catalog and the field length caps each turn a named test red.Manual verification
N/A for a live pod in this revision: the change is covered by the jsdom tests above, and screenshots of the prefilled card follow after review of the evidence. The two manual pod scripts were rewritten and pass
node --check; they were not run against a pod.Screenshots / video
Opened from a Captain create link (
/members?create=1&name=Scout&goal=…): the name is prefilled, Advanced settings unfolds with the goal in "What it looks after", and the hint under the name says the crewmate will confirm this job.More: end of Advanced settings, phone, empty create link
Not capturable as images:
window.confirm("Leave this page? Your unsaved crewmate draft will be lost."). Reproduced on a test gateway: edit the name, open a second create link, the prompt appears; Cancel keeps the edited draft.test/test_captain_greeting.pyonly.Related Issues
Stacked on #17617 (quick create), which is stacked on #15326 (Captain).
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.