Repository navigation
ci(sensitive-review): let the PR author's template comment clear the check - #17865
Conversation
Sensitive Change ReviewSensitive files changed:
How to clear this check (a plain PR comment does NOT count):
The author may draft the filled template as a comment for the |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Before relying on the new path, run the post-merge check: an author comment on a [DESIGN-REVIEWED] 8d5f547 Description read[DESCRIPTION-READ] b1a672bd4a8bf32234b831695def77c518f5cd00e501c422825ac9ea25b2c9b3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The PR reverses a pinned #16862 rule, and the only thing it rests on is the description saying the gate owner agreed. Nothing on record shows that decision. Not justified as shipped
What this change shipsInventory (8 items) — 7 justifiedIntent: let a sensitive PR's author clear Sensitive Change Review with their own filled template, without waiting for an approver. This is an ADDITION that loosens a gate.
[FIRST-PRINCIPLES-REVIEWED] 8d5f547 Description read[DESCRIPTION-READ] bc3b399e00d97042fcfbabe028ac12cc03f028fc2db8f29842d08c89a56541eb That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
7bef946 to
0ac8b7e
Compare
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: yes
|
|
Draft for the approver to paste into an Approve review (main's checker does not read author comments yet, so this PR still needs a reviewer). Sensitive change review
|
UX Review (Opus 5.5) — ⏭️ skippedRevision |
0ac8b7e to
8d5f547
Compare
|
@chenmingwei23 thanks for the approval. Sensitive Change Review is still red because the approval body is empty. This PR changes the gate itself, so main's checker still reads the template only from an Approve review. Please submit one more Approve review on head 8d5f547 with the filled template from the draft comment above, with the head SHA set to 8d5f547. |
Problem / Motivation
Goal: The PR author can turn Sensitive Change Review green by posting the filled template, without waiting for an approver.
Today only an approver's review body can clear the check. The author did the sandbox checks, but has to wait for someone to paste the template into an Approve review. A plain comment does nothing.
Why it matters
Sensitive PRs sit red until a reviewer copies text the author already wrote. That slows every sandbox, floor and redaction change, and it makes the approver's job paperwork instead of review.
Not a goal
mainruleset still needs one approval from someone else.What changed (motivation → approach → change)
This reverses one rule from #16862: "the PR author cannot clear the check". The gate owner (@iamwhatever, author of #16862) decided the author, who ran the sandbox, should write the record. The approver's job becomes the review, not copying text.
The second person stays, enforced by the
mainruleset (read today):required_approving_review_count: 1,require_last_push_approval: true,dismiss_stale_reviews_on_push: true,require_code_owner_review: true. So no sensitive head merges without a fresh approval from someone else..github/scripts/sensitive_change_review.py- Head commit: <sha>. The glob coverssensitive-change-review*.yml..github/workflows/sensitive-change-review-comment.yml(new)issue_commentruns frommain, so a PR cannot edit it. Job-level concurrency, so other comments cannot cancel it. Hosted, no checkout, forks skipped..github/workflows/sensitive-change-review.ymldocs/ci/ci-and-reviews.mdBackwards compatibility
Compatible: a reviewer's template approval clears the check exactly as before.
Loosens one rule: the author's own comment now clears the check, where #16862 said the author does not count. The reviewer path, fork refusal, head match and sticky comment are unchanged.
Tests
test/test_sensitive_change_review.py(101 passed):main()passes on an author comment; a comment read error exits 2issue_comment, author-onlyif, hosted, no checkout, minimal permissions, job-level non-cancelling concurrency, re-runs the check workflowManual verification
Still required after merge (the comment workflow only runs from
main): on a test PR touchingsrc/kiro_crew/sandbox.py, post the filled template as the author and confirm the check re-runs and goes green; then push and confirm it goes red again.This PR changes the gate's own files, and
main's checker does not know the author path yet. So this PR itself needs a reviewer's template approval.Related Issues
Reverses part of #16862. Related to #16870.
Checklist