Repository navigation
Conversation
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Before merge, confirm that the launcher re-stamps [DESIGN-REVIEWED] fafea92 Description read[DESCRIPTION-READ] 9aa5b061281b96f6658ccd56d5eb343c6f10529bf1d23fa54ccf25cab0a3064c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check one claim before merge: the launcher writes its own nonce into What this change shipsInventory (7 items) — 7 justifiedIntent: let a
[FIRST-PRINCIPLES-REVIEWED] fafea92 Description read[DESCRIPTION-READ] f4ff7b75f86d71537c92e287f50e0769b189af22ba93afdac5836e58e2cffb86 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
|
self-added: no
|
|
The four red backend shards on 721ec75 are main's, not this diff's. Two tests fail, and both fail the same way on a pristine
Tracked in #17900, with the fix in flight in #17907. This PR will rebase onto main once that lands, rather than push around the red. |
721ec75 to
ac79a74
Compare
|
self-added: no
|
|
self-added: no
|
ac79a74 to
ac5bcb6
Compare
|
self-added: yes
|
|
self-added: no
|
ac5bcb6 to
4d4e7b5
Compare
|
Rebased onto main 5dbde27 to clear a merge conflict with #17870, which rewrote the same |
|
Round 4 on 4d4e7b5 finished with one red: Backend Tests (Windows) (8), failing A fork account cannot re-run jobs. Could a maintainer re-run the failed job? https://github.com/kirodotdev/KiroCrew/actions/runs/37715637871/job/113112328799 |
4d4e7b5 to
c7e66e3
Compare
|
Rebased onto main 372915e to pick up the flake fix #17957 (closes #17876), which failed Backend Tests (Windows) (8) on the previous head. Both commits' patches are unchanged by the rebase. One test-only line was added in the co-authored commit: |
c7e66e3 to
5cf5f45
Compare
|
Rebased onto main 1c5a71d; both commits' patches are unchanged. On the previous head (c7e66e3), none of the reds came from this diff:
Locally the related modules pass (434), including |
|
Round 6 on 5cf5f45: all five AI review lanes are clean (GPT 6.1 and Opus 5.5 found nothing; Design and First Principles PASS; UX skipped), and 86 checks pass. None of the three reds comes from this diff:
A fork account cannot re-run jobs. Could a maintainer re-run the failed jobs in this run? https://github.com/kirodotdev/KiroCrew/actions/runs/37742642107 |
Small changes on top of the carried fix, none of them behavioural: - The nonce-restamp test rewrote the default spec with a second nonce of the same length, so its identity assertion rested on st_mtime_ns alone; on a coarse-timestamp filesystem both writes can land in one tick. A longer nonce changes the size, so the identity always moves. The nonce-fingerprint test clears KIROCREW_SKILL_VIEW_VOLATILE_ENV, as its sibling tests do, so an extended volatile list in the environment cannot change its result. - worker_agent.py imports from agent_spec_format on one line (the rebase left two side by side, and isort wants one), and the _without_volatile_mcp_env docstring names both checks that read the fingerprint and why a value-only change may skip the re-derive. - skill_projection.py imports volatile_env_keys straight from agent_spec_format, without alias constants or a forwarding wrapper, and the list's constants stay private there: nothing else read them. - The acp-client system spec and the comment beside the list say a key declared volatile must be one the launcher writes into every agent spec it manages, the worker's included, since the worker gate ignores its value too. Co-authored-by: paigebelliveau <40582209+paigebelliveau@users.noreply.github.com>
5cf5f45 to
fafea92
Compare
|
Rebased: main moved in This replaces my re-run request for 5cf5f45 above. That head's two reds, Integration |
bolichen97
left a comment
There was a problem hiding this comment.
Approving head fafea92. PR Readiness success on this head, no CHANGES_REQUESTED, no open blocking review request, merges cleanly into current main.
Reviewed by Kiro (agent) on behalf of bolichen97 as part of a repo-wide ready-PR sweep.
Supersedes #16879 by @paigebelliveau, who closed it in favour of this PR. This PR carries their commit rebased onto current main, plus one co-authored commit. The fix and the credit are theirs.
Review requested from @chenmingwei23.
Problem / Motivation
Goal: A
kirocrew-workerspawn survives another session launching at the same moment.A sandbox launcher that stamps a fresh env value into every agent spec each time a session starts (#15119) changes the worker spec fingerprint, so a
kirocrew-workerwhose load overlaps any launch, its own included, dies withDerivedSpecStalebefore its first turn (full write-up in #16879).Why it matters
On a host with such a launcher, every
kirocrew-workerdispatch dies, because the worker's own launch re-stamps the default spec too. A conductor cannot hand work to a worker, and each failure is reported as a runtime error with the task undone. The gate is right to end a worker when a grant changes under it, but a per-launch nonce is not a grant.Not a goal
tools,allowedTools,excludedTools,mcpServers,model).What changed (motivation → approach → change)
The worker gate fingerprints the default spec's mirrored keys before the spawn and again after
initialize, and ends the session when the two differ. The same fingerprint decides whether the worker mirror needs a re-derive. It hashed everymcpServersenv value, so the launcher's per-launch value moved it on every launch. Skill-view identity already skips those keys throughvolatile_env_keys(); the gate did not.agent_materialization/worker_agent.pyhashes each volatile env value as a fixed marker. The key, every other env value, command, args, tools, allow and deny lists, and model still move the hash. The volatile list moves toagent_spec_format.py, so the gate does not import the ACP layer. The rebase merged one import: main putSKILL_VIEW_PROJECTION_CEILINGon the sameskill_projection.pyline, so the commit's grouped import names it too.acp/skill_projection.pyimportsvolatile_env_keysstraight fromagent_spec_format.py, with no alias constants or forwarding wrapper: nothing read them.worker_agent.pytakes its twoagent_spec_formatnames on one line, where the carried commit keeps main'sparse_markdown_specimport beside its own._without_volatile_mcp_envnames both checks that read the fingerprint, and why a value-only change may skip the mirror re-derive.docs/system-specs/modules/acp-client.mdand the comment beside the list say a key added throughKIROCREW_SKILL_VIEW_VOLATILE_ENVmust be one the launcher writes into every agent spec it manages, the worker's included, because the worker gate ignores its value too.st_mtime_nsalone and could fail on a coarse-timestamp filesystem. The nonce-fingerprint test clearsKIROCREW_SKILL_VIEW_VOLATILE_ENV, as its sibling tests do, so an extended volatile list in the environment cannot change its result.Backwards compatibility
Compatible: a spec with no volatile env key fingerprints exactly as before. A spec with one hashes differently once, and the gate answers that with one re-derive of the worker mirror on the next spawn.
skill_projection.volatile_env_keysstays importable under the same name, now the function imported fromagent_spec_format.py. The private_VOLATILE_ENV_KEYS_DEFAULTand_VOLATILE_ENV_VARmove toagent_spec_format.pyand stay private; nothing on main reads them from outside the module.volatile_env_keys(), the same function imported from agent_spec_format; every ACP spawn reaches it (chat, subagent, cron); test_native_skill_projection.pyTests
test_a_per_launch_env_nonce_does_not_move_the_fingerprint: a changed volatile value leaves the fingerprint unchanged, while another env value in the same entry, or removing the key, still moves it.test_a_nonce_restamp_during_the_load_does_not_end_the_session: capture, a re-stamp that changes the file identity, thenrequire_unchanged_derived_specreturns instead of raising.Both fail on main with the production
DerivedSpecStaleand pass here.test_worker_agent.py,test_native_skill_projection.pyandtest_skill_view_relaunch_harness.py: 386 passed, which covers bothskill_projectionreaders above.Manual verification
Verified live on Linux under a sandbox launcher that stamps a per-launch env value into every agent spec, on #16879's head 33c0a5b, whose behaviour matches this PR. One
kirocrew-workerand three concurrent ones each reached a tool call (pwd) and replied, with noDerivedSpecStale. The launcher re-stamped the default spec mid-run, inside the window main rejects; main fails both cases.On the same host, two read-only snapshots of the agents directory, with values hashed and never printed, show each launch rewriting every spec in one pass,
kirocrew-worker.jsonincluded, each with its own new value. So skipping the re-derive on a value-only change never leaves the worker on a copied value.Related Issues
Closes #17616
Pattern harvest
Rule candidate: review-prompt
Pattern: two digests of the same structure (skill-view identity and worker-spec fingerprint) with different exclusion lists; any new hash over
mcpServersmust consumevolatile_env_keys().Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)