Repository navigation
fix(members): seed crew recency from the human-turn marker - #17953
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that a thread with one marked row but older typed rows from before the marker still ranks by its newest marked row. The seed ignores those older rows. [DESIGN-REVIEWED] 42ebeac Description read[DESCRIPTION-READ] 9b0ad48a24818308215301247f21ea92e061c20830c5e09529fad797c681f7b2 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The fallback fires on any thread with no marked row, not just threads older than the marker, so a heartbeat-only thread still seeds a crewmate the user never talked to. Not justified as shipped
What this change shipsInventory (4 items) — 2 justifiedIntent: the first Crewmates visit after upgrade should list only crews the user actually messaged. FIX.
[FIRST-PRINCIPLES-REVIEWED] 42ebeac Description read[DESCRIPTION-READ] 3a8731648d0e007209dcce1640542658c45a3d6b5530b7c16f08fa610b72383c That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
0d7c85c to
8276e17
Compare
…refix The one-time crew_recency seed decided a DM row was typed by the user from content not opening with '[', which counted heartbeat prompts and skipped human messages like '[1, 2, 3]'. Require meta[HUMAN_TURN_META_KEY], the allowlist the human send paths set. Follow-up to #17808.
8276e17 to
42ebeac
Compare
|
|
|
|
Self-review (crew-pr-reviewer, read-only): RECOMMEND APPROVE Reviewed head |
Problem / Motivation
Goal: The one-time crew recency seed counts only rows a person typed, read from the human-turn marker.
#17808's seed fills
crew_recency.jsonfrom old Crewmates DM threads. It treated a user-role row as typed when its text did not open with[. That counts gateway rows that do not open with[, such as a💓 Heartbeatprompt. It also skips a real human message like[1, 2, 3] is the list.Why it matters
A wrong seed lists a crewmate the user never talked to, or hides one they did, on the first Crewmates visit after upgrade. The seed runs once, so a wrong answer stays until the user sends that crew a new message.
Not a goal
POST /api/chat,POST /api/agents).What changed (motivation → approach → change)
Symptom: heartbeats count, typed
[…]messages do not. Cause: an exclusion rule on the text prefix.history.pydocuments that "a reader that wants human activity must require this marker rather than exclude the machine callers it happens to know about".Change:
_seed_from_dm_threadsinsrc/kiro_crew/dashboard/handlers/members.pyreadsmeta[HUMAN_TURN_META_KEY], the allowlist marker the human send paths set. In a thread where any row carries it, only marked rows count. A thread where no row carries it predates the marker (#11733, 2026-09-30; DM threads go back to 2026-08-27). There the old "does not open with[" rule still applies, so that history is not lost.docs/system-specs/modules/crew-mode.mdstates the new rule.Answers the #17808 review spans GPT
fdf96ec23d53and First Principles3c53b19d9965, which were held for a follow-up under the scope freeze.Backwards compatibility
Compatible: only the one-time seed's row choice changes; the file format and every field on
GET /api/membersare unchanged.Removes nothing: no field, route or record is taken away; an already-seeded data home is untouched.
Tests
test/test_crew_recency.py::test_seed_reads_only_what_the_user_typed_in_a_dm_thread: a human-marked row that opens with[counts. A peer[sent by session …]delivery and assistant speech do not.test_seed_reads_a_thread_from_before_the_marker_by_the_old_rule: an unmarked old thread still counts its typed row and skips the[envelope. In a marked thread, a newer unmarked heartbeat is skipped; it is told apart by that thread's own row stamps (monotonic per thread), never across threads, so a coarse Windows clock cannot tie them. Mutations: forcing the "marked" branch, or dropping the marker filter, each turn this test red.test_a_seed_that_could_not_read_a_thread_runs_again_later: its fixture row now carries the marker.Manual verification
N/A — unit coverage sufficient: the seed is a pure read over
ConversationLogrows, driven end to end throughGET /api/membersin the tests above.Related Issues
Follow-up to #17808.
Pattern harvest
Rule candidate: review-prompt
Pattern: inferring "a person wrote this" by excluding known machine shapes (a text prefix) instead of requiring the
HUMAN_TURN_META_KEYallowlist marker.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)