Repository navigation
feat(agents): every conductor gets the work ledger from the shared base - #17992
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ✅ human override accepted@chenmingwei23 overrode this lane for |
Design Review (Opus 5.5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Step 3 of the shared protocol says the child reports with Watch
[DESIGN-REVIEWED] 01132a6 Description read[DESCRIPTION-READ] fa8da046b3003ec5d893a29228633123812ee646cade7bf7eb659391e3ec56bf That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsAdvisory only: the new ledger protocol tells the pipeline and security conductors their children will FINDING — src/kiro_crew/agent.py:4949 — the protocol appended to the pipeline and security charters says "The child reports against its item with [OPUS-REVIEWED] 01132a6 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
The shared conductor base now mounts kirocrew-work unconditionally and auto-approves the two conductor ledger verbs (work_ledger_read and work_ledger_record) on every conductor spec. The pipeline and security conductors also get one shared work-ledger protocol block appended to their charters: create with a concrete acceptance, bind before seeding, the worker reports with work_report, the conductor gives the verdict and closes. The goal conductor's charter already states that flow and is left unchanged. Their dispatched items now write work/recorded entries, so the workstreams fold mints a board for them. Their own stores (pipeline queue and decisions.md, security findings ledger) stay as the detail behind each ledger row. The conductor work-ledger RFC (v5) records the ruling that reverses the earlier retraction. Fixes #17977
e274e70 to
01132a6
Compare
Human judgment recorded@chenmingwei23 marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: A pipeline or security conductor's Dashboard tab shows its boards and tasks, because every conductor records its dispatched items in the work ledger.
Only
kirocrew-conductor(and itskirocrew-ledger-conductoralias) mounted@kirocrew-work.kirocrew-pipeline-conductorandkirocrew-security-conductorare built from the same shared conductor base but called_conductor_mcp_servers(config)withoutwork=True, so they wrote nowork/recordedentry at all.Why it matters
The Dashboard tab reads the
workstreamsfold, and that fold mints a board only fromwork/recordedentries. A pipeline or security conductor running a full fleet showed "No workstream yet": the reader could not see what was in flight, what each task cost, or what was waiting on them. Two conductors were inspectable through one read tool; the rest only by opening files on the host.Not a goal
SKILL.mdprocedures. Their own stores (pipeline queue +decisions.md, securityscripts/ledger.py) stay as the detail behind each ledger row.crew-manager-conductorare not materialized by Crew. One picks this up only if it is built from this base.What changed (motivation → approach → change)
Symptom: no board for pipeline/security conductors → cause: the shared base mounted
kirocrew-workonly behind awork=Trueflag that only the goal conductor passed → fix in the base, so every conductor gets it and no conductor is edited one by one._conductor_mcp_servers(config)mountskirocrew-workunconditionally; theworkparameter is removed and the docstring says why._conductor_shippedbuilds every conductor's grant tuple and always includes the new_CONDUCTOR_BASE_WORK_GRANTS(work_ledger_read,work_ledger_record). The goal conductor still addswork_ledger_rebuildandwork_brief.work_reportstays gated on every conductor: it writes into a parent's record._conductor_promptappends one shared block,_CONDUCTOR_WORK_LEDGER_PROTOCOL, to the pipeline and security charters: create with a concrete acceptance, bind before seeding, the worker reports withwork_report, the conductor gives the verdict and closes._conductor_speckeeps_CONDUCTOR_SYSTEM_PROMPTas is, so the goal conductor does not carry the flow twice._SHIPPED_GRANT_HISTORYgains the two base verbs on the security conductor. The pipeline conductor already listed them from the release that once shipped them.docs/request-for-change/rfc-conductor-work-ledger.md(v5) records it in §Agent spec changes, §Scope, the migration table and Q10, and its README row is updated.docs/system-specs/modules/pipeline-conductor.md, the security installer docstring and the feature-map row no longer say the server is not mounted.Backwards compatibility
Compatible: every conductor spec gains a mount and two auto-approved conductor-owned verbs; nothing a spec accepted before is refused, and every grant still passes the governance ceiling filter.
Reader: src/kiro_crew/agent_materialization/conductor_agents.py:_conductor_mcp_servers -- entry: release -- its three callers (
_conductor_spec,_install_pipeline_conductor_agent,_install_security_conductor_agent) are in this file and are updated; the privateworkkeyword had no other caller (signature pinned intest_agent_refactor_contracts.py).Tests
test/test_conductor_base_work_ledger.py: for each of conductor, ledger-conductor alias, pipeline and security, the written spec mountskirocrew-work, auto-approves both base verbs onallowedToolsand the derived KAS rule, and keepswork_reportgated. Pipeline and security prompts are exactly their charter plus the shared block (once); the goal conductor and alias prompts are their charter unchanged. A real-path test installs the pipeline conductor, runs goal, create, bind (conductor session) and report (worker) through the realapi_work_ledger_record/api_work_reportroutes, and folds the recorded entries through theworkstreamsfold into one board with the done task._conductor_mcp_serverssignature in the surface inventory, and the spec-byte goldens for the pipeline and security files only (events and state digests unchanged).-n 2. black, isort, flake8, mypy (repo venv), the comment-history gate, docs lint and semgrep (semgrep/+ p/python, p/security-audit, p/secrets) are clean.scripts/local-gate.py --dry-runplans 1730 backend and 804 frontend files under-n auto, close to the full suite, so that run is left to CI.Manual verification
N/A — unit coverage sufficient: the change is spec materialization plus the ledger routes and fold, all driven by the tests above.
Related Issues
Fixes #17977
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.