Skip to content

fix(chat): label the title regenerate button with a verb - #18016

Merged
bolichen97 merged 1 commit into
mainfrom
fix/regenerate-title-label-14443
Oct 8, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/regenerate-title-label-14443

Conversation

@bolichen97

@bolichen97 bolichen97 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The session header's title button says what it does ("Regenerate title"), so nobody reads it as "this title is automatic".

After pressing Enter in the rename editor, focus goes back to the title and reveals a button labelled "Auto-title". A tester read that noun as a status badge on the new name, not as a button.

Why it matters

Every user who renames a session with Enter sees this button. A label that reads like a state makes people think their typed name was replaced or marked automatic.

Not a goal

What changed (motivation → approach → change)

The button's visible label is the noun "Auto-title", while its tooltip already says "Regenerate title with LLM". The label now says the same verb as the tooltip, "Regenerate title", in all 12 catalogs under website/src/i18n/locales/ plus the regenerated en-XA pseudolocale. The same key names the phone menu item, so that reads "Regenerate title" too.

While a title is being made, the spinner shows its own progress phrase, "Generating title…", from a new key pages.chatPage.regenerating_title in all 12 catalogs. SessionTitleControl.tsx reads that key there instead of the button's label, so the busy state never shows an imperative verb that reads like another button.

The docs that name the button (docs/feature-map/README.md, the packaged user guide docs/dashboard.md, website/docs/narrow-viewport.md) and the evidence script website/scripts/capture-pane-header-autotitle.mjs use the new labels.

Backwards compatibility

Compatible: one catalog value changes and one key is added; the key pages.chatPage.auto_title and every behaviour stay the same.

Removes nothing: the button, its tooltip, its key and its behaviour are all kept; only the text on the button and the spinner changes.

Tests

  • website/src/test/SessionTitleControl.test.tsx: a new test pins the button text to "Regenerate title", its accessible name to start with "Regenerate title", and no "Auto-title" text anywhere. Red on main (Received: "Auto-title"), green here.
  • The spinner test in the same file reads "Generating title…" inside role="status" and asserts no "Regenerate title" text shows while busy.
  • The phone menu test in website/src/test/ChatPage.mobileSingleTopbar.test.tsx looks up the new label.
  • The existing Enter focus-return tests pass unchanged. Shuffled runs of SessionTitleControl.test.tsx pass 4 times.

Gates: tsc -p tsconfig.app.json, npm run i18n:check, lint:i18n, eslint on changed files, I18N_BASE_REF=origin/main vitest run src/i18n/style (the register checks, 117 tests), and vitest run src/i18n plus the title-control and phone-bar suites (805 tests) all pass.

Manual verification

Built the SPA from this branch and from main, and ran website/scripts/capture-pane-header-autotitle.mjs on each. Its label assert reads "Auto-title" / "自动命名" on main and "Regenerate title" / "重新生成标题" here; its spinner frame looks for "Generating title…". Its editor-selection frame fails the same way on main and on this branch, so the spinner and phone-menu shots below come from a one-off run of the same fixtures against this branch's build: the single-session header with a held title request, and the phone session menu opened from the title.

Screenshots / video

Hovered pane header, before (main):

before

After (this branch):

after

zh-CN, before and after

before zh-CN

after zh-CN

While a title is being made (en, zh-CN):

generating en

generating zh-CN

Phone session menu, the row beside Rename (en, zh-CN):

phone menu en

phone menu zh-CN

Related Issues

Closes #14443

Pattern harvest

Not generalizable: whether a short label reads as an action or a state is a wording judgment per control, not a shape a rule can match.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested a review from a team as a code owner October 8, 2026 05:46
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 8, 2026
@bolichen97
bolichen97 enabled auto-merge (squash) October 8, 2026 05:47
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of c7ec9fd4c81524c202a5db2d46b74384268a8fd4 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (5 items) — 5 justified

Intent: FIX. People who rename a session should see the header's title button as an action ("Regenerate title"), not as a badge saying the title is automatic. Provenance is Closes #14443, plus a test that fails on main (Received: "Auto-title").

  1. The header title button's visible label changes from "Auto-title" to "Regenerate title" in all 12 catalogs and en-XA — justified
  2. The phone session menu row changes to "Regenerate title" because it uses the same pages.chatPage.auto_title key, which SessionActionsMenu.tsx:218 is its only other consumer of — justified
  3. The busy spinner now reads "Generating title…" from the new key regenerating_title, which has one consumer, SessionTitleControl.tsx:441 — justified
  4. The feature map, the packaged dashboard.md and narrow-viewport.md use the new label — justified
  5. The evidence capture script asserts the new label and the new spinner phrase — justified

[FIRST-PRINCIPLES-REVIEWED] c7ec9fd

Description read

[DESCRIPTION-READ] cc1f26be3cb16661d1d767e29d24e33053a5277e7e09d687d8fd5acbe96c1884

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of c7ec9fd4c81524c202a5db2d46b74384268a8fd4 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that the eight attached screenshots show the "Regenerate title" label still fitting the pane header in narrow split panes and longer locales (de, ru).

[DESIGN-REVIEWED] c7ec9fd

Description read

[DESCRIPTION-READ] 53643877b56ee70409dfebf7f7d829e54f78d39fc844c9aabdfc978a2d8faa16

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of c7ec9fd4c81524c202a5db2d46b74384268a8fd4 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c7ec9fd

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c7ec9fd4c81524c202a5db2d46b74384268a8fd4: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of c7ec9fd4c81524c202a5db2d46b74384268a8fd4 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Check that the longer labels, such as ru "Сгенерировать заголовок заново", still fit beside a long title in a narrow split-pane header.

[UX-REVIEWED] c7ec9fd

Description read

[DESCRIPTION-READ] 7ba5c526cfb115eb7df4050537bc661f6c8102686665f1c307df3f0ab3c8dc6a

That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed c7ec9fd4c81524c202a5db2d46b74384268a8fd4 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] c7ec9fd

Verdict parsed from the review's SHA-scoped output markers for commit c7ec9fd4c81524c202a5db2d46b74384268a8fd4.

False positive or not applicable? A repository writer can comment:
/ai-review override fable c7ec9fd4c81524c202a5db2d46b74384268a8fd4: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 8, 2026
@bolichen97
bolichen97 force-pushed the fix/regenerate-title-label-14443 branch from e8f5061 to 21e9651 Compare October 8, 2026 06:12
@bolichen97

bolichen97 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=2e39d6530310 The in-progress label reads like a button.

fixed in 21e9651: the spinner now reads its own key pages.chatPage.regenerating_title ("Generating title…", all 12 catalogs), not the button's imperative label.
SessionTitleControl.test.tsx asserts the status shows "Generating title…" and no "Regenerate title" text while busy.

@bolichen97

bolichen97 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=b50b29c8a2a8 The main button was read correctly

rebutted: the item itself says no change is needed; the reader read the verb label correctly and the Undo offer the reader asked for is kept unchanged by this PR.

@bolichen97

Copy link
Copy Markdown
Contributor Author

The red Backend Tests (Windows) (1) shard on the previous head is test/test_crew_recency.py failing on main (patches a name #16867 removed); this PR does not touch it. Fix is in #18021; this PR waits for it.

@bolichen97
bolichen97 force-pushed the fix/regenerate-title-label-14443 branch from 21e9651 to d97f142 Compare October 8, 2026 06:21
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=446c077f8759 Pencil vs. regenerate

rebutted (out of goal, as the item itself says): the tooltip already says "the current name can be restored with Undo", and the Undo offer is unchanged; reworking the tooltip or pre-click Undo hint is new scope the frozen Not-a-goal excludes.
The evidence gaps (spinner state, menu row) are closed on d97f142: the description now carries en + zh-CN shots of "Generating title…" and of the phone menu row "Regenerate title" beside Rename.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 8, 2026
@bolichen97
bolichen97 force-pushed the fix/regenerate-title-label-14443 branch from d97f142 to c7ec9fd Compare October 8, 2026 07:11
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto main after #18021 merged (fixes the test_crew_recency red on backend shard 1); no change to this PR's diff. CI re-running.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 8, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on maintainer request after review: fix (20 files, label and docs only). The title control's button now reads "Regenerate title", and the busy state shows its own progress phrase ("Generating title…") instead of the button verb with an ellipsis. The new regenerating_title key is added to every locale; docs and the capture script follow the new wording. Spec files changed as a ride-along (a minority of the diff on both file count and changed lines), not reviewed as a design decision: docs/feature-map/README.md.

@bolichen97
bolichen97 merged commit 6d09c07 into main Oct 8, 2026
148 of 149 checks passed
@bolichen97
bolichen97 deleted the fix/regenerate-title-label-14443 branch October 8, 2026 09:48
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ux(chat): After I pressed Enter, an "Auto-title" badge suddenly appeared next to my new title and I…

2 participants