Repository navigation
fix(chat): label the title regenerate button with a verb - #18016
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (5 items) — 5 justifiedIntent: FIX. People who rename a session should see the header's title button as an action ("Regenerate title"), not as a badge saying the title is automatic. Provenance is Closes #14443, plus a test that fails on main (
[FIRST-PRINCIPLES-REVIEWED] c7ec9fd Description read[DESCRIPTION-READ] cc1f26be3cb16661d1d767e29d24e33053a5277e7e09d687d8fd5acbe96c1884 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the eight attached screenshots show the "Regenerate title" label still fitting the pane header in narrow split panes and longer locales (de, ru). [DESIGN-REVIEWED] c7ec9fd Description read[DESCRIPTION-READ] 53643877b56ee70409dfebf7f7d829e54f78d39fc844c9aabdfc978a2d8faa16 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Check that the longer labels, such as ru "Сгенерировать заголовок заново", still fit beside a long title in a narrow split-pane header. [UX-REVIEWED] c7ec9fd Description read[DESCRIPTION-READ] 7ba5c526cfb115eb7df4050537bc661f6c8102686665f1c307df3f0ab3c8dc6a That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
e8f5061 to
21e9651
Compare
|
|
21e9651 to
d97f142
Compare
|
d97f142 to
c7ec9fd
Compare
|
Rebased onto main after #18021 merged (fixes the |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved on maintainer request after review: fix (20 files, label and docs only). The title control's button now reads "Regenerate title", and the busy state shows its own progress phrase ("Generating title…") instead of the button verb with an ellipsis. The new regenerating_title key is added to every locale; docs and the capture script follow the new wording. Spec files changed as a ride-along (a minority of the diff on both file count and changed lines), not reviewed as a design decision: docs/feature-map/README.md.
Problem / Motivation
Goal: The session header's title button says what it does ("Regenerate title"), so nobody reads it as "this title is automatic".
After pressing Enter in the rename editor, focus goes back to the title and reveals a button labelled "Auto-title". A tester read that noun as a status badge on the new name, not as a button.
Why it matters
Every user who renames a session with Enter sees this button. A label that reads like a state makes people think their typed name was replaced or marked automatic.
Not a goal
What changed (motivation → approach → change)
The button's visible label is the noun "Auto-title", while its tooltip already says "Regenerate title with LLM". The label now says the same verb as the tooltip, "Regenerate title", in all 12 catalogs under
website/src/i18n/locales/plus the regenerateden-XApseudolocale. The same key names the phone menu item, so that reads "Regenerate title" too.While a title is being made, the spinner shows its own progress phrase, "Generating title…", from a new key
pages.chatPage.regenerating_titlein all 12 catalogs.SessionTitleControl.tsxreads that key there instead of the button's label, so the busy state never shows an imperative verb that reads like another button.The docs that name the button (
docs/feature-map/README.md, the packaged user guidedocs/dashboard.md,website/docs/narrow-viewport.md) and the evidence scriptwebsite/scripts/capture-pane-header-autotitle.mjsuse the new labels.Backwards compatibility
Compatible: one catalog value changes and one key is added; the key
pages.chatPage.auto_titleand every behaviour stay the same.Removes nothing: the button, its tooltip, its key and its behaviour are all kept; only the text on the button and the spinner changes.
Tests
website/src/test/SessionTitleControl.test.tsx: a new test pins the button text to "Regenerate title", its accessible name to start with "Regenerate title", and no "Auto-title" text anywhere. Red on main (Received: "Auto-title"), green here.role="status"and asserts no "Regenerate title" text shows while busy.website/src/test/ChatPage.mobileSingleTopbar.test.tsxlooks up the new label.SessionTitleControl.test.tsxpass 4 times.Gates:
tsc -p tsconfig.app.json,npm run i18n:check,lint:i18n, eslint on changed files,I18N_BASE_REF=origin/main vitest run src/i18n/style(the register checks, 117 tests), andvitest run src/i18nplus the title-control and phone-bar suites (805 tests) all pass.Manual verification
Built the SPA from this branch and from main, and ran
website/scripts/capture-pane-header-autotitle.mjson each. Its label assert reads "Auto-title" / "自动命名" on main and "Regenerate title" / "重新生成标题" here; its spinner frame looks for "Generating title…". Its editor-selection frame fails the same way on main and on this branch, so the spinner and phone-menu shots below come from a one-off run of the same fixtures against this branch's build: the single-session header with a held title request, and the phone session menu opened from the title.Screenshots / video
Hovered pane header, before (main):
After (this branch):
zh-CN, before and after
While a title is being made (en, zh-CN):
Phone session menu, the row beside Rename (en, zh-CN):
Related Issues
Closes #14443
Pattern harvest
Not generalizable: whether a short label reads as an action or a state is a wording judgment per control, not a shape a rule can match.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)