Skip to content

feat(settings): move Subagent Settings and Warm Pool to Settings > Agent Harness - #18048

Merged
bolichen97 merged 1 commit into
mainfrom
feat/settings-subagent-warm-pool-8940
Oct 8, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
feat/settings-subagent-warm-pool-8940

Conversation

@bolichen97

@bolichen97 bolichen97 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Subagent Settings and Warm Pool are edited from Settings > Agent Harness, next to the coding-agent switch, instead of from the Developer page.

The two cards that change how agents run (how many subagents, how many turns each, how many pre-started processes) only show on Developer > Config. That page is for internals and sits behind Developer Mode, so an ordinary user has no visible place to tune them. The Agent Harness tab already holds the other "how agents run" knob, the backend picker, since #13888.

Why it matters

A user who wants faster session starts (Warm Pool) or more parallel subagents has to find a hidden internals page. Putting both cards on the Settings tab that already governs agents makes them findable without Developer Mode.

Not a goal

  • Retiring /developer or moving any of its other tabs: the internals views stay where they are.
  • Changing what either card does, its defaults, or the config keys it writes.
  • Moving the read-only config viewers (Config Summary, the tables, the raw JSON editor).

What changed (motivation → approach → change)

Card Before After
Subagent Settings Developer > Config Settings > Agent Harness, with a visible line saying what it is and that it waits for Save
Warm Pool Developer > Config Settings > Agent Harness, named "Pre-started Sessions", with a visible line saying what it does and that it saves on change

The cards keep their controls and config keys. Settings is read by people who never open the internals page, so the cards speak plainly there: "Kept Ready", "Retire After" and "Uses Crewmate" replace "Pool Size", "Pool TTL" and "Pool Agent"; the empty Uses Crewmate option reads "Default crewmate ()"; each card shows one line saying what it does and how it saves. The Max Turns hint says a turn is one tool call (default 1000).

KiroCrewCfgTab.tsx exports AgentRunSettings, which renders both cards on the same ['kirocrewConfig'] cache, so an edit on one page shows on the other; a refused warm-pool save shows through ErrorNotice, and Subagent Settings keeps an unsaved draft safe on the shared tab: it resyncs only when its own stored values change, so a harness switch or warm-pool edit leaves the draft alone, and it stakes a leave guard so a hand-off from the picker's error notices asks before dropping it. SettingsPage.tsx lazy-loads it under the backend picker on the agent tab, in its own Suspense boundary. Developer > Config no longer renders the cards, and its subtitle drops the "Subagent Settings has its own Save" clause. Every locale carries the new copy; en-XA.json is regenerated. The agent row of docs/feature-map/README.md names the two cards.

Backwards compatibility

Compatible: the same controls write the same config keys through the same endpoints; only the page that hosts them changes.

Reader: website/src/pages/SettingsPage.tsx:AgentRunSettings -- entry: crew page -- the cards now render on /settings/agent (SettingsPage.agentHarness.test.tsx "hosts the Subagent Settings and Warm Pool cards beside the switch")
Reader: KiroCrewCfgTab.tsx:KiroCrewCfgTab (in website/src/pages/overview) -- entry: crew page -- Developer > Config keeps every other card (CfgTabCoverage.test.tsx "leaves Subagent Settings and Warm Pool to Settings > Agent Harness")

Tests

  • SettingsPage.agentHarness.test.tsx: the Agent Harness tab renders the run cards beside the switch, waiting for each lazy panel on its own. Red on origin/main, green here.
  • CfgTabCoverage.test.tsx: the Developer config tab no longer shows either card; every existing Subagent Settings and Warm Pool test renders AgentRunSettings under the new labels; cross-card cases render both on one cache; a failed warm-pool patch shows as an alert in its own card; each card's visible line renders; the empty Uses Crewmate option names the default crewmate.
  • CfgTabCoverage.test.tsx "stakes a leave guard while a subagent draft is unsaved": the guard stakes nothing when clean and asks before leaving a dirty draft. Red without the guard.
  • CfgTabCoverage.test.tsx "keeps an unsaved subagent draft when an unrelated config write lands": red when the card resyncs on any config object.
  • SettingsPage.agentHarnessSignIn.test.tsx: stubs the run cards, which read a config shape that suite does not seed.
  • The i18n style suites (register, spacing) pass on the changed values.
  • Determinism: the three files ran 3 times with --sequence.shuffle and random seeds, all passing.

Manual verification

Rendered the real SettingsPage and DeveloperPage through the capture harness (capture/settings-agent-harness.html) with fixture API answers, before and after, and checked both pages by eye. Gates run locally: tsc, eslint, i18n:check, i18n:render, phantom-classes, restyle-ratchet, jscpd, scoped frontend tests, vite build with bundle-size and chunk-cycle checks.

Screenshots / video

Settings > Agent Harness, after:

Settings > Agent Harness after

Developer > Config, after (no Subagent Settings or Warm Pool):

Developer > Config after

Before (origin/main)

Settings > Agent Harness before

Developer > Config before

Related Issues

Closes #8940

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 8, 2026 07:04
@bolichen97
bolichen97 requested a review from buluoray October 8, 2026 07:04
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 8, 2026
@bolichen97
bolichen97 enabled auto-merge (squash) October 8, 2026 07:05
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of dd2fbd9229b4c2011fc814b9affdbe18da5edf56 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The move rests on #8940, but the relabel that rides along has no named user who misread "Warm Pool", and the card now says the same thing twice.

Not justified as shipped

  • Item 3 — unjustified move: the description justifies the relabel only by saying "Settings is read by people who never open the internals page, so the cards speak plainly there". That is a preference, and nobody is named as having misread "Pool Size/TTL/Agent". The shipped src/kiro_crew/docs/index.md:72 still says "Warm Pool".
    Subtraction: put back the warm_pool, pool_size, pool_ttl and pool_agent values in every locale.
    Clears when: a linked report shows users misread the old labels, or the relabel is reverted.
  • Item 4 — duplicate of warm_pool_description (the InfoTip on the same card): "Keeps agents started so new chats open at once" repeats "Keep a few agents started… so a new chat opens right away". That is 1 repeated sentence.
    Subtraction: cut warm_pool_save_note down to its save clause.
    Clears when: the repeated clause is gone.

What this change ships

Inventory (9 items) — 7 justified

Intent: let ordinary users tune subagent limits and pre-started sessions without turning on Developer Mode. This is an ADDITION (a move).

  1. Subagent Settings moves from Developer > Config to Settings > Agent Harness — justified
  2. Warm Pool moves from Developer > Config to Settings > Agent Harness — justified
  3. Warm Pool and its fields are renamed (Pre-started Sessions, Kept Ready, Retire After, Uses Crewmate) — unjustified move: relabel, nobody named as failing
  4. Each card shows a visible line saying what it does and how it saves — duplicate of warm_pool_description InfoTip
  5. The Max Turns and pool hints are rewritten in plain words — justified
  6. The empty Uses Crewmate option names the default crewmate — justified
  7. Leaving with an unsaved subagent draft now asks for confirmation — justified
  8. An unrelated config write no longer resets the subagent draft — justified
  9. The Developer > Config subtitle drops the Subagent Save clause — justified

[FIRST-PRINCIPLES-REVIEWED] dd2fbd9

Description read

[DESCRIPTION-READ] ef618adbcc92d112559f9ebbee520fe0703a937f3c581b4febcf8769063a8096

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of dd2fbd9229b4c2011fc814b9affdbe18da5edf56 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that the shipped docs and guides that still say "drain the warm pool" make sense now that the dashboard calls the card "Pre-started Sessions".

Suggestions

  • In the same commit, add the new label next to the old term in src/kiro_crew/docs/index.md:72 (still a "Warm Pool" row) and in the "drain the warm pool" steps in connections.md and docs/guides/connecting-remote-oauth-mcp-server.md. A user following those steps will look for a card that no longer goes by that name.

[DESIGN-REVIEWED] dd2fbd9

Description read

[DESCRIPTION-READ] 2aaa3a8cc3b7269a34b3f4bef66f4c2ca38ca3bfd59946f2f9ab7fe35cba8168

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of dd2fbd9229b4c2011fc814b9affdbe18da5edf56 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

"agent" means two things on one page: the harness picker ("New sessions use this agent") and the new Pre-started Sessions copy ("Keeps agents started").

Watch

  • Same word, two meanings on Agent Harness. The picker's "agent" is Kiro CLI / KAS / Claude Code. The new strings warm_pool_save_note ("Keeps agents started…"), number_of_pre_spawned_processes_0_disables ("How many agents to keep started") and agent_for_pool_processes… ("Which crewmate the waiting agents start as") use it for pre-started processes. The card title says "Sessions" while its body says "agents". The blind reader: "I can't tell an agent from a crewmate." Every visitor to this tab sees it. It causes confusion, not task failure. Fix: say "sessions" all through the card, e.g. "How many sessions to keep started and waiting."
  • "Retire After" is unclear. The blind reader: "I am not sure what 'Retire After' means, though (1800 seconds before they shut down?)". The meaning is only in the InfoTip. The reader also rated both run cards' controls "a guess". Seen on first use, low impact. Fix: rename the label to something like "Restart idle after".
  • New states aren't shown. The ErrorNotice for a refused warm-pool save and the window.confirm leave guard for an unsaved subagent draft appear in no screenshot. A screenshot of each would let reviewers check them.

Suggestions

  • warm_pool_save_note: drop "Keeps agents started so new chats open at once", which repeats the warm_pool_description InfoTip. Keep "Changes save right away, and you can change them back."

[UX-REVIEWED] dd2fbd9

Description read

[DESCRIPTION-READ] 2f437fc390aade1cdcd90da7e0fec95c4b71429d0989e392cd5073628ee16895

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of dd2fbd9229b4c2011fc814b9affdbe18da5edf56 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] dd2fbd9

False positive or not applicable? A repository writer can comment:
/ai-review override gpt dd2fbd9229b4c2011fc814b9affdbe18da5edf56: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed dd2fbd9229b4c2011fc814b9affdbe18da5edf56 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] dd2fbd9

Verdict parsed from the review's SHA-scoped output markers for commit dd2fbd9229b4c2011fc814b9affdbe18da5edf56.

False positive or not applicable? A repository writer can comment:
/ai-review override fable dd2fbd9229b4c2011fc814b9affdbe18da5edf56: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 8, 2026
@bolichen97
bolichen97 force-pushed the feat/settings-subagent-warm-pool-8940 branch from 838c66c to 286425a Compare October 8, 2026 08:02
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 8, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Render the moved save failure through ErrorNotice span=1c02ff41008c

fixed in 286425a: the warm-pool save error renders through ErrorNotice (inline, no hand-off; a comment names the unsaved Subagent Settings draft beside it). A test asserts it is announced as an alert.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Wait independently for both lazy panels span=092fb7df9a95

fixed in 286425a: the placement test awaits each lazy panel with its own findByTestId and an explicit 5s timeout, with a comment naming the two independent lazy imports.

@bolichen97
bolichen97 force-pushed the feat/settings-subagent-warm-pool-8940 branch from 286425a to f224e85 Compare October 8, 2026 08:29
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Conflicting save cues: severity span=1faf6e33f73d

fixed in f224e85: Pre-started Sessions now carries a muted line, "Each change here saves as soon as you make it.", matching Subagent Settings' "Changes here apply only when you press Save." Each card states its own save model; a test asserts both notes render.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Inherited relabel not justified span=23954ec2941e

rebutted: the relabel is the UX lane's own BLOCK on head 838c66c (spans e676e411f2b3, cb9d23d2814b, 157e5d1fbef8: "Warm Pool", "Pool TTL", "Pool Agent" unreadable to the Settings audience this move creates). Moving the card without it fails the UX gate; keys and behaviour are unchanged.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Default crewmate dropdown label span=2dea40fdfdce

rebutted: the "(name)" default label is the existing shared CfgSelect convention, unchanged by this PR; the hint reads "Empty uses the default crewmate." Out of goal.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Conflicting save cues: what the user experiences span=5b15b946ac2d

fixed in f224e85: Pre-started Sessions now carries a muted line, "Each change here saves as soon as you make it.", matching Subagent Settings' "Changes here apply only when you press Save." Each card states its own save model; a test asserts both notes render.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Page header no longer describes the page span=815242c3ddd4

rebutted: the subtitle belongs to the Agent Harness tab itself (settings.tabs.agent), not to the moved cards; rewording the tab is out of goal. The two cards carry their own titles and save notes.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Subagent Settings jargon: turn span=88e2b59f1d31

rebutted: the Max Turns hint now says a turn is one tool call and gives the default (100). Moving the hint inline would restyle a card this PR only relocates; out of goal.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Conflicting save cues: fix span=9591a37a87c4

fixed in f224e85: Pre-started Sessions now carries a muted line, "Each change here saves as soon as you make it.", matching Subagent Settings' "Changes here apply only when you press Save." Each card states its own save model; a test asserts both notes render. Unifying the two save models is out of goal (Not a goal: changing what either card does).

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Conflicting save cues: cause span=bb439807c2ae

fixed in f224e85: Pre-started Sessions now carries a muted line, "Each change here saves as soon as you make it.", matching Subagent Settings' "Changes here apply only when you press Save." Each card states its own save model; a test asserts both notes render.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Warm Pool save resets an unsaved Subagent Settings draft span=17e65a15318a

rebutted: pre-existing, intended behaviour carried over unchanged. The two cards shared one page and one cache on Developer > Config too, and the existing test "resyncs local edits when a fresh config arrives" pins that a fresh config replaces the uncommitted subagent draft. The new save line on Subagent Settings tells the reader to press Save.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Save button looks disabled span=1e24c14db65e

rebutted: Save is disabled until the form has edits, then full weight; that is the shared button style, unchanged by this PR. The card now states "Changes here apply only when you press Save." Restyling the shared button is out of goal.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Heading group for the run cards span=71dcd0ea7849

rebutted: each card already carries its own title and save line under the picker; an extra heading layer is new layout this move does not need.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Mixed vocabulary in Pre-started Sessions span=77e06ca3e8ad

rebutted: "session", "agent" and "crewmate" are the dashboard's established nouns for three different things (the chat, the process that runs it, the configured identity). The card uses each for its own referent; unifying them is a product-wide vocabulary change, out of goal.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Move AgentRunSettings under pages/settings span=cecdfbe643f7

rebutted: AgentRunSettings shares CfgNumber, CfgSelect and the config types with KiroCrewCfgTab; splitting them into a new module is a refactor beyond the move. Placement and behaviour are tested where they live.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Show Retire After in minutes span=d3310fca45f1

rebutted: the field keeps its seconds unit and its "s" suffix as the config key stores it; a unit change is out of goal.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Docs out of date span=dd057d8d29e5

fixed in 89755f7: the feature-map agent row names Subagent Settings and Pre-started Sessions with their config keys and the PUT/PATCH endpoints; the stale comment in KiroCrewCfgTab.tsx now names the Workspaces create dialog, the draft still on that page.

@bolichen97
bolichen97 force-pushed the feat/settings-subagent-warm-pool-8940 branch from 89755f7 to dd2fbd9 Compare October 8, 2026 11:34
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • New labels were correct guesses span=0049203b35de

rebutted: the reader guessed each label correctly; the hints carry the full meaning. More copy rounds would keep widening a move PR.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Save-note lines ride along span=53940e0e5e46

rebutted: UX spans bb439807c2ae and b7519e70fc0f required a visible line per card. the UX lane BLOCKed heads 838c66c, 286425a and 3b7e9e7 on this copy (spans e676e411f2b3, bb439807c2ae, b7519e70fc0f); the relabel, hints, save lines and default-crewmate option are its required fixes, and reverting re-fails that gate. Keys, config paths and behaviour are unchanged.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Hint rewrites ride along span=600b74651e8f

rebutted: the UX lane BLOCKed heads 838c66c, 286425a and 3b7e9e7 on this copy (spans e676e411f2b3, bb439807c2ae, b7519e70fc0f); the relabel, hints, save lines and default-crewmate option are its required fixes, and reverting re-fails that gate. Keys, config paths and behaviour are unchanged.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Two save models side by side span=8bfeabe107f7

rebutted: each card states its save rule in its visible line; unifying the save models changes what a card does, which the frozen Not-a-goal excludes.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Empty-option label ride along span=90416c277c9b

rebutted: UX span 85a7a4151e3c required it. the UX lane BLOCKed heads 838c66c, 286425a and 3b7e9e7 on this copy (spans e676e411f2b3, bb439807c2ae, b7519e70fc0f); the relabel, hints, save lines and default-crewmate option are its required fixes, and reverting re-fails that gate. Keys, config paths and behaviour are unchanged.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Pre-started Sessions vs agents span=989fed64a08b

rebutted: the card's value is sessions that start instantly; the hints describe the agents that make that possible. Each noun names its own thing.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Switching harnesses silently discards unsaved subagent settings span=cc7e3de6ed48

fixed in dd2fbd9: SubagentSettings resyncs its draft only when the stored subagent_max_turns, max_subagents or subagent_auto_max change, not on every new config object, so a harness switch or warm-pool edit keeps the draft. New test "keeps an unsaved subagent draft when an unrelated config write lands" is red with the old [cfg] dependency.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Inherited relabel span=d4e0db38a94f

rebutted: the UX lane BLOCKed heads 838c66c, 286425a and 3b7e9e7 on this copy (spans e676e411f2b3, bb439807c2ae, b7519e70fc0f); the relabel, hints, save lines and default-crewmate option are its required fixes, and reverting re-fails that gate. Keys, config paths and behaviour are unchanged.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Retire After vs restart span=eb0c5866a2c9

rebutted: the label names the effect for the user (the waiting agent is retired and replaced); the hint names the mechanism. Both are accurate.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Rename Max Turns span=ebec8b1cd424

rebutted: "turn" is the term the subagent tool, docs and config key (subagent_max_turns) use; renaming only the label would split the vocabulary.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Relabel not justified span=09525db556ac

rebutted: the UX lane BLOCKed heads 838c66c, 286425a and 3b7e9e7 on this copy (spans e676e411f2b3, bb439807c2ae, b7519e70fc0f); its blind reader could not read the old labels on Settings. Reverting re-fails that gate. Keys, config paths and behaviour are unchanged.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Same word, two meanings span=1c4d4477bbd4

rebutted: the warm pool pre-starts the selected harness's agent processes, so "agent" names the same thing the picker selects.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Name the new label in the user docs span=3e448909ccde

rebutted: the user docs describe the warm pool by its config keys (session.pool_size and friends), which are unchanged; the card title is one place among several. A docs pass is out of this move's goal.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Retire After is unclear span=424c3f9a4a41

rebutted: the reader's own guess (shut down after 1800 s) is correct, and the hint states it. Further copy rounds widen a move PR.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Save note repeats the description span=b4ecf6daadcd

rebutted: the visible line is what a reader sees without opening the hint; the UX lane required a visible what-it-does line (span b7519e70fc0f). The hidden hint is the same idea for the reader who opens it, not a second visible copy.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • New states not shown in screenshots span=f49fc1582ec1

rebutted: both states are pinned by tests ("surfaces a failed warm-pool patch in its own card and refetches" asserts the alert; "stakes a leave guard while a subagent draft is unsaved" asserts the confirm). The confirm is the browser's native dialog.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Trim the save note span=f75f4c120b13

rebutted: the visible what-it-does half was the UX lane's own required fix (span b7519e70fc0f); dropping it reopens that BLOCK.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 8, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

This PR moves the Subagent Settings and Warm Pool cards from Developer > Config to Settings > Agent Harness. It also renames user-visible labels ("Pool Size/Pool TTL/Pool Agent" become "Kept Ready/Retire After/Uses Crewmate", and the card becomes "Pre-started Sessions") and rewrites copy in all 14 locales. I read the description and the lane history. The draft-resync fix for the GPT finding (cc7e3de6ed48: resync only when the card's own stored keys change) is a real fix and is pinned by a test. Every Design, UX and First Principles item on head dd2fbd9 has a posted disposition. I am holding because this is a product/UX decision: it changes where two run-time knobs live, takes them out from behind Developer Mode, and renames them. Several rounds of UX BLOCKs drove that copy, and the PR does not show a maintainer signing off on the placement or the new names. Auto-merge is already armed, so a maintainer should confirm the placement and the labels before it lands. Checks are green and base is main. — crew-pr-reviewer

@cruisercohen cruisercohen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after review: relocates Subagent Settings and Warm Pool to Settings > Agent Harness with no change to config keys or endpoints, so persistence is unchanged. The two shared-cache regression gaps (unsaved draft surviving an unrelated config write; leave guard against the picker hand-off) are each closed with a dedicated test.

@bolichen97
bolichen97 merged commit 8dd0c3b into main Oct 8, 2026
102 checks passed
@bolichen97
bolichen97 deleted the feat/settings-subagent-warm-pool-8940 branch October 8, 2026 23:13
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings > Developer: should the remaining /developer tabs move too?

3 participants