Skip to content

feat(chat): draw the crew window with the shared transcript and composer - #18095

Merged
iamwhatever merged 1 commit into
mainfrom
feat/16774-crew-window-shared-components
Oct 9, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
feat/16774-crew-window-shared-components

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A crew session's window shows the same chat rows and composer as a local chat, so tool calls, cards, approvals and future chat features reach crew sessions too.

The crew chat window (CrewChatWindow.tsx, wave 3 of the remote-crew sidebar RFC) kept its own copy of the transcript, the approval card, the running label and a bare textarea. A tool call on the peer showed as a raw 🔧 … line, a sent file as raw JSON, and no new row type ever reached it.

Why it matters

Every chat feature had to be built twice, and the crew copy fell behind. People driving a crew session saw less than in a local chat for the same work.

Not a goal

What changed (motivation → approach → change)

The window now feeds the peer's slot data into the shared parts instead of drawing rows itself.

Part Before After
Rows own messages.map shared ChatMessageList + dashboard row set (reply row kept copy-only)
Running own spinner line + Stop shared ChatFooter + the composer's Stop
Approval own card shared approval group in the transcript
Composer bare textarea shared ChatInput (side-panel preset)

Approve answers only the row the peer says is pending: same request id AND same row id (meta.mid). The peer's slot detail used to drop that id: _prepare_messages_scoped (chat_utils.py) replaces meta with the parsed cls dict, and cls has no mid. It now keeps the stored row's non-empty mid when cls replaces meta, for permission rows only, so every other row's wire meta is unchanged (a mid inside cls still wins). Without this, every Approve against a real peer was refused. The peer reuses request ids, so a stale card for a reused id makes no peer call. The "Approve runs this one command…" hint still shows under a pending approval.

crewWindowRenderers.tsx lets in only shared rows on an allowlist (PEER_SAFE_ROWS). A new shared row falls back to the store-free default until someone adds it. Left out: the launch cards (they read the hub's run by id) fall back to the tool line, and a sent file shows as "The agent on sent . The file stays on ." The user row adds the peer's rewind. The reply row stays plain markdown (it comes after the shared notice and completion cards, so those still win): the shared reply's verdict thumbs would write the hub's own decision log.

Every code fence in the window is copy-only. A new ReadOnlyCodeCtx in components/markdown/contexts.ts does for a subtree what the readOnlyCode prop does for one renderer; the window wraps its transcript in it, so no peer fence (reply, user, skill or inject row) offers Edit or Run in THIS machine's terminal.

Offline, a disabled fieldset turns the whole composer off, as before and as the RFC says.

The shared rows and composer mount under a slot key no local session has, so they never pick up a hub session's state.

Five crewWindow strings only the old card and textarea used are removed from every locale; one new string (file_on_crew) is added. The feature map row names the new file.

Backwards compatibility

Compatible: the window reads and posts the same peer routes with the same bodies; only how rows are drawn changed.

Reader: website/src/i18n/locales/*.json:pages.chat.crewWindow.{approval_title,approve,reject,stop,send} -- crew page -- no reader left; git grep on origin/main finds them only in CrewChatWindow.tsx, which no longer uses them (npm run i18n:check key-refs passes).
Reader: website/src/test/CrewChatWindow.test.tsx:crew-window-approval / crew-window-running test ids -- crew page -- no other reader on origin/main; the tests now find the shared Approve button and the footer's Thinking… status.

Tests

test/test_prepare_messages_permission_mid.py: a runner-shaped permission row (_ChatSlot.append("permission", ..., json.dumps({...}))) through _prepare_messages keeps its meta.mid; fails on origin/main. Three more cases: a mid in cls is not overwritten, a row with no stored mid gains none, and a non-permission row's wire meta gains no mid (red when the role check is removed). The 14 pytest files that call _prepare_messages or read slot detail pass (1492 tests).

The crew window fixture now sends the real wire shape: JSON cls, meta parsed from it, mid carried by the server. A new case pins that a row with no mid (an older peer) gets no peer call.

website/src/test/CrewChatWindow.test.tsx, updated for the shared parts, plus eight new cases:

  • draws a peer tool call as the shared tool line, not its raw text
  • draws a peer file as its name, never as the hub outbox file of that name
  • answers only the approval the peer itself reports pending
  • answers no stale card whose request id the peer has reused: red when the mid check is removed (mutation run)
  • says what Approve and Reject do while an approval is pending
  • lets in only shared rows decided safe for a peer (a new row falls back): fails on any new shared row id nobody decided
  • draws a peer code fence copy-only, with no Run into this machine: red when readOnlyCode is removed (mutation run)
  • draws a code fence in a peer USER row copy-only too: red when the context is off (mutation run)
  • still draws a peer system notice as its card, not as a reply: red when the reply row is moved ahead of the shared rows (mutation run)

The existing cases still pin approve, stop, continue, regenerate, rewind, send, draft recovery, the event feed, the version gate and the offline disabled composer. Determinism: 38/38 on three repeats and with --sequence.shuffle.

Manual verification

Rendered the real CrewChatWindow in Chromium against a stubbed proxy (user row, reply, tool call, sent file, pending native approval). Checked in the DOM: tool line present, raw 🔧 text gone, file row shows its name, the old approval card is gone, Approve is in the transcript, composer present.

Local AI review: WARNING, the extracted gpt and opus lanes (and a sonnet fallback) all failed on Bedrock throttling with no report, so this head had only a manual self-review against both contracts before push. CI's lanes are the first model review.

Screenshots / video

All "after" shots were taken on head 8713de07c2; later heads change no pixel, the real CrewChatWindow against a stubbed proxy.

Before (origin/main): raw tool text, raw file JSON, separate approval card, bare textarea.

before

After, idle: Rewind on the user row, a typed draft, Send.

idle with draft and send

After, running: thinking indicator and the composer's Stop.

running

After, approval pending: the sent-file row, the approval in the transcript, and its hint.

file row and approval hint

After, peer offline: "devbox is not connected" and the composer turned off.

peer offline

Related Issues

Closes #16774
Part of #6180

RFC: docs/request-for-change/rfc-remote-crew-sidebar.md

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 8, 2026 08:44
@iamwhatever
iamwhatever requested a review from bolichen97 October 8, 2026 08:44
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 91a262b8fa3145d6e8655207867e65ac19409fde — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check one thing before merge: the Approve button in the shared transcript should reach the peer through the real /api/instances/{id}/proxy/ path with the newly kept meta.mid still on the row.

[DESIGN-REVIEWED] 91a262b

Description read

[DESCRIPTION-READ] a4f19ae3570f12c08200dd24477a1ba30ed5464dc7d5926607ff08f5a2305269

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of 91a262b8fa3145d6e8655207867e65ac19409fde — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The composer's unlabeled red-square Stop replaces the labeled "Stop", and the blind reader would not use it because they couldn't tell what it ends.

Watch

  • Stop lost its label. The old window had a text "Stop" button. The shared composer now shows only a red square. The header still says "Closing does not stop the agent on devbox," so it is unclear what the square stops. The reader's words: "no, it has no label, and I don't know if it stops just this reply or the whole job on devbox." Severity: every running turn, and the risk is cutting off remote work. Fix: give the crew window's Stop a visible label or tooltip naming its scope, e.g. "Stop this reply on devbox".
  • The approval hint sits outside the approval group and out of line. It renders below the transcript in its own px-4 mx-auto block (crew-window-approval-hint). In shot-04 it starts about 16px left of the content column and is cut off from the Approve/Reject buttons it explains. The reader noticed it was "shifted left and out of line with everything else". Severity: every pending approval, where Approve and Reject are decided. Fix: render the hint inside the approval group, directly under the buttons, on the same inset.
  • file_on_crew contradicts itself. "The agent on devbox sent upload-timings.csv. The file stays on devbox." The reader said: "'sent', yet it 'stays' there." The row also cannot be clicked, which leaves the reader unsure what they can do with the file. Severity: every peer file row; it costs comprehension, not the task.

Suggestions

  • pages.chat.crewWindow.file_on_crew: change it to "The agent on {{name}} made {{file}}. It stays on {{name}} and can't be opened here."

[UX-REVIEWED] 91a262b

Description read

[DESCRIPTION-READ] 23c0d1a99a1210d640073eebe106dbb6bcf1e8555af49106dfa69e63f6521378

That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 91a262b8fa3145d6e8655207867e65ac19409fde — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Before merge, check on a real peer (not the stubbed proxy) that Approve in the shared transcript row reaches the peer with the meta.mid the backend now keeps.

What this change ships

Inventory (10 items) — 10 justified

Intent: People driving a crew session should see the same chat rows and composer as in a local chat, so every chat feature does not have to be built twice. ADDITION (wave 3 of the partial RFC rfc-remote-crew-sidebar, closes #16774).

  1. Peer tool calls, notices, completions and thinking now show as the shared rows instead of raw 🔧 text — justified
  2. A file the peer sent shows as "The file stays on " instead of raw JSON — justified
  3. The separate approval card is gone; Approve and Reject now sit in the transcript's shared permission row — justified
  4. Stop moved from the running line and the approval card into the composer's Stop — justified
  5. The bare textarea is replaced by the shared side-panel composer, which is still turned off when the crew is offline — justified
  6. Every code fence in the window is copy-only, through a new ReadOnlyCodeCtx context — justified
  7. The peer's slot detail now carries meta.mid on permission rows (wire change in chat_utils.py) — justified
  8. A stale card whose request id the peer reused makes no peer call — justified
  9. The reply row stays plain markdown, with no verdict thumbs that would write the hub's decision log — justified
  10. Five crewWindow strings are removed from every locale and one (file_on_crew) is added — justified

[FIRST-PRINCIPLES-REVIEWED] 91a262b

Description read

[DESCRIPTION-READ] fb4e6c2298a3f139105b304da38339320297fc20e5f63c1bfe6017d922062df4

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 91a262b8fa3145d6e8655207867e65ac19409fde and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 91a262b

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 91a262b8fa3145d6e8655207867e65ac19409fde: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 91a262b8fa3145d6e8655207867e65ac19409fde — this comment is updated in place on each push.

Review details

No findings that block the merge.

FINDING — website/src/pages/chat/crew-window/crewWindowRenderers.tsx:35 — 'workflow_completion' is on PEER_SAFE_ROWS, so a peer's workflow completion card is drawn with the shared WorkflowCompletionCard, and that card's panel button runs dispatch(openActivityToTab('workflows')). That opens this hub's Workflows panel for the hub's own active session, not the peer's run, which contradicts the list's "no hub API, no hub file" contract → Fix: remove 'workflow_completion' from PEER_SAFE_ROWS (or draw the row without the panel button) until the card can point at the peer's run.

[OPUS-REVIEWED] 91a262b

Verdict parsed from the review's SHA-scoped output markers for commit 91a262b8fa3145d6e8655207867e65ac19409fde.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 91a262b8fa3145d6e8655207867e65ac19409fde: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 8, 2026
@iamwhatever
iamwhatever force-pushed the feat/16774-crew-window-shared-components branch from a28ea4c to a774688 Compare October 8, 2026 11:09
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 8, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • A stale approval card can authorize a different request span=382e37d5e4da

Disposition: fixed. Fixed in a774688: each permission row hands back its own meta.mid with its id, and approve posts only when id AND mid match the peer's pending request, sending that mid. Test answers no stale card whose request id the peer has reused goes red when the mid check is removed.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Offline composer no longer disabled span=d82d2f36b2b5

Disposition: fixed. Fixed in a774688: a disabled fieldset turns the whole composer off offline, so the textbox is disabled again; the test is back to toBeDisabled().

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Pinned "input disabled" decision reversed span=792d951c1c92

Disposition: fixed. Fixed in a774688: same change as d82d2f36b2b5; the RFC's "input disabled" holds again and the body no longer claims otherwise.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The denylist fails open span=3c13dc2f7951

Disposition: fixed. Fixed in a774688: the filter is now an allowlist (PEER_SAFE_ROWS), so a new shared row falls back to the store-free default. Test lets in only shared rows decided safe for a peer fails on any shared row id nobody decided.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Approve and Reject lost their explanation span=cb931b55c8a9

Disposition: fixed. Fixed in a774688: the existing approval_hint line ("Approve runs this one command. Reject skips it…") shows under a pending approval again; pinned by says what Approve and Reject do while an approval is pending.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The sent-file row is a bare muted file name span=40aea6e86746

Disposition: fixed. Fixed in a774688: the row now reads "The agent on sent . The file stays on that crew." (new file_on_crew string, all locales). See the after-v2 screenshot.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Stop is now an unlabeled red square span=8093a2e004ec

Disposition: rebutted. This is the shared composer's Stop control, the same one every local chat uses, with title and aria-label "Stop generation". The goal of #16774 is for the crew window to match local chat; relabelling the shared control would change every chat and is out of this goal.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 8, 2026
@iamwhatever
iamwhatever force-pushed the feat/16774-crew-window-shared-components branch from a774688 to 8a5f6c7 Compare October 8, 2026 12:03
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 8, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Peer code fences lose the guard against hub-side execution span=382e37d5e4da

Disposition: fixed. Fixed in 8a5f6c7: the crew window registers its own assistant row that renders the peer reply with MarkdownRenderer readOnlyCode (copy only, no Edit, no Run in terminal), as before this PR. Test draws a peer code fence copy-only, with no Run into this machine goes red when readOnlyCode is removed.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Peer decisions_strip writes the hub decision log span=a8223a6f5191

Disposition: fixed. Fixed in 8a5f6c7: the same assistant row draws only the peer text, so no verdict thumbs (and no hub file chips) render for a peer reply.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • workflow_completion Panel button opens the hub Workflows panel span=a8223a6f5191

Disposition: deferred. Same item answered on 8713de0: it opens the hub's own Workflows tab, writes nothing and reaches no peer. Every check is green, so it rides the follow-up (drop workflow_completion from PEER_SAFE_ROWS).

@iamwhatever
iamwhatever merged commit 50239ff into main Oct 9, 2026
106 of 112 checks passed
@iamwhatever
iamwhatever deleted the feat/16774-crew-window-shared-components branch October 9, 2026 06:41
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 9, 2026
iamwhatever pushed a commit that referenced this pull request Oct 10, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
iamwhatever pushed a commit that referenced this pull request Oct 10, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
iamwhatever pushed a commit that referenced this pull request Oct 10, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
iamwhatever pushed a commit that referenced this pull request Oct 10, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
iamwhatever pushed a commit that referenced this pull request Oct 10, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
iamwhatever pushed a commit that referenced this pull request Oct 10, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
iamwhatever pushed a commit that referenced this pull request Oct 10, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
iamwhatever pushed a commit that referenced this pull request Oct 10, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
iamwhatever pushed a commit that referenced this pull request Oct 10, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
iamwhatever pushed a commit that referenced this pull request Oct 10, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
iamwhatever pushed a commit that referenced this pull request Oct 10, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
iamwhatever pushed a commit that referenced this pull request Oct 11, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
iamwhatever pushed a commit that referenced this pull request Oct 11, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
iamwhatever pushed a commit that referenced this pull request Oct 11, 2026
The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765
chenmingwei23 pushed a commit that referenced this pull request Oct 11, 2026
…#18801)

The crew chat window passed the shared composer none of its model,
effort or agent props, and drew its own reply row plus loose "Rewind to
here" / "Regenerate" buttons. In a two-machine test it showed a bare
message box, misplaced actions and a reply row unlike the local chat.

- The composer's model chip and model + effort picker (the shared
  ModelEffortDropdown) now read the peer's roster and write the PEER
  slot's model and effort through the hub proxy. ReasoningEffortDropdown
  gains an optional writeEffort seam for that write.
- Attach, the agent picker and the approval-mode picker would write
  this machine's state, not the peer's, so the window does not draw them.
- User and reply rows are the local UserMessage / AssistantMessage
  bubbles with the same hover rows: Quote stages a message for the next
  send, Edit & Resend rewinds on the peer, Regenerate sits on the newest
  reply's row. Peer rows keep the #18095 fences: decision
  records are stripped before drawing (no verdict thumbs) and the reply
  draws no file-change chips; code stays copy-only.

Closes #18765

Co-authored-by: Joe Guo <zejiangg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crew chat window: reuse the shared transcript and composer components

3 participants