Repository navigation
feat(crewmate-chat): fold a run of steps into one live line with a quiet finished summary - #18221
iamwhatever wants to merge 1 commit into
Conversation
9adca77 to
f87d886
Compare
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that opened steps render correctly with the outer row's [DESIGN-REVIEWED] 98bebed Description read[DESCRIPTION-READ] e68a962c036d140f8d16334043ac8f6ce5ac045a25e7e74abbac46220e77493e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The collapsed live line reads as an order: its title is the agent's imperative step text, so the reader feared clicking would start the merge. Watch
Suggestions
[UX-REVIEWED] 98bebed Description read[DESCRIPTION-READ] fd1e1dac814b4a597522324fa6467c6ad2e7d76cdd3e6b30e980d7e9e9952028 That sha256 names everything this verdict read: the PR description, plus the 31 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check before merge: a thinking-only run that comes before mid-turn speech is now dropped, so a running turn shows less thinking than it does on main. What this change shipsInventory (7 items) — 7 justifiedIntent: let a person chatting with a crewmate see one "working on X" line instead of a growing log of step rows. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 98bebed Description read[DESCRIPTION-READ] 6ec38d349484ee60bffbc49e25a67f3641b6095125271aab21a1d020dce3356a That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings block this merge. FINDING — website/src/components/chat/crewmateBubbles.ts:191 — a live run that starts with a [OPUS-REVIEWED] 98bebed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
f87d886 to
dcfca79
Compare
dcfca79 to
e60817e
Compare
e60817e to
82f14fe
Compare
|
|
|
|
|
|
|
|
|
|
|
|
|
…iet finished summary A crewmate's live tool/thinking rows now draw as ONE collapsed line: a pulsing mark, the current step's title and the step count; the pane's working footer hides while it is the newest row. A finished turn the crewmate spoke in keeps a quiet 'Did N steps' line. Both open on click or Enter (aria-expanded) to the ordinary tool line and thinking rows. Ordinary chats are unchanged.
c9aeadc to
98bebed
Compare
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Problem / Motivation
Goal: While a crewmate works, its chat shows one line that says it is working and what step it is on, instead of a growing list of tool rows; when the turn ends the steps fold away, as they already do since #17794.
In a crewmate's chat on the Crew page, a running turn draws every tool call and thinking burst as its own row (
Verify heads and build approve/RC bodies,Post 5 approvals…,Merge clean PRs…, each with a status dot), plus the ghost working animation below them. A 1:1 chat with a crewmate reads like a log, not a conversation, and shows two "working" indicators at once.Why it matters
The Crew page chat is meant to read like messaging a teammate. A wall of step rows pushes the crewmate's actual words off screen and makes every patrol look noisy; the reader only needs to know that it is working and on what, with the detail one click away.
Not a goal
What changed (motivation → approach → change)
A crewmate's live tool rows were drawn one per row because #17794 only filtered which rows the chat keeps; nothing grouped them. The grouping now happens in the same place:
filterCrewmateChatfolds each contiguous run of the running turn's progress rows into one syntheticcrewmate_stepsrow carrying the folded rows, their tool-call count and whether it is the step the crewmate is on now (the run with nothing drawn after it). A run that the crewmate has spoken after stays in place as its own quiet line, so mid-turn speech stays where it was said; such an earlier run with no tool call (thinking only) has no step to count and is dropped. When the turn has no run at its tail (just opened, or just spoke) an empty live row stands in, so the turn shows one working line from start to end. The turn's trailingstreamingrow (text started before the tools, which the store parks below the tool rows) does not end the live run, and the footer still stands down. A run keys on its first tool call, so the live line keeps its identity and open state as steps arrive. When the turn ends, every steps line folds away, exactly as #17794 left it.A new
website/src/pages/chat/CrewmateStepsLine.tsxdraws that row as one disclosure button, the sharedBtnflattened to a text line (aria-expanded,aria-controls, a native button so Enter and Space work). Live: the tool line's own spinning ring (still underprefers-reduced-motion), the current step's title (the slot's live tool status, else the newest call's purpose or title, else "Thinking"; wrapping in full on narrow screens rather than cut, with a tooltip) and "N steps"; open, the heading keeps only the count, since the running row below names the step; before the first step a plain "Thinking" line with nothing to open. An earlier run of the same turn reads "Worked through N steps", the existingpages.chat.turnBlock.worked_through_stepsummary. Opened, it draws the folded rows, indented past the chevron, through the same renderer registry, so each is the ordinary tool line with its own live state (running, done, failed) from the slot's tool log. The crewmate renderer set inwebsite/src/pages/chat/transcriptRenderers.tsxgains the entry; ChatPane hides its PLAIN working footer while the live line is the newest row (stopping and compacting still show), and the line carries the footer'srole="status"announcement, so only one working indicator shows. The steps row is run-transparent, so bubble corners are unchanged. One new plural keypages.chat.crewmateSteps.stepin every catalog underwebsite/src/i18n/(pluspluralKeys.json);chatRolesParity.contract.test.tsdocuments the new renderer id;crew-mode.mdand the Crewmate chat row ofdocs/feature-map/README.mddescribe the rule.Backwards compatibility
Compatible: only a crewmate's chat (ChatPane with
crewmate) builds or draws the new row; the role never reaches the wire or any other surface.Removes nothing: the folded rows are still drawn when the line opens, and the transcript and Work log keep every row as before.
Tests
crewmateBubbles.test.ts: a running turn folds into ONE live row counting only 🔧 calls (✅/🚫 siblings and thinking ride along); a thinking-only live run is still live; a settled reply after a run makes it not live; mid-turn speech keeps an earlier run as its own line; a working line shows from the turn's start and again after mid-turn speech, but not after a pending approval; a trailing streaming row parked below the tools does not end the live run; when the turn ends every steps row folds away, even when it spoke between them; an earlier turn's steps are gone; the row keys on its first step.CrewmateStepsLine.test.tsx: collapsed by default; live shows the ring, current step and "3 steps"; the slot's live tool status wins; trailing thinking reads "Thinking"; the title has a tooltip; astatusannouncement; the open live heading keeps only the count; before the first step there is nothing to open; reduced-motion class; an earlier run reads "Worked through 3 steps" without the ring; singular; click opens/closes witharia-expanded/aria-controls; Enter opens it.ChatPane.crewmate.test.tsx: a running crewmate turn draws one collapsed live line and no footer, also when a streaming row is parked below its tool rows (red against a last-row-only check); an ordinary chat with the same rows still draws its tool row and the footer, no steps line.ChatPane.*,TurnBlock*,CrewmateMessageand role-parity suites pass locally, run serially (39 files).Manual verification
Rendered the real
ChatMessageListwith the crewmate renderer set in Storybook (a local, uncommitted story) and captured each state below in light and dark at 320px and 1100px; checked the DOM for the line's text, the absent footer and no horizontal overflow at 320px. Local gates:tsc -p tsconfig.app.json, eslint--max-warnings 0on the touched files,npm run i18n:checkwithI18N_BASE_REF=origin/main.Screenshots / video
Before (main): the ghost footer at turn start, then one row per step plus the footer.
After: turn start (one working line, no footer); live collapsed; live open (each row its real state: two done, the newest spinning); mid-turn speech (earlier run stays in place, newest run live); finished (steps folded away, as on main):
Narrow (320px): the live title wraps in full instead of being cut.
Every variant (light/dark x 320px/1100px)
Related Issues
Builds on #17794.
Checklist