Repository navigation
docs(session): idle-exempt sessions also end on an account switch - #18225
iamwhatever merged 1 commit into
Conversation
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 95ef7c8 Description read[DESCRIPTION-READ] 9d5fb490e95924890797d9d07ea2afd988298e627350bbc4a2ee55b89f350c49 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Before merge, check that the help text's "mid-turn ... at a later dashboard chat turn" sentence matches how a busy session actually gets retired. What this change shipsInventory (4 items) — 4 justifiedIntent: an operator gets correct docs on what still ends an idle-exempt session. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 95ef7c8 Description read[DESCRIPTION-READ] c77e366d9a25121680c196bd4175d21a5e281492556b2441eb0aa0903a59fdb3 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
344a088 to
8625b71
Compare
8625b71 to
5b92130
Compare
3850375 to
de575c1
Compare
The session.idle_exempt_keys help text and docs said that only the RSS limit or a gateway restart ends a listed session with no tab. The identity sweep (retire_kiro_identity_sessions) also retires one after a Kiro account switch or sign-out, and it reads no list. It runs before each dashboard chat turn and at once on a dashboard sign-out, not on a cron fire. The five places drop "only", name the account switch and say when it takes effect.
de575c1 to
95ef7c8
Compare
iamwhatever
left a comment
There was a problem hiding this comment.
This PR corrects the session.idle_exempt_keys help text and docs. They claimed a listed session with no tab is ended only by the RSS limit or a gateway restart, but the Kiro identity sweep also ends it. I checked the new wording against main. retire_kiro_identity_sessions (session_lifecycle.py:1963) reads no exempt list, chat_runner.py calls it before each dashboard turn with the live fingerprint, and kas_login._retire_runtimes_after_sign_out runs it on a dashboard sign-out. Busy sessions are flagged and retired later, which matches the new mid-turn sentence. Only prose changes: one help string and its regenerated baseline line, plus three doc passages. No identity or auth code path changes, so no hold rule applies. All lanes PASS on the current head, CI is green, the PR is mergeable on main and nobody has requested changes. — crew-pr-reviewer
Problem / Motivation
Goal: The
session.idle_exempt_keyshelp text and docs say that a Kiro account switch or sign-out also ends a listed session with no tab, and when it does, instead of claiming that only the RSS limit or a gateway restart does.#16034 added
session.idle_exempt_keys. In five places it says that a listed key no tab ever claimed, such as a cron job that runs without one, is ended only by the RSS recycle or a gateway restart. That is wrong. The identity sweep also ends it. At the next dashboard chat turn after a Kiro account switch or sign-out,retire_kiro_identity_sessions(session_lifecycle.py) retires each idle kiro-backed session not spawned under the live account. A Kiro sign-out from the dashboard runs it at once with no live account, so it retires every idle kiro-backed session, whatever account each signed in with. The sweep reads no list.Why it matters
An operator who trusts "only" expects a listed session to outlive everything but a restart. After an account switch it starts cold anyway, which is the cold start the setting exists to avoid. The reverse case is missing too: after a sign-out in a terminal, on a host where only crons run, a listed session keeps working on the previous account until a dashboard chat takes a turn, and no doc says so.
Not a goal
What changed (motivation → approach → change)
The five places now say that a listed session with no tab keeps running after its job is deleted, and that the RSS limit or a gateway restart still ends it. On the kiro-cli or KAS backend, so does a Kiro sign-out or account switch: a Kiro sign-out from the dashboard ends it at once, whatever account it signed in with, and any other switch or sign-out of the account it signed in with ends it at the next dashboard chat turn. None of them says "only" any more.
config/sections.py, andconfig-baseline.jsondocs/configuration.mdsession.idle_exempt_keysrow carries the same sentences.docs/system-specs/modules/session.md("Idle cleanup") anddocs/system-specs/modules/config.md(SessionConfig)dashboard/chat_runner.pyruns the sweep before each dashboard chat turn, and the dashboard's Kiro sign-out indashboard/handlers/kas_login.pyruns it at once with no live account. A cron fire does not run it. The sweep walks every session, leaves alone providers that do not use the Kiro identity store and sessions spawned under the live account, and retires the rest; with no live account it spares no kiro-backed session. A busy one is flagged and retired later. The sweep landed in #4159, before #16034, so the "only" was wrong from the start.Backwards compatibility
Compatible: only prose changes; no key, default, type or code path differs.
Removes nothing: the diff rewords one help string, its copy in the baseline, and three doc passages.
Tests
No test is added or changed, since only prose changes.
test/test_config_baseline.py(test_committed_snapshot_matches_generator) checks the regeneratedconfig-baseline.json, andtest/test_session_idle_exempt_keys.pypasses unchanged.Manual verification
N/A: no behaviour changes. The new sentences were checked against main.
retire_kiro_identity_sessionswalksowner._sessions, skips only providers that do not use the Kiro identity store and sessions spawned under the live account, and never readssession.idle_exempt_keys. Its callers are_retire_sessions_on_identity_change, which_run_chatawaits before each dashboard turn, and_retire_runtimes_after_sign_outon the dashboard's Kiro sign-out, which passes no fingerprint, sospawned_underspares no session. The cron callback inslack/gateway.pyacquires its session without either.Related Issues
Follows #16034, which added the setting for issue #16618.
no linked issue: a wording fix to docs that #16034 added, with no separate issue.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)