Skip to content

fix(chat): name the private chat rows by what they do with memory - #18336

Merged
chenmingwei23 merged 2 commits into
mainfrom
fix/private-chat-menu-copy
Oct 12, 2026
Merged

chenmingwei23 merged 2 commits into
mainfrom
fix/private-chat-menu-copy

Conversation

@buluoray

@buluoray buluoray commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A user can tell, from the sidebar menu alone, what "Incognito" and "Temporary" chats do and start one with a single tap.

The sidebar offers the two private chat modes behind a New ephemeral chat submenu, in the + New caret menu and in both folder menus (list view and board view). "Ephemeral" appears nowhere else in the product: the mode picker, Settings and the memory chip all say Incognito and Temporary. At phone width the submenu becomes a small-caps caption with a ghost icon, followed by the two rows. The caption looks like a menu item but does nothing when tapped. The folder menus also showed the bare words "Incognito" and "Temporary" with nothing explaining how they differ.

The phone-width New chat in folder caption had the same problem: it used the same Folder glyph as the folder rows under it, so it read as one more row.

Why it matters

Incognito and Temporary differ only in what they do with memory, and that difference is the whole reason to pick one. A user who cannot tell them apart picks at random or skips both. On a phone the menu also has a row that looks tappable and does nothing.

Not a goal

  • Renaming the modes themselves. "Incognito" and "Temporary" stay as they are everywhere else (mode picker, Settings, memory chip).
  • Changing what either mode does. Memory behaviour and transcript retention are unchanged (decision record).
  • Restyling the other small-caps captions in the filter menu (FILTER / SORT BY, stale-collapse). Those carry no row icon and are not mistaken for items.

What changed (motivation → approach → change)

  • Why: the confusion comes from a grouping word nobody else uses, and at phone width from a heading drawn like a row.
  • Approach: remove the grouping layer. Each row names its own action and says in one line what it does with memory. Three designs were mocked up (flat rows, a text-only caption, one entry with a memory toggle); the owner picked flat rows.
  • Change:
    • New website/src/pages/chat-sidebar/PrivateChatRow.tsx: icon, label and one-line hint for the two modes. The + New menu and both folder menus render it, so the wording cannot drift between them.
    • Hints: Uses memory, learns nothing new (Incognito) and No memory, learns nothing new (Temporary). "Learns" rather than "saves": both modes keep their transcript in History, so the hint names what does not happen (nothing new reaches memory) without implying the chat itself disappears.
    • ChatSidebar.tsx: the ephemeral submenu and its phone caption are gone from all three menus. The two rows sit at the top level on desktop and phone alike. The now-unused Ghost and ContextMenuSub* imports are removed.
    • The phone-width New chat in folder caption drops its icon and gets a separator above, in the existing FILTER / SORT BY caption style.
    • website/scripts/restyle-baseline.json: ChatSidebar.tsx lowered from 37 to 24, recording the primitive restyles this diff removed.
    • Catalog: pages.chatSidebar.new_ephemeral_chat is replaced by new_incognito_chat, new_temporary_chat, incognito_hint, temporary_hint in all 12 shipped languages; en-XA regenerated with npm run i18n:pseudo.
    • Docs: the folder-menu entry in docs/feature-map/README.md and the entry_path in test/gui_user/features.json now name the new rows.

Backwards compatibility

Compatible: only menu structure and copy change. The create calls, memory modes and data-testids on the create rows are the same.

Reader: website/src/pages/ChatSidebar.tsx -- the only renderer of pages.chatSidebar.new_ephemeral_chat and of the new-ephemeral sub-trigger test ids, both removed in this diff.
Reader: website/src/test/ChatSidebar.ephemeralCreate.test.tsx, website/src/test/ChatSidebar.folderEphemeralCreate.test.tsx -- the only tests that opened the submenu; updated to the flat rows.
Reader: test/gui_user/features.json -- entry_path text naming the old row; updated; test/gui_user/test_features_catalog.py passes.
Reader: CHANGELOG.md -- a shipped section mentions "New ephemeral chat"; left untouched, as shipped sections must be.

Searched on origin/main with git grep -i "new_ephemeral_chat\|new-ephemeral\|New ephemeral chat" outside the locale catalogs.

Tests

  • ChatSidebar.ephemeralCreate.test.tsx: the + New menu lists both modes as top-level rows with their hint on desktop and phone (it.each), the rows sit in the root menu, and no "ephemeral" text remains. New case: at phone width the folder list is under a text-only caption that is not a menu item and holds no icon. Existing create-call assertions (memory mode rides the CREATE, run mode '') are unchanged.
  • ChatSidebar.folderEphemeralCreate.test.tsx: the same flat-rows assertion for the folder ⋯ menu on desktop and phone. The incognito/temporary create-in-folder assertions are kept.
  • Mutation checks: swapping the incognito hint for the temporary one reddens 4 tests; putting the Folder icon back on the phone caption reddens the new caption test.
  • Ran: vitest run src/test/ChatSidebar (114 files, 1194 tests), tsc -b, eslint on touched files, lint:restyle-ratchet, lint:i18n, pytest test/gui_user/test_features_catalog.py test/test_check_feature_map.py, scripts/docs-lint.sh.

Manual verification

Built the SPA and drove the three menus on an isolated scratch gateway (separate KIROCREW_HOME, two seeded folders), dark theme: the list-view folder ⋯ menu and the board-column folder ⋯ menu at 1280px, and the + New menu at 390px.

Not covered: the phone-width New chat on crew caption. It renders only while a peer crew holds a live tunnel, which this host cannot produce, so it is left exactly as on main (icon kept) rather than changed without a screenshot. Follow-up: apply the same text-only caption there and capture it on a host with a connected crew.

Screenshots / video

Folder ⋯ menu, list view, desktop:
Folder menu desktop

Folder ⋯ menu, board view, desktop:
Board folder menu

  • New menu, phone (390px), showing the flat rows and the text-only NEW CHAT IN FOLDER caption:
    New menu phone

Related Issues

Introduced by #6857 (the "New ephemeral chat" submenu), #7327 (its phone-width caption) and #8171 (the same structure in the folder menu).

Pattern harvest

Not generalizable: a one-off naming and layout choice in one menu family, not a repeatable code defect.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of cc5075b1309152d9a1c4de13036b6d10c1751b14 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Confirm the guide index changes are covered: the description never mentions sessions.create-menu.ephemeral being dropped or sessions.create-menu.temporary being added. No reader of the old id remains in the tree.

[DESIGN-REVIEWED] cc5075b

Description read

[DESCRIPTION-READ] 64fb215cede4123111de48825b1b0b902b7540f641c2fc4f1e068b9d4459e09b

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of cc5075b1309152d9a1c4de13036b6d10c1751b14 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] cc5075b

False positive or not applicable? A repository writer can comment:
/ai-review override gpt cc5075b1309152d9a1c4de13036b6d10c1751b14: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of cc5075b1309152d9a1c4de13036b6d10c1751b14 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The new memory hints are a second wording of the glosses MemoryModeChip still shows. The + New flattening also reverses a commented decision without addressing why it was made.

Not justified as shipped

  • Item 5 — duplicate of components.welcomeView.incognito_desc / temporary_desc (website/src/components/MemoryModeChip.tsx:104-105): on base, the + New submenu already showed these glosses. The diff swaps them for new pages.chatSidebar.incognito_hint / temporary_hint keys in all 12 locales. The sidebar and the memory chip now explain the same two modes in two different wordings, and those will drift apart.
    Subtraction: delete the two *_hint keys and have PrivateChatRow render the existing *_desc keys.
    Clears when: PrivateChatRow reads components.welcomeView.*_desc, or one of the two wordings is removed so only one remains.
  • Item 1 — inherited: the diff deletes a comment that recorded why the rows were grouped: "they are two spellings of one choice … listing both at the top level would double the session-type rows a user reads before picking an ordinary chat." The description never answers that cost. Its only support is "the owner picked flat rows", with no link to that choice.
    Clears when: a linked maintainer decision or issue shows the row-count rationale was wrong.

What this change ships

Inventory (8 items) — 4 justified

Intent: let a user tell Incognito and Temporary apart from the sidebar menu and start either one in a single tap. This is a FIX.

  1. Incognito and Temporary move from a submenu to the top level of the + New menu on desktop — inherited (reverses the comment on row count)
  2. The "New ephemeral chat" caption that looked tappable at phone width is gone from all three menus — justified
  3. The folder menus (list and board view) list both modes flat, each with a hint — justified
  4. The rows are relabelled "New incognito chat" / "New temporary chat" — justified
  5. The + New rows show new hint copy instead of the existing glosses — duplicate of welcomeView.*_desc
  6. The phone-width "New chat in folder" caption loses its icon and gets a separator above it — rides along
  7. The find_ui index drops sessions.create-menu.ephemeral and adds .temporary — undeclared
  8. One shared row body is used by all three menus — justified

[FIRST-PRINCIPLES-REVIEWED] cc5075b

Description read

[DESCRIPTION-READ] 4634465a3cc77d35b4b2732bf04d71b9eab66eb3d294ea9bcd3118d3de190725

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of cc5075b1309152d9a1c4de13036b6d10c1751b14 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The blind reader still can't tell incognito from temporary: both hints end in "learns nothing new", so only the opening two words differ.

Watch

  • Both rows were read only as "a guess" and confused with each other. Each hint ends in the same clause ("Uses memory, learns nothing new" / "No memory, learns nothing new"), so the only difference is the first two muted 11px words. The blind reader reported: "I can't easily tell it apart from incognito… both end with 'learns nothing new'", and "'Incognito' makes me think nothing is used at all, so 'Uses memory' surprised me." This PR's stated goal is that users can tell the modes apart. The shared clause works against that on all three menus, every time someone opens them. The rows are still usable, so this is a concern rather than a blocker.
  • "Memory" is too abstract for a first-time user. The reader could not tell whether "Uses memory", "No memory" and "Choose memory mode" refer to the same thing. The hint should describe what the user will see happen, not use the internal term.

Suggestions

  • Make each hint carry only the difference and drop the repeated clause. For example, incognito_hint: "Knows what it's learned about you; adds nothing", and temporary_hint: "Starts blank; remembers nothing".

[UX-REVIEWED] cc5075b

Description read

[DESCRIPTION-READ] e7a4cbbca333ee146319fefdd2effc35e81e4304da133c083955b34684298eff

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed cc5075b1309152d9a1c4de13036b6d10c1751b14 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] cc5075b

Verdict parsed from the review's SHA-scoped output markers for commit cc5075b1309152d9a1c4de13036b6d10c1751b14.

False positive or not applicable? A repository writer can comment:
/ai-review override fable cc5075b1309152d9a1c4de13036b6d10c1751b14: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 9, 2026
@buluoray
buluoray force-pushed the fix/private-chat-menu-copy branch from 9043a4e to 4aeb85b Compare October 9, 2026 20:16
@buluoray

buluoray commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

UX Review on 9043a4e, addressed in 4aeb85b:

  • Evidence gaps: the description now has the phone + New menu at 390px showing the text-only NEW CHAT IN FOLDER caption, and the board-column folder ⋯ menu. The New chat on crew caption only renders while a peer crew holds a live tunnel, which this host cannot produce, so that slice is reverted to main and listed under "Not covered" as a follow-up instead of shipping unverified.
  • "Saves nothing new" reads as "the chat isn't kept": fixed. Both hints now say "learns nothing new" (Incognito: "Uses memory, learns nothing new"; Temporary: "No memory, learns nothing new"), in all 12 languages. That keeps the transcript truth, and the difference still comes first ("Uses memory" / "No memory").
  • "Memory" is undefined: kept on purpose. The mode picker, the memory chip and Settings all call it memory, so the row matches the word the user meets everywhere else.
  • EyeOff matches Hide folder: kept. EyeOff is the product-wide Incognito glyph (memory-mode chip, the incognito badge on session rows). Changing it here alone would make this the one surface where Incognito looks different.

@buluoray
buluoray marked this pull request as ready for review October 9, 2026 20:16
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners October 9, 2026 20:16
@buluoray
buluoray requested a review from chenmingwei23 October 9, 2026 20:16
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 9, 2026
@buluoray

buluoray commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=6d8b0cd233b3 — rebutted

Incognito using memory is the product's real behaviour, and the mode picker already says so (incognito_desc: "Uses existing memory but learns no lessons"). The hint states that fact; renaming the mode is outside this PR's goal.
Owner ruling (PR author and maintainer @buluoray): keep the shipped hints "Uses memory, learns nothing new" / "No memory, learns nothing new".
A menu row carries one short line; what the chat keeps is already explained where the mode is chosen (components.welcomeView.incognito_desc / temporary_desc: "Keeps the transcript for tab recovery").

@buluoray

buluoray commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=d13c2567df9a — rebutted

"Does it get deleted?" is about transcript retention, which the mode picker description answers; the menu row stays one short line.
Owner ruling (PR author and maintainer @buluoray): keep the shipped hints "Uses memory, learns nothing new" / "No memory, learns nothing new".
A menu row carries one short line; what the chat keeps is already explained where the mode is chosen (components.welcomeView.incognito_desc / temporary_desc: "Keeps the transcript for tab recovery").

@buluoray

buluoray commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=d85a9469af97 — rebutted

The two hints differing by one word is the intent: memory on vs off is the only difference between the modes, so the shared clause is shared on purpose.
Owner ruling (PR author and maintainer @buluoray): keep the shipped hints "Uses memory, learns nothing new" / "No memory, learns nothing new".
A menu row carries one short line; what the chat keeps is already explained where the mode is chosen (components.welcomeView.incognito_desc / temporary_desc: "Keeps the transcript for tab recovery").

@buluoray

buluoray commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=db5e70fa2d99 — rebutted

The goal is that the two rows read as two distinct actions instead of an unclickable "ephemeral" caption; the hints name the one axis they differ on.
Owner ruling (PR author and maintainer @buluoray): keep the shipped hints "Uses memory, learns nothing new" / "No memory, learns nothing new".
A menu row carries one short line; what the chat keeps is already explained where the mode is chosen (components.welcomeView.incognito_desc / temporary_desc: "Keeps the transcript for tab recovery").

@buluoray

buluoray commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=59a19719d724 — rebutted

Severity rests on the blind reader's doubt about the mode names, which this PR keeps unchanged from main and from the mode picker.
Owner ruling (PR author and maintainer @buluoray): keep the shipped hints "Uses memory, learns nothing new" / "No memory, learns nothing new".
A menu row carries one short line; what the chat keeps is already explained where the mode is chosen (components.welcomeView.incognito_desc / temporary_desc: "Keeps the transcript for tab recovery").

@buluoray

buluoray commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=08ef2faa9a43 — rebutted

Adding "· stays in History" to both rows was offered to the owner and declined: it lengthens every row to restate the mode picker description.
Owner ruling (PR author and maintainer @buluoray): keep the shipped hints "Uses memory, learns nothing new" / "No memory, learns nothing new".
A menu row carries one short line; what the chat keeps is already explained where the mode is chosen (components.welcomeView.incognito_desc / temporary_desc: "Keeps the transcript for tab recovery").

@buluoray

buluoray commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=61a84379f8a0 — rebutted

"memory" is the product-wide term (the memory mode button and chip); using the same word in the rows is consistency, not a new concept. Linking the chip to the rows is out of this PR's goal.
Owner ruling (PR author and maintainer @buluoray): keep the shipped hints "Uses memory, learns nothing new" / "No memory, learns nothing new".
A menu row carries one short line; what the chat keeps is already explained where the mode is chosen (components.welcomeView.incognito_desc / temporary_desc: "Keeps the transcript for tab recovery").

@buluoray

buluoray commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=c279b9f890b8 — rebutted

incognito_desc / temporary_desc are two-sentence descriptions for the mode picker; a menu row needs a one-line form. The hints say the same thing (uses / no memory, learns nothing) in menu length, so there is one meaning with a long and a short wording, not two competing descriptions.

@buluoray

buluoray commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=e46bf49abf78 — rebutted

The flat layout is the owner's direct decision on this PR (author and maintainer @buluoray picked layout A from three mockups). The confusion it fixes is checkable on main: the submenu trigger reads "New ephemeral chat", an internal term, and on phone it renders as an unclickable caption with an icon.

@buluoray
buluoray force-pushed the fix/private-chat-menu-copy branch from 4aeb85b to 696c2d7 Compare October 9, 2026 22:49
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 11, 2026
@buluoray
buluoray force-pushed the fix/private-chat-menu-copy branch from d355ec8 to 9896d54 Compare October 11, 2026 00:09
@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 11, 2026
@buluoray
buluoray force-pushed the fix/private-chat-menu-copy branch from 9896d54 to 8f6d55c Compare October 11, 2026 01:02
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 11, 2026
@buluoray
buluoray force-pushed the fix/private-chat-menu-copy branch from 8f6d55c to 23402cc Compare October 11, 2026 03:10
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 11, 2026
@buluoray
buluoray force-pushed the fix/private-chat-menu-copy branch from 23402cc to d6dc7b6 Compare October 11, 2026 05:56
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Oct 11, 2026
@buluoray
buluoray force-pushed the fix/private-chat-menu-copy branch from d6dc7b6 to 90598c1 Compare October 11, 2026 07:15
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 11, 2026
@buluoray

Copy link
Copy Markdown
Contributor Author
  • span=93f42f265c32 — rebutted

The hints follow the recorded decision docs/decisions/2026-09-25-incognito-and-temporary-chats-keep-their-transcript.md: both modes promise "learn nothing", not "leave nothing", so each hint names what does not happen (nothing new reaches memory).
Incognito does use existing memory; saying so is the product's real behaviour, and the mode picker already says the same (incognito_desc: "Uses existing memory but learns no lessons").
The PR body explains "learns" over "saves": both modes keep their transcript in History, so "saves nothing" would imply the chat disappears.
The suggested "Knows your memory" names the capability as something the chat possesses, which the owner's copy rule for these rows avoids.
Owner ruling: keep "Uses memory, learns nothing new" / "No memory, learns nothing new". The same copy passed this lane on d6dc7b6; this head differs only by a rebase.

The sidebar offered Incognito and Temporary behind a "New ephemeral
chat" submenu. "Ephemeral" appears nowhere else in the product, and at
phone width the submenu collapsed into a small-caps caption with an
icon that read as a button but did nothing when tapped.

The + New menu and both folder menus now list "New incognito chat" and
"New temporary chat" as flat rows, each with a one-line hint ("Uses
memory, saves nothing new" / "No memory, saves nothing new"), rendered
by one shared PrivateChatRow. The phone-width "New chat in folder" and
"New chat on crew" captions drop the icon that made them look like the
rows under them.
…ws them

The create menu no longer has a "New ephemeral chat" submenu: Incognito
and Temporary sit at its top level on every viewport. The guide registry
still described the submenu, so it pointed guides at a control that is no
longer drawn and labelled incognito with a key the row stopped rendering.

- drop sessions.create-menu.ephemeral; its search terms move to incognito
- sessions.create-menu.incognito sits under sessions.create-menu on desktop
  and mobile, labelled pages.chatSidebar.new_incognito_chat
- add sessions.create-menu.temporary beside it
- the SubTrigger marker test uses a fixture id, since no shipped location
  sits on a submenu row any more
- regenerate ui-index.generated.json and guidePlans.gen.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants