Repository navigation
fix(chat): name the private chat rows by what they do with memory - #18336
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Confirm the guide index changes are covered: the description never mentions [DESIGN-REVIEWED] cc5075b Description read[DESCRIPTION-READ] 64fb215cede4123111de48825b1b0b902b7540f641c2fc4f1e068b9d4459e09b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The new memory hints are a second wording of the glosses Not justified as shipped
What this change shipsInventory (8 items) — 4 justifiedIntent: let a user tell Incognito and Temporary apart from the sidebar menu and start either one in a single tap. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] cc5075b Description read[DESCRIPTION-READ] 4634465a3cc77d35b4b2732bf04d71b9eab66eb3d294ea9bcd3118d3de190725 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The blind reader still can't tell incognito from temporary: both hints end in "learns nothing new", so only the opening two words differ. Watch
Suggestions
[UX-REVIEWED] cc5075b Description read[DESCRIPTION-READ] e7a4cbbca333ee146319fefdd2effc35e81e4304da133c083955b34684298eff That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
9043a4e to
4aeb85b
Compare
|
UX Review on 9043a4e, addressed in 4aeb85b:
|
|
|
|
|
|
|
|
|
|
4aeb85b to
696c2d7
Compare
d355ec8 to
9896d54
Compare
9896d54 to
8f6d55c
Compare
8f6d55c to
23402cc
Compare
23402cc to
d6dc7b6
Compare
d6dc7b6 to
90598c1
Compare
|
The sidebar offered Incognito and Temporary behind a "New ephemeral
chat" submenu. "Ephemeral" appears nowhere else in the product, and at
phone width the submenu collapsed into a small-caps caption with an
icon that read as a button but did nothing when tapped.
The + New menu and both folder menus now list "New incognito chat" and
"New temporary chat" as flat rows, each with a one-line hint ("Uses
memory, saves nothing new" / "No memory, saves nothing new"), rendered
by one shared PrivateChatRow. The phone-width "New chat in folder" and
"New chat on crew" captions drop the icon that made them look like the
rows under them.
…ws them The create menu no longer has a "New ephemeral chat" submenu: Incognito and Temporary sit at its top level on every viewport. The guide registry still described the submenu, so it pointed guides at a control that is no longer drawn and labelled incognito with a key the row stopped rendering. - drop sessions.create-menu.ephemeral; its search terms move to incognito - sessions.create-menu.incognito sits under sessions.create-menu on desktop and mobile, labelled pages.chatSidebar.new_incognito_chat - add sessions.create-menu.temporary beside it - the SubTrigger marker test uses a fixture id, since no shipped location sits on a submenu row any more - regenerate ui-index.generated.json and guidePlans.gen.ts
Problem / Motivation
Goal: A user can tell, from the sidebar menu alone, what "Incognito" and "Temporary" chats do and start one with a single tap.
The sidebar offers the two private chat modes behind a New ephemeral chat submenu, in the + New caret menu and in both folder menus (list view and board view). "Ephemeral" appears nowhere else in the product: the mode picker, Settings and the memory chip all say Incognito and Temporary. At phone width the submenu becomes a small-caps caption with a ghost icon, followed by the two rows. The caption looks like a menu item but does nothing when tapped. The folder menus also showed the bare words "Incognito" and "Temporary" with nothing explaining how they differ.
The phone-width New chat in folder caption had the same problem: it used the same Folder glyph as the folder rows under it, so it read as one more row.
Why it matters
Incognito and Temporary differ only in what they do with memory, and that difference is the whole reason to pick one. A user who cannot tell them apart picks at random or skips both. On a phone the menu also has a row that looks tappable and does nothing.
Not a goal
What changed (motivation → approach → change)
website/src/pages/chat-sidebar/PrivateChatRow.tsx: icon, label and one-line hint for the two modes. The + New menu and both folder menus render it, so the wording cannot drift between them.ChatSidebar.tsx: the ephemeral submenu and its phone caption are gone from all three menus. The two rows sit at the top level on desktop and phone alike. The now-unusedGhostandContextMenuSub*imports are removed.website/scripts/restyle-baseline.json:ChatSidebar.tsxlowered from 37 to 24, recording the primitive restyles this diff removed.pages.chatSidebar.new_ephemeral_chatis replaced bynew_incognito_chat,new_temporary_chat,incognito_hint,temporary_hintin all 12 shipped languages; en-XA regenerated withnpm run i18n:pseudo.docs/feature-map/README.mdand theentry_pathintest/gui_user/features.jsonnow name the new rows.Backwards compatibility
Compatible: only menu structure and copy change. The create calls, memory modes and
data-testids on the create rows are the same.Reader: website/src/pages/ChatSidebar.tsx -- the only renderer of
pages.chatSidebar.new_ephemeral_chatand of thenew-ephemeralsub-trigger test ids, both removed in this diff.Reader: website/src/test/ChatSidebar.ephemeralCreate.test.tsx, website/src/test/ChatSidebar.folderEphemeralCreate.test.tsx -- the only tests that opened the submenu; updated to the flat rows.
Reader: test/gui_user/features.json --
entry_pathtext naming the old row; updated;test/gui_user/test_features_catalog.pypasses.Reader: CHANGELOG.md -- a shipped section mentions "New ephemeral chat"; left untouched, as shipped sections must be.
Searched on origin/main with
git grep -i "new_ephemeral_chat\|new-ephemeral\|New ephemeral chat"outside the locale catalogs.Tests
ChatSidebar.ephemeralCreate.test.tsx: the + New menu lists both modes as top-level rows with their hint on desktop and phone (it.each), the rows sit in the root menu, and no "ephemeral" text remains. New case: at phone width the folder list is under a text-only caption that is not a menu item and holds no icon. Existing create-call assertions (memory mode rides the CREATE, run mode'') are unchanged.ChatSidebar.folderEphemeralCreate.test.tsx: the same flat-rows assertion for the folder ⋯ menu on desktop and phone. The incognito/temporary create-in-folder assertions are kept.vitest run src/test/ChatSidebar(114 files, 1194 tests),tsc -b, eslint on touched files,lint:restyle-ratchet,lint:i18n,pytest test/gui_user/test_features_catalog.py test/test_check_feature_map.py,scripts/docs-lint.sh.Manual verification
Built the SPA and drove the three menus on an isolated scratch gateway (separate
KIROCREW_HOME, two seeded folders), dark theme: the list-view folder ⋯ menu and the board-column folder ⋯ menu at 1280px, and the + New menu at 390px.Not covered: the phone-width New chat on crew caption. It renders only while a peer crew holds a live tunnel, which this host cannot produce, so it is left exactly as on main (icon kept) rather than changed without a screenshot. Follow-up: apply the same text-only caption there and capture it on a host with a connected crew.
Screenshots / video
Folder ⋯ menu, list view, desktop:

Folder ⋯ menu, board view, desktop:

Related Issues
Introduced by #6857 (the "New ephemeral chat" submenu), #7327 (its phone-width caption) and #8171 (the same structure in the folder menu).
Pattern harvest
Not generalizable: a one-off naming and layout choice in one menu family, not a repeatable code defect.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.