Repository navigation
Conversation
This reverts commit b83c99c. The chevron overlay on the lucide Folder/FolderOpen glyph hangs outside the 12px glyph box at sidebar size and changes how the whole folder row reads. The emoji folder path keeps its existing chevron; the lucide path goes back to the shape swap as its only cue until #11269 is redesigned to add a chevron without touching the rest of the row. Refs #18351 Reopens #11269
Design Review (Opus 5.5) — 🔴 BLOCK (blocking)Design-level review of Design-Verdict: BLOCK cannot evaluate: missing a screenshot of the sidebar folder rows (lucide, collapsed and expanded) with the chevron removed at this revision. BlockersThe changed sidebar folder row has no rendered evidence WatchOnce this merges, #11269 is open again. That issue says first-time users don't read the Folder/FolderOpen swap as open or closed. The restored comment says "The lucide shapes carry the collapse cue themselves", which brings back the very assumption #11269 disproved, with nothing recorded to say why. [DESIGN-REVIEWED] 1b3ac0f Description read[DESCRIPTION-READ] 8e0d763f72b1ee9da8dd880325da562a5777ec8e2bf713d55de52f2fc4353025 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that #18351 records the product owner's revert request. The description's only evidence is "(screenshot to follow)". What this change shipsInventory (3 items) — 3 justifiedIntent: put the sidebar's lucide folder rows back to how they looked before #16117, because the chevron overlay hangs outside the 12px glyph. This is a FIX (a revert).
[FIRST-PRINCIPLES-REVIEWED] 1b3ac0f Description read[DESCRIPTION-READ] 07baf63b9c07a620e4117802f4f3785b70b34c93684f872a5a7cda6cc860d575 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK cannot evaluate: missing a screenshot of the sidebar folder rows with the lucide chevron removed. The description promises one ("screenshot to follow") but attaches none. Watch
Evidence gaps
[UX-REVIEWED] 1b3ac0f Description read[DESCRIPTION-READ] 898c583d405d9b59f63501db8ca5e1cb3efdec2acb7c5a21ffcbecb8df69c7ca That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Reverts #16117 (
b83c99c2d8). Closes #18351. Reopens #11269.Summary
#16117 overlaid a
ChevronRighton the lucideFolder/FolderOpenglyph. At the sidebar's 12px glyph size the chevron (absolute -bottom-0.5 -right-1) hangs outside the glyph box into the gap before the folder name, and the folder row no longer reads as it did. The product owner asked for the revert first; the disclosure cue for #11269 will be re-approached as a change that adds a chevron and alters nothing else about the row.The emoji folder path is untouched by this revert and keeps the chevron it already had before #16117.
Changes
website/src/components/FolderGlyph.tsx: lucide path renders the bareFolder/FolderOpenagain (pre-fix(sidebar): show a disclosure chevron on lucide folder rows #16117 code, byte-for-byte).website/src/test/FolderGlyph.disclosureCue.test.tsx: back to the pre-fix(sidebar): show a disclosure chevron on lucide folder rows #16117 assertions (emoji path shows the chevron, lucide path does not).Evidence
Current
main(what is being reverted):Left:
mainwith #16117 (chevron on the lucide glyph). Right: this branch. Harnesswebsite/scripts/capture-folder-glyph.mjs; measured glyph/name/session-text left edges are identical on both (248/264/255 px at root), so the revert changes the glyph only, not the row geometry.Testing
tsc --noEmit: clean.eslinton both touched files: clean.git revert, no conflicts (no later commit touched either file).