Skip to content

revert: show a disclosure chevron on lucide folder rows (#16117) - #18352

Closed
CrysisDeu wants to merge 1 commit into
mainfrom
revert/folder-glyph-chevron-16117
Closed

CrysisDeu wants to merge 1 commit into
mainfrom
revert/folder-glyph-chevron-16117

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Reverts #16117 (b83c99c2d8). Closes #18351. Reopens #11269.

Summary

#16117 overlaid a ChevronRight on the lucide Folder / FolderOpen glyph. At the sidebar's 12px glyph size the chevron (absolute -bottom-0.5 -right-1) hangs outside the glyph box into the gap before the folder name, and the folder row no longer reads as it did. The product owner asked for the revert first; the disclosure cue for #11269 will be re-approached as a change that adds a chevron and alters nothing else about the row.

The emoji folder path is untouched by this revert and keeps the chevron it already had before #16117.

Changes

Evidence

Current main (what is being reverted):

Left: main with #16117 (chevron on the lucide glyph). Right: this branch. Harness website/scripts/capture-folder-glyph.mjs; measured glyph/name/session-text left edges are identical on both (248/264/255 px at root), so the revert changes the glyph only, not the row geometry.

folder row before and after

Testing

  • tsc --noEmit: clean.
  • eslint on both touched files: clean.
  • Clean git revert, no conflicts (no later commit touched either file).
  • Unit tests: CI (per repo policy, no local suite runs).

This reverts commit b83c99c.

The chevron overlay on the lucide Folder/FolderOpen glyph hangs outside
the 12px glyph box at sidebar size and changes how the whole folder row
reads. The emoji folder path keeps its existing chevron; the lucide path
goes back to the shape swap as its only cue until #11269 is redesigned
to add a chevron without touching the rest of the row.

Refs #18351
Reopens #11269
@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners October 9, 2026 05:54
@CrysisDeu
CrysisDeu requested a review from dodgeblaster October 9, 2026 05:54
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — 🔴 BLOCK (blocking)

Design-level review of 1b3ac0fdf622c32edc43e03d2bf7140ddcfd49d7 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: BLOCK

cannot evaluate: missing a screenshot of the sidebar folder rows (lucide, collapsed and expanded) with the chevron removed at this revision.

Blockers

The changed sidebar folder row has no rendered evidence
The revert changes what the sidebar shows. The lucide path drops {disclosure} from the Folder/FolderOpen span, so every folder without an emoji icon loses its chevron. The case for the change is visual: the description says the chevron "hangs outside the glyph box into the gap before the folder name". But the Evidence section only says "(screenshot to follow)". The evidence file lists 0 images, 0 recordings and no committed media. I can't confirm the restored row reads correctly, and I can't confirm the rows still match each other: emoji folders keep their chevron and lucide folders now don't.
Fix: attach a screenshot of the restored sidebar showing lucide folders collapsed and expanded, next to an emoji folder. A before/after pair of the 12px glyph would be better.
Clears when: a github.com/user-attachments image of the sidebar folder rows at this head SHA appears in the PR description and the evidence list records it.

Watch

Once this merges, #11269 is open again. That issue says first-time users don't read the Folder/FolderOpen swap as open or closed. The restored comment says "The lucide shapes carry the collapse cue themselves", which brings back the very assumption #11269 disproved, with nothing recorded to say why.
Clears when: the code comment and the test header record that the lucide cue is under re-approach in #11269 instead of claiming the shape swap is sufficient.

[DESIGN-REVIEWED] 1b3ac0f

Description read

[DESCRIPTION-READ] 8e0d763f72b1ee9da8dd880325da562a5777ec8e2bf713d55de52f2fc4353025

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 1b3ac0fdf622c32edc43e03d2bf7140ddcfd49d7 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check that #18351 records the product owner's revert request. The description's only evidence is "(screenshot to follow)".

What this change ships

Inventory (3 items) — 3 justified

Intent: put the sidebar's lucide folder rows back to how they looked before #16117, because the chevron overlay hangs outside the 12px glyph. This is a FIX (a revert).

  1. Lucide folder rows (folders with no emoji) lose the corner chevron and show only the Folder/FolderOpen shape again — justified
  2. Emoji folder rows keep their chevron, and its markup is inlined again exactly as it was before fix(sidebar): show a disclosure chevron on lucide folder rows #16117 — justified
  3. The tests that required a chevron on lucide folders are back to requiring none — justified

[FIRST-PRINCIPLES-REVIEWED] 1b3ac0f

Description read

[DESCRIPTION-READ] 07baf63b9c07a620e4117802f4f3785b70b34c93684f872a5a7cda6cc860d575

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🔴 BLOCK

UX-level review of 1b3ac0fdf622c32edc43e03d2bf7140ddcfd49d7 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: BLOCK

cannot evaluate: missing a screenshot of the sidebar folder rows with the lucide chevron removed. The description promises one ("screenshot to follow") but attaches none.

Watch

  • The comprehension problem from ux(sidebar): I wasn't sure whether the Demos folder was expanded or collapsed in the initial state — i… #11269 comes back. The revert removes the chevron and returns the lucide rows to signalling state only through the Folder/FolderOpen swap. The removed comment recorded the result of that design: "first-time users do not read the Folder/FolderOpen swap as open/closed state and click an expanded folder expecting it to expand." This hits every user who doesn't use emoji folder icons, and it lasts until the follow-up lands. The fix is to schedule the chevron-only follow-up now, so the gap doesn't stay open.
  • Emoji folders and plain folders now give different open/closed cues in the same sidebar. Emoji folders get a rotating chevron; plain folders get only the shape swap. A user with both kinds sees two different ways of showing the same state. The planned follow-up should give both kinds the same cue.

Evidence gaps

  • No blind read was performed. The PR has no image attached and none committed, so nobody has looked at the sidebar row. The author can close this by attaching to the PR description:
    • a before/after pair of the sidebar folder rows (lucide glyph at 12px), showing one collapsed and one expanded folder;
    • one shot of an emoji folder, to show its chevron is unchanged.

[UX-REVIEWED] 1b3ac0f

Description read

[DESCRIPTION-READ] 898c583d405d9b59f63501db8ca5e1cb3efdec2acb7c5a21ffcbecb8df69c7ca

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 1b3ac0fdf622c32edc43e03d2bf7140ddcfd49d7 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1b3ac0f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 1b3ac0fdf622c32edc43e03d2bf7140ddcfd49d7: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 1b3ac0fdf622c32edc43e03d2bf7140ddcfd49d7 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1b3ac0f

Verdict parsed from the review's SHA-scoped output markers for commit 1b3ac0fdf622c32edc43e03d2bf7140ddcfd49d7.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 1b3ac0fdf622c32edc43e03d2bf7140ddcfd49d7: <one-sentence reason>

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Not the culprit: measured row geometry is identical with and without #16117; the folder-row look change comes from #14099 (sticky folder headers). Closing.

@CrysisDeu CrysisDeu closed this Oct 9, 2026
@CrysisDeu
CrysisDeu deleted the revert/folder-glyph-chevron-16117 branch October 9, 2026 06:01
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revert(sidebar): lucide folder chevron overlay (#16117) changed the folder row look

1 participant