Skip to content

docs: rfc, a plain session is the default template, never the default crewmate - #18355

Merged
CrysisDeu merged 1 commit into
mainfrom
docs/rfc-session-template-vs-crewmate
Oct 9, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
docs/rfc-session-template-vs-crewmate

Conversation

@CrysisDeu

Copy link
Copy Markdown
Contributor

Problem / Motivation

The First Principles lane on #18342 blocks: two accepted RFCs record that a chat with no crew picked counts for the default crew, and the product owner decided the opposite on 2026-10-09. This RFC records that decision so the implementation can be judged against it.

What changed

  • docs/request-for-change/rfc-session-template-vs-crewmate.md (accepted): a plain session is the default template on the default folder and Global memory, never the default crewmate; a crewmate is credited only for its DM thread and explicit picks. Amends one sentence each of rfc-crewmates-chatted-list.md and rfc-crewmate-guides-and-mate.md.
  • README index row.

Tests

scripts/docs-lint.sh clean. Docs only.

Related Issues

Refs #18328. Implementation: #18342.

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners October 9, 2026 06:01
@CrysisDeu
CrysisDeu requested a review from buluoray October 9, 2026 06:01
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 13cc7f09e65f408a03873e958b7dd26b221bb4b2 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 13cc7f09e65f408a03873e958b7dd26b221bb4b2 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — 🟡 CONCERNS

Design-level review of 13cc7f09e65f408a03873e958b7dd26b221bb4b2 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

The RFC contradicts itself on whether an explicit crewmate pick credits that crewmate, and the implementation will be judged against it.

Watch

  • Two rules on crediting a pick. §1 says the default crewmate "is credited only for its own DM thread and for chats that picked it". The description and the README row say the same. But the §3 table says a "Crewmate picked for an ordinary chat" earns "nothing: the crewmate's conversation is its DM thread", and rule 3 lists and orders crewmates by DM-thread messages only. When fix(session): a plain session is the default template, never the default crewmate #18342 is reviewed, the First Principles lane will find support for either reading, so this RFC doesn't settle the dispute it was written to settle.
    Clears when: §1, the README row and the description use one rule (DM thread only, or DM thread plus explicit picks), and it matches the §3 table and rule 3.
  • "Amends one sentence each" understates what §6 changes. §6 replaces all of rfc-crewmates-chatted-list.md §3. It also records a second owner decision: order by newest message from anyone, "like iMessage". It removes crew_recency.json and drops the "created on the dashboard" exemption. A reader of the index or the PR text won't see that the chatted-with record and its seed are gone. The two amended RFCs carry no pointer back to this one, so a reader of either still sees the old rule.
    Clears when: the description and the README row say §6 replaces chatted-list §3, including the removal of crew_recency.json, and both amended RFCs' README rows name this RFC as their amendment.

[DESIGN-REVIEWED] 13cc7f0

Description read

[DESCRIPTION-READ] ccff83e3f66ed00a3054bfb00d37f5c7745a2305ad3cd69004cc1b5ae138fb54

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 13cc7f09e65f408a03873e958b7dd26b221bb4b2 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 13cc7f0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 13cc7f09e65f408a03873e958b7dd26b221bb4b2: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 13cc7f09e65f408a03873e958b7dd26b221bb4b2 — this comment is updated in place on each push.

Review details

No findings block this merge. One advisory finding below.

FINDING — docs/request-for-change/rfc-session-template-vs-crewmate.md:42 — The decision sentence contradicts itself. The text reads "the default crewmate is a crewmate. It is not the default crewmate.", so "It" points back to the default crewmate. A reader of the accepted Summary gets the opposite of the rule that §3 states. → Fix: replace "It" with "A template session", or move that sentence to sit right after "on the default folder and Global memory".

[OPUS-REVIEWED] 13cc7f0

Verdict parsed from the review's SHA-scoped output markers for commit 13cc7f09e65f408a03873e958b7dd26b221bb4b2.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 13cc7f09e65f408a03873e958b7dd26b221bb4b2: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 9, 2026
@CrysisDeu
CrysisDeu force-pushed the docs/rfc-session-template-vs-crewmate branch from f42b6f6 to 7608789 Compare October 9, 2026 06:57
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 9, 2026
… crewmate

Records the product owner's decision of 2026-10-09: a session that picked
no crewmate runs the default template on the default folder and Global
memory, a crewmate is credited only for its DM thread and explicit picks,
and the `default` crewmate is one roster row like any other. Amends one
sentence each of rfc-crewmates-chatted-list.md and
rfc-crewmate-guides-and-mate.md. Implementation is #18342.

Refs #18328
@CrysisDeu
CrysisDeu force-pushed the docs/rfc-session-template-vs-crewmate branch from 7608789 to 13cc7f0 Compare October 9, 2026 08:01
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 9, 2026
@CrysisDeu
CrysisDeu merged commit c93a963 into main Oct 9, 2026
99 of 101 checks passed
@CrysisDeu
CrysisDeu deleted the docs/rfc-session-template-vs-crewmate branch October 9, 2026 10:15
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant