Skip to content

fix(dashboard): cancel native turns before timeout unwind - #18417

Merged
iamwhatever merged 1 commit into
mainfrom
replace/16301-native-cancel
Oct 11, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
replace/16301-native-cancel

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Ensure a timed-out chat turn stops its native model work before the dashboard reports the timeout.

When a guarded chat turn reaches its wall-clock ceiling, Kiro Crew cancels the local Python stream task. That local unwind can mark the ACP turn inactive without sending session/cancel, so the native turn and its built-in subagents can continue editing files or requesting tools after the dashboard has stopped listening.

Why it matters

A timeout must stop the work it reports as stopped. Otherwise invisible native work can continue for minutes, mutate the workspace, strand queued results, and leave later Stop requests with no active turn to cancel.

Not a goal

What changed (motivation → approach → change)

Observed symptom: a timed-out dashboard stream stopped locally while its native ACP turn continued unattended.

Root cause: the timeout callback cancelled _run_chat first. Stream teardown then cleared active-turn state before any native cancellation was sent, so later cancellation resolved no_turn even though the underlying prompt was still running.

Approach: use the session lease's existing owner task as the generation fence. At the deadline, request native cancellation only while that exact task still owns the session, wait for the provider's bounded acknowledgement, and only then unwind the local stream. This prevents a stale timeout from cancelling a successor turn.

Change: guarded and off-loop timeout dispatches now share the owner-fenced cancellation sequence and one timeout-reporting path. A provider-confirmed completed turn skips redundant cancellation and replay. Unfinished no_turn, timeout, and error outcomes preserve partial output and show that resuming is unsafe because native cancellation was not acknowledged.

Implementation map:

  • src/kiro_crew/dashboard/turn_dispatch.py: deadline ordering, acknowledgement handling, and shared timeout reporting.
  • src/kiro_crew/session_lifecycle.py and src/kiro_crew/session.py: exact-owner cancellation and provider-confirmed completion proof.
  • src/kiro_crew/slack/gateway.py and src/kiro_crew/apps/builtins/spec_builder/backend/runtime.py: pass session state and slot identity to the shared timeout wrapper and consume task exceptions.
  • docs/system-specs/modules/learn-cron-dashboard.md: document the owner-fenced native cancellation contract.
  • .github/black-baseline.txt: remove the cancellation consistency test after this change makes it Black-clean.

Backwards compatibility

Compatible: existing callers keep their timeout behavior and signatures remain compatible through optional cancellation context; production call sites now supply session state and slot identity for native cancellation.

Removes nothing: the change adds owner-fenced cancellation and more precise timeout reporting without deleting or rejecting an existing input, API, or recovery path.

Tests

  • test/test_turn_dispatch.py: deadline ordering, bounded acknowledgement, repeated cancellation, provider-confirmed completion, replay, and fail-closed timeout cards.
  • test/test_session.py: exact-owner cancellation, wrong-owner refusal, completion proof, and pre-await replay marking.
  • test/test_chat_turn_timeout_consistency.py: every timed dispatch uses a valid guarded form, supplies state and slot identity, and consumes task exceptions.
  • test/test_spec_builder_routes_coverage.py: Spec Builder passes the exact state and slot into the shared timeout wrapper.
  • Final affected suite: 926 passed, including the overlapping cron-routing tests.
  • Black, isort, flake8, mypy (2,063 source files), documentation lint, and git diff --check passed on the rebased head.

Manual verification

N/A — the change is an async lifecycle and ownership repair with deterministic race coverage; it does not change a rendered UI surface.

Screenshots / video

N/A — no user-visible frontend files or layout behavior changed.

Related Issues

Fixes #18416.

Replaces #16301 by @junjiequ (original fork PR; re-authored onto the main repo so CI and the fork review lanes can run). #14058 also tracks stage-boundary, queued-message, and Stop recovery outside this focused native-cancellation repair.

Related but non-overlapping: #15918 reports an honest response when Stop finds an already-idle wedged slot; this PR prevents the native turn from being abandoned at the timeout boundary.

Pattern harvest

Rule candidate: review-prompt
Pattern: a timeout around a remote stream must stop and acknowledge the remote operation before cancelling the local consumer, fenced by the exact operation owner so a stale timeout cannot cancel successor work.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Generated UI index

Commit 74b0096d9 regenerates src/kiro_crew/docs/ui-index.generated.json with npm run gen:ui. gen-ui-index --check fails on current main, which reddens Frontend Lint, Build Wheel, Build Desktop and E2E on every PR. This is the same fix as #18753, regenerated on newer main (it also includes the notifications.sound-category-dictation setting main has since added). Once either lands, the other becomes a no-op on rebase.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 9, 2026 09:05
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — 🟡 CONCERNS

Design-level review of 899d3129ff27be909fcb1afdf94114848769007f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

The description's "Generated UI index" section describes a commit that regenerates ui-index.generated.json, but no such file is in this diff.

Watch

  • The description claims a change the diff doesn't contain. It says "Commit 74b0096d9 regenerates src/kiro_crew/docs/ui-index.generated.json… which reddens Frontend Lint, Build Wheel, Build Desktop and E2E on every PR." That file is not in the patch. Reviewers will expect those lanes to be fixed by this PR, then see them red and wonder whether this PR caused it.
    Clears when: the section is removed from the description, or the regenerated ui-index file is in the diff.
  • No test has run the new ordering against a real kiro-cli. The fix depends on two things about the real runtime. First, _active_turn_session_key and the ACP active-turn state must still be set when the deadline fires. Second, session/cancel must be acknowledged within the time limit while _run_chat is held behind asyncio.shield. All the coverage uses fake providers. "Manual verification: N/A" leaves open whether a real timed-out turn now shows "acked" or always falls through to the "do not resume" card.
    Clears when: one isolated-gateway run with a short agent.chat_turn_timeout_secs shows the native turn stopping and the acknowledged-timeout card rendering.

[DESIGN-REVIEWED] 899d312

Description read

[DESCRIPTION-READ] d98e3eecc7e72e94a0788f2a5fedbcf74df54107a9c1eb4a35644d6d953699de

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 899d3129ff27be909fcb1afdf94114848769007f touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 899d3129ff27be909fcb1afdf94114848769007f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 899d312

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 899d3129ff27be909fcb1afdf94114848769007f: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of 899d3129ff27be909fcb1afdf94114848769007f — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

spawn_guarded_turn gains a cancel_ack_timeout_secs override that no production caller passes. Only tests use it, so it is surface the fix does not need.

Not justified as shipped

  • Item 6 — zero consumers: + cancel_ack_timeout_secs: float | None = None, on spawn_guarded_turn. I grepped cancel_ack_timeout_secs= in src/ and found 0 callers outside turn_dispatch.py. The only callers are 3 in test/test_turn_dispatch.py, and line 490 of that file already pins the value with monkeypatch.setattr(td, "native_cancel_ack_timeout_secs", ...).
    Subtraction: delete the parameter. Always call native_cancel_ack_timeout_secs() and have the 3 tests use the monkeypatch they already use.
    Clears when: the parameter is removed, or a production caller passes it.

What this change ships

Inventory (7 items) — 5 justified

Intent: when a chat turn times out, actually stop the native agent's work before reporting it as stopped. This is a FIX (#18416).

  1. At the deadline, a timed-out turn sends a native session/cancel to the turn's exact owner and waits for a bounded acknowledgement before the local stream unwinds — justified
  2. A new timeout card says "did not acknowledge… Do not resume" when the cancel is not confirmed — justified
  3. Slack recovery, injection and Spec Builder turns now get the same deadline handling and timeout card as dashboard turns — justified
  4. A Stop or shutdown that cancels the wrapper now explicitly ends the inner turn, which the wrapper now shields — justified
  5. A cancelled-at-deadline turn is marked for replay before the cancel is sent — justified
  6. spawn_guarded_turn gains a cancel_ack_timeout_secs override — zero consumers (only tests pass it)
  7. Spec Builder logs task exceptions instead of leaving them unretrieved — rides along: a small exception-consumer rider the description mentions, with no premise risk

[FIRST-PRINCIPLES-REVIEWED] 899d312

Description read

[DESCRIPTION-READ] 207f226dc2d551dc3dc87ff76fedea349fe483dfe77b26253ddd1932c7402a24

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 899d3129ff27be909fcb1afdf94114848769007f — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 899d312

Verdict parsed from the review's SHA-scoped output markers for commit 899d3129ff27be909fcb1afdf94114848769007f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 899d3129ff27be909fcb1afdf94114848769007f: <one-sentence reason>

@iamwhatever
iamwhatever force-pushed the replace/16301-native-cancel branch 2 times, most recently from d07886a to 2be6f34 Compare October 9, 2026 09:57
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 9, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Self-review (crew-pr-reviewer, read-only): RECOMMEND APPROVE

This fixes the root cause of #18416. Before, the wall-clock deadline cancelled _run_chat first, and the stream teardown cleared ACP's active-turn state before any session/cancel was sent, so the native turn kept running. Now _bounded_turn sends an owner-fenced native cancel through the new cancel_owned_turn, which refuses when session.turn_owner is not the inner task and has no await between that check and provider.cancel. It waits for the bounded acknowledgement and only then cancels the local task. The card switches to "do not resume" when the acknowledgement does not arrive. I read the full production diff and checked these points: the shielded inner task is still cancelled and awaited explicitly on Stop and shutdown; bounded_chat_turn now renders the timeout card itself, and none of its three callers (Spec Builder, gateway recovery, gateway injection) renders a second one; and if the lease owner is ever a different task, the result is None, which falls back to the old "stopped" card, so that case is no worse than the base. All checks are green, there are no reviews or change requests, and the Opus, GPT and Design lanes report no blocking findings. One open item has no answer yet: First Principles CONCERNS (item 7) is correct that native_cancel_ack_timeout_secs repeats the clamp already done at config/sections.py:1986. That code is dead but harmless, so either delete the <= 0 branch and the min/max re-clamp, or post a disposition, before merging. A small note: after the deadline fires, _settle_deadline_cancel holds off a Stop or shutdown cancellation for up to the acknowledgement budget plus 0.5s (at most about 60.5s). That is bounded and intended. — crew-pr-reviewer

@iamwhatever
iamwhatever enabled auto-merge (squash) October 9, 2026 16:34

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this fixes a real problem: at the wall-clock ceiling the native turn now gets session/cancel while ACP still marks the turn active, and the dashboard waits a bounded time for the ack before it unwinds. I checked the main claims against the source and they hold:

  • The lease owner is the inner task _bounded_turn creates (turn_owner is set from current_task() at acquire inside _run_chat). Nothing is awaited between the owner check and provider.cancel in cancel_owned_turn, so a stale deadline can't cancel a successor turn.
  • The deadline is a single call_later, so it sends at most one native cancel. A cancel that raises, or that exceeds ack + 0.5s, becomes error/timeout, and the finally still cancels the inner task, so the slot can't hang.
  • Turns that complete normally take the unchanged path: shield(task), then the result, then the handle is cancelled.
  • No runtime is reset or killed on an unacknowledged outcome, which matches the non-goal and the runtime-ownership rules.
  • Reverting each of these alone turns a named test red: the cancel-before-unwind ordering, the owner fence, the known-terminal skip, and replay arming.

Requesting changes for one spec-sync item. Auto-merge is on, so I'm holding owning-spec accuracy to the merge bar:

  1. cancel_owned_turn sets prev_turn_cancelled = True before the provider cancel, for every attempted outcome (acked, timeout, error, no_turn). The comment explains this is fail-closed on purpose, and I agree with the behaviour. The specs don't match it yet:

    • The new paragraph in learn-cron-dashboard.md says "acked marks the cancelled prompt and partial assistant output for reinjection", which reads as acked-only.
    • session.md owns session.py/session_lifecycle.py. Its Stop Orchestration step 1 says prev_turn_cancelled is set only after the ack, and its Cancelled-turn context restore section says the flag is set on soft-cancel success. The new SessionManager.cancel_owned_turn isn't described there.

    Please add a short cancel_owned_turn subsection to session.md covering: the exact-owner fence, the known-terminal skip, replay armed before the first await on every non-skipped outcome, and no hard reset on an unacknowledged outcome (unlike stop_turn). Please also correct the learn-cron-dashboard sentence. This is docs only, no code change.

Non-blocking follow-ups:

  • The ack bound isn't pinned by a test. Replacing the wait_for(native_cancel(...), ack + 0.5) with a plain await keeps the suite green. A test where cancel_owned_turn never returns, asserting the turn unwinds with a timeout outcome, would lock in the "no hung slot" guarantee.
  • The loop in _settle_deadline_cancel that swallows cancellation isn't independently covered. test_second_cancellation_cannot_orphan_native_cancel cancels the wrapper while it is still in shield(task), so making the settle loop re-raise also stays green.
  • A Stop or shutdown that arrives during the deadline's ack window is held until the native cancel settles (about 10.5s by default) and ends as TurnTimeoutError instead of CancelledError. It's bounded and seems intended; one sentence in the spec would make it explicit.
  • On the ordinary Stop path, a _run_chat that swallows the cancellation now still ends the wrapper with CancelledError, where before it returned the result. That looks more correct, but it isn't mentioned in the PR.
  • The "do not resume until idle" card gives the user no signal for when the session is idle. This probably belongs with #14058.

CI on 2be6f34: 89 success, 9 skipped, 0 failures, nothing pending. I ran the touched test files at this head (904 passed). I didn't run the full suite or the linters locally; for those I'm relying on CI.

@iamwhatever
iamwhatever force-pushed the replace/16301-native-cancel branch from 2be6f34 to a96b598 Compare October 10, 2026 07:22
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 10, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

@buluoray thanks for the careful review. The spec-sync item is addressed in a96b598 (docs only, no code change); the branch is also rebased onto current main.

docs/system-specs/modules/session.md

  • New subsection Owner-fenced deadline cancel: cancel_owned_turn (before "Interrupted-turn context restore"). It covers, in order: the exact-owner fence (turn_owner is owner_task, else None); the known-terminal skip (provider_turn_is_known_terminal → None, no cancel, replay not armed; a bare no_turn is not that proof); replay armed with prev_turn_cancelled = True before the first await, for every attempted outcome (acked/timeout/error/no_turn), stated as fail-closed on purpose; and no reset()/hard kill/eager respawn on any outcome, unlike stop_turn().
  • "Cancelled-turn context restore" now names both writers of the flag: stop_turn() on acked only, cancel_owned_turn() before the provider cancel for every attempted outcome.
  • Stop Orchestration step 1 now says it is stop_turn() that sets the flag only after the ack, so it no longer reads as a rule for every path.

docs/system-specs/modules/learn-cron-dashboard.md

  • The "acked marks the cancelled prompt…" sentence now says every attempted outcome marks it, the mark is set before the cancel request starts, fail-closed on purpose, with a link to the new session.md subsection.

From the non-blocking list I also took the one-sentence spec note: a Stop or shutdown arriving during the ack window waits for it to settle (bounded at max(0.1, agent.soft_stop_budget_secs) + 0.5s) and ends the turn as a timeout rather than a plain cancellation. It is in both files. The other follow-ups (a never-returning cancel_owned_turn test pinning the ack bound, independent coverage of the _settle_deadline_cancel loop, the Stop-path CancelledError change, and the idle signal for #14058) are left out of this PR to keep it to the requested change.

Local: comment-history gate and scripts/docs_lint.py pass; test/test_chat_turn_timeout_consistency.py 6 passed.

buluoray
buluoray previously approved these changes Oct 10, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at a96b598. This supersedes my CHANGES_REQUESTED on 2be6f34: the spec now matches the code.

docs/system-specs/modules/session.md "Cancelled-turn context restore" now names the two writers of _Session.prev_turn_cancelled: stop_turn() sets it only on an acked soft cancel (session_lifecycle.py:3068), and cancel_owned_turn() sets it before the provider cancel starts, so every outcome it attempts leaves it set (session_lifecycle.py:3010). The new "Owner-fenced deadline cancel" section describes the same sequence the code runs: exact-owner fence, known-terminal skip, arm replay before the first await, then provider.cancel on the exact provider read in step 1, with no reset() or hard kill on any outcome. Arming replay on unacknowledged outcomes is fail-closed and the spec now says so.

CI on this head: 83 success, 10 skipped, 5 failure. All five (Build Wheel, Frontend Lint & Type Check, E2E, Build Desktop x2) fail on gen-ui-index: ui-index.generated.json is stale. That is not this diff: the PR touches no website/ file and no generated index, and the same check fails on its merge-base 6166905. A rebase onto current main should clear it.

I re-read the code and spec on this head; I did not re-run the Python tests.

@iamwhatever
iamwhatever force-pushed the replace/16301-native-cancel branch 2 times, most recently from 62e2304 to 74b0096 Compare October 10, 2026 08:29
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Follow-up: PR Hygiene caps a PR at two commits, so the spec-sync docs change from a96b598 is now folded into 13bee06 (the fix commit). The text is unchanged. 74b0096 is a separate commit that regenerates the stale ui-index (see the PR body).

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 10, 2026
When a guarded chat turn reaches its wall-clock ceiling, cancel the
native ACP turn against the exact session lease owner and wait for the
provider's bounded acknowledgement before unwinding the local Python
stream. This stops native work (and its built-in subagents) from
continuing to edit files or request tools after the dashboard has
reported the timeout, and prevents a stale deadline from cancelling a
successor turn.

Guarded and off-loop timeout dispatches now share the owner-fenced
cancellation sequence and one timeout-reporting path. A
provider-confirmed completed turn skips redundant cancellation and
replay; unacknowledged outcomes preserve partial output and warn that
resume is unsafe.

The virtual-time turn harness is given the healthy-session answer for
the new SessionManager.cancel_owned_turn call ("acked"), and
turn_dispatch keeps off the agent-sdk boundary: CancelOutcome is spelled
as a local Literal rather than imported from kiro_crew.providers, so the
shrink-only boundary gate stays at its baseline.

Replaces #16301 by @junjiequ.

Co-authored-by: JJ_Q <5853857+junjiequ@users.noreply.github.com>
@iamwhatever
iamwhatever force-pushed the replace/16301-native-cancel branch from 74b0096 to 899d312 Compare October 10, 2026 18:13
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 10, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Self-review (crew-pr-reviewer, read-only): RECOMMEND APPROVE

This fixes the root cause of #18416: at the wall-clock deadline _bounded_turn now sends an owner-fenced session/cancel through cancel_owned_turn while ACP still holds the active turn, waits a bounded time for the acknowledgement, and only then cancels the local _run_chat task, so the native turn no longer keeps working after the dashboard reports a timeout. I read the full production diff at head 899d312 (single commit, base main, all checks green, GPT and Opus lanes no findings) and re-checked the key invariants: no await sits between the turn_owner is owner_task check and provider.cancel, the known-terminal skip only fires on an explicit has_unfinished_turn() is False, the shielded inner task is still cancelled and awaited on Stop/shutdown, and bounded_chat_turn now renders the timeout card itself while the Slack recovery/injection and Spec Builder callers only log, so no card is doubled. buluoray's earlier change request (spec sync for cancel_owned_turn in docs/system-specs/modules/session.md and the acked-only sentence in learn-cron-dashboard.md) is addressed in this head, but the approval was dismissed by the later force-push, so it needs a fresh approval. Before auto-merge lands it, please answer the two open lane items: the Design CONCERNS is correct that the PR body's "Generated UI index" section describes commit 74b0096 and a ui-index.generated.json change that is no longer in the diff, so delete that section; and First Principles is correct that spawn_guarded_turn(cancel_ack_timeout_secs=...) (turn_dispatch.py:616) has no production caller, so drop it and let the three tests use the existing native_cancel_ack_timeout_secs monkeypatch, or post a disposition. My earlier point is still open too: native_cancel_ack_timeout_secs re-clamps to min(60, max(0.5, x)) with a <= 0 branch that config validation already makes unreachable, and the spec's stated bound max(0.1, agent.soft_stop_budget_secs) + 0.5 does not mention that clamp. Reviewer note: this is a kill/cancel path, so the code owner should look at _settle_deadline_cancel, which swallows a Stop or shutdown cancellation for up to about 60.5s once the deadline has fired, and at the fail-closed prev_turn_cancelled = True that is set before the provider cancel for every outcome. — crew-pr-reviewer

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at head 899d312: PR Readiness is green, no open change requests, and the review lanes passed. (AI-assisted review at bolichen97's request.)

@iamwhatever
iamwhatever merged commit ca82b13 into main Oct 11, 2026
109 of 110 checks passed
@iamwhatever
iamwhatever deleted the replace/16301-native-cancel branch October 11, 2026 01:06
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timed-out chat turn can leave native work running after the dashboard reports the timeout

4 participants