Repository navigation
chore(i18n): call a connected machine a crew in every user string - #18436
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that "Crew 1" reads as a machine placeholder in Settings → Remote Crew, since "crew" also names an agent team elsewhere in the product. [DESIGN-REVIEWED] 3eb7bfc Description read[DESCRIPTION-READ] 2bdf6c9305494f209c1e42a10b45689d3696c878bda9a7a8e89fc8a574ae3b08 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (8 items) — 8 justifiedIntent: make every user-visible string call a connected machine a "crew", so the feature reads as one concept. This is a FIX (copy consistency; #10481 records the owner's choice).
[FIRST-PRINCIPLES-REVIEWED] 3eb7bfc Description read[DESCRIPTION-READ] c795741641b1aa6774c1c79a8a467378fecfa755a5adb9b91a86a9a475acbc49 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS Next to the product name, "crew" for a machine reads oddly: "Kiro Crew does not manage this crew" and "run on the crew" made the blind reader stumble. Watch
[UX-REVIEWED] 3eb7bfc Description read[DESCRIPTION-READ] 534cec980950698084199bbd3a80c62101d4cbd829ab265e4106499b4b4bb481 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
|
|
|
|
|
|
|
|
Self-review (crew-pr-reviewer, read-only): RECOMMEND APPROVE Copy-only PR: the eight English strings that still called a connected machine an "instance", "machine", "remote host" or "server badge" now say "crew", with the same change in all 11 translated catalogs, a regenerated en-XA and both generated settings registries. No i18n key, API field or config key is renamed. I read the full diff. The en, de and zh-CN values match the table in the body, and the two embedded-newline strings were collapsed, which renders the same in JSX. The two panel tests now match the new wording, which matters because several of those |
buluoray
left a comment
There was a problem hiding this comment.
Approving at 3eb7bfc.
What this fixes for users: the connected machine was "remote instance", "server badge", "the remote host" and "this machine" depending on the screen; after this every user string calls it a crew, in each language's existing word for crew.
Decision check: there is no entry in docs/decisions/ on this naming, and the noun matches the accepted remote-crew-sidebar RFC and the maintainer's comment on #10481 ("a crew is another computer you connected"). No contradiction.
What I checked
- All 13 catalogs (12 languages plus en-XA) change exactly the same 8 keys versus the merge base: no key added, removed or renamed, and no other value touched.
{{productName}}and<0>…</0>tokens are identical before and after in every changed value. - Each locale uses the same noun its neighbouring crew strings already use (zh-CN Crew, ja クルー, ko 크루, ru команда, hi क्रू, bn ক্রু, Crew/crew elsewhere). French keeps U+202F before
;and:. - All 8 keys are read through i18nT at their call sites and none lives in en.manual.json, so editing en.json is the right source. No code identifier, API field, config key or route changes. The two generated settings registries differ only by the one Feature Previews line and match en.json.
- No leftover old wording outside the catalogs.
- Locally: the two panel tests plus the i18n parity/glossary/pseudolocale/changed-value/style suites, 324 tests, pass, and the i18n check passes. I did not run the Python tests, tsc or eslint locally; CI on this head is 90 success and 7 skipped, with no failures.
Non-blocking follow-ups
- The i18n gates do not catch a locale that keeps its old meaning after the English source changes: reverting the German name placeholder to the old "Remote-Host 1" left every i18n test and the i18n check green. This was already true before this PR. Worth an issue so a changed English value flags any locale whose value did not change with it.
- The name placeholder reads "Crew 1" in English and most locales, but "My crew 1" in de/fr/es/pt/it. It is harmless for a placeholder, and only noted for consistency.
- Two Remote Crew hints still say "remote gateway". They name the gateway process on the crew rather than the crew, so they are outside this PR's scope, but could be polished later.
Problem / Motivation
Goal: Every user-visible string calls another computer you connected a "crew", so Settings, the sidebar, the crew window and their notices no longer name it three different ways.
The same connected machine was called a "remote instance", a "crew", a "server badge", "the remote", "the remote host" and "this machine" depending on where you looked. #12697 moved most strings back to "crew". Eight English strings still used another noun.
Why it matters
A user who reads "remote crew" in Settings, "server badge" in Feature Previews and "That instance" in the Send-to menu can fairly think these are three different things. One noun makes the feature read as one concept. The owner picked crew for #10481.
Not a goal
What changed (motivation → approach → change)
Eight English strings in
website/src/i18n/locales/en.jsonstill named the connected machine with another noun. Each now says "crew":All 11 translated catalogs carry the same change in each language's own word for crew. The rewritten strings follow each style guide's register (tu, du, ты, तुम, তুমি), which moves six strings off the formal form (bn, de, fr, hi, ru).
en-XAcomes fromnpm run i18n:pseudo.settingsRegistry.gen.tsandsrc/kiro_crew/docs/settings-registry.generated.jsoncome fromnpm run gen:settings; each moves by the one Feature Previews line. Two panel tests that matched the old wording now match the new.Backwards compatibility
Compatible: only display copy changes; every i18n key, API field and config key keeps its name.
Removes nothing: no key, field, route or record is removed or renamed.
Tests
InstancesPanel.test.tsxandRemoteCrewPanel.test.tsxmatch the new placeholder and row notes. Several of those assertions arenot.toBeInTheDocument(), so they would have passed silently on the old wording; they now check the new text.*Styletests withI18N_BASE_REF=origin/main: 117/117. They hold every changed value to its locale's register and punctuation rules (French U+202F before;and:).src/i18n, both panel tests andcommandPalette: 74 files, 1212 tests pass.npm run i18n:check(parity, DNT, pseudolocale, changed-passthrough) passes, as dotsc -p tsconfig.app.jsonand eslint on the touched files.test_settings_deeplink_registry.pyandtest_brand_name_gate.py: 91 passed. Re-running both generators after rebasing on main gives no diff.Manual verification
Rendered the real
RemoteCrewPanel,CrewGroupSectionandCrewChatWindowin a local Vite harness (api client stubbed in the page, English), once onorigin/mainand once on this branch.Screenshots / video
Settings → Remote Crew, with the add form open. The row note, the name placeholder and the path hint change.
Before:
After:
Sidebar crew group and crew window header (no change: they already said crew)
Both PNGs are byte-identical between main and this branch. #12697 had already moved these two surfaces to "crew", and they are shown here as the consistency check.
Related Issues
Closes #10481
Part of #6180
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)