Repository navigation
Conversation
On the Crewmates page, a file path a crewmate names in its reply draws as a confirmed path chip, but clicking it opens nothing: the page's ChatPane has no `onFileOpen` prop, so the markdown renderer sees no handler and `activatePath` falls back to the OS file-manager reveal, which on a remote gateway shows the reader nothing. The chat page opens the same chip as a Files tab in its side panel. Backport of the ChatPane and Members-page part of kirodotdev#14458, which main has carried since 2026-09-29 (release/0.8.0 branched a day earlier): - ChatPane takes `onFileOpen` and hands it to the transcript renderers (the crewmate bubble, the attachment card, the tool row) and to ChatMessageList, whose render context already forwarded it. - MembersPage passes its `usePanelDocumentActions` opener, the same one the panel's Files view uses, so the tab lands in the member slot's bucket and the live placement (docked column or overlay) is revealed. The split-pane binding and the attachment-card inert state of kirodotdev#14458 are not carried over; the release branch never had the behaviours they corrected. `ChatPane.fileOpen.test.tsx` pins the hop at the pane boundary: a crewmate reply, a split-pane reply and a sent prompt's attachment card each open through the host handler, and without a handler the reply renders with no opener.
Contributor
Author
|
Status note for reviewers: every check on head
The change itself is the two |
Contributor
|
Thanks for tracking this down, @rubencu! Crewmate chats already open file paths in the side panel on main and on release/0.9.0 (the onFileOpen wiring from #14458 is present in MembersPage there), and release/0.8.0 has had no changes since its final changelog merge on Oct 9 now that 0.9.0 is cut. Closing since there is no further 0.8 release to carry the backport. If a 0.8.x patch release is still planned, please reopen. |
This was referenced Oct 27, 2026
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
Goal: On the Crewmates page, clicking a file path in a crewmate's reply opens that file in the page's side panel, the way it does in an ordinary chat.
Bug fix. A crewmate's reply names the files it produced; the dashboard confirms each path and draws it as a path chip with a file glyph. On the Crewmates page a click on that chip does nothing visible. The same chip in a chat session opens the file as a Files tab in the side panel. Observed on the 0.8.0.9 build (cut from
release/0.8.0), on a dashboard served by a remote gateway.Why it matters
A crewmate's output is mostly documents it wrote to disk, and the reply is where it points the reader at them. Every reader of a crewmate chat on 0.8 hits this on every file the crewmate names: the chip looks actionable, the click answers nothing, and the reader has to copy the path and open it elsewhere. The chat page has had the working behaviour since #14458 (2026-09-29);
release/0.8.0branched one day earlier and never received it.Not a goal
SessionGridView,usePanelDocumentActions,usePanelTabs): the release branch never had split-pane file opens, so there is nothing to rebind.FileMentionChip/FileAttachmentCard): a locale-catalog change the release branch does not need for this fix./artifacts/<slug>links in a crewmate reply (fix(crew): crewmate DM cannot open files or artifacts from the transcript #18320 / fix(crew): open artifact links from a crewmate DM in its side panel #18323 on main): a separate plumbing (onArtifactOpen), not touched here.What changed (motivation → approach → change)
Symptom: a confirmed path chip in a crewmate reply opens nothing.
Root cause:
MarkdownRendererroutes a chip click throughactivatePath, which callsactions.onFileOpen(path)when the host wired one and otherwise falls back torevealOrOpen(path, 'reveal'), the OS file-manager reveal. On a remote gateway that reveal has nothing to show. Onrelease/0.8.0the Members page'sChatPanehas noonFileOpenprop at all, so no handler ever reaches the renderer;ChatMessageList,createTranscriptRenderers,renderAssistantBubbleandAssistantMessagealready forward one when given it. Main fixed this in #14458 by adding the prop toChatPaneand passing the page's opener.Change, the
ChatPaneandMembersPagehunks of #14458 applied to the release branch:website/src/components/ChatPane.tsx: a documentedonFileOpenprop, handed tocreateTranscriptRenderers(and its dependency array) and to theChatMessageListmount.website/src/pages/members/MembersPage.tsx: the DM pane receivesopenFilefrom the page's existingusePanelDocumentActions, the same opener the panel's Files view uses, so the tab lands in the member slot's bucket andonOpenedreveals whichever placement (docked column or overlay) is live.Backwards compatibility
Compatible: one optional prop added to
ChatPane; every other host passes nothing and keeps today's behaviour (capability by omission, likeopenSideChat).Tests
website/src/test/ChatPane.fileOpen.test.tsx(new, 4 tests) pins the hop at the pane boundary with aMarkdownRendererstand-in that activates a chip exactly asactivatePathdoes when a handler is wired:crewmateprop, steer-only) opens a named file through the host handler;Mutation check: with the
ChatPane.tsxhunks reverted the three positive tests fail (3 failed, 1 passed); with them, 4 passed.vitest runover everyChatPane.*test andsrc/pages/members: 33 files, 603 tests passed.tsc -p tsconfig.app.jsonclean,eslintclean on the three files.Manual verification
Not run on a built SPA. The code path below the pane is the one the chat page exercises daily:
MarkdownRenderer→PathActionCtx→InlineCode→activatePath→onFileOpen, unchanged by this PR. The before state is the reporter's screenshot on 0.8.0.9: confirmed path chips in a crewmate reply, side panel closed, click answers nothing.Screenshots / video
Why no screenshot: nothing changes at rest. The chip, its glyph and the panel draw exactly as before; the change is what a click on an existing chip does, and that behaviour is pinned by the tests above.
Related Issues
Backport of the
ChatPaneand Members-page part of #14458 torelease/0.8.0.no linked issue: #14458 is the main-branch fix this backports, already closed; no issue tracks the 0.8 symptom.
Pattern harvest
Rule candidate: review-prompt
Pattern: a transcript host mounts
ChatPane(orChatMessageList) on a surface with a side panel but passes noonFileOpen; the renderer's fallback is the OS reveal, which is silent on a remote gateway, so the omission shows up as a dead chip rather than an error.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)