Repository navigation
feat: let crewmates propose changes the user confirms as cards - #18448
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Press a card all the way through to its write on a live gateway, including a multi-step plan that gets interrupted. The PR says this was never exercised. Suggestions
[DESIGN-REVIEWED] 93dbeef Description read[DESCRIPTION-READ] 20ab3d632ffa306f0f21d75f2a3d26193b2eadcd18d2ae2f26f63ed3c63af82d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ human override accepted@buluoray overrode this lane for |
First Principles Review (Opus 5.5) — ✅ human override accepted@buluoray overrode this lane for |
GPT 6.1 Review — ✅ human override acceptedHuman judgment by @buluoray overrides the GPT 6.1 finding for [GPT-OVERRIDE] 93dbeef This comment is updated in place on each push. The model was not re-run because an authorized human decision supersedes it. False positive or not applicable? A repository writer can comment: |
40c156a to
5d0724b
Compare
9144913 to
ccb8169
Compare
5d0724b to
de717d0
Compare
ccb8169 to
b06cfa3
Compare
de717d0 to
3ba9530
Compare
b06cfa3 to
1545743
Compare
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings block this merge. Two advisory findings in the new diagnose probes. FINDING — src/kiro_crew/diagnose_probes.py:278 — the probe checks FINDING — src/kiro_crew/diagnose_probes.py:576 — [OPUS-REVIEWED] 93dbeef Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
3ba9530 to
56b5be4
Compare
1545743 to
1e9a750
Compare
56b5be4 to
d8add30
Compare
1e9a750 to
927e629
Compare
Human judgment recorded@buluoray marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
|
|
|
|
/ai-review override fable 8a2fd7e: Infrastructure failure, not a finding: discovery returned under 250 characters with no [OPUS-DISCOVERY] marker on both the run and its rerun. |
Human judgment recorded@buluoray marked the fable AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
|
/ai-review override gpt 8a2fd7e: Owner decision: reaching it needs about 400 near-limit cards proposed and each one applied by the owner; every card is capped at proposal and the store at 512, and the extreme case is a visible 503 with the file left intact, not data loss. |
Human judgment recorded@buluoray marked the gpt AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Sensitive change review
|
Sensitive change review
|
Sensitive change review
|
A crewmate can now prepare a change to Kiro Crew instead of only pointing at the control: propose_change names one registered kind (settings, schedules and one-time reminders, crewmates and their capabilities, templates, MCP servers, connections, secrets, app trust, denied-command rules) and the gateway writes what changes, the risk and the exact requests. Nothing changes until the user presses the card; the browser replays the routes the settings pages already call, under a hook that verifies each step. find_setting, get_member_capabilities and diagnose_settings are the read-only lookups a proposal needs. A secret is typed into the card and never passes through the agent, and a card that widens what an agent may do without asking needs an acknowledgement tick as well as the press. Only a turn the user sent from the dashboard may propose.
Sensitive change review
|
|
/ai-review override first-principles 93dbeef: Owner decision: secret.save, app-trust and denied-command cards are in scope for this PR; the RFC will be amended to list them. |
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
/ai-review override ux 93dbeef: Owner decision: no new screenshots for this PR; the card copy and states are covered by tests, and the remaining evidence gaps are accepted by the owner. |
Human judgment recorded@buluoray marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
|
/ai-review override gpt 93dbeef: Owner decision, same finding as overridden on 1a98c8b: the race needs a second tab's save to land inside a few-millisecond admission flush while the same owner clicks Undo, which no human can do (about 200 ms reaction, two tabs); the loss is the owner's own visible edit, the residual undo-time window already accepted for in-place cards. |
Human judgment recorded@buluoray marked the gpt AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: Let a crewmate prepare a change to Kiro Crew (a setting, schedule, crewmate, MCP server, connection, secret, app trust or denied-command rule) that applies only after the user presses its card.
With guided tours (#18443) a crewmate can point at the control, but the user still has to find every field and fill it in. A crewmate asked "make replies shorter" or "move that reminder to 8:30" cannot hand over a prepared change for the user to confirm. The decision is recorded in
docs/request-for-change/rfc-crewmate-guides-and-mate.md(accepted, merged in #18326). This is the third of three PRs that ship it: Mate (#18406), guided tours (#18443, the base of this PR), then change cards (this one).Why it matters
A prepared change that applies on one press turns a settings hunt into a one-message request, while every change still needs the user's own click and goes through the routes the settings pages already use.
Not a goal
cron_addand its other tools, under their own approvals.What changed (motivation → approach → change)
Approach: the agent names one registered kind with parameters; the gateway, not the model, writes what changes, the risk and the exact requests, and the owner's browser applies it through the existing routes under a hook that verifies each step.
src/kiro_crew/mcp_guide.py):list_change_kinds,propose_change,get_change_status, plus the readsfind_setting,get_member_capabilitiesanddiagnose_settings. ExactallowedToolsgrants (agent._GUIDE_AUTO_GRANTSinsrc/kiro_crew/agent.py,config/defaults.json), through the governance ceiling.change_card_catalog.py): settings, schedules and one-time reminders, crewmates and their capabilities, templates, MCP servers, connections, secrets (typed into a field the agent never sees), app trust and denied-command rules. Each plan is rebuilt from kind and params on load; card text the output redactors would change is refused.dashboard/change_cards.py,dashboard/handlers/change_cards.py,dashboard/server_runtime/crewmate_prune.py,dashboard/server.py,server_runtime/mcp_routes.py): a write step is persisted before its route runs; the card hook on the hooked routes verifiesX-Card-*steps; proposing needs a turn the user sent (feat: welcome users with Mate, a first crewmate they get to name #18406's admission). Outcomes reach the proposing slot's next turn as a[CHANGE CARD RESULTS]block (context_blocks.py,chat_runner.py).Dashboard: ...line to Global memory history (_record_memory), sodiagnose_settingscan name recent changes. Names only, never a secret or token value; nothing is written when persistent memory is off (docs/architecture/context-management.md).diagnose_probes.py): twelve read-only symptom probes behinddiagnose_settings;agent_sdk/drivers/acp.pyre-exportsresolve_usable_modelfor them.website/src/cards,website/src/api/cards.ts): the card is a row of the conversation, drawn where it was proposed, with Apply, Undo and a widen acknowledgement;card_updateframes keep it live (hooks/useWebSocket.ts).Smaller pieces:
crew_log/emit.py,crew_log/entry_types.py,crew_log/schema.pyanddashboard/chat_cards.pyadd thecard/*entries and thechangerow surface;security_posture.py,validation.pyandhistory_projection.pylist the new redaction sinks and schemas;dashboard/handlers/guide.pyanddashboard/guide_runs.pyshare the admission and retention;website/src/guide,website/src/components,website/src/pages/chat,website/src/store,website/src/app-sdkandwebsite/src/hookscarry the card row and wording;website/src/i18nholds the card strings;src/kiro_crew/config/prompt.md,src/kiro_crew/docsanddocs/cover MCP, crew log, crew mode, history and the feature map.Design decision: a card that widens what an agent may do without asking (approval mode
auto, sandbox off, a crewmate'sautoApprove) stays possible, but only behind an acknowledgement tick plus the user's own press (risk: widen).Backwards compatibility
Compatible: every change a card makes goes through a route that already exists, and the hook only adds checks to requests that carry card headers. The new routes refuse callers they cannot attribute to a dashboard turn.
Removes nothing: the diff adds a tool set, a store and a card UI; nothing main accepts is narrowed.
Tests
test_change_cards.py(catalog, persist-before-run, rebuild on load, redaction refusal, hook),test_change_card_one_shot.py,test_diagnose_probes.py,test_guide_admission.py(a turn the user did not send cannot propose a card),test_guide_server.py(card grant under the ceiling, off-dashboard wording, card reply hints), plus updated composition, spec-byte, crew-log and persistence contracts.src/cards/*.test.tsx(every kind renders, plan steps in order, refusals, widen gate, secret field, undo, one-shot schedules),chatSlice.cardRow.test.ts,TurnBlock.cardRow.test.tsx,useWebSocket.frameTrace.test.ts.Manual verification
Earlier heads, live on a preview gateway with a real model: "Move that PR reminder to 8:30am America/Los_Angeles" →
propose_changeput a schedule card in the chat; it was not pressed. That run found the time zone shown twice, fixed inkindBodies.tsxand pinned byshows a changed time zone once, in its change row. Gates on this head: flake8, mypy,tsc, the index check, i18n against origin/main, and the related pytest and vitest sets. Not exercised: pressing a card through to its write on a live gateway; Windows and macOS hosts.Screenshots / video
From an earlier head: a schedule change card in the chat.
Related Issues
Part of #18300 and the RFC in #18326; based on #18443.
Pattern harvest
Not generalizable: a feature PR.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.