Repository navigation
Conversation
…e (release/0.8.0) On a phone the Crewmates page hands its side panel the whole window, so the panel covers the chat. Its strip then holds three labelled leading chips (Notes, Work log, Dashboard), the pinned views, the + menu and the close control, and that row is wider than the screen. The group holding the leading and pinned chips was `shrink-0`, so instead of shrinking it pushed the + menu and the close control past the panel root's `overflow-hidden` edge. Nothing at that width brings them back, and the scrim the overlay would otherwise dismiss on is fully covered by the panel: the person is left on the Notes tab with no way back to the chat (seen on an iPhone at 390px, dashboard 0.8.0.9). Backport of the strip part of kirodotdev#14925, which main has carried since 2026-09-30: the fixed group takes the dynamic tablist's class set (`min-w-0 overflow-x-auto scrollbar-none`) and drops `shrink-0`, so it shrinks to the width the strip controls leave and scrolls by touch, while the chips inside stay `shrink-0` and never squeeze. The trailing controls are siblings of the group, so they stay put at the trailing edge. The Schedules tab, the leading-tab badge and the leave guard that kirodotdev#14925 also brought are not carried over; the release branch has none of the surfaces they serve. Tests: `sidePanelLeadingTab.test.tsx` gains the upstream case pinning the group's overflow contract and that the close control sits outside the scroller; `sidePanelBrowserTabs.test.tsx` names the group by its testid rather than by the layout class it no longer has, as upstream does.
|
Status note for reviewers: every check on head |
|
Thanks for the careful write-up and the before/after measurements! Closing this backport because there is no further 0.8 release to carry it: release/0.8.0 has had no changes since its final changelog merge (#18523, 442779c, Oct 9), and v0.9.0 is now the latest stable with 0.10.0 in rc. The fix itself is already on main since #14925 (aec8141), and it survived the SidePanel split in #22106 (8baa93d): website/src/pages/chat/SidePanel.tsx on main keeps the fixed-chip group as |
Problem / Motivation
Goal: On a phone, the Crewmates side panel always shows its close control, so a person who opened a crewmate's Notes, Work log or Dashboard can get back to the chat.
Bug fix. On a phone the Crewmates page hands its side panel the whole window, so the panel covers the chat. Its tab strip then holds three labelled leading chips (Notes, Work log, Dashboard), the pinned view chips, the + menu and the close control, and that row is wider than the screen. The group holding the leading and pinned chips is
shrink-0, so instead of shrinking it pushes the + menu and the close control past the panel root'soverflow-hiddenedge. The scrim that would otherwise dismiss the overlay is fully covered by the panel at that width. What the person sees: the strip ends at the pinned icon chips, and there is no control anywhere on the screen that returns to the chat. Observed on an iPhone (390px) on the 0.8.0.9 build, cut fromrelease/0.8.0.Why it matters
Every phone reader of a crewmate's panel on 0.8 hits this on every open: one tap into Notes or the Work log and the only way back is the browser's own reload or back, which drops the page state. The dismiss control exists and is wired; it is simply laid out off-screen.
mainhas not had this since #14925 (2026-09-30);release/0.8.0branched before it.Not a goal
badge, theonBeforeLeaveleave guard): the release branch has none of the surfaces those serve.mainlater added to this group in fix(dashboard): cue clipped overflow on four hidden-scrollbar strips (#4074) #17949 (the fade that signals more chips to the side). That is a separate fix with its own hook (useScrollEdges) and touches four strips; the pinned chips here are reachable by swiping the strip, the same statemainshipped between feat(crewmates): a crewmate's schedules in its own side panel tab #14925 and fix(dashboard): cue clipped overflow on four hidden-scrollbar strips (#4074) #17949.What changed (motivation → approach → change)
Symptom: on a phone the Crewmates side panel's strip shows Notes, Work log, Dashboard and the pinned icon chips, and nothing after them.
Root cause: in
SidePanel.tsxthe group wrapping the host's leading chips and the pinned chips wasflex items-end gap-2 shrink-0 -mb-px. Withshrink-0the group keeps its content width whatever the strip's width, so on a 390px-wide panel the siblings after it (the + menu, the divider, the close control) are laid out at x = 387 and x = 434, past the right edge, and the panel root'soverflow-hiddenclips them. The dynamic tablist beside it never had this problem because it ismin-w-0 overflow-x-auto.Change, the strip hunk of #14925 applied to the release branch:
website/src/pages/chat/SidePanel.tsx: the fixed group takes the dynamic tablist's overflow contract (min-w-0 overflow-x-auto scrollbar-none) and dropsshrink-0, so it shrinks to the width the strip controls leave and scrolls by touch. The chips inside it stayshrink-0, so they scroll rather than squeeze. The group gainsdata-testid="side-panel-fixed-tabs", as onmain. The trailing controls are siblings of the group, so they stay at the trailing edge.Backwards compatibility
Compatible: a class change on one strip container and a test id. No prop, store key, or endpoint changes; a wide panel, where the group never exceeded the strip, lays out as before.
Tests
website/src/test/sidePanelLeadingTab.test.tsx: the upstream case from feat(crewmates): a crewmate's schedules in its own side panel tab #14925, "the fixed-chip group scrolls instead of pushing its own chips and the strip controls off the edge". Renders a closable panel with the three Crewmates leading tabs and pins that the group carriesoverflow-x-autoandmin-w-0and notshrink-0, that the dynamic tablist keeps the same contract, that the leading chips stayshrink-0, and that the close control is rendered outside the scroller (so it cannot scroll away with the chips).website/src/test/sidePanelBrowserTabs.test.tsx: the seam-hairline case located the fixed group bydiv.shrink-0; it now uses the group's test id, asmaindoes, since the group no longer has that layout class.Mutation check: with
SidePanel.tsxreverted to the branch tip the new case fails (1 failed, 17 skipped); with the fix the file passes (18 tests).vitest runover every test that importsSidePanelor touchesside-panel-strip, plussrc/test/sidePanel*,src/pages/members/MembersPage*andsrc/test/ChatPane*: 62 files, 792 tests passed.tsc -p tsconfig.app.jsonclean;eslintclean on the three files.Manual verification
Driven with Playwright against the repository's own gateway-free capture entry (
website/capture/members-page.html, the realMembersPageon the Vite dev server with the Members API stubbed), at a 390 × 844 layout viewport, dark theme: tap theradarrow, tap the header's Details toggle, measure the strip's controls.shrink-0, overflows the stripNot run on a phone device. The cause and the fix are pure layout, and the frames below were taken at the reporter's viewport width.
Screenshots / video
Frames from the harness above, 390px wide. Before, the strip ends at the pinned icon chips with nothing after them:
After, the + menu and the close control sit at the trailing edge; the chip group scrolls beneath them:
The same strip scrolled to its end, pinned chips reached, controls unmoved:
Full-height frames (390 × 844). The first 42px row is the page's own thread header, exposed because the harness mounts no app top bar; in the app the overlay sits under the top bar and that row is covered.
Committed under
temp-screenshots/withgit add -f, as the template prescribes for a fork PR; the maintainer may drop the directory from the tip after merge.Related Issues
Backport of the strip hunk of #14925 to
release/0.8.0.no linked issue: #14925 is the main-branch change that already carries this fix; no issue tracks the 0.8 symptom.
Pattern harvest
Rule candidate: review-prompt
Pattern: a horizontal flex strip inside an
overflow-hiddenframe holds ashrink-0group of variable content next to fixed trailing controls; at a narrow width the group's content, not the frame, decides where the controls land, and the controls fall past the clipped edge with no scrollbar to reveal them. Any group that can grow (host-supplied chips, labels in a long locale) needsmin-w-0 overflow-x-auto, withshrink-0kept on the items inside it.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)