Skip to content

test(e2e): keep a trace on 17b's first failure, wait for row B - #18529

Closed
iamwhatever wants to merge 2 commits into
mainfrom
fix/17941-tags-picker-rightclick-flake
Closed

iamwhatever wants to merge 2 commits into
mainfrom
fix/17941-tags-picker-rightclick-flake

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Stop 17b aiming its right-click at a point the sidebar's search dock covers, and make any later CI failure leave the evidence to explain it.

Spec session-tags-e2e.spec.ts › 17b (right-click on another row while the Tags picker is open) fails on CI's first attempt and passes on the retry. MAX_FLAKY_SPECS=0 then fails the whole E2E job. It has hit at least 10 unrelated PRs since 2026-09-30 (see #17941). The failing attempt stops at expect(menu).toBeVisible(): picker closed, __ctx true, no menu open, focus on body.

Why it matters

Every PR that hits it goes red for a spec it never touched.

Not a goal

  • A product change. The CI hit test below points at test geometry, not a product race: a right-click where the search dock covers row B is a right-click on the search field.
  • Hiding the flake. An in-test retry (toPass) was tried in an earlier revision and removed: on CI all 6 in-test reloads missed in the same browser context (run 37991140068, evidence in Flaky: session-tags-e2e.spec.ts 17b right-click on another row passes only on a retry in E2E (stub ACP backend, offline) #17941), so it masked nothing and only weakened the gate.
  • Changing retries or MAX_FLAKY_SPECS.
  • Keeping a trace for every failing attempt in the file. An earlier revision set test.use({ trace: 'retain-on-failure', screenshot: 'only-on-failure' }) at file level; it caught the first CI trace of 17b, but while it was on, browser.newContext crashed Chrome (SEGV) in other specs of this file on three CI runs (specs 18; 16b and 26; 2), and on no main or other-PR run checked. Playwright refuses these options inside a describe, so it cannot be narrowed to 17b. It is removed; the flaky-gesture annotation and hit test carry a miss's evidence.
  • Any product code change.

What changed (motivation → approach → change)

Test-only, three files:

  1. website/playwright/session-tags-e2e.spec.ts, 17b: before aiming at row B, centre it in its scroller (scrollIntoView({ block: 'center' })), wait until its box is the same across two animation frames, and poll that the first element under the backdrop at the click point is inside row B. The sidebar's ListDock floats the search capsule over the top of the list, and CI's miss had the sidebar search input there (see Evidence). If the point is still covered, 17b fails with a geometry message instead of a missing menu.
  2. Same spec, 17b: on a failure, add a flaky-gesture annotation with the step that failed, the page state (menu count, picker, focus, row B live/stub, its data-state, __ctx), the click point, and an elementsFromPoint hit test at that point taken before the right-click (what the backdrop's elementBeneath() walks) and after the miss. Then rethrow, so the attempt still fails and the flaky ceiling still sees it. The page reads are guarded, so a crashed page never replaces the assertion error.
  3. test/test_playwright_e2e.py: read every flaky-gesture annotation (GESTURE_MISS_ANNOTATION) from the JSON report the harness already parses, and print each one to the job log and $GITHUB_STEP_SUMMARY. The reporters keep test stdout out of the job log, so without this the annotation is only inside the uploaded report. docs/ci/e2e-gate.md names the channel.

Evidence

At 9605e6d the hit-test probe caught a CI miss (run 37995411780). At row B's click point (269, 105), elementsFromPoint returned the backdrop, then input inside search-field-glass, then row B. So elementBeneath() forwarded the right-click to the search input. Details in #17941.

With the fix (centre row B, check the point reaches row B), 17b passed on CI's first attempt at 29e56c0 (run 37997670466): not in the flaky list, no flaky-gesture line. In the same window, 17b was the flaky spec on 4 of 4 other PRs' E2E runs (runs 37998093717, 37998079541, 37997794520, 37997518889).

Backwards compatibility

Compatible: test-only change; no product code or contract is touched.

Removes nothing: the spec keeps every assertion it had; it only adds a scroll, a hit-target check and a failure annotation.

Tests

Run Result
Harness unit tests for the annotation reader, summary and log line red before the harness change, pass after (16 selected pass)
Real Playwright 1.58.2 JSON report with a runtime-pushed annotation found in both tests[].annotations and results[].annotations, read once
Geometry check in real Chromium: a dock over a scrolled list, under a backdrop point covered before scrollIntoView (false), reaches row B after it (true)
Hit-test helper in real Chromium (fixed backdrop over a row) ["div[role=button].fixed inset-0","span[role=button][in row B].inner","div[in row B].","html."]
CI at an earlier revision the printed [flaky-gesture] lines reached the job log

The spec file runs mode: 'serial', so a shuffled order does not apply.

Manual verification

Reproduction attempts on origin/main before the change, all 0 failures of 17b: 30x alone, 40x under full CPU load, 20x with 250 seeded sessions, 20x at 3x CDP CPU throttle, whole spec 8x, about 33 full-suite passes. An event-order logger on 13 passes showed the same order every time: trusted contextmenu on the backdrop → forwarded contextmenu on row B → menu focus → backdrop removed.

Related Issues

Fixes #17941

Pattern harvest

A Playwright toBeVisible() row can still be covered by a floating dock; a spec that drives the raw mouse at a row's box should check the hit target, as 17b now does.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 9, 2026 16:57
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision e4bb54cc92ca930395cfd068416921e6634709e4 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of e4bb54cc92ca930395cfd068416921e6634709e4 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Nothing to check.

[UX-REVIEWED] e4bb54c

Description read

[DESCRIPTION-READ] ac1788727ef257716e5746d915085971413525d212ebb809336db0f9174351c7

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of e4bb54cc92ca930395cfd068416921e6634709e4 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] e4bb54c

False positive or not applicable? A repository writer can comment:
/ai-review override gpt e4bb54cc92ca930395cfd068416921e6634709e4: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed e4bb54cc92ca930395cfd068416921e6634709e4 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] e4bb54c

Verdict parsed from the review's SHA-scoped output markers for commit e4bb54cc92ca930395cfd068416921e6634709e4.

False positive or not applicable? A repository writer can comment:
/ai-review override fable e4bb54cc92ca930395cfd068416921e6634709e4: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of e4bb54cc92ca930395cfd068416921e6634709e4 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

The title says "keep a trace on 17b's first failure", but this diff keeps no trace and the description says trace retention was removed. Retitle before merge.

Suggestions

  • In _gesture_misses, read GESTURE_MISS_ANNOTATION the same way the spec writes it: the spec pushes the literal 'flaky-gesture', so a rename on either side silently stops the log and summary lines. A one-line comment beside the spec's push naming the harness constant is enough.

[DESIGN-REVIEWED] e4bb54c

Description read

[DESCRIPTION-READ] 4e6dd4aa721906385901aefad3d0edb75610824dcb053f78877bc8349b98ab29

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 9, 2026
@iamwhatever
iamwhatever force-pushed the fix/17941-tags-picker-rightclick-flake branch from 37ad0a1 to adf6b0d Compare October 9, 2026 17:18
@iamwhatever

iamwhatever commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=80b3a708a69f The retry tests a different path

Fixed in adf6b0d. Every toPass attempt now goes through the open picker's backdrop: a retry presses Escape and re-opens A's Tags picker before the right-click, and __ctx is reset and asserted per attempt. Mutation check: making onBackdropContextMenu return before dispatchEvent now turns 17b red at the toPass block (menu not found).

@iamwhatever

iamwhatever commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=027c512fc4e3 After a failed attempt the backdrop is gone

Fixed in adf6b0d. Every toPass attempt now goes through the open picker's backdrop: a retry presses Escape and re-opens A's Tags picker before the right-click, and __ctx is reset and asserted per attempt. Mutation check: making onBackdropContextMenu return before dispatchEvent now turns 17b red at the toPass block (menu not found).

@iamwhatever

iamwhatever commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=45d0155d0ed8 The second right-click hits row B directly

Fixed in adf6b0d. Every toPass attempt now goes through the open picker's backdrop: a retry presses Escape and re-opens A's Tags picker before the right-click, and __ctx is reset and asserted per attempt. Mutation check: making onBackdropContextMenu return before dispatchEvent now turns 17b red at the toPass block (menu not found).

@iamwhatever

iamwhatever commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=bb8e8c2c9be8 Broken forwarding could pass green

Fixed in adf6b0d. Every toPass attempt now goes through the open picker's backdrop: a retry presses Escape and re-opens A's Tags picker before the right-click, and __ctx is reset and asserted per attempt. Mutation check: making onBackdropContextMenu return before dispatchEvent now turns 17b red at the toPass block (menu not found).

@iamwhatever

iamwhatever commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=4e0d50fdda0c Clears when: each retry re-opens A's picker

Fixed in adf6b0d. Every toPass attempt now goes through the open picker's backdrop: a retry presses Escape and re-opens A's Tags picker before the right-click, and __ctx is reset and asserted per attempt. Mutation check: making onBackdropContextMenu return before dispatchEvent now turns 17b red at the toPass block (menu not found). This is the first Clears when option, as written.

@iamwhatever

iamwhatever commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=f9e3001e5b7b Wait for a trace before adding tolerance

Rebutted, kept as is. The conductor asked for the tolerance now, because 17b is failing unrelated PRs several times a day. The tolerance can no longer hide a broken forward (see the fixed Watch items), every retry leaves a flaky-gesture annotation, and the first-attempt trace is still kept, so the evidence this suggestion wants is still collected.

@iamwhatever

iamwhatever commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=f3f006b72ade toPass means 17b no longer fails when forwarding is broken

Fixed in adf6b0d. Every toPass attempt now goes through the open picker's backdrop: a retry presses Escape and re-opens A's Tags picker before the right-click, and __ctx is reset and asserted per attempt. Mutation check: making onBackdropContextMenu return before dispatchEvent now turns 17b red at the toPass block (menu not found).

@iamwhatever
iamwhatever force-pushed the fix/17941-tags-picker-rightclick-flake branch from adf6b0d to d52132f Compare October 9, 2026 17:38
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=91f9d339e19f Retry setup branches on instantaneous picker visibility

Fixed in d52132f. The isVisible() branch is gone. Each toPass attempt now reloads /chat and re-opens A's Tags picker from scratch, so every attempt starts from the same known state and goes through the backdrop; nothing samples visibility to decide a path.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=27ad4126a94e Retry path branches on a single isVisible() sample

Fixed in d52132f. The isVisible() branch is gone. Each toPass attempt now reloads /chat and re-opens A's Tags picker from scratch, so every attempt starts from the same known state and goes through the backdrop; nothing samples visibility to decide a path.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=908fde2170f3 The two halves of the goal cancel out

Fixed in d52132f, by the first Clears when option. A masked miss now leaves evidence that does not depend on the test failing: each missed attempt prints a [flaky-gesture] line to the CI log with the page state at the miss (menu count, picker, focus, row B live/stub, its data-state, __ctx), plus an annotation. A broken forward still fails red: with dispatchEvent removed, 17b fails after 5 attempts.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 9, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=8f4be559ea95 Ship without toPass for one cycle

Rebutted, kept as is. The conductor asked for the tolerance in this PR, because 17b is failing unrelated PRs several times a day. The tolerance cannot hide a broken forward (it fails red under that mutation), and every miss still prints its page state to the CI log, so the evidence #17941 needs is collected either way.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=4690f8f8b912 The race is masked, not fixed

Addressed by the first Clears when option, no code change. #17941 stays open (Refs, not Fixes), and an issue comment now names the [flaky-gesture] log line and annotation as its evidence channel: #17941 (comment)

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=453a67be0d3b The new trace setting may not capture what it's meant to

Addressed by the first Clears when option, no code change. The PR description now says that for a recovered miss the [flaky-gesture] page-state dump, not the trace, is the evidence, and that a trace is kept only when every attempt fails.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 9, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the fresh-page-per-attempt shape and the stable-box wait are good, and keeping a trace when every attempt fails is exactly what #17941 needs. One blocking problem with the masked-miss path:

A recovered miss leaves no evidence anywhere on CI. Inside toPass, a miss that a later attempt recovers makes 17b pass as expected, not flaky, so the MAX_FLAKY_SPECS = 0 ceiling (docs/ci/e2e-gate.md: retries detect a flake, they never fix one) stops seeing it. The PR offers the [flaky-gesture] line as the replacement evidence, but on CI it never reaches the job log:

  • The harness runs Playwright with --reporter=html,json (test/test_playwright_e2e.py:435). Neither reporter echoes test stdout to the terminal, so console.log goes only into the report files.
  • playwright-report/ and test-results/ are uploaded only if: failure() (ci.yml, "Upload Playwright failure artifacts"). On a green run the annotation and the stdout are discarded with the runner.

So an intermittent regression in backdrop-forwarded right-click, the very race this issue is about, would now pass with no signal at all. A deterministic break still goes red, which is good.

Any one of these would fix it:

  1. Have the harness read flaky-gesture annotations from the JSON report it already parses, print them, and write them to the step summary (ideally counting them against the flaky ceiling).
  2. Emit the line on a channel the job log shows, and upload the report whenever such an annotation exists.
  3. Drop the toPass wrapper and keep only the stable-box wait plus retain-on-failure. A remaining miss would then still trip the flaky gate, and it would now come with a trace.

Non-blocking:

  • The catch block's page.evaluate can throw on a crashed page and replace the original error. Consider guarding it so the assertion error is always the one rethrown.
  • Please note in #17941 that the wrapper should come out once the root cause is fixed.

@iamwhatever
iamwhatever force-pushed the fix/17941-tags-picker-rightclick-flake branch from d52132f to 6735b55 Compare October 9, 2026 20:21
@iamwhatever

Copy link
Copy Markdown
Contributor Author

@buluoray Thanks, agreed: the [flaky-gesture] line never reached the job log. Fixed in 6735b55 with your option 1 (rebased onto main first).

Blocking: a recovered miss now shows on CI, green runs included.

  • test/test_playwright_e2e.py reads every flaky-gesture annotation (RECOVERED_MISS_ANNOTATION) from the JSON report it already parses. It prints each one, with its page-state description, to the job log, and writes them to $GITHUB_STEP_SUMMARY under "recovered miss(es)". This runs before the floor assertions, so it does not depend on the run failing.
  • The spec's console.log is gone; the annotation is the one channel.
  • docs/ci/e2e-gate.md names the channel beside MAX_FLAKY_SPECS.
  • Red first: 5 new harness unit tests failed before the change and pass after.
  • Checked on a real Playwright 1.58.2 JSON report: a toPass that recovers on attempt 2 reports expected=1, flaky=0. The annotation is in both tests[].annotations and results[].annotations; the harness reads it once.

Not counted against the flaky ceiling, on purpose. Counting it would turn every recovered miss red again, which is the same as today's red on unrelated PRs, and option 3 does that with less code. If you would rather have the ceiling count it, it is a small change in _assert_suite_not_darkened; say so and I will do it, or drop toPass per option 3.

Non-blocking:

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 9, 2026
@iamwhatever
iamwhatever force-pushed the fix/17941-tags-picker-rightclick-flake branch from 6735b55 to 84ed380 Compare October 9, 2026 21:04
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The retry gets past the flaky ceiling

Doc part fixed in 84ed380: the docs/ci/e2e-gate.md bullet now calls an in-test toPass retry a temporary exception, not a pattern to copy. It is allowed only while an open Flaky: issue tracks the race, and it comes out when that issue is fixed. Each annotation names its issue. Whether a recovered miss should also count toward MAX_FLAKY_SPECS is the open question to buluoray in the reply above. Counting it would turn unrelated PRs red again, as they are today. Also in 84ed380, from the Opus note: every step of an attempt is now inside the annotating try, so a recovered failure at any step (load, picker, aim, menu) is tagged with the step name.

  • The edit moves an existing rule onto the new bullet

Fixed in 84ed380: "Never raise the ceiling or retries for it." is back at the end of the flake-ledger bullet, and the new bullet follows it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The annotating try/catch covers only the steps after the click

Fixed in 84ed380. The whole attempt body, from page.goto through the menu check, is now inside the try. A step variable names where it failed (picker on row A, aim at row B, menu on row B after the right-click), and the flaky-gesture description includes that step. Any attempt that toPass retries now leaves an annotation, which the harness prints to the log and the step summary.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 9, 2026
@iamwhatever
iamwhatever force-pushed the fix/17941-tags-picker-rightclick-flake branch from 84ed380 to 9605e6d Compare October 9, 2026 21:46
@iamwhatever

Copy link
Copy Markdown
Contributor Author

@buluoray Switched to your option 3 in 9605e6d. CI made the case: at 84ed380, all 6 in-test toPass reloads missed in the same browser context, and only Playwright's retry in a new worker passed (run 37991140068; details in #17941). So the wrapper masked nothing.

  • toPass is gone. 17b is one attempt again, and a miss fails it, so MAX_FLAKY_SPECS sees every flake.
  • Kept: the stable-box wait for row B and retain-on-failure trace and screenshot.
  • Added: on a failure, the flaky-gesture annotation records the step, the page state, the click point, and an elementsFromPoint hit test at that point. One is taken before the right-click (what elementBeneath() walks) and one after the miss. The next CI hit shows what the forwarded right-click reached.
  • The harness still prints every flaky-gesture annotation to the job log and step summary, so the evidence is readable without the artifact. The doc bullet now says the tag is evidence only and does not change the gate.
  • Non-blocking items stay done: guarded page reads, and the Flaky: session-tags-e2e.spec.ts 17b right-click on another row passes only on a retry in E2E (stub ACP backend, offline) #17941 note.

17b can still flake on this PR's own E2E run until the race is fixed. That is the known #17941 flake, not a new one.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

The new hit-test probe caught 17b's CI miss at 9605e6d: at row B's click point the first element under the backdrop was the sidebar search input (the floating ListDock), not row B. In 29e56c0, 17b centres row B in its scroller and checks that the point reaches row B before right-clicking. Evidence: #17941 (comment). The other flaky spec on that run, 18, crashed in browser.newContext (chrome-headless-shell SEGV), which this PR does not touch.

Joe Guo added 2 commits October 9, 2026 22:58
The sidebar's search dock floats over the top of the list, so row B can be
visible yet covered at the click point, and the backdrop then forwards the
right-click to the search input. Centre row B in its scroller and check the
point reaches row B before right-clicking. Tag a miss with the page state
and hit tests at the click point.

Fixes #17941
A spec can tag a failing attempt with a flaky-gesture annotation holding
the page state at the failure. The reporters keep test stdout out of the
job log and the report is uploaded only from a red job, so the harness now
reads those annotations from the JSON report and prints each one to the
log and the step summary. The tag is evidence only: the attempt still
fails, and a passing retry still counts against MAX_FLAKY_SPECS.
@iamwhatever
iamwhatever force-pushed the fix/17941-tags-picker-rightclick-flake branch from ae8d7d8 to e4bb54c Compare October 9, 2026 22:59
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 9, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Another recurrence of 17b (session-tags-e2e.spec.ts, right-click on another row) passing only on retry, on unrelated backend-only PR #18412 head 47caa58: https://github.com/kirodotdev/KiroCrew/actions/runs/38004325522/job/114070347259 . Same failure: expect(menu).toBeVisible() at line 783 times out at 5000ms on the first attempt.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Closing: #18644 landed the same 17b fix on main (keep row B clear of the search dock, then check the point beneath the backdrop is row B) and closed #17941. It was built from the trace and hit-test probe this PR captured on CI, so nothing here is still needed for 17b. Thanks @buluoray for the review that pushed this toward evidence instead of a retry.

@iamwhatever iamwhatever closed this Oct 9, 2026
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 9, 2026
@bolichen97
bolichen97 deleted the fix/17941-tags-picker-rightclick-flake branch November 6, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky: session-tags-e2e.spec.ts 17b right-click on another row passes only on a retry in E2E (stub ACP backend, offline)

2 participants