Skip to content

docs(rfc): record the Older Sessions row-click preview as accepted - #18535

Open
Pearcekieser wants to merge 1 commit into
kirodotdev:mainfrom
Pearcekieser:docs/rfc-history-preview
Open

Pearcekieser wants to merge 1 commit into
kirodotdev:mainfrom
Pearcekieser:docs/rfc-history-preview

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record on main, as an accepted RFC, the product owner's decision that activating an Older Sessions row opens a read-only preview and that reopening the session takes a separate Resume, so #15730 has a decision on the base branch to land against.

#15730 changes what a click on an Older Sessions row does: today it reopens the session as a tab, and after #15730 it opens a preview and leaves the session closed. Its First Principles review blocks it because no non-draft RFC on main records that product-shape change, and #12257 is an issue, not a decision. Pearcekieser, as product owner, decided on 2026-10-09 to make the change, so this document records it with status: accepted.

Why it matters

A row click is the pane's main gesture. Changing it from reopen to preview changes what every user gets from Older Sessions, and that decision belongs in a docs-only diff a maintainer can read on its own, not inside the component change.

Not a goal

What changed (motivation → approach → change)

  • New docs/request-for-change/rfc-history-preview-not-reopen.md, status: accepted, accepted 2026-11-06 by the maintainer Bolin Chen (@bolichen97) at 9d5d7bb; its Status line and README row name them and the date. It records the before/after table for each row action, the preview's states, the new owner route the preview reads (GET /api/sessions/{key}/preview, answering {key, title, messages, has_more}), the 400 no_conversation_log answer, and three rejected alternatives. GET /api/sessions/{key} keeps its bare array for every caller: since feat(instances): add crew= scope to the session read MCP tools #26334 a hub's crew transcript read calls it on a peer and refuses anything but a list, so reshaping it (the earlier design, now alternative 2) would break remote-crew reads.
  • docs/request-for-change/README.md gets an accepted row and one audit-log sentence, verified at 85dcaeed2f on 2026-10-17 and re-verified at 66db87b900 on 2026-11-03: the row's activation (activateRow) in chat-sidebar/HistoryPane.tsx dispatches resumeFromHistory on click, Enter and Space, and api.sessionDetail has no consumer.

Backwards compatibility

Compatible: documentation only; no code, config or contract changes.

Removes nothing: the diff adds one RFC file, one README row and one log sentence.

Tests

python3 scripts/docs_lint.py passes. No code changed, so no code tests apply.

Manual verification

Read sections 3 and 4 of the new RFC against the #15730 diff: each row action, preview state and response shape it lists matches a branch in ChatSidebar.tsx, HistoryPreviewModal.tsx or api_session_detail on that PR, and a test in test/test_session_preview.py or website/src/test/HistoryPreviewModal.test.tsx.

Screenshots / video

None; docs only. The preview screenshots are on #15730.

Related Issues

Refs #12257. Unblocks #15730.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@Pearcekieser
Pearcekieser requested review from a team and KiroCrewCaptain as code owners October 9, 2026 17:16
@github-actions github-actions Bot added the fork Pull request from a fork (external contributor) label Oct 9, 2026
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision e3ad93a03a6e9e18e8c860b477128d9c088aae2e touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision e3ad93a03a6e9e18e8c860b477128d9c088aae2e ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of e3ad93a03a6e9e18e8c860b477128d9c088aae2e via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Docs-only RFC that records an owner decision; it removes nothing, renders nothing, and conflicts with no recorded decision.

Notes

  • The README audit-log line says "added 2026-10-09", but the description says the row was added in this PR. If an auditor reads that date as the date the row landed, it's wrong; "decided 2026-10-09" says what is meant.

[DESIGN-REVIEWED] e3ad93a

Description read

[DESCRIPTION-READ] 647756b7636ecc53a845b9149b0fb6f7c15b0ddb6d2eea92bba8f5d3fe1d3646

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed e3ad93a03a6e9e18e8c860b477128d9c088aae2e via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] e3ad93a

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed e3ad93a03a6e9e18e8c860b477128d9c088aae2e via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] e3ad93a

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note (non-blocking): Design Review, confirm the product-owner decision is posted on #15730

It is. Pearcekieser posted it on #15730 at issuecomment-6085726298, under First Principles item 1: a click or Enter on an Older Sessions row opens the read-only preview, and Resume reopens the session. That comment links this PR as the decision record. No change to the RFC is needed.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 9, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note (non-blocking): Backend Tests (3.12, 2) and Coverage Gate are red from one test timeout

Shard 2 failed one test, test/test_queue_receipt.py::TestAnAddressKeyNamesOneConversation::test_every_receipt_surface_stand_in_names_its_address, on Timeout >120.0s, with 25938 passed (run 37965085819). This PR changes only two Markdown files under docs/request-for-change/, so nothing in the diff reaches that test. Coverage Gate fails closed because that shard failed. The fork token cannot rerun jobs ("Must have admin rights"). A maintainer gh run rerun 37965085819 --failed should clear both.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 9, 2026
@Pearcekieser
Pearcekieser force-pushed the docs/rfc-history-preview branch from 148d318 to 95e7b78 Compare October 10, 2026 01:55
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Same-tree retrigger as 95e7b78, no content change: the tree is identical to 148d318 and only the commit date moved. It starts a fresh CI run past the 120 s timeout in test_queue_receipt on Backend Tests (3.12, 2), which also failed Coverage Gate.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 10, 2026
@Pearcekieser
Pearcekieser force-pushed the docs/rfc-history-preview branch from 95e7b78 to 4bd164b Compare October 10, 2026 02:13
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Rebased on main as 4bd164b, no content change. SAST (Semgrep) on 95e7b78 reported one test-autouse-shared-monkeypatch finding in test/test_readiness_poll_gate_max_age_14857.py. This PR does not touch that file, which main changed in decba81. The diff scan counted main's commits since the old base d4c3a73 as part of this PR, so rebasing onto 950be41 moves the scan baseline past them. The PR still changes only the two files under docs/request-for-change/, and scripts/docs_lint.py passes.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 10, 2026
@Pearcekieser
Pearcekieser force-pushed the docs/rfc-history-preview branch from 4bd164b to 39b8bc5 Compare October 10, 2026 07:57
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Rebased on main as 39b8bc5, no content change. Main merged #18650, which appended a sentence to the same audit paragraph in docs/request-for-change/README.md. The resolution keeps main's rfc-crewmate-greeting-as-message sentence and puts this PR's rfc-history-preview-not-reopen sentence after it. The PR still changes only the two files under docs/request-for-change/, and scripts/docs_lint.py passes.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main 0f2fbcf as 623ed28 to clear another README audit-paragraph conflict, no behaviour change. Another RFC row landed in the same paragraph; this PR's row and sentence are unchanged. The RFC decision gate (HOLD r125) is unchanged and still needs a maintainer call.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note (non-blocking): GPT 6.1 Review and Opus 5.5 Review on 623ed28 both ended "review incomplete" (check-runs 123829727001 and 123829715664, finished 01:07:42Z and 01:07:32Z) without updating their PR comments, so neither reached a verdict. Their last completed reviews, on f98c5ee, found nothing, and 623ed28 carries the same 2-file diff rebased onto 0f2fbcf. I am not pushing the same tree to retrigger them; the next rebase or a maintainer re-run of the fork review lanes will cover it. The RFC decision gate (HOLD r125) still needs a maintainer call.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main 18d6b4e as a67968e to clear another README audit-paragraph conflict, no behaviour change. Another RFC row landed in the same paragraph; this PR's row and sentence are unchanged. This push also reruns the GPT 6.1 and Opus 5.5 fork reviews, which ended "review incomplete" on 623ed28. The RFC decision gate (HOLD r125) is unchanged and still needs a maintainer call.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note (non-blocking): Integration (in-process gateway) on a67968e fails on main, not on this diff. test/integration/test_boot_smoke.py::test_a_second_boot_touches_only_known_module_globals reports kiro_crew.shared_crew.admission_gate._last_config_at as an unrestored module global (job 123928449990). That global came in with #25620 (0ad5aee), and on main 787d273 it is neither in conftest._reset_home_bound_globals nor in _KNOWN_SECOND_BOOT_CHANGES, so the check fails for any PR based on current main. This PR changes only 2 Markdown files. I will rebase onto the fix once it lands rather than re-running the same tree.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main 13e3ff2, no behaviour change. Main now carries #26180, which resets admission_gate._last_config_at between harness boots and lists it as a known second-boot change; that was the test_a_second_boot_touches_only_known_module_globals failure behind Integration (in-process gateway) on a67968e. The RFC decision gate (HOLD r125) is unchanged and still needs a maintainer call.

@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at 5fbce69.

The RFC text is unchanged since our r125 review, and CI and every AI lane are green. Two things still block:

  1. Merge conflict. GitHub reports this branch as conflicting with main again in docs/request-for-change/README.md. It needs another rebase.
  2. Maintainer decision. The RFC records status: accepted on the author's own decision on the implementation PR fix(sidebar): preview Older Sessions rows instead of reopening them #15730 (Status), and Dashboard: the remaining items from six partially delivered issues #12257 is tier:T3. A maintainer needs to accept that a row click opens a read-only preview and Resume reopens the session. The Status line and the README row should then name that maintainer and the date. The alternative is to set the status to draft. No maintainer acceptance appears in the thread yet, and your note on this head says the same.

AI findings judged non-blocking:

  • Design note: the doc-pr: field is empty (L8). This is a metadata nit. Filling it in with this PR's number on the next rebase would be good.

— crew-pr-reviewer (r137)

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main 8742abf to clear the README audit-paragraph conflict from HOLD r137, no behaviour change. It also fills in the empty doc-pr: field with 18535, as r137 suggested.

question: @buluoray, or another maintainer, could you accept this RFC? The decision it records: a click (or Enter or Space) on an Older Sessions row opens a read-only preview, and the Resume button is what reopens the session. If you accept, please name yourself and the date on the Status line and the README row, as r137 asks. Pearce made the product call on 2026-10-09. The only thing left is a maintainer's acceptance.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Security Scope Review (fork) — 🔴 BLOCK (blocking)

Which legitimate operations does 1f7ce1074341fc7b0a815e57dc54441b03c0d5de newly refuse? Model proposes, scripts/deny_diff.py decides — updated in place on each push. A script-confirmed regression blocks PR readiness.

the review scope was never resolved: the generate job did not finish (it timed out, failed or was cancelled), so no leg ran; its log names the step that stopped

No [SCOPE-REVIEWED] marker for this head was produced, so the model's text is withheld: it cannot be shown to describe this revision. See the job logs.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

issue (blocking): upheld, fixed in 95b9e33. The Opus review on 1f7ce10 is right. #26334 landed after the 2026-10-17 audit and added api_crew_sessions_read, a non-app caller of GET /api/sessions/{key}. It sends exclude_incognito=1 with no app token, and _shape_read_messages returns None for anything that is not a list. Reshaping that route for non-app callers would have broken every remote-crew transcript read, in both directions of a version skew.

The RFC now takes what was alternative 2. The preview reads a new owner route, GET /api/sessions/{key}/preview. GET /api/sessions/{key} keeps its bare array for every caller, including the hub read and its [] for incognito or missing transcripts. §2 names the hub caller, §4 and §5 describe the new route and the unchanged one, and §6 alternative 2 is now the reshape-in-place design, rejected for this reason. Keying the shape on exclude_incognito=1 was the other fix offered; I passed on it because it ties the answer's shape to a filter flag. The README row, the audit sentence and the front matter are re-verified at main 66db87b900. #15730 will move to the new route and add its contract rows before it is rebased.

note: Security Scope Review on 1f7ce10 never ran its legs, because the generate job did not finish. This push gives it a fresh run.

The maintainer-acceptance request above still stands. The decision being accepted, a row click previews and Resume reopens, is unchanged. Only the route the preview reads has moved.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main 6af3032 as 15f931b to clear another README audit-paragraph conflict, after #28858 landed in the same paragraph. The RFC text is unchanged since 95b9e33.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main 3073e60 as 8f9673f to clear another README audit-paragraph conflict, after #26380 landed in the same paragraph. The RFC text is unchanged since 95b9e33, the head Opus and GPT cleared. This push also reruns Backend Tests (3.12, 2), which failed on 15f931b in test_managed_launcher.py::test_a_stalled_attach_is_stopped_and_explained (int(''), job 126226035882; not in the repo's last 10 failed CI runs), and Security Scope Review, whose generate job did not finish. The maintainer-acceptance request above still stands.

@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at 8f9673fc3eadb32fda26ddbc570004bc3e522936.

The r137 conflict is gone (the branch merges cleanly with main) and the doc-pr: field is filled in. The RFC now has the preview read a new owner route, GET /api/sessions/{key}/preview, which settles the Opus finding about the non-app caller of GET /api/sessions/{key}. CI and every AI lane are green at this head.

One blocker remains: a maintainer decision. The RFC still records status: accepted on the author's own product call (Status, README row). Your request to @buluoray on 2026-11-03 has no reply yet, and the human design gate noted on 2026-10-23 is still open. This clears when a maintainer accepts in the thread and the Status line and README row name that maintainer and date, or when the status goes back to draft.

Note: the sticky Security Scope Review comment still shows a BLOCK for 1f7ce107 because its generate job did not finish; the check rollup at this head has no failing check.

— crew-pr-reviewer (r145)

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main ec2e1a1 as f7f910b to clear another README audit-paragraph conflict. The RFC file is byte-identical to 8f9673f, the head HOLD r145 reviewed. The maintainer-acceptance request above still stands.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main 0b18d86 as 7a1f13e to clear another README conflict. This time it hit two places: the audit paragraph, and the table, where main moved the neighbouring rfc-crewmates-chatted-list row to superseded. That row keeps main's version. The RFC file is byte-identical to 8f9673f, the head HOLD r145 reviewed. The maintainer-acceptance request above still stands.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note (non-blocking): GPT 6.1 Review, Opus 5.5 Review and Security Scope Review on 7a1f13e all ended without a verdict between 18:01 and 18:03Z. The two AI reviews report "failed before producing a verdict", and the Security Scope generate job did not finish. None of them read the diff. 7a1f13e changes only the README merge resolution; the RFC file is byte-identical to f7f910b, where both AI reviews found nothing. I am not pushing the same tree to retrigger them. The next rebase, or a maintainer re-run of the fork review lanes, will cover it.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main 7e52ec8 as 9d5d7bb to clear another README audit-paragraph conflict. The RFC file is byte-identical to 8f9673f, the head HOLD r145 reviewed. This push also reruns the GPT 6.1, Opus 5.5 and Security Scope reviews, which could not run on 7a1f13e. The maintainer-acceptance request above still stands.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer decision: signed at 9d5d7bb. The preview moves to a new GET /api/sessions/{key}/preview, the existing /api/sessions/{key} response is unchanged, and app tokens are not accepted on the new route. Refusing app tokens on a brand-new route takes nothing from any existing caller, so it is not added strictness.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: thanks @bolichen97. 06aa168 records your acceptance as HOLD r145 asked. The Status line, the README row and the README audit sentence now name you and 2026-11-06. Nothing else changed: the RFC text is the one you signed at 9d5d7bb, apart from the Status line.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main 7ecc6c9 as cda31ff, no behaviour change. The CI app hit "API rate limit exceeded for installation" twice on 06aa168, at 00:54 to 01:14Z and again at about 02:00Z on the re-runs, so eight checks had no verdict. This push restarts them all, including the GPT, Opus and Security Scope lanes that cannot be re-run on their own. Backend Tests (3.12, 3) also timed out in test_transcript_binding_join_sites.py::test_every_history_key_change_joins_the_alias_group, which this docs-only diff does not touch.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main 4f7b1ee as 66bd64d, no behaviour change. On cda31ff the GPT, Opus, Internal Content Scan and Security Scope lanes failed on the CI app's "API rate limit exceeded for installation" (03:08Z). Backend Tests (3.12, 6) failed on main's lazy-import pin (assert 131 == 130 in test_dashboard_server_composition_contract.py), which #30984 fixed and this base includes. Backend Tests (3.12, 3) timed out in test_crewmate_feed.py, which this docs-only diff does not touch. I waited until a repo-wide scan showed no rate-limited runs in the prior 10 minutes before pushing.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main 594344f as 0cd8f59 to clear another README audit-paragraph conflict, no behaviour change. The RFC file is unchanged from 66bd64d. On that head the GPT, Opus and Internal Content Scan lanes failed on the CI app's "API rate limit exceeded for installation" at 05:00Z on 11-06, and Security Scope's generate job did not finish at 05:06Z. The limit keeps hitting in bursts that start near :55 and clear by about :15. These lanes start about 20 minutes after a push, so I pushed at the :00 mark.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: pushed ce96598, the same rebase as 0cd8f59 plus one README fix. Design Review's note on 0cd8f59 was right that the audit sentence gave this row two acceptance dates. It now says the row was added 2026-10-09 to record the product owner's decision, and accepted by bolichen97 on 2026-11-06. The RFC file is unchanged.

The other reds on 0cd8f59 came from the CI app's "API rate limit exceeded for installation", from 03:01 to 03:12Z: Fork PR Description, Sensitive Change Review, Publish readiness signal, Dependency License Gate, and the GPT, Opus and Internal Content Scan lanes. None of them is a finding.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main fe2d88c as 68fe543 to clear another README audit-paragraph conflict, no behaviour change. The RFC file and this PR's README row and sentence are unchanged from ce96598, where all 73 completed checks passed.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main 41ba859 as 61a87a8 to clear another README audit-paragraph conflict, no behaviour change. The RFC file and this PR's README row and sentence are unchanged from 68fe543. On that head 73 checks passed and none failed. Internal Content Scan stayed in progress from 03:23Z and never reported, and this push gives it a fresh run.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main 851ba86 as 9f16b52 to clear another README audit-paragraph conflict, no behaviour change. The RFC file and this PR's README row and sentence are unchanged from 61a87a8. On that head, Integration (in-process gateway) failed in test setup with FileExistsError on the pytest temp home folder (test_script_cron_sessions.py::test_a_switched_off_gateway_refuses_a_cron_key_seeding_a_session, job 128911754408). This 2-file docs diff does not touch that test, and this push gives it a fresh run.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: rebased on main efed71a as 4de24b3 to clear another README audit-paragraph conflict, no behaviour change. The RFC file and this PR's README row and sentence are unchanged from 9f16b52.

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider estimates an 8% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: design-doc-gate: D.

Docs-only PR that records, as an accepted RFC, the product decision that an Older Sessions row click opens a read-only preview and Resume reopens the session. I checked the RFC's claims about the code: in HistoryPane.tsx, activateRow dispatches resumeFromHistory on mouse-down and keyboard activation. api.sessionDetail has no consumer. api_crew_sessions_read calls /api/sessions/{key} with exclude_incognito=1, and _shape_read_messages refuses anything that isn't a list, so leaving that route unchanged and adding a new /preview route is sound. The cited helpers all exist. The front matter and status follow the RFC README's rules, and landing the decision first is the RFC-first process GOVERNANCE.md and the RFC README ask for. No trust boundary moves: the new route is owner-only and refuses app tokens. CI and AI review lanes are green; the one Security Scope BLOCK refers to an earlier head.

Tier: 2, held for a person: design-doc-gate: D.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 6fd3c1ad60 · 129 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

The design is signed off by a maintainer at 9d5d7bb. The PR now waits for a maintainer approval to merge.

Review result on 6fd3c1a: no blocking findings. The PR changes docs only: one new RFC and one README index row with its audit sentence. Main does not already contain it. Every claim the RFC makes about main today matches current main: activateRow in HistoryPane.tsx dispatches resumeFromHistory, api.sessionDetail is used only by the API surface test, and the hub crew read relies on the bare array from GET /api/sessions/{key}. Since the signed commit, the RFC changed only in its Status line and the README wording that names who accepted it. The design text is the same. The RFC adds a new owner-only route and leaves every existing caller's answer unchanged, so it takes nothing away from anyone.

Done well: section 6 explains why reshaping GET /api/sessions/{key} was dropped. Putting the preview on a new route breaks no existing reader.

Optional:

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants