Repository navigation
fix(sidebar): Cmd/Ctrl-Shift-click on New opens the chat in a new active tab - #18545
Conversation
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that the cited ruling (#18544 comment 6231918549) says Cmd/Ctrl+Shift opens the active tab: the PR adds the decision record itself. What this change shipsInventory (7 items) — 7 justifiedIntent: let a person start a new chat in a new tab they can type into right away, without losing the tab they were on. This is an ADDITION, framed as a fix for #18544.
[FIRST-PRINCIPLES-REVIEWED] c20910d Description read[DESCRIPTION-READ] 01f4274b6e4879fd7818c16019873855b1e3315e6e441f425e815cc14b491dd9 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Before merge, confirm that the maintainer comment on #18544 says what the new [DESIGN-REVIEWED] c20910d Description read[DESCRIPTION-READ] fc271f491d4d5ddf2d85e569ddb28b2cd7e46b8ff81d13647c68c24dc4e9ff6e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Nobody has tried this in a real browser. Before merge, Ctrl/Cmd+Shift-click New and check that the new tab opens beside the old one, becomes active, and has the composer focused. [UX-REVIEWED] c20910d Description read[DESCRIPTION-READ] 05d935b39363b27973d0e8431e248cfc02dc3d622de17bc10d795bf4be27a7bb That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
240bd1a to
d92acbf
Compare
|
|
|
|
|
|
|
|
|
|
|
|
[operator: bolichen97] The maintainer ruling on the gesture is now on #18544: Cmd/Ctrl-click stays background everywhere; foreground goes on Cmd/Ctrl-Shift-click for the create controls, plus a short docs/decisions/ entry. That is the fallback you offered on 2026-10-13. The branch also conflicts with main again (labelled 2026-10-15), so it needs a rebase. Thanks for the careful work here. |
83993d9 to
a88dec7
Compare
|
chore (non-blocking): implemented the maintainer ruling from #18544 and rebased on main. New head is a88dec7. Cmd/Ctrl-click and middle-click on the create controls open a background tab again, as on a session row, and main's original tests for that are back unchanged. Cmd/Ctrl+Shift-click on the header New button, a folder "+" and an empty-folder row now opens the new chat in a new active tab. One helper, The rebase resolved conflicts with main's offline create handling in The round-5 First Principles and Design items on 83993d9 were about the reversed Cmd/Ctrl-click contract and the lost trackpad background gesture. This head restores both, so I will answer the lanes' items for a88dec7 once they re-review. |
|
question (non-blocking): could a maintainer approve the fork workflows for head a88dec7? PR Readiness has reported "5 workflow(s) awaiting maintainer approval; none has run yet" since the push at 12:31 UTC, so no CI or review lane has run on the Cmd/Ctrl+Shift-click change. While you are here, this bug fix still needs the |
|
|
|
|
|
…ive tab Cmd/Ctrl-click and middle-click on the create controls (header New, folder "+", empty-folder row) still open a background tab, as on a session row. Cmd/Ctrl-Shift-click now creates the chat with activate: false, adds a tab beside the current one and switches to it. If the user moved to another session while the create was in flight, the tab opens in the background. Records the maintainer ruling from kirodotdev#18544 in docs/decisions. Fixes kirodotdev#18544
a88dec7 to
c20910d
Compare
|
chore (non-blocking): rebased on main, no behaviour change. New head is c20910d. The rebase had no conflicts. It picks up main's later edit to |
|
|
|
iamwhatever
left a comment
There was a problem hiding this comment.
Approving at c20910d.
The change implements the maintainer ruling on #18544 (#18544 (comment)): Cmd/Ctrl-click stays a background tab everywhere, and Cmd/Ctrl+Shift-click on the create controls opens an active tab. createTabModeForClick (
KiroCrew/website/src/pages/chat-sidebar/chrome.tsx
Lines 27 to 31 in c20910d
KiroCrew/website/src/pages/chat-sidebar/create.ts
Lines 46 to 62 in c20910d
— crew-pr-reviewer (r111)
Problem / Motivation
Goal: Ctrl+Shift-click (Cmd+Shift-click on macOS) on a sidebar create control opens the new chat in a new tab and makes that tab active, keeping the tab the user was on.
The create controls are the header New button, a folder "+" button and an empty folder's "New chat in " row. Today a plain click replaces the current tab with the new chat, and Ctrl-click or middle-click opens it in a background tab. There is no one-step way to keep the old tab and start typing in the new chat.
Why it matters
People open a new chat to type into it. With a background tab they need a second click to reach it, and it is easy to start typing into the old session's composer by mistake.
Not a goal
What changed (motivation → approach → change)
The create controls passed one boolean,
inNewTab, which always opened the tab withbackground: true. That flag is nowNewTabModeinwebsite/src/pages/chat-sidebar/create.ts, with the values'foreground','background'orfalse. A new helper,createTabModeForClickinwebsite/src/pages/chat-sidebar/chrome.tsx, returns'background'for Cmd/Ctrl-click,'foreground'for Cmd/Ctrl+Shift-click andfalsefor anything else, including any click with Alt held. The five create click sites inSidebarHeader.tsx,folderBlocks.tsxandboardLane.tsxcall it. Middle-click passes'background'.Both tab modes still create with
activate: false. On success the key goes toonOpenSlotInNewTab(key, { background: mode === 'background' }). The foreground call adds the tab and then switches to it, the same path as the session row menu's "Open in new tab". Activating before the tab exists would make the tab strip replace the current tab, which is why the create itself does not activate. The foreground path then focuses the composer, as a plain create does. The create reads the session that was active when it started fromcreateSlot's fulfilled meta. If the user has moved to another session by the time it resolves, the tab still opens but in the background, so a slow create cannot pull them off the session they just picked.docs/decisions/2026-10-17-sidebar-create-controls-shift-opens-the-active-tab.mdrecords the ruling, citing the maintainer's comment on #18544 and its restatement on this PR.Backwards compatibility
Compatible and additive. Cmd/Ctrl+Shift-click on a create control was a plain create before and opens an active tab now. No other gesture changes, and no API, stored state or prop shape changes.
Tests
website/src/test/ChatSidebar.newChatInTab.test.tsx: Ctrl+Shift-click, and Cmd+Shift-click on macOS, hand the key to the tab opener withbackground: false, and the create itself leaves the active slot on the origin session. A Ctrl+Shift-click whose create resolves after the active session changed opens withbackground: true. Ctrl+Shift+Alt-click is a plain create. The existing Ctrl-click and middle-click tests still assertbackground: true.website/src/test/ChatSidebar.folderCreateInTab.test.tsx: the same foreground and moved-session cases for the folder "+", Cmd+Shift-click on macOS, the empty-folder row, and a Ctrl+Shift-click with no tab strip staying a plain create.website/src/test/ChatSidebar.boardFolderCreateInTab.test.tsx: Ctrl+Shift-click on the board column's folder "+" and empty-folder row opens a foreground tab, and the column drop still runs.website/src/test/ChatPage.sessionTabs.test.tsxalready covers a foregroundopenSlotInNewTabadding the tab and activating the session.The 129 ChatSidebar and chat-sidebar test files (1,579 tests),
tscand ESLint on the changed files pass locally.scripts/check_decisions_history.pyagainstorigin/mainpasses.Manual verification
Not run in a browser. The foreground path is the existing
openSlotInNewTabcode that the row menu's "Open in new tab" already uses, and the unit tests pin the argument each gesture passes to it.Screenshots / video
Why no screenshot: no component, layout or style changes; Ctrl+Shift-click calls the existing foreground open-in-tab path, which renders the same tab strip as the row menu's "Open in new tab".
Related Issues
Fixes #18544
Pattern harvest
Not generalizable: this is a product decision about which gesture means foreground on a create control, not a code defect class.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)