Skip to content

fix(sidebar): Cmd/Ctrl-Shift-click on New opens the chat in a new active tab - #18545

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/ctrl-click-new-session-tab
Oct 19, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/ctrl-click-new-session-tab

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Ctrl+Shift-click (Cmd+Shift-click on macOS) on a sidebar create control opens the new chat in a new tab and makes that tab active, keeping the tab the user was on.

The create controls are the header New button, a folder "+" button and an empty folder's "New chat in " row. Today a plain click replaces the current tab with the new chat, and Ctrl-click or middle-click opens it in a background tab. There is no one-step way to keep the old tab and start typing in the new chat.

Why it matters

People open a new chat to type into it. With a background tab they need a second click to reach it, and it is easy to start typing into the old session's composer by mistake.

Not a goal

What changed (motivation → approach → change)

The create controls passed one boolean, inNewTab, which always opened the tab with background: true. That flag is now NewTabMode in website/src/pages/chat-sidebar/create.ts, with the values 'foreground', 'background' or false. A new helper, createTabModeForClick in website/src/pages/chat-sidebar/chrome.tsx, returns 'background' for Cmd/Ctrl-click, 'foreground' for Cmd/Ctrl+Shift-click and false for anything else, including any click with Alt held. The five create click sites in SidebarHeader.tsx, folderBlocks.tsx and boardLane.tsx call it. Middle-click passes 'background'.

Both tab modes still create with activate: false. On success the key goes to onOpenSlotInNewTab(key, { background: mode === 'background' }). The foreground call adds the tab and then switches to it, the same path as the session row menu's "Open in new tab". Activating before the tab exists would make the tab strip replace the current tab, which is why the create itself does not activate. The foreground path then focuses the composer, as a plain create does. The create reads the session that was active when it started from createSlot's fulfilled meta. If the user has moved to another session by the time it resolves, the tab still opens but in the background, so a slow create cannot pull them off the session they just picked.

docs/decisions/2026-10-17-sidebar-create-controls-shift-opens-the-active-tab.md records the ruling, citing the maintainer's comment on #18544 and its restatement on this PR.

Backwards compatibility

Compatible and additive. Cmd/Ctrl+Shift-click on a create control was a plain create before and opens an active tab now. No other gesture changes, and no API, stored state or prop shape changes.

Tests

  • website/src/test/ChatSidebar.newChatInTab.test.tsx: Ctrl+Shift-click, and Cmd+Shift-click on macOS, hand the key to the tab opener with background: false, and the create itself leaves the active slot on the origin session. A Ctrl+Shift-click whose create resolves after the active session changed opens with background: true. Ctrl+Shift+Alt-click is a plain create. The existing Ctrl-click and middle-click tests still assert background: true.
  • website/src/test/ChatSidebar.folderCreateInTab.test.tsx: the same foreground and moved-session cases for the folder "+", Cmd+Shift-click on macOS, the empty-folder row, and a Ctrl+Shift-click with no tab strip staying a plain create.
  • website/src/test/ChatSidebar.boardFolderCreateInTab.test.tsx: Ctrl+Shift-click on the board column's folder "+" and empty-folder row opens a foreground tab, and the column drop still runs.
  • website/src/test/ChatPage.sessionTabs.test.tsx already covers a foreground openSlotInNewTab adding the tab and activating the session.

The 129 ChatSidebar and chat-sidebar test files (1,579 tests), tsc and ESLint on the changed files pass locally. scripts/check_decisions_history.py against origin/main passes.

Manual verification

Not run in a browser. The foreground path is the existing openSlotInNewTab code that the row menu's "Open in new tab" already uses, and the unit tests pin the argument each gesture passes to it.

Screenshots / video

Why no screenshot: no component, layout or style changes; Ctrl+Shift-click calls the existing foreground open-in-tab path, which renders the same tab strip as the row menu's "Open in new tab".

Related Issues

Fixes #18544

Pattern harvest

Not generalizable: this is a product decision about which gesture means foreground on a create control, not a code defect class.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@Pearcekieser
Pearcekieser requested review from a team and KiroCrewCaptain as code owners October 9, 2026 17:45
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of c20910d57458ee44269db24740b0050ae8b755c6 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check that the cited ruling (#18544 comment 6231918549) says Cmd/Ctrl+Shift opens the active tab: the PR adds the decision record itself.

What this change ships

Inventory (7 items) — 7 justified

Intent: let a person start a new chat in a new tab they can type into right away, without losing the tab they were on. This is an ADDITION, framed as a fix for #18544.

  1. Cmd/Ctrl+Shift-click on the header New button opens the new chat in an active new tab — justified
  2. Cmd/Ctrl+Shift-click on a folder "+" (list and board views) does the same — justified
  3. Cmd/Ctrl+Shift-click on an empty folder's "New chat in " row does the same — justified
  4. A foreground create that resolves after the user switched sessions opens in a background tab instead — justified
  5. The composer gets focus after a foreground tab open — justified
  6. Holding Alt with Cmd/Ctrl+Shift gives a plain create — justified
  7. New docs/decisions entry and README row recording the gesture ruling — justified

[FIRST-PRINCIPLES-REVIEWED] c20910d

Description read

[DESCRIPTION-READ] 01f4274b6e4879fd7818c16019873855b1e3315e6e441f425e815cc14b491dd9

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of c20910d57458ee44269db24740b0050ae8b755c6 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Before merge, confirm that the maintainer comment on #18544 says what the new docs/decisions/ entry, written "Decided by" them, records.

[DESIGN-REVIEWED] c20910d

Description read

[DESCRIPTION-READ] fc271f491d4d5ddf2d85e569ddb28b2cd7e46b8ff81d13647c68c24dc4e9ff6e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of c20910d57458ee44269db24740b0050ae8b755c6 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Nobody has tried this in a real browser. Before merge, Ctrl/Cmd+Shift-click New and check that the new tab opens beside the old one, becomes active, and has the composer focused.

[UX-REVIEWED] c20910d

Description read

[DESCRIPTION-READ] 05d935b39363b27973d0e8431e248cfc02dc3d622de17bc10d795bf4be27a7bb

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed c20910d57458ee44269db24740b0050ae8b755c6 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c20910d

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed c20910d57458ee44269db24740b0050ae8b755c6 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] c20910d

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 9, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/ctrl-click-new-session-tab branch from 240bd1a to d92acbf Compare October 9, 2026 21:15
@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • create.ts:208 foreground open after the user moved to another session

fixed in d92acbf: the create mutation's onMutate records the active slot at click time.
settledTabMode downgrades a foreground open to a background one when the active slot changed before the create resolved, so switchSlot and focusComposer do not run.
The same path covers the header New button and the folder create buttons.
New tests in ChatSidebar.newChatInTab.test.tsx and ChatSidebar.folderCreateInTab.test.tsx fail on 240bd1a and pass on d92acbf.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 9, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • question: one modifier gives two results in the same sidebar

needs-a-decision: Pearce, who filed #18544, chose to keep Cmd/Ctrl-click on New opening an active tab.
New creates a session that does not exist yet, so it follows the browser new-tab button and Ctrl+T, which open an active tab.
A session row points at an existing session, so Cmd/Ctrl-click there keeps the background-tab rule from #10574.
Middle-click on New still opens a background tab, so the #10574 gesture keeps a path.
A maintainer needs to confirm the reversal of #10574 for create controls.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • question: clears with maintainer confirmation plus a docs/decisions entry

needs-a-decision: no docs/decisions/ entry exists for either gesture today.
Once a maintainer confirms the split on #18544, I will add an entry that says Cmd/Ctrl-click on a create control opens an active tab and on a session row opens a background tab, with middle-click as background everywhere.
I have not written it before sign-off so it does not record a decision nobody has made.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • question: the New tooltip does not mention the Cmd/Ctrl-click gesture

rebutted: session rows have no gesture hint either, so a hint on New alone would document one control and leave the other undocumented.
A sidebar-wide hint touches every tooltip string and every locale file, which is outside a bug fix for #18544.
If a maintainer wants it, it fits a separate change that covers rows and create controls together.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

needs-a-decision: Pearce, who filed #18544, chose to keep Cmd/Ctrl-click on New opening an active tab.
New creates a session that does not exist yet, so it follows the browser new-tab button and Ctrl+T, which open an active tab.
A session row points at an existing session, so Cmd/Ctrl-click there keeps the background-tab rule from #10574.
Middle-click on New still opens a background tab, so the #10574 gesture keeps a path.
A maintainer needs to confirm the reversal of #10574 for create controls.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • question: recorded gesture decision reversed without maintainer sign-off

needs-a-decision: Pearce, who filed #18544, chose to keep Cmd/Ctrl-click on New opening an active tab.
New creates a session that does not exist yet, so it follows the browser new-tab button and Ctrl+T, which open an active tab.
A session row points at an existing session, so Cmd/Ctrl-click there keeps the background-tab rule from #10574.
Middle-click on New still opens a background tab, so the #10574 gesture keeps a path.
A maintainer needs to confirm the reversal of #10574 for create controls.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • question: the foreground fallback is silent

rebutted: the fallback runs only when the user picked another session between the click and the create resolving.
Switching them back at that point would take them away from the session they chose, which is the bug the round-1 Opus finding (span 38f88e62a3b5) reported.
The new tab still appears in the tab strip, so the result is visible, and one click opens it.
Tests in ChatSidebar.newChatInTab.test.tsx and ChatSidebar.folderCreateInTab.test.tsx pin this path.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

needs-a-decision: Pearce, who filed #18544, chose to keep Cmd/Ctrl-click on New opening an active tab.
New creates a session that does not exist yet, so it follows the browser new-tab button and Ctrl+T, which open an active tab.
A session row points at an existing session, so Cmd/Ctrl-click there keeps the background-tab rule from #10574.
Middle-click on New still opens a background tab, so the #10574 gesture keeps a path.
A maintainer needs to confirm the reversal of #10574 for create controls.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • question: one modifier, two meanings in the same sidebar

needs-a-decision: Pearce, who filed #18544, chose to keep Cmd/Ctrl-click on New opening an active tab.
New creates a session that does not exist yet, so it follows the browser new-tab button and Ctrl+T, which open an active tab.
A session row points at an existing session, so Cmd/Ctrl-click there keeps the background-tab rule from #10574.
Middle-click on New still opens a background tab, so the #10574 gesture keeps a path.
A maintainer needs to confirm the reversal of #10574 for create controls.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • question: create controls open foreground, session rows open background

needs-a-decision: Pearce, who filed #18544, chose to keep Cmd/Ctrl-click on New opening an active tab.
New creates a session that does not exist yet, so it follows the browser new-tab button and Ctrl+T, which open an active tab.
A session row points at an existing session, so Cmd/Ctrl-click there keeps the background-tab rule from #10574.
Middle-click on New still opens a background tab, so the #10574 gesture keeps a path.
A maintainer needs to confirm the reversal of #10574 for create controls.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • question: no docs/decisions entry for the gesture

needs-a-decision: no docs/decisions/ entry exists for either gesture today.
Once a maintainer confirms the split on #18544, I will add an entry that says Cmd/Ctrl-click on a create control opens an active tab and on a session row opens a background tab, with middle-click as background everywhere.
I have not written it before sign-off so it does not record a decision nobody has made.

@bolichen97

Copy link
Copy Markdown
Contributor

[operator: bolichen97] The maintainer ruling on the gesture is now on #18544: Cmd/Ctrl-click stays background everywhere; foreground goes on Cmd/Ctrl-Shift-click for the create controls, plus a short docs/decisions/ entry. That is the fallback you offered on 2026-10-13. The branch also conflicts with main again (labelled 2026-10-15), so it needs a rebase. Thanks for the careful work here.

@Pearcekieser Pearcekieser changed the title fix(sidebar): Cmd/Ctrl-click on New opens the chat in a new active tab fix(sidebar): Cmd/Ctrl-Shift-click on New opens the chat in a new active tab Oct 17, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/ctrl-click-new-session-tab branch from 83993d9 to a88dec7 Compare October 17, 2026 12:32
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

chore (non-blocking): implemented the maintainer ruling from #18544 and rebased on main. New head is a88dec7.

Cmd/Ctrl-click and middle-click on the create controls open a background tab again, as on a session row, and main's original tests for that are back unchanged. Cmd/Ctrl+Shift-click on the header New button, a folder "+" and an empty-folder row now opens the new chat in a new active tab. One helper, createTabModeForClick in website/src/pages/chat-sidebar/chrome.tsx, picks the mode for all five click sites. The moved-session fallback to a background tab is kept. docs/decisions/2026-10-17-sidebar-create-controls-shift-opens-the-active-tab.md records the ruling and cites @bolichen97's comment.

The rebase resolved conflicts with main's offline create handling in SidebarHeader.tsx, boardLane.tsx, folderBlocks.tsx and create.ts, keeping main's offline refusal. The 129 ChatSidebar and chat-sidebar test files (1,579 tests), tsc, ESLint and check_decisions_history.py pass locally.

The round-5 First Principles and Design items on 83993d9 were about the reversed Cmd/Ctrl-click contract and the lost trackpad background gesture. This head restores both, so I will answer the lanes' items for a88dec7 once they re-review.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 17, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

question (non-blocking): could a maintainer approve the fork workflows for head a88dec7? PR Readiness has reported "5 workflow(s) awaiting maintainer approval; none has run yet" since the push at 12:31 UTC, so no CI or review lane has run on the Cmd/Ctrl+Shift-click change. While you are here, this bug fix still needs the bug label on #18544 and this PR. The fork account cannot add labels.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • No visible way to learn the gesture

outcome: rebutted
No sidebar tab gesture has an on-screen hint today: session rows' Cmd/Ctrl-click and middle-click carry none, and neither does Cmd/Ctrl-click on New.
The maintainer ruling on #18544 scopes this PR to the gesture itself. Adding hints means new i18n strings in every locale for every tab gesture, which is its own change.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • The switch to the new tab is never verified on screen

outcome: rebutted
The foreground open calls the existing onOpenSlotInNewTab(key, { background: false }), the same call the row menu's "Open in new tab" already makes in the shipped product.
ChatPage.sessionTabs.test covers that call adding the tab and activating the session; the new sidebar tests pin that each create control passes background: false and that the create itself does not activate first.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Silent fallback to a background tab

outcome: rebutted
No change: the lane agrees the fallback is right and needs no notice. The tab still appears in the strip, and the fallback only fires when the user already moved to another session.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

outcome: rebutted
Checked: issue comment 6231918549 on #18544 is by @bolichen97, listed in MAINTAINERS.md as Bolin Chen, who restated it on this PR in comment 6231920572. The decision entry cites both.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

outcome: rebutted
#18544 is a bug report: there was no one-step way to start a new chat in an active tab without losing the current one. This PR fixes it in the shape the maintainer ruled, which happens to add a gesture rather than change one.
A maintainer may retitle it feat(sidebar) at merge if they prefer; the squash title is theirs to set.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 17, 2026
…ive tab

Cmd/Ctrl-click and middle-click on the create controls (header New, folder
"+", empty-folder row) still open a background tab, as on a session row.
Cmd/Ctrl-Shift-click now creates the chat with activate: false, adds a tab
beside the current one and switches to it. If the user moved to another
session while the create was in flight, the tab opens in the background.

Records the maintainer ruling from kirodotdev#18544 in docs/decisions.

Fixes kirodotdev#18544
@Pearcekieser
Pearcekieser force-pushed the fix/ctrl-click-new-session-tab branch from a88dec7 to c20910d Compare October 17, 2026 20:47
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

chore (non-blocking): rebased on main, no behaviour change. New head is c20910d. The rebase had no conflicts. It picks up main's later edit to website/src/pages/chat-sidebar/boardLane.tsx, which this PR also touches. The 131 ChatSidebar and chat-sidebar test files (1,589 tests) and tsc pass locally. The round-6 red on a88dec7 was Backend Tests (3.12, 1) in test/test_platform_compat_process_identity.py::TestProcessArgvMatchesExact::test_argv_fingerprint_is_stable_and_tells_processes_apart. That is a backend process-identity test, and this PR changes only frontend code and docs.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 17, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

outcome: rebutted
Checked: #18544 comment 6231918549 by @bolichen97 (Bolin Chen, MAINTAINERS.md) says Cmd/Ctrl-click opens a background tab everywhere, Cmd/Ctrl-Shift-click on New, folder "+" and empty-folder rows opens an active tab, and asks for a docs/decisions entry. The entry records exactly that and cites it.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

outcome: rebutted
Checked: point 2 of #18544 comment 6231918549 reads "Foreground goes on Cmd/Ctrl-Shift-click for the create controls named in this issue", and point 5 asks this PR to add the decision entry. Bolin restated it on this PR in comment 6231920572.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

outcome: rebutted
No browser run here. The foreground open is the existing onOpenSlotInNewTab(key, { background: false }) call that the row menu's "Open in new tab" ships today; ChatPage.sessionTabs.test covers it adding the tab beside the current one and activating it.
The new sidebar tests pin that each create control passes background: false and that the create itself does not activate. A maintainer can Cmd/Ctrl+Shift-click New before merge if they want a live check.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 18, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at c20910d.

The change implements the maintainer ruling on #18544 (#18544 (comment)): Cmd/Ctrl-click stays a background tab everywhere, and Cmd/Ctrl+Shift-click on the create controls opens an active tab. createTabModeForClick (

export function createTabModeForClick(e: React.MouseEvent): 'foreground' | 'background' | false {
if (isOpenInTabModifierClick(e)) return 'background'
const tabModifier = IS_MAC ? e.metaKey && !e.ctrlKey : e.ctrlKey && !e.metaKey
return tabModifier && e.shiftKey && !e.altKey ? 'foreground' : false
}
) maps the gestures. Creates still run with activate: false, so the current tab is kept, and settledTabMode (
function settledTabMode(store: { getState: () => RootState }, inNewTab: NewTabMode, originSlot: string | null): NewTabMode {
if (inNewTab !== 'foreground') return inNewTab
return (store.getState().chat?.activeSlot ?? null) === originSlot ? 'foreground' : 'background'
}
/**
* Dispatch createSlot and return the new slot with the session that was
* active when the create started. createSlot already records that origin in
* its fulfilled meta, which `.unwrap()` would drop. A rejection throws exactly
* as `.unwrap()` does, so the callers' onError paths are unchanged.
*/
async function createSlotWithOrigin(dispatch: AppDispatch, args: Parameters<typeof createSlot>[0]): Promise<{ slot: Slot; originSlot: string | null }> {
const action = await dispatch(createSlot(args))
if (createSlot.fulfilled.match(action)) return { slot: action.payload, originSlot: action.meta.originActiveSlot ?? null }
unwrapResult(action)
throw new Error('createSlot settled without fulfilling or rejecting')
}
) falls back to a background tab if the user moved while the create was in flight. Tests pin each of these. The decision entry matches the ruling, every AI lane punchline has a reply, and PR Readiness is green. One Publish readiness signal run failed on a CI rate limit before the status was republished as success. I did not run this in a browser.

— crew-pr-reviewer (r111)

@iamwhatever
iamwhatever merged commit 9c98bf0 into kirodotdev:main Oct 19, 2026
100 of 101 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(sidebar): Cmd/Ctrl-click on New opens a background tab instead of an active one

3 participants