Skip to content

fix(crew): remove ghost-face icon picker UI, default new mates to SVG icon - #18618

Closed
dodgeblaster wants to merge 2 commits into
mainfrom
fix/crewmate-remove-ghost-icon-ui
Closed

dodgeblaster wants to merge 2 commits into
mainfrom
fix/crewmate-remove-ghost-icon-ui

Conversation

@dodgeblaster

@dodgeblaster dodgeblaster commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A new or edited crewmate can no longer pick or set a hand-built ghost face; it is built from an SVG icon pose and a colour instead.

The avatar builder shipped two ways to define a crewmate's icon: the game-style
ghost "捏脸" trait builder (plus its per-state reaction layer), and the Icon tier
— one of eleven shipped SVG poses over a solid background. The Icon tier was
introduced as the primary creator and the ghost builder was left in place; the
PR that added it deliberately deferred hiding the ghost tabs to a follow-up.
This is that follow-up.

Why it matters

The ghost "捏脸" builder is a large, fiddly surface (seven trait axes, a reaction
layer) kept only for the few crews that already wear a ghost face. Leaving it in
the create flow invites every new crewmate down a path the product no longer
wants as the default, and keeps a second, competing avatar model in front of
users who should land on the simple SVG-pose picker.

Not a goal

  • Removing or changing the ghost-face data model, types, API/backend fields, or
    rendering. Crewmates already configured with a ghost face keep rendering
    exactly as before; stored configs are not migrated or rewritten.
  • Removing the shipped ghost pose/trait assets that rendering still needs.
  • Touching the Picture (uploaded image) or Library (appearance pack) tiers.

What changed (motivation → approach → change)

New crewmates should default to the SVG-pose Icon tier, and nobody should be
able to author a ghost face any more — but the thousands of crews already
wearing one must keep rendering untouched. The avatar builder is one shared
component used by both the create and the edit flow, so the whole change lands
in website/src/components/CrewAvatarBuilder.tsx.

The builder now offers three tiers — Icon, Picture, Library. The "Ghost face"
tab and its "Reactions" sub-tab (reactions only ever decorated the ghost tier)
are gone, and with them the trait grid, the reaction panes and their now-unused
helpers and props. A crew with no override, and a crew that stored a ghost face,
both open on the Icon tier; a brand-new crew's Apply commits the name-seeded SVG
pose and a colour. Editing a stored ghost face is the careful case: the picker
opens on the Icon/colour controls; the preview shows that crew's STORED ghost
(via CrewAvatar) with a one-line note that the current face is kept until a
pose or colour is picked, and an untouched Apply hands the stored ghost record
straight back — traits and reactions intact — so only an active pose or colour
pick replaces it. The editor's existing save-path carry logic (which
preserves a stored record's reactions through an unrelated save) is left in
place, which is what keeps requirement 3 true.

The removed authoring copy took 78 now-dead components.avatarBuilder.* keys
with it, pruned from every locale catalog (website/src/i18n/locales/en.manual.json
and its sibling locales) and the website/src/i18n/en.context.json sidecar, so
the dead-key ratchet stays at its baseline.

The product decision (Icon tier as the primary creator; ghost builder retained
only for existing crews) was recorded by the icon-avatar-tier PR, which states
hiding the ghost builder tabs was "deliberately left to a later PR".

Backwards compatibility

Compatible: no stored record changes shape or meaning; the ghost kind, its
readers (ghostTraitsFrom, motionsFrom, soundsFrom) and the renderer
(CrewAvatar, kiroGhostAvatar) are untouched, so every existing ghost crew
renders identically.

Removes nothing from the data layer: only an authoring UI is withdrawn, no
stored data, record kind, API field, or rendering path. The removed builder
props (retiredCue, savedPack, savedReactions) were display-only inputs to
the deleted panes; the two editor call sites — website/src/components/crew/CrewEditorDialog.tsx
and website/src/pages/KiroCrewAgentsPage.tsx — drop them and keep their own
save-path state, which never read them.

Tests

  • CrewAvatarBuilder.test.tsx — the Ghost face and Reactions tabs do not render
    (even when editing a stored ghost crew); the Icon tier is the default and a
    fresh crew's Apply yields {kind:'icon', pose, bg}; editing a stored ghost
    opens on Icon, an untouched Apply returns the ghost verbatim, and a pose/colour
    pick replaces it; a stored ghost still renders via the shared CrewAvatar.
  • CrewAvatarBuilder.library.test.tsx — retargeted the ghost-dependent tier
    tests to the Icon tier; dropped the reactions-pane note tests.
  • CrewRoster.test.tsx — the editor Apply→Save plumbing tests now drive the Icon
    tier; the reaction-carry-through-an-unrelated-save tests are unchanged and
    still green (requirement 3).
  • Deleted CrewAvatarBuilder.reactions.test.tsx — the reactions-authoring pane
    it covered no longer exists.
  • deadKeys / contextSidecar i18n ratchets stay green after the key pruning.

Manual verification

N/A — unit coverage sufficient. The builder's tiers, panes and Apply payloads
are asserted by the rendered component tests above; no integration or external
path is involved.

Screenshots / video

Create new mate is left untouched:
Screenshot 2026-10-14 at 9 09 21 AM

But when u make a new mate, the icon is autoselected rather than the ghostface:
Screenshot 2026-10-14 at 9 17 13 AM

And editing no longer shows the ghostface as an option:
Screenshot 2026-10-14 at 9 17 35 AM

Related Issues

Closes #18616

Pattern harvest

Not generalizable: this removes one specific authoring UI (the ghost "捏脸"
tier) that a prior PR already decided to retire; it is a product-shape change,
not a recurring defect class, so there is no rule, lint, or review-prompt to
harvest from it.

Checklist

  • At most two commits with a Conventional Commits title

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — 🔴 BLOCK (blocking)

Design-level review of 14316ab1b82a70af22c10eb2e3acf89f92ab4418 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: BLOCK

cannot evaluate: missing screenshot or recording of the reshaped avatar builder (three-tier Icon default, stored-ghost edit preview with keep-note).

Blockers

Reshaped user-visible surface with no rendered evidence of this revision
The diff rewrites website/src/components/CrewAvatarBuilder.tsx. It removes the "Ghost face" and "Reactions" tabs, makes Icon the opening tier, and adds a new edit state for stored ghosts: the preview shows the stored ghost through CrewAvatar, with "a one-line note that the current face is kept until a pose or colour is picked". The description says "Screenshots / video: Not captured", and the evidence file lists 0 attachments, 0 committed images and 0 transport failures. The new tier bar and the ghost-preview-plus-Icon-controls layout are the design questions here, and they can't be judged without seeing them:

  • Does the note read clearly next to an Icon pose that isn't applied yet?
  • Does the preview match what Apply will commit?

Component tests check that elements exist, not how they look.

Fix: from any authenticated dashboard session (a local kirocrew gateway with an isolated KIROCREW_HOME works), capture the picker in two states: (a) a new crewmate, (b) editing a crew that has a stored ghost face. Attach both to the description, or commit them under temp-screenshots/.

Clears when: the description carries github.com/user-attachments images (or committed temp-screenshots/ media) of the builder for a new crewmate and for an existing ghost-face crewmate at HEAD 14316ab1b

[DESIGN-REVIEWED] 14316ab

Description read

[DESCRIPTION-READ] 64745c47c6547725fcfc1386677e675de1f1dc23ed2a7d96e4a44bbe258272d8

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🔴 BLOCK

UX-level review of 14316ab1b82a70af22c10eb2e3acf89f92ab4418 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: BLOCK

cannot evaluate: missing screenshots of the avatar picker. The PR attaches no image, so the blind read was not performed.

Evidence gaps

  • The avatar builder's tier strip, now Icon, Picture and Library, with Ghost face and Reactions removed. No screenshot shows it. Close it with a still of CrewAvatarBuilder opened from the create flow, showing the strip and the Icon pane it opens on by default.
  • Editing a crewmate that has a stored ghost face. No screenshot shows this state: the preview of the stored ghost, the Icon and colour controls, and the new note "Current face is kept until you pick a pose or colour." (components.avatarBuilder.icon_keeps_current). Close it with a still of the editor in CrewEditorDialog or KiroCrewAgentsPage opened on such a crewmate.
  • The same edit after a pose or colour pick. No screenshot shows the preview switching to the SVG pose and the note going away. Close it with a still taken after the pick.

The description says screenshots weren't captured because the preview pod has no session. Passing unit tests don't count as screenshot evidence. Someone with a dashboard session needs to attach these stills to the PR description and re-run this workflow.

Watch

  • The new note is wordy and doesn't say what Apply will do. "Current face is kept until you pick a pose or colour." starts with the subject rather than the outcome, and it names neither the action that keeps the face nor the one that replaces it. A user editing a ghost crewmate may not realise that picking a pose replaces the stored ghost. This is low severity: it only shows up when editing an existing ghost crewmate, and it is friction rather than a failed task.

Suggestions

  • Change icon_keeps_current to "Keeps the current ghost face. Pick a pose or colour to replace it."

[UX-REVIEWED] 14316ab

Description read

[DESCRIPTION-READ] 33afb4c44ac038c833bc0865d0542877f9649ade9ac3cf1ac77fe1c89a66280f

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🔴 BLOCK

Premise-level review of 14316ab1b82a70af22c10eb2e3acf89f92ab4418 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: BLOCK

product-shape change without accepted RFC: the change removes ghost-face authoring and per-state reaction authoring, and no non-draft RFC on base covers either.

Not justified as shipped

  • Item 1 — product shape, no recorded decision: the diff deletes the key: 'face' "Ghost face" tier. The only record cited is a PR, not an RFC: "recorded by the icon-avatar-tier PR".
    Clears when: an RFC covering the retirement of ghost-face authoring is merged with a non-draft status on base (then push or rebase), or a maintainer posts /ai-review override first-principles 14316ab1b82a70af22c10eb2e3acf89f92ab4418: <decision>.
  • Item 2 — product shape, outside the Goal: the Goal names only "pick or set a hand-built ghost face". The diff also removes the only place to set per-state motions and sounds (mode_reactions, stateRow).
    Clears when: the same record covers removing reaction authoring, or a human amends the Goal.
  • Item 6 — undeclared: the warning on picture and pack crews, "Saved sounds on this crew ({{states}}) no longer play", is removed. The description never mentions it.

What this change ships

Inventory (8 items) — 5 justified

Intent: stop people from building ghost faces and make new crewmates start from an SVG icon pose. This is a FIX framed over an ADDITION-sized removal.

  1. The Ghost face tab is removed from the avatar builder — product shape, no RFC
  2. The Reactions tab (per-state motion and sound) is removed — product shape, out of goal
  3. Crews with a stored ghost face open on Icon, showing that ghost and a "kept" note — justified
  4. An untouched Apply on a ghost crew keeps the stored record as it was — justified
  5. Reset lands on the Icon tab and saves the default — justified
  6. The saved-sound warning on picture and pack crews is removed — undeclared
  7. The "no Reactions tab here" note is removed — justified
  8. 78 unused i18n keys are pruned and one is added in every locale — justified

Blockers

  • product-shape change without accepted RFC: removing ghost-face and reaction authoring
    The diff deletes the 'face' and 'reactions' tab entries in CrewAvatarBuilder.tsx. In rfc-status.txt I found no avatar RFC; rfc-crewmates-launch.md mentions avatars but does not cover retiring either authoring surface. docs/decisions/ also has no entry for "avatar" or "ghost".
    Clears when: an RFC covering this shape is merged with a non-draft status on base (then push or rebase), or a maintainer posts /ai-review override first-principles 14316ab1b82a70af22c10eb2e3acf89f92ab4418: <decision>.

[FIRST-PRINCIPLES-REVIEWED] 14316ab

Description read

[DESCRIPTION-READ] f11c6ce6ce4e31df43c99ed4a037a8ecbdd5d3af7dcd43e13d314260d1391d95

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 14316ab1b82a70af22c10eb2e3acf89f92ab4418 — this comment is updated in place on each push.

Review details

Nothing blocks this merge. There are two advisory findings.

FINDING — website/src/components/CrewAvatarBuilder.tsx:578 — If the crew has a saved picture, the user clicks Reset, then opens the Picture tab, the pane still shows the stored picture through value?.kind === 'image' ? (<CrewAvatar … avatar={value}. But buildResult returns early with if (reset) return null, so Apply saves a reset that the preview doesn't show. Before this change, the same steps kept the picture. → Fix: in the tier onChange at :412, clear reset when switching to the picture/pack tier. Or, while reset is true, hide the stored-image preview.

FINDING — docs/system-specs/modules/learn-cron-dashboard.md:3532 — Two docs still describe what this PR removes. The spec says reactions are "authored on the builder's Reactions tab, which is offered on the ghost tier". The feature-map Crewmates row (docs/feature-map/README.md:153) says "The builder also still offers hand-picked ghost traits", and also describes the Reactions tab and the retiredCueFrom lost-cue notice. AGENTS.md requires updating the owning spec in the same commit. → Fix: in both docs, say ghost faces and reactions can no longer be authored (stored ghosts still render and survive an Apply where nothing was touched), and that Reset now returns null on every tier.

[OPUS-REVIEWED] 14316ab

Verdict parsed from the review's SHA-scoped output markers for commit 14316ab1b82a70af22c10eb2e3acf89f92ab4418.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 14316ab1b82a70af22c10eb2e3acf89f92ab4418: <one-sentence reason>

@dodgeblaster
dodgeblaster force-pushed the fix/crewmate-remove-ghost-icon-ui branch from 4b6f445 to 68264c9 Compare October 9, 2026 21:57
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 14316ab1b82a70af22c10eb2e3acf89f92ab4418 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 14316ab

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 14316ab1b82a70af22c10eb2e3acf89f92ab4418: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 9, 2026
@dodgeblaster
dodgeblaster force-pushed the fix/crewmate-remove-ghost-icon-ui branch from 68264c9 to 07fa40d Compare October 9, 2026 22:40
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Rebased: main moved (aee520e -> 97fdb00) while CI ran; the earlier Frontend Tests shard reds were flaky/env-sensitive tests not in this diff (focusRingContrast.test.ts, notifMeta.codeScan.test.ts), confirmed passing on the rebased base. CI re-running on 07fa40d.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 9, 2026
@dodgeblaster
dodgeblaster force-pushed the fix/crewmate-remove-ghost-icon-ui branch from 07fa40d to 14316ab Compare October 9, 2026 22:56
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Addressed both advisory Opus 5.5 findings in 14316ab:

  • CrewAvatarBuilder.tsx Reset preview/save mismatch — the Icon preview now renders CrewAvatar seed={name} (no override) after a Reset, matching the name-derived default that Apply's null saves, instead of a seeded icon pose. Added a test ("shows the name-derived default preview after Reset — not a seeded icon pose").
  • bn.json icon_keeps_current typo — fixed "রখা" → "রাখা" (kept).

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 9, 2026
The ghost-face picker was removed from the editor, but the create door
(NewCrewmateDialog) still sent no avatar in its POST body, so a new mate
stored none and both the roster and editor fell back to the name-derived
ghost. Send a default ICON avatar on create -- a name-seeded pose over a
random background from the builder's own palette -- so new mates default
to an icon, not the ghost. Both stay re-pickable in the avatar builder.
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 14, 2026
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Superseded by #20392. This branch was ~900 commits behind main, which has since rebuilt the crewmate avatar create flow (#16232 icon tier as primary creator, #18805 single-card create). #20392 reimplements the intent cleanly on current main: new mates default to a name-seeded icon, and the Ghost face authoring tab is hidden for non-ghost crews (existing ghost mates keep rendering and editing).

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 14, 2026
@bolichen97
bolichen97 deleted the fix/crewmate-remove-ghost-icon-ui branch November 6, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ghost-face icon picker UI from crewmate create/edit; default new mates to SVG icon + colour

2 participants