Repository navigation
fix(crew): remove ghost-face icon picker UI, default new mates to SVG icon - #18618
dodgeblaster wants to merge 2 commits into
Conversation
Design Review (Opus 5.5) — 🔴 BLOCK (blocking)Design-level review of Design-Verdict: BLOCK cannot evaluate: missing screenshot or recording of the reshaped avatar builder (three-tier Icon default, stored-ghost edit preview with keep-note). BlockersReshaped user-visible surface with no rendered evidence of this revision
Component tests check that elements exist, not how they look. Fix: from any authenticated dashboard session (a local
[DESIGN-REVIEWED] 14316ab Description read[DESCRIPTION-READ] 64745c47c6547725fcfc1386677e675de1f1dc23ed2a7d96e4a44bbe258272d8 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK cannot evaluate: missing screenshots of the avatar picker. The PR attaches no image, so the blind read was not performed. Evidence gaps
The description says screenshots weren't captured because the preview pod has no session. Passing unit tests don't count as screenshot evidence. Someone with a dashboard session needs to attach these stills to the PR description and re-run this workflow. Watch
Suggestions
[UX-REVIEWED] 14316ab Description read[DESCRIPTION-READ] 33afb4c44ac038c833bc0865d0542877f9649ade9ac3cf1ac77fe1c89a66280f That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK product-shape change without accepted RFC: the change removes ghost-face authoring and per-state reaction authoring, and no non-draft RFC on base covers either. Not justified as shipped
What this change shipsInventory (8 items) — 5 justifiedIntent: stop people from building ghost faces and make new crewmates start from an SVG icon pose. This is a FIX framed over an ADDITION-sized removal.
Blockers
[FIRST-PRINCIPLES-REVIEWED] 14316ab Description read[DESCRIPTION-READ] f11c6ce6ce4e31df43c99ed4a037a8ecbdd5d3af7dcd43e13d314260d1391d95 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNothing blocks this merge. There are two advisory findings. FINDING — website/src/components/CrewAvatarBuilder.tsx:578 — If the crew has a saved picture, the user clicks Reset, then opens the Picture tab, the pane still shows the stored picture through FINDING — docs/system-specs/modules/learn-cron-dashboard.md:3532 — Two docs still describe what this PR removes. The spec says reactions are "authored on the builder's Reactions tab, which is offered on the ghost tier". The feature-map Crewmates row (docs/feature-map/README.md:153) says "The builder also still offers hand-picked ghost traits", and also describes the Reactions tab and the [OPUS-REVIEWED] 14316ab Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
4b6f445 to
68264c9
Compare
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
68264c9 to
07fa40d
Compare
07fa40d to
14316ab
Compare
|
Addressed both advisory Opus 5.5 findings in 14316ab:
|
The ghost-face picker was removed from the editor, but the create door (NewCrewmateDialog) still sent no avatar in its POST body, so a new mate stored none and both the roster and editor fell back to the name-derived ghost. Send a default ICON avatar on create -- a name-seeded pose over a random background from the builder's own palette -- so new mates default to an icon, not the ghost. Both stay re-pickable in the avatar builder.
|
Superseded by #20392. This branch was ~900 commits behind main, which has since rebuilt the crewmate avatar create flow (#16232 icon tier as primary creator, #18805 single-card create). #20392 reimplements the intent cleanly on current main: new mates default to a name-seeded icon, and the Ghost face authoring tab is hidden for non-ghost crews (existing ghost mates keep rendering and editing). |
Problem / Motivation
Goal: A new or edited crewmate can no longer pick or set a hand-built ghost face; it is built from an SVG icon pose and a colour instead.
The avatar builder shipped two ways to define a crewmate's icon: the game-style
ghost "捏脸" trait builder (plus its per-state reaction layer), and the Icon tier
— one of eleven shipped SVG poses over a solid background. The Icon tier was
introduced as the primary creator and the ghost builder was left in place; the
PR that added it deliberately deferred hiding the ghost tabs to a follow-up.
This is that follow-up.
Why it matters
The ghost "捏脸" builder is a large, fiddly surface (seven trait axes, a reaction
layer) kept only for the few crews that already wear a ghost face. Leaving it in
the create flow invites every new crewmate down a path the product no longer
wants as the default, and keeps a second, competing avatar model in front of
users who should land on the simple SVG-pose picker.
Not a goal
rendering. Crewmates already configured with a ghost face keep rendering
exactly as before; stored configs are not migrated or rewritten.
What changed (motivation → approach → change)
New crewmates should default to the SVG-pose Icon tier, and nobody should be
able to author a ghost face any more — but the thousands of crews already
wearing one must keep rendering untouched. The avatar builder is one shared
component used by both the create and the edit flow, so the whole change lands
in
website/src/components/CrewAvatarBuilder.tsx.The builder now offers three tiers — Icon, Picture, Library. The "Ghost face"
tab and its "Reactions" sub-tab (reactions only ever decorated the ghost tier)
are gone, and with them the trait grid, the reaction panes and their now-unused
helpers and props. A crew with no override, and a crew that stored a ghost face,
both open on the Icon tier; a brand-new crew's Apply commits the name-seeded SVG
pose and a colour. Editing a stored ghost face is the careful case: the picker
opens on the Icon/colour controls; the preview shows that crew's STORED ghost
(via
CrewAvatar) with a one-line note that the current face is kept until apose or colour is picked, and an untouched Apply hands the stored ghost record
straight back — traits and reactions intact — so only an active pose or colour
pick replaces it. The editor's existing save-path carry logic (which
preserves a stored record's reactions through an unrelated save) is left in
place, which is what keeps requirement 3 true.
The removed authoring copy took 78 now-dead
components.avatarBuilder.*keyswith it, pruned from every locale catalog (
website/src/i18n/locales/en.manual.jsonand its sibling locales) and the
website/src/i18n/en.context.jsonsidecar, sothe dead-key ratchet stays at its baseline.
The product decision (Icon tier as the primary creator; ghost builder retained
only for existing crews) was recorded by the icon-avatar-tier PR, which states
hiding the ghost builder tabs was "deliberately left to a later PR".
Backwards compatibility
Compatible: no stored record changes shape or meaning; the
ghostkind, itsreaders (
ghostTraitsFrom,motionsFrom,soundsFrom) and the renderer(
CrewAvatar,kiroGhostAvatar) are untouched, so every existing ghost crewrenders identically.
Removes nothing from the data layer: only an authoring UI is withdrawn, no
stored data, record kind, API field, or rendering path. The removed builder
props (
retiredCue,savedPack,savedReactions) were display-only inputs tothe deleted panes; the two editor call sites —
website/src/components/crew/CrewEditorDialog.tsxand
website/src/pages/KiroCrewAgentsPage.tsx— drop them and keep their ownsave-path state, which never read them.
Tests
CrewAvatarBuilder.test.tsx— the Ghost face and Reactions tabs do not render(even when editing a stored ghost crew); the Icon tier is the default and a
fresh crew's Apply yields
{kind:'icon', pose, bg}; editing a stored ghostopens on Icon, an untouched Apply returns the ghost verbatim, and a pose/colour
pick replaces it; a stored ghost still renders via the shared
CrewAvatar.CrewAvatarBuilder.library.test.tsx— retargeted the ghost-dependent tiertests to the Icon tier; dropped the reactions-pane note tests.
CrewRoster.test.tsx— the editor Apply→Save plumbing tests now drive the Icontier; the reaction-carry-through-an-unrelated-save tests are unchanged and
still green (requirement 3).
CrewAvatarBuilder.reactions.test.tsx— the reactions-authoring paneit covered no longer exists.
deadKeys/contextSidecari18n ratchets stay green after the key pruning.Manual verification
N/A — unit coverage sufficient. The builder's tiers, panes and Apply payloads
are asserted by the rendered component tests above; no integration or external
path is involved.
Screenshots / video
Create new mate is left untouched:

But when u make a new mate, the icon is autoselected rather than the ghostface:

And editing no longer shows the ghostface as an option:

Related Issues
Closes #18616
Pattern harvest
Not generalizable: this removes one specific authoring UI (the ghost "捏脸"
tier) that a prior PR already decided to retire; it is a product-shape change,
not a recurring defect class, so there is no rule, lint, or review-prompt to
harvest from it.
Checklist