Repository navigation
docs(skills): a Motion section in the dashboard-template skill - #18666
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] ec57719 Description read[DESCRIPTION-READ] 66594528e4d2cf7b803833615fc448ae4d1fb2a2a2f670a45bb76450a05d6566 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
6701c25 to
86882cc
Compare
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that the frame-facts bullets stay in step with What this change shipsInventory (5 items) — 5 justifiedIntent: authors of dashboard pages learn which motion is allowed, what the frame permits, and that reduced motion is mandatory. This is an ADDITION (docs).
[FIRST-PRINCIPLES-REVIEWED] ec57719 Description read[DESCRIPTION-READ] 85ac871670c36be7a08f9398306f40b5615a96df61321b2cbe950910a819fab6 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
|
|
|
|
|
|
86882cc to
7d92dad
Compare
Allowed effects: pop-in on first draw, a subtle live loop (live shimmer, or a soft glow on a needs-you element), and a one-shot state-change flash. Only live or needs-you elements loop, and every loop stops under prefers-reduced-motion. States the frame's sandbox and CSP, the host open bridge (kirocrew-dashboard:open via useFrameOpenLink), and a MANDATORY prefers-reduced-motion block. Cites the goal-board built-in as the reference. test_dashboard_template_motion_guide.py pins the section, its reduced-motion rule, and every class, keyframes, loop, bridge and sandbox fact it names against the code.
7d92dad to
ec57719
Compare
|
Self-review (crew-pr-reviewer, read-only): RECOMMEND APPROVE Recommend approve. This adds a |
Problem / Motivation
Goal: An author writing a dashboard page knows which animations are allowed, what the frame permits, and that reduced motion is mandatory.
The
dashboard-templateskill says nothing about motion. The goal-board built-in (#18557) now animates, so the next page will copy it with no written rule.Why it matters
Without a rule, pages will add loops that never stop and skip
prefers-reduced-motion. That hurts readers who asked their OS for less motion. Authors will also trytarget="_blank"links that are dead clicks in the sandbox.Not a goal
What changed (motivation → approach → change)
One new
## Motionsection insrc/kiro_crew/builtin_skills/kirocrew-dev/dashboard-template/SKILL.md:gb-pop,gb-grow,gb-shimmer,gb-blink,gb-glow).sandbox="allow-scripts"only, the CSP, and the one way out,kirocrew-dashboard:openviauseFrameOpenLink, which opens only right after a click in that frame.test/test_dashboard_template_motion_guide.pyholds every one of those facts to the code. Was stacked on #18557; that merged, so this is now one docs commit onmain.Backwards compatibility
Compatible: documentation and a test only; no code path changes.
Removes nothing: the commit only adds a section and a test file.
Tests
test/test_dashboard_template_motion_guide.py(new, 6 cases):gb-shimmerandgb-blink;gb-glowis 3 pulses, as the guide says.OPEN_MESSAGE_TYPEfromuseFrameOpenLink.ts, goal-board sends it, and the host gates it on a gesture.CREW_DASHBOARD_SANDBOX.Red-before: removing the section fails 6; removing the css block fails 2; dropping
::afterfails 2. Locally: 6 passed with-n 2. The tests only read files, so order and repeats cannot change them.Manual verification
N/A: docs only; the test file checks every stated fact against the code.
Related Issues
Closes #18665
Follows #18557.
Checklist