Skip to content

docs(skills): a Motion section in the dashboard-template skill - #18666

Merged
buluoray merged 1 commit into
mainfrom
docs/dashboard-motion-guide
Oct 10, 2026
Merged

buluoray merged 1 commit into
mainfrom
docs/dashboard-motion-guide

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: An author writing a dashboard page knows which animations are allowed, what the frame permits, and that reduced motion is mandatory.

The dashboard-template skill says nothing about motion. The goal-board built-in (#18557) now animates, so the next page will copy it with no written rule.

Why it matters

Without a rule, pages will add loops that never stop and skip prefers-reduced-motion. That hurts readers who asked their OS for less motion. Authors will also try target="_blank" links that are dead clicks in the sandbox.

Not a goal

What changed (motivation → approach → change)

One new ## Motion section in src/kiro_crew/builtin_skills/kirocrew-dev/dashboard-template/SKILL.md:

  • Three allowed effects: pop-in on first draw, a subtle live loop, a one-shot state-change flash.
  • Only live or needs-you elements may loop, gently; a needs-you glow pulses a few times and stops. Every loop stops under reduced motion.
  • Each effect points at goal-board's real class and keyframes (gb-pop, gb-grow, gb-shimmer, gb-blink, gb-glow).
  • Frame facts: sandbox="allow-scripts" only, the CSP, and the one way out, kirocrew-dashboard:open via useFrameOpenLink, which opens only right after a click in that frame.
  • The mandatory reduced-motion CSS block, copied from goal-board.
  • Scaffolded pages stay inert, so their motion is CSS only.

test/test_dashboard_template_motion_guide.py holds every one of those facts to the code. Was stacked on #18557; that merged, so this is now one docs commit on main.

Backwards compatibility

Compatible: documentation and a test only; no code path changes.

Removes nothing: the commit only adds a section and a test file.

Tests

test/test_dashboard_template_motion_guide.py (new, 6 cases):

  • The section exists, says MUST, and its css block stops animations and transitions on every element and both pseudo-elements.
  • The guide's reduced-motion rule equals goal-board's own rule.
  • Every class and keyframes the guide cites exists in goal-board.
  • Goal-board loops forever only gb-shimmer and gb-blink; gb-glow is 3 pulses, as the guide says.
  • The bridge call the guide shows uses OPEN_MESSAGE_TYPE from useFrameOpenLink.ts, goal-board sends it, and the host gates it on a gesture.
  • The sandbox the guide states is CREW_DASHBOARD_SANDBOX.

Red-before: removing the section fails 6; removing the css block fails 2; dropping ::after fails 2. Locally: 6 passed with -n 2. The tests only read files, so order and repeats cannot change them.

Manual verification

N/A: docs only; the test file checks every stated fact against the code.

Related Issues

Closes #18665

Follows #18557.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 9, 2026 23:41
@iamwhatever
iamwhatever requested a review from bolichen97 October 9, 2026 23:41
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ec5771937d5edfc7028bbf26f34a4d08fa55f9e7 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] ec57719

Description read

[DESCRIPTION-READ] 66594528e4d2cf7b803833615fc448ae4d1fb2a2a2f670a45bb76450a05d6566

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ec5771937d5edfc7028bbf26f34a4d08fa55f9e7 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ec57719

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ec5771937d5edfc7028bbf26f34a4d08fa55f9e7: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 10, 2026
@iamwhatever
iamwhatever force-pushed the docs/dashboard-motion-guide branch from 6701c25 to 86882cc Compare October 10, 2026 00:11
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 10, 2026
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of ec5771937d5edfc7028bbf26f34a4d08fa55f9e7 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check that the frame-facts bullets stay in step with docs/architecture/dashboard-iframe-hosts.md, which already records the same CrewDynamicDashboard sandbox from the host's side.

What this change ships

Inventory (5 items) — 5 justified

Intent: authors of dashboard pages learn which motion is allowed, what the frame permits, and that reduced motion is mandatory. This is an ADDITION (docs).

  1. The dashboard-template skill gains a Motion section listing three allowed effects, each mapped to goal-board's classes and keyframes — justified
  2. A rule that only live or needs-you elements may loop, that the glow stops, and that pop-in is not replayed on refill — justified
  3. Frame facts for authors: sandbox, CSP, and the kirocrew-dashboard:open bridge that only opens after a click — justified
  4. A required reduced-motion CSS block, copied from goal-board — justified
  5. A new test file that checks every stated fact against goal-board, useFrameOpenLink.ts and CrewDynamicDashboard.tsx — justified

[FIRST-PRINCIPLES-REVIEWED] ec57719

Description read

[DESCRIPTION-READ] 85ac871670c36be7a08f9398306f40b5615a96df61321b2cbe950910a819fab6

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision ec5771937d5edfc7028bbf26f34a4d08fa55f9e7 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ec5771937d5edfc7028bbf26f34a4d08fa55f9e7 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ec57719

Verdict parsed from the review's SHA-scoped output markers for commit ec5771937d5edfc7028bbf26f34a4d08fa55f9e7.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ec5771937d5edfc7028bbf26f34a4d08fa55f9e7: <one-sentence reason>

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted: Option buttons only fill the chat box span=34889d51f9de

Not this PR's code. The goal-board UI is #18557's commit, carried unchanged so CI can run; this PR's own commit only adds a Motion section to the dashboard-template SKILL.md and a test.
The finding belongs on #18557. When #18557 merges this branch becomes one docs-only commit and the UX lane re-reads a diff with no UI in it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted: Reader cannot tell if an option sends span=13cf4aeb4707

Not this PR's code. The goal-board UI is #18557's commit, carried unchanged so CI can run; this PR's own commit only adds a Motion section to the dashboard-template SKILL.md and a test.
The finding belongs on #18557. When #18557 merges this branch becomes one docs-only commit and the UX lane re-reads a diff with no UI in it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted: Needs-you buttons go unused span=b6612a520459

Not this PR's code. The goal-board UI is #18557's commit, carried unchanged so CI can run; this PR's own commit only adds a Motion section to the dashboard-template SKILL.md and a test.
The finding belongs on #18557. When #18557 merges this branch becomes one docs-only commit and the UX lane re-reads a diff with no UI in it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted: Hint line and Write a reply rename span=52b21e2a39b9

Not this PR's code. The goal-board UI is #18557's commit, carried unchanged so CI can run; this PR's own commit only adds a Motion section to the dashboard-template SKILL.md and a test.
The finding belongs on #18557. When #18557 merges this branch becomes one docs-only commit and the UX lane re-reads a diff with no UI in it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted: Reply on a blocked task span=14ce8edc3800

Not this PR's code. The goal-board UI is #18557's commit, carried unchanged so CI can run; this PR's own commit only adds a Motion section to the dashboard-template SKILL.md and a test.
The finding belongs on #18557. When #18557 merges this branch becomes one docs-only commit and the UX lane re-reads a diff with no UI in it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted: PR chips look clickable span=1ca048a5d574

Not this PR's code. The goal-board UI is #18557's commit, carried unchanged so CI can run; this PR's own commit only adds a Motion section to the dashboard-template SKILL.md and a test.
The finding belongs on #18557. When #18557 merges this branch becomes one docs-only commit and the UX lane re-reads a diff with no UI in it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted: open segment hides stuck tasks span=c1c7398532e1

Not this PR's code. The goal-board UI is #18557's commit, carried unchanged so CI can run; this PR's own commit only adds a Motion section to the dashboard-template SKILL.md and a test.
The finding belongs on #18557. When #18557 merges this branch becomes one docs-only commit and the UX lane re-reads a diff with no UI in it.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 10, 2026
@iamwhatever
iamwhatever force-pushed the docs/dashboard-motion-guide branch from 86882cc to 7d92dad Compare October 10, 2026 08:57
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 10, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 10, 2026
Allowed effects: pop-in on first draw, a subtle live loop (live shimmer, or a soft glow on a needs-you element), and a one-shot state-change flash. Only live or needs-you elements loop, and every loop stops under prefers-reduced-motion. States the frame's sandbox and CSP, the host open bridge (kirocrew-dashboard:open via useFrameOpenLink), and a MANDATORY prefers-reduced-motion block. Cites the goal-board built-in as the reference. test_dashboard_template_motion_guide.py pins the section, its reduced-motion rule, and every class, keyframes, loop, bridge and sandbox fact it names against the code.
@iamwhatever
iamwhatever force-pushed the docs/dashboard-motion-guide branch from 7d92dad to ec57719 Compare October 10, 2026 09:27
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 10, 2026
@buluoray
buluoray enabled auto-merge (squash) October 10, 2026 11:31
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Self-review (crew-pr-reviewer, read-only): RECOMMEND APPROVE

Recommend approve. This adds a ## Motion section to the dashboard-template skill: three allowed effects, a rule that only live or needs-you elements may loop, a mandatory reduced-motion CSS block, and facts about the frame (sandbox, CSP, the kirocrew-dashboard:open bridge). That fills the gap #18557 left, since goal-board animates but no rule was written down. I read the full diff at ec57719 and checked its claims against main. PR_URL_RE and hasGesture in useFrameOpenLink.ts and the CSP in widgetSrcdoc.ts (connect-src 'none', img-src data: blob:) match the text. Base is main, checks are green, every AI lane on the current head is PASS, and there are no change requests. The six tests read the real files. They would fail if the section, its CSS block, a cited keyframe or the bridge name drifted, so they guard the documentation against rot. Scope is docs plus a read-only test (148 lines), and no code paths change. — crew-pr-reviewer

@buluoray
buluoray merged commit fc72062 into main Oct 10, 2026
102 checks passed
@buluoray
buluoray deleted the docs/dashboard-motion-guide branch October 10, 2026 18:43
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(skills): dashboard-template skill has no motion guidance

3 participants