Skip to content

docs: record that the crewmate chat draws messages only - #18672

Merged
CrysisDeu merged 2 commits into
mainfrom
docs/decision-crewmate-chat-messages-only
Oct 12, 2026
Merged

CrysisDeu merged 2 commits into
mainfrom
docs/decision-crewmate-chat-messages-only

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record, in the decisions ledger, the maintainer's decision that a crewmate's chat draws messages only, so no later fix re-introduces runtime notices into that surface.

A crewmate's chat today draws runtime notice rows such as the automation arm refusal ("Automation update refused: a stopped loop cannot be restarted by updating it") as a yellow bar inside the person's conversation with the crewmate. The maintainer decided on 2026-10-09 that this surface shows the person's rows and the crewmate's speech only, and that anything the runtime has to say goes to the crewmate (next turn) or to the log. That decision had no ledger entry, so nothing protected it from being undone by a report such as #18232.

Why it matters

Without an entry, a friction report or a review finding that a notice is "missing" from the crewmate chat reads as a bug and gets fixed back in; the recorded-decisions-are-not-regressions rule and issue triage read only docs/decisions/.

Not a goal

What changed (motivation → approach → change)

Decision needed a durable record → the ledger under docs/decisions/ is the one place triage and the review rule read → one new immutable entry docs/decisions/2026-10-09-crewmate-chat-draws-messages-only.md following the README's entry format, plus its row in the README's Entries index (Docs Lint requires every doc to be reachable from an index).

Per README rule 4, the maintainer restates the decision on record on this pull request: #18672 (comment). The entry's Evidence section cites that comment, #18669, #18232 and #16429.

Backwards compatibility

Compatible: documentation only; no code, schema or config changes.

Removes nothing: the diff adds one file and one index row.

Tests

N/A — documentation only. scripts/check_decisions_history.py (Fast Gate decision-ledger-history) verifies the 14 existing entries stay byte-identical; scripts/docs-lint.sh verifies the new entry is indexed.

Manual verification

  • DECISIONS_BASE_REF=origin/main python3 scripts/check_decisions_history.py → 14 entries at origin/main intact at head OK.
  • bash scripts/docs-lint.sh → no finding for docs/decisions/.

Screenshots / video

N/A — no user-visible frontend surface is touched.

Related Issues

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 8c2716bcbac2eac98039bd21cafdbb88c6a7f714 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 8c2716bcbac2eac98039bd21cafdbb88c6a7f714 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 8c2716bcbac2eac98039bd21cafdbb88c6a7f714 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that comment 6091359535 is by @CrysisDeu, who must be listed in MAINTAINERS.md, and that it covers the full "whatever its tag" scope.

[DESIGN-REVIEWED] 8c2716b

Description read

[DESCRIPTION-READ] 69ecd6d16d2f3065c47c2e98c93bdbd2c978688a10136370d011abf798e5f11e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 8c2716bcbac2eac98039bd21cafdbb88c6a7f714 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 8c2716b

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 8c2716bcbac2eac98039bd21cafdbb88c6a7f714: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 8c2716bcbac2eac98039bd21cafdbb88c6a7f714 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 8c2716b

Verdict parsed from the review's SHA-scoped output markers for commit 8c2716bcbac2eac98039bd21cafdbb88c6a7f714.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 8c2716bcbac2eac98039bd21cafdbb88c6a7f714: <one-sentence reason>

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Decision, on record (Zezhen Xu, maintainer): the crewmate chat draws messages only — the person's rows and the crewmate's own speech. No runtime notice row of any kind is drawn there (automation arm refusals included); what the runtime has to say goes to the crewmate on its next turn, or to the log. The Sessions page is unchanged.

In my words from the dashboard: 用户不看,至少 UI 层不应该显示出来,crew chat 只显示消息。

Posted from my account at my instruction.

@CrysisDeu
CrysisDeu marked this pull request as ready for review October 10, 2026 00:02
@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners October 10, 2026 00:02
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 10, 2026
A crewmate's chat shows the person's rows and the crewmate's speech;
runtime notices (arm refusals, empty-turn cards) are fed back to the
crewmate or logged, never drawn there. Records the maintainer decision
behind #18669; the maintainer restates it on the pull request.
@CrysisDeu
CrysisDeu force-pushed the docs/decision-crewmate-chat-messages-only branch from 1eebf1d to be2d5a8 Compare October 10, 2026 06:15
@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 10, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 12, 2026
@CrysisDeu
CrysisDeu merged commit 67c96de into main Oct 12, 2026
44 of 45 checks passed
@CrysisDeu
CrysisDeu deleted the docs/decision-crewmate-chat-messages-only branch October 12, 2026 00:42
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant