Skip to content

fix(dashboard): open a crewmate's staged dashboard preview in the Dashboard tab - #18798

Merged
buluoray merged 2 commits into
mainfrom
fix/dashboard-preview-link
Oct 13, 2026
Merged

buluoray merged 2 commits into
mainfrom
fix/dashboard-preview-link

Conversation

@adlio

@adlio adlio commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The link a crewmate hands out after dashboard_preview opens a page where the person sees the staged dashboard, labelled as a preview, so they can say whether to keep it.

A crewmate called dashboard_preview, and the person opened the link it returned: /api/members/bi-buddy/dashboard?preview=1. Two things were wrong with it:

Why it matters

The dashboard flow is "stage a page, show the person, ask, then apply". Every preview link has been dead, so the person had nothing to look at, and the ask before dashboard_apply was about a page nobody could see.

Not a goal

What changed (motivation → approach → change)

The link was built from the slug and pointed at the JSON API, and no page knew how to draw a staged dashboard.

preview_url (dashboard_templates/instance.py) now takes the crew name and builds a page link: /members?member=<name>&dashboard=preview. The dashboard_preview tool reply (mcp_panel.py) hands it to the agent as a markdown link, [Open the dashboard preview](...), because the chat makes a root-relative path clickable only in that form. The Members page treats dashboard=preview as "show the staged page": it opens the side panel on the Dashboard tab, and the tab reads the same owner-gated route with preview=1 and draws the result in the same sandboxed frame as the live page; memberDashboard in api/client/agents.ts gains the preview flag for that read.

Situation What the person sees
A page is staged The staged page, under the shared Preview, not applied label: "Not live yet. Reply in chat to keep this page or ask for changes."
Nothing staged (404 no_preview: applied or expired) The label drops and "This preview has closed. It was applied or it expired." shows, no retry. The tab stays on that notice, never on an unlabelled live page
Any other failure, including 404 member_not_found The tab's existing load-failure notice with Retry
Dynamic Dashboard Feature Preview off The staged page anyway: it exists only in that form
Switching crewmate The dashboard query is dropped; the live page returns

A Playwright spec on the real gateway opens the link the tool returns and checks it lands on the staged page (docs/ci/e2e-gate.md describes it). No new strings ship: the label and notice are #18837's (pages.chat.dashboardPreviewPanel.*), and dashboard-instances.md describes the link and the tab.

Backwards compatibility

Breaking: instance.preview_url(slug) becomes preview_url(member), and Preview.wire() now takes the crew name. Writer sweep on origin/main @ d3f462f: the only callers are agent_panel.api_dashboard_preview (passes the session's crew name) and Preview.wire itself; both updated. Open PR #18105 adds a new preview.wire() call and will need the crew name on rebase. The JSON route and its preview=1 read are unchanged.

Reader: src/kiro_crew/mcp_panel.py:_render_preview -- chat (crewmate MCP tool) -- reads preview_url from the wire as a string; now a page link (test_it_hands_back_the_link_and_says_nothing_changed)
Reader: src/kiro_crew/dashboard/handlers/agent_panel.py:api_dashboard_preview -- chat -- passes crew_name to wire (test_a_staged_template_comes_back_with_its_link)

Tests

The end-to-end guard: website/playwright/dashboard-preview-link.spec.ts. It opens the exact link dashboard_preview returns, against a real gateway, and checks both halves. The UI route renders the staged page under the Preview, not applied label. The dashboard read accepts the crewmate the link names (200, preview: true, no missing_member). The harness (test_playwright_e2e._stage_dashboard_preview) stages the page with the production store and passes the link that store's wire() returns, so the spec never builds the link. It stages standup, not the default page, so a tab showing the live page fails. This is the guard against a person being asked to approve a page they could not open. Run locally on an ephemeral gateway: green on this branch (4/4 with --repeat-each=3), and red with the old slug-only /api/ link restored (the preview label not found). MIN_EXECUTED_SPECS goes from 241 to 242 for it. test_the_staged_preview_outlives_the_whole_browser_run pins the 30-minute preview window above the run's ceiling.

  • test_dashboard_tools.py::TestThePreviewLinkIsAPageForOneCrewmate: the link names the crewmate, is a page and never /api/, round-trips names slugification loses (BI Buddy, R&D, a/b?c=d, non-ASCII), and its two query literals match dashboardPreview.ts.
  • test_agent_panel_routes.py: the preview route's link is /members?member=<crew>&dashboard=preview, built from the crew name.
  • test_member_dashboard_routes.py: the preview=1 read serves the staged page with preview: true and rendered_html and leaves instance_version alone; nothing staged is 404 no_preview.
  • CrewDynamicDashboard.test.tsx: preview mode reads with preview=true and draws the sandboxed frame with no label of its own, a 404 no_preview shows the closed notice with no retry and tells the host, any other 404 shows the load-failure notice, and the live page is not marked as a preview.
  • MembersPage.test.tsx: a preview link opens a closed panel on the Dashboard tab in preview mode under the shared label, works with the Feature Preview off, and a closed preview stays on its notice.

Determinism: the new frontend tests await the state they assert on and use no timers; the new backend tests use the file's isolated home.

Manual verification

Drove the real MembersPage (isolated capture entry, gateway stubbed at /api/) with Playwright at the exact link preview_url builds, panel closed beforehand. Each shot asserts its state first: the label text, the staged page inside the iframe, a preview=1&member=radar read, and the URL. A 390px shot asserts the label's hint keeps a readable width, and the closed shot asserts the label is gone. The driver is website/scripts/capture-crew-dashboard-preview.mjs. Not run against a live gateway.

Screenshots / video

Preview link opened with the panel closed (dark):

Preview, not applied label above the staged page

Nothing staged any more:

Preview closed notice

Light theme, and 390px

Preview label, light

Preview label at 390px

Related Issues

Closes #18768
Closes #18769

Pattern harvest

Rule candidate: review-prompt
Pattern: a link built for a person points at a JSON API route, or omits a query parameter the route requires; test a user-facing link by the route it opens, not by its suffix.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Rebase + follow-up

Rebased on main to resolve conflicts with #18837, which shipped a chat side-panel preview for the same staged page.

@adlio
adlio requested review from a team and KiroCrewCaptain as code owners October 10, 2026 09:05
@adlio
adlio requested a review from CrysisDeu October 10, 2026 09:05
@adlio

adlio commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

Build is red on main for a reason outside this PR: ui-index.generated.json is stale on origin/main (#18749), fix in flight at #18753. This PR waits for that fix and rebases onto it.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 10, 2026
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of c647b26a37d89f5076509cab16ac21b2a85558cf — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that #18105 passes the crew name to Preview.wire(member) when it rebases. The new parameter has no default, so a call without it raises TypeError.

[DESIGN-REVIEWED] c647b26

Description read

[DESCRIPTION-READ] 9f2a5c333bf0c080a0b0d94ee81c5b3fd6583fba89893ca804388d5d1fb44182

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of c647b26a37d89f5076509cab16ac21b2a85558cf — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The Members-page preview builds a second host for a staged page that DashboardPreviewPanel already draws on /members, and moves #18837's thread-click behaviour without a report behind it.

Not justified as shipped

  • Item 3 — duplicate of website/src/pages/chat/DashboardPreviewPanel.tsx (via usePanelDocumentActions.openArtifact): on base, a plain click on a preview link in a /members thread already opens the staged page in that page's side panel. This PR adds a second host for it: CrewDashboardTab gains preview, previewGone, the key on preview, and a bypass of the feature flag.
    Subtraction: on ?dashboard=preview, call the existing openArtifact(dashboardPreviewRef({kind:'member-name', member})), which this PR already teaches member-name. Then delete CrewDashboardTab's preview/previewGone, the dashboardPreview || dashboardPreviewLink flag bypass, and the separate DashboardPreviewLabel file.
    Clears when: the tab-preview path is removed, or a reason shows the existing panel cannot host the page link.
  • Item 4 — unjustified move: openDashboardPreviewHere sends feat(chat): open a staged dashboard preview in the side panel #18837's thread click on /members to the Dashboard tab instead of a side-panel tab. The only support is "one preview surface per page". No person is named who was failing.
    Subtraction: delete openDashboardPreviewHere, openArtifactInThread and openArtifactInPanel, and keep openArtifactGuarded/openArtifact.
    Clears when: a report links someone who was confused by the side-panel preview tab on /members.

What this change ships

Inventory (8 items) — 6 justified

Intent: a person opens the link a crewmate gives them after dashboard_preview, sees the staged dashboard labelled as a preview, and answers in chat. This is a FIX.

  1. The dashboard_preview link is now /members?member=<name>&dashboard=preview instead of the JSON API route — justified
  2. The tool reply gives the link as a clickable markdown link — justified
  3. On /members, ?dashboard=preview opens the Dashboard tab on the staged page, even with the flag off — duplicate of DashboardPreviewPanel
  4. A thread click on a preview link on /members now goes to the Dashboard tab instead of a side-panel tab — unjustified move
  5. On the chat page, the new link form still opens the side-panel preview — justified
  6. When nothing is staged, the notice says the preview closed, with no retry — justified
  7. The preview label moved into a shared component — justified
  8. A Playwright spec and the MIN_EXECUTED_SPECS bump — justified

[FIRST-PRINCIPLES-REVIEWED] c647b26

Description read

[DESCRIPTION-READ] bc935d19fa0fcd040d786a33120c263eabd9578d9005f393b35bcdf7a40e702d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of c647b26a37d89f5076509cab16ac21b2a85558cf — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The closed-preview notice doesn't say whether the page was kept or lost. On a phone, the preview link opens an overlay that hides the chat the label says to reply in.

Watch

  • Closed notice gives no clear outcome. On a no_preview 404 the tab shows "This preview has closed. It was applied or it expired." The blind reader on shot-02: "I can't tell whether my dashboard was kept or lost… I wouldn't dare press" the chat link that is still there. This happens to everyone who reopens an old link, and the outcome matters most at that moment. Smallest fix: give the closed notice one action, "Open the live dashboard", so the person can see what is actually live.
  • Mobile lands without the chat. The preview effect calls setOverlayOpen(true) when the panel isn't docked beside the chat. Shot-04 shows "Reply in chat to keep this page…" with no chat on screen; the reader: "there's no chat on screen to reply in, so I don't know how to get back to it." This affects every narrow-screen preview open and blocks the keep/change decision the PR exists to support. Fix: on overlay layouts, show a visible "Back to chat" control next to the label.
  • Primary link was only a guess. The reader read "Open the dashboard preview" correctly but rated it "a guess", because the panel was already open in the screenshot. The link is the PR's main path, so the guess is worth noting, but it isn't blocking.

Suggestions

  • DashboardPreviewLabel: the badge says "not applied" and the hint says "Not live yet", which the reader flagged as two ways of saying one thing. Use one term: drop "Not live yet." and start the hint with "Reply in chat to keep this page or ask for changes."

[UX-REVIEWED] c647b26

Description read

[DESCRIPTION-READ] 22ac403cc28729d77e13d5c7eb5f27514c69ac65a1c0e3635105d0bd9a6c2c66

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed c647b26a37d89f5076509cab16ac21b2a85558cf — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] c647b26

Verdict parsed from the review's SHA-scoped output markers for commit c647b26a37d89f5076509cab16ac21b2a85558cf.

False positive or not applicable? A repository writer can comment:
/ai-review override fable c647b26a37d89f5076509cab16ac21b2a85558cf: <one-sentence reason>

@adlio
adlio force-pushed the fix/dashboard-preview-link branch from 3e9e771 to 0ec07cc Compare October 10, 2026 09:16
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of c647b26a37d89f5076509cab16ac21b2a85558cf and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c647b26

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c647b26a37d89f5076509cab16ac21b2a85558cf: <one-sentence reason>

@adlio

adlio commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in src/kiro_crew/dashboard/handlers/guide.py, test/test_guide_observe.py since this head went green (d3f462f -> d32c084); CI re-running. The new base also clears the stale ui-index.generated.json that turned Build, Build Desktop and E2E (at its Build frontend step) red on the previous head.

@adlio

adlio commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=b9b028f54080 "Show live dashboard" has no way back -- rebutted (disproportional)

The way back is the link the crewmate posted in the chat, which stays in the thread; the companion fix for the unclickable-link item makes that link clickable, so returning to the draft is one click.
A "Back to preview" button on the live view would need a second staged-page read on every live dashboard render and poll, which is new surface this PR's goal does not need.
A staged page also expires after 30 minutes or is consumed by dashboard_apply, so a persistent button would often point at nothing; the nothing-staged notice already covers that state.

@adlio

adlio commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

Frontend Tests (3) red is main's: GuideLayer.test.tsx > pressing the highlighted control on the last step finishes the guide, tracked in #18771 (also red on main push CI). This PR touches nothing under website/src/guide/. Frontend Coverage Merge fails only because that shard did.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 10, 2026
@adlio
adlio force-pushed the fix/dashboard-preview-link branch from 0ec07cc to 3c7232d Compare October 10, 2026 09:48
@adlio

adlio commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author
  • span=7b303a9f2772 The link can't be opened from the chat -- fixed in 3c7232d

_render_preview (src/kiro_crew/mcp_panel.py) hands the agent the link as a markdown link, [Open the dashboard preview](/members?member=...&dashboard=preview), which the chat renders as a clickable in-app link (MarkdownRenderer localHref for a root-relative href).
Pinned by test_dashboard_tools.py::TestDashboardPreviewTool::test_it_hands_back_the_link_and_says_nothing_changed; the refreshed preview-dark.png shows the clickable link in the chat.
self-added: no

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 10, 2026
@adlio

adlio commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author
  • span=9648a711c3fe "Staged" read as jargon in the preview band -- fixed in 3c7232d

The band now reads "{{crew}} made this draft for you to look at. Your dashboard hasn't changed yet. Tell {{crew}} in the chat whether to keep it." in all 12 catalogs, in each language's required register.
The translator note asks for the everyday word for a draft; the unit test and the Playwright spec assert the new text.
self-added: yes

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 10, 2026
@adlio

adlio commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author
  • span=26890b1857ee The nothing-staged notice leaves the user guessing -- rebutted (disproportional)

The gateway keeps no record of why a staged page is gone (apply and discard both delete preview.json, expiry drops it on read), so the notice cannot name the outcome, as the review itself notes.
The pointer the review asks for is already the notice's only control: "Show live dashboard" sits directly under the sentence, and the live page answers whether the draft was kept; restating it in a second sentence across 12 catalogs adds words, not information.

@adlio

adlio commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author
  • span=39e973ec3fbf "Show live dashboard" reads as a one-way exit -- rebutted (same class as span b9b028f54080, already answered)

Leaving the preview only drops the dashboard=preview query; the staged page stays on disk until it is applied, discarded or expires, and the clickable chat link reopens it in one click.
The band already says the dashboard has not changed and points the person at the chat, which is where that link lives; a third sentence in a band that must fit a 320px panel trades readability for a reassurance the link provides.

@adlio

adlio commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author
  • span=1385c351cb43 One state goes by four names -- rebutted (not a defect)

Two of the four are not person-facing: "Staged for a look" is the tool reply's instruction to the AGENT (mcp_panel._render_preview), and "Staged template" is text inside the capture fixture page, not product UI.
What the person reads is one vocabulary: the chat link "Open the dashboard preview", the "Preview" badge naming the view, and the band calling the page a "draft"; preview names the mode, draft names the page.

@adlio
adlio force-pushed the fix/dashboard-preview-link branch from 3c7232d to b15efea Compare October 10, 2026 10:30
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 10, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor
  • span=c36bc00d581b Item 8, no retry on no_preview -- rebutted (by design)

A 404 no_preview answers the same on every retry. Without the rule, the closed notice waits behind the client's retry ladder. This is part of showing the closed state honestly, which the link fix needs.

@iamwhatever

Copy link
Copy Markdown
Contributor

The ruling removed the tab's exit button and its string. The way out is to pick the crewmate again or switch crewmate, which drops the query. Jumping to the live page by itself was tried and refused by this lane, because it shows an unlabelled page under a preview link.

@iamwhatever

Copy link
Copy Markdown
Contributor

The hint is #18837's shipped string, shared by both surfaces by ruling. Closing the overlay returns to the chat. A phone-only control is a separate design change.

@iamwhatever

Copy link
Copy Markdown
Contributor

Each page opens the staged page in its own panel, under the same label. That is the ruling's one surface per page.

@iamwhatever

Copy link
Copy Markdown
Contributor
  • span=ab918ee0c363 Say which outcome happened -- rebutted (advisory)

The gateway answers one 404 no_preview for applied and expired alike, so the page cannot tell them apart. The live-page action was cut by ruling.

@iamwhatever

Copy link
Copy Markdown
Contributor

The /members link this PR hands out (?dashboard=preview) lands on the Dashboard tab, so that tab must draw the staged page; the member-name ref is the chat page's side of the same link. Both hosts share one label and one closed notice.

@iamwhatever

Copy link
Copy Markdown
Contributor
  • span=c33134bcd088 Item 4, undeclared reroute and the preview flag line -- fixed in PR body

The body's "Rebase + follow-up" section now says in-thread clicks on /members open the Dashboard tab, not #18837's side-panel tab, and that memberDashboard(preview) was already on base so the diff only rewrites its comment.

@iamwhatever

Copy link
Copy Markdown
Contributor

The gateway answers one 404 no_preview for applied and expired alike, so the page cannot say which. The tab's exit button and its string were cut by ruling; an auto-return to the live page was refused by this lane on an earlier head. The way out is picking the crewmate again, which drops the query.

@iamwhatever

Copy link
Copy Markdown
Contributor
  • span=4af95ffec65c The chat link reads as a guess -- rebutted (author's copy)

The link text comes from the tool reply (mcp_panel._render_preview), the author's string. The lane rates it low to medium and names no change for this PR.

@iamwhatever

Copy link
Copy Markdown
Contributor

The hint is #18837's shipped string, shared by both surfaces by ruling. Closing the overlay returns to the chat. A phone-only control is a separate design change.

@iamwhatever

Copy link
Copy Markdown
Contributor

Advisory. The three strings shipped in #18837 across 13 locales; rewording them is its own copy change.

@iamwhatever

Copy link
Copy Markdown
Contributor

The tab's exit button and its string were cut by ruling. An auto-return to the live page was refused by this lane on an earlier head: an unlabelled live page under a preview link reads as the preview. The way out is picking the crewmate again, which drops the query.

@iamwhatever

Copy link
Copy Markdown
Contributor

"Staged for a look" is the tool reply, the author's string; "Preview, not applied" shipped in #18837 across 13 locales. Rewording either is its own copy change.

@iamwhatever

Copy link
Copy Markdown
Contributor
  • span=2ee95a383ebe Split the closed notice by cause -- rebutted (advisory)

The gateway answers one 404 no_preview for applied and expired alike (member_dashboard.py), so the page cannot tell them apart. Recording the cause is a backend change outside this fix.

@iamwhatever

Copy link
Copy Markdown
Contributor

The maintainer asked for one preview surface per page in this PR's follow-up commit (the body's "Rebase + follow-up" section). On /members the link this PR hands out already lands on the Dashboard tab, so a thread click there opens that same tab instead of a second, side-panel copy of the staged page. The chat page keeps #18837's side panel.

@iamwhatever

Copy link
Copy Markdown
Contributor

The tab's "Show live dashboard" action and its string were cut by ruling, and the conductor kept that cut for this rebase. An auto-return to the live page was refused by this lane on an earlier head: an unlabelled live page under a preview link reads as the preview. Re-picking the same crewmate keeps the query; the way out is switching to another crewmate, which writes a fresh ?member=, or opening Crewmates from the rail.

@iamwhatever

Copy link
Copy Markdown
Contributor

The link is a line in the transcript, so it cannot change once sent. The lane ties this item to the closed-notice item above, which the same ruling answers.

@iamwhatever

Copy link
Copy Markdown
Contributor

The hint is #18837's shipped string, shared by both surfaces by ruling. On a phone the panel's close control, or a rightward swipe, returns to the chat. A phone-only control is a separate design change.

@iamwhatever

Copy link
Copy Markdown
Contributor

The tab's "Show live dashboard" action and its string were cut by ruling, and the conductor kept that cut for this rebase. An auto-return to the live page was refused by this lane on an earlier head: an unlabelled live page under a preview link reads as the preview. Re-picking the same crewmate keeps the query; the way out is switching to another crewmate, which writes a fresh ?member=, or opening Crewmates from the rail.

@iamwhatever

Copy link
Copy Markdown
Contributor

The badge ("Preview, not applied"), the hint ("Not live yet. Reply in chat to keep this page or ask for changes.") and the closed notice are #18837's strings, shipped in 13 locales and shared by both surfaces by ruling. "Staged for a look" is the dashboard_preview tool reply (mcp_panel._render_preview), the author's string. Rewording them is its own copy change.

@iamwhatever

Copy link
Copy Markdown
Contributor

Advisory. The hint is #18837's shipped string in 13 locales, shared by both surfaces by ruling; rewording it is its own copy change.

adlio and others added 2 commits October 12, 2026 23:00
…page

but only for the /api/members/<slug>/dashboard?preview=1 form. preview_url now
hands out /members?member=<name>&dashboard=preview, so the chat page catches
that form too and resolves its crew name to a slug from the roster; the old form
keeps working for links already in transcripts.

On /members a plain click on either form opens the named crewmate's Dashboard
tab on the staged page, the same place ?dashboard=preview lands, instead of a
second side-panel tab.

Both surfaces draw the staged page under one label, DashboardPreviewLabel
("Preview, not applied"), and one gone notice. The Dashboard tab's own band,
its exit button, its nothing-staged notice and their four strings are removed.

@chenmingwei23 chenmingwei23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Opening the staged preview inside the Dashboard tab is the right place.

Non-blocking follow-ups:

  1. Use one preview link shape, ?dashboard=preview, and have the dashboard_save preview link use the same one, so there is a single way in.
  2. This PR and #19335 both change member_dashboard.py, CrewDynamicDashboard.tsx, CrewDashboardTab.tsx and dashboardPreview.ts. Let's agree which lands first so the second rebases once.

@chenmingwei23 chenmingwei23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending for review, need to revoke my approval

@chenmingwei23 chenmingwei23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after a second look. The bug is still on main (preview_url still returns the slug-only /api/ link), the PR works with the Feature Preview off so it fits RFC #19609, and all review lanes are green on c647b26. Only open point: it shares four files with #19335, so whichever lands second rebases once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crewmate dashboard preview link opens raw JSON; no UI renders a staged page Crewmate dashboard preview link is refused with missing_member

4 participants