Skip to content

fix(build): regenerate stale ui index after concurrent merges - #18799

Closed
chenmingwei23 wants to merge 1 commit into
kirodotdev:mainfrom
chenmingwei23:fix/main-ui-index-stale
Closed

chenmingwei23 wants to merge 1 commit into
kirodotdev:mainfrom
chenmingwei23:fix/main-ui-index-stale

Conversation

@chenmingwei23

Copy link
Copy Markdown
Contributor

Why this change

main is red on every platform (Build Wheel "Build frontend", Build Desktop, E2E). npm run build in website/ fails at its first step, gen-ui-index.mjs --check:

gen-ui-index: src/kiro_crew/docs/ui-index.generated.json is stale. Run `npm run gen:ui` in website/ and commit the result.

The committed UI index is stale against its own sources. Several PRs changed the index's inputs (dashboard components and the settings registry) without regenerating the committed src/kiro_crew/docs/ui-index.generated.json. The index was last regenerated at #18443 (last green build); builds have been red since the next merge. The most recent missing input is the notifications.sound-category-dictation setting added in #17923, which merged within ~5 seconds of #17732, so each PR was green alone but the committed index was left out of sync once they landed together.

This is a CI-only, generated-artifact fix. It does not change any product behaviour, UI, or copy for users, and it does not change the index generator or its inputs.

What changed

Ran npm run gen:ui in website/ on the current main tip and committed the result. The only change is to src/kiro_crew/docs/ui-index.generated.json:

  • adds the setting:notifications.sound-category-dictation entry and its label strings in all 12 locales, and
  • updates the input_digest and the generated/setting coverage counts to match.

gen:ui reported no change to website/src/uiLocations/guidePlans.gen.ts, so the diff is the index file only.

Verification

On this branch, in website/:

  • node scripts/gen-ui-index.mjs --check ... exits 0 ("up to date"); it failed with the stale-digest error on main before the regeneration.
  • npm run build completes (gen:ui check, tsc, and vite build all pass).

Backwards compatibility

Compatible: a generated artifact is brought back in sync with its inputs. No code or schema changes; nothing removed.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Unblocks main build; please merge first.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Oct 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision f695dfee5a6ea3231c948dee580eaf74b5d1bd2a touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of f695dfee5a6ea3231c948dee580eaf74b5d1bd2a via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Before merging, re-run gen-ui-index.mjs --check on the latest main. Any merge after this PR's base that touches the index inputs makes the index stale again.

What this change ships

Inventory (2 items) — 2 justified

Intent: get main building again by syncing the committed UI index with its sources. This is a FIX.

  1. find_ui can now locate the "Interrupted dictation" sound setting under Settings › Notifications › Per category, in all 12 locales — justified
  2. The index digest and the generated/setting coverage counts are updated to match the new entry — justified

[FIRST-PRINCIPLES-REVIEWED] f695dfe

Description read

[DESCRIPTION-READ] fe5fd910639cd1fd81649ef586e8bf1cd478e04b46feb4f2da293109e0cdbe11

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of f695dfee5a6ea3231c948dee580eaf74b5d1bd2a via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Before merging, re-run gen-ui-index.mjs --check against the current main tip. Another merge that changes an index input would make this digest stale again.

[DESIGN-REVIEWED] f695dfe

Description read

[DESCRIPTION-READ] f3812246f6bcf7204999df6c0b9730dccbc2360a953d8917f8898fda9690691a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed f695dfee5a6ea3231c948dee580eaf74b5d1bd2a via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f695dfe

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed f695dfee5a6ea3231c948dee580eaf74b5d1bd2a via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f695dfe

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Superseded: main's index is fresh again after #18782.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant