Repository navigation
Conversation
UX Review (Opus 5.5, fork) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing the failed-edit state. No screenshot shows the new "Could not update the lesson" or "Lesson updated, but the list could not be refreshed" notice. That notice also renders above the table, away from the row being edited. Evidence gaps
Notes
[UX-REVIEWED] a2e50ab Description read[DESCRIPTION-READ] 91aab5a698b0bac02a81d19fd8ec9076f15137b2dc4be8cf326f1e5c5fd43770 That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS No blocking design problem. Server-side Notes
[DESIGN-REVIEWED] a2e50ab Description read[DESCRIPTION-READ] cc57a088f018c25ee27d4a5f384468aaeb33c572754dab5935f7949af7d6c109 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. One wire field has no reader, and the description describes a client-side delete that the diff does not do. Notes
What this change shipsInventory (10 items) — 7 justifiedIntent: let users find lessons by text and reword one in place on the Memory tab. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] a2e50ab Description read[DESCRIPTION-READ] e4f9f325bfd90d047934eb5db23049dae0a6c9dc79c7ea9af5468ddd890c97c7 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review (fork) — 🔴 changes requested (blocking)Reviewed 2 of 2 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands. BLOCKING -- src/kiro_crew/learn.py:598 -- Editing into an existing rule permanently drops the original NOT-clause
BLOCKING -- website/src/pages/overview/MemoryTab.tsx:400 -- Redacted replacement selectors silently create a second lesson
[BLOCK-MERGE] a2e50ab Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 stays fenced as written. Merging a lesson into an existing rule is an ordinary edit, and the NOT-clause is lost silently and for good.
F2 is flagged; a writer could reasonably accept the risk.
🏷️ Fenced finding(s) machine-flagged as likely edge caseThe security fence keeps these findings blocking regardless of adjudication; the only clearance path is a human override recorded by a repository writer, who must independently verify a rationale before recording it — it is machine-authored, and a wrong override on a security-class finding ships exactly the class the fence exists to stop. (This lane's comment deliberately carries no override command.)
|
Opus 5.5 Review (fork) — 🔴 changes requested (blocking)Reviewed BLOCKING: an inline edit of a lesson whose rule text gets redacted sends the masked text back as the new rule and as BLOCKING — src/kiro_crew/dashboard/handlers/cron_lessons.py:1029 Notes:
|
bf55d3e to
eefc2a3
Compare
eefc2a3 to
3b88709
Compare
3b88709 to
b3374e4
Compare
e549447 to
589c50c
Compare
d77186c to
53b5e95
Compare
afca62d to
64337b2
Compare
7808382 to
0ecae84
Compare
8b7dc44 to
a2e50ab
Compare
…otdev#17982) Add text search filtering over loaded lessons and in-place rule editing to the lessons table on the Overview Memory tab, creating the replacement before deleting the original to prevent data loss and preserving category, scope, workspace, and applies attributes. Includes committed screenshot evidence under temp-screenshots for normal, filtered-empty, and editing states.
a2e50ab to
e76692e
Compare
|
[operator: bolichen97] Continuing this in #31438; thanks for the start. |
|
Thanks for this work, @bhumin18. Search and inline editing in the memory tab's lessons now ship on main through #31438 (merge commit d4dfaad), which continued from this PR, and issue #17982 is closed as completed. Closing this one as superseded. If something here is not covered by #31438, please open a new issue and we can pick it up. |
Problem / Motivation
Goal: Enable users to quickly search and filter lessons by rule text and edit existing lesson rules inline on the Overview Memory tab.
Users managing accumulated memory records could not filter lessons by text query and had to delete and re-create a rule if they needed to update its wording.
Why it matters
As the memory knowledge base grows, browsing hundreds of rules to find or tweak a specific guideline becomes cumbersome. Direct filtering and inline edits streamline memory curation.
Not a goal
What changed (motivation → approach → change)
<SearchInput>component above the lessons table with client-side case-insensitive filtering over the loaded lessons window and a FilteredEmpty state with a clear filter action.<Input>with Save (Enter) and Cancel (Escape). Creation occurs first viaapi.createLesson(...); the old rule is deleted only after creation succeeds (insertedorenriched) to prevent data loss. If creation is refused or fails, the original row is preserved and the draft remains open. Unusable-scope rows (repo_scope: null) do not offer editing to prevent silent global promotion.createLessoninwebsite/src/api/client/memory.tsandtypes/index.tsto supportappliesand preserve existingcategory,scope,repo_scope,workspace, andappliesattributes across updates.search_lessons,edit,cancel,edit_rule,edit_failed) across all 13 locale catalogs.temp-screenshots/17982-lessons-evidence/for normal, filtered-empty, and inline-editing states.Backwards compatibility
Compatible: All memory API payloads and props remain backward compatible with existing lesson schemas.
Removes nothing: No existing APIs, components, or fields are removed.
Tests
website/src/test/MemoryTab.lessonsSearchEdit.test.tsxverifying:scope,workspace,category, andapplies.repo_scope: null) rows.tsc -p tsconfig.app.json).Manual verification
Verified via headless browser screenshot capture across normal, filtered-empty, and editing states.
Screenshots / video
Committed evidence under
temp-screenshots/17982-lessons-evidence/:temp-screenshots/17982-lessons-evidence/01-lessons-table-normal.png(Lessons table with search box and actions)temp-screenshots/17982-lessons-evidence/02-lessons-table-filtered-empty.png(Filtered empty state with clear action)temp-screenshots/17982-lessons-evidence/03-lessons-table-editing.png(Inline editing input with Save and Cancel)Related Issues
Closes #17982
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)