Repository navigation
Conversation
When Chat on a crew (PREVIEW_REMOTE_CREW_CHAT) is enabled, the user can dispatch a session to a connected crew, but the Sessions sidebar was missing the crew group unless Remote crew sessions (PREVIEW_INSTANCE_SESSIONS) was also enabled. Gate sidebar crew groups on either PREVIEW_REMOTE_CREW_CHAT or the legacy PREVIEW_INSTANCE_SESSIONS switch so starting a chat on a crew renders the group to return to while preserving existing devices that had the legacy preview flag set. Closes kirodotdev#18750
Design Review (Opus 5.5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The "Remote crew sessions" switch stops working: with Chat on a crew on, it reads off but crew groups still show, and turning it off does nothing. Watch
[DESIGN-REVIEWED] 54f2340 Description read[DESCRIPTION-READ] 4f55545e39ade3e8158465817cf9658303f41f3174dcb03a5828d9bcf18f7540 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK cannot evaluate: missing a screenshot of the crew groups appearing in the Sessions sidebar with "Chat on a crew" on; two settings toggles now give wrong information. Blockers
Evidence gaps
[UX-REVIEWED] 54f2340 Description read[DESCRIPTION-READ] 100ac94ee56c57e8f04083f48b2bce8c3018d3c49f6c7573e14d5e881d870060 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The OR silently overturns the base's recorded "separate flags" decision, and the "Remote crew sessions" switch stops turning anything off whenever Chat on a crew is on. Not justified as shipped
What this change shipsInventory (3 items) — 1 justifiedIntent: let a person who starts a chat on a peer crew find that session again in the Sessions sidebar. FIX.
[FIRST-PRINCIPLES-REVIEWED] 54f2340 Description read[DESCRIPTION-READ] c6dbba12ffe1ce8616ad328f416afb8c86d570e825acfc8cc34888f355b6aced That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review (fork) — 🔴 changes requested (blocking)Reviewed Adjudication upheld 1 of 1 blocking finding(s); those must be resolved before merging. BLOCKING -- website/src/test/ChatSidebar.machineGroups.test.tsx:167 -- Give the chained-query wait an explicit ceiling
Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 — The finding is anchored to [ADJUDICATION] 54f2340 total=1 uphold=1 downgrade=0 |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo blocking findings. One advisory finding: the "Remote instance sessions" switch can no longer turn its feature off. FINDING — website/src/pages/chat-sidebar/sessionSources.ts:28 — with "Chat on a crew" on, [OPUS-REVIEWED] 54f2340 |
54f2340 to
2fa4a9f
Compare
2fa4a9f to
54f2340
Compare
Problem / Motivation
Goal: Ensure the chat sidebar displays connected crew groups whenever the "Chat on a crew" feature preview is turned on.
When a user turned on Chat on a crew (
PREVIEW_REMOTE_CREW_CHAT) but had the legacy Remote crew sessions (PREVIEW_INSTANCE_SESSIONS) preview toggle off, they could launch a remote chat on a peer crew, but the Sessions sidebar displayed no crew group to return to it.Why it matters
Users who start a session on a connected machine lose the primary affordance to access, inspect, or return to that session from the sidebar unless they also happen to discover and turn on the secondary preview flag.
Not a goal
What changed (motivation → approach → change)
website/src/pages/chat-sidebar/sessionSources.ts, evaluatedinstanceSessionsEnabledasremoteCrewChat || legacyInstanceSessions.PREVIEW_INSTANCE_SESSIONSswitch.Backwards compatibility
Compatible: Devices that enabled
PREVIEW_INSTANCE_SESSIONScontinue to show crew groups. No storage keys or APIs are broken.Removes nothing: No existing APIs or preview flags are removed.
Tests
website/src/test/ChatSidebar.machineGroups.test.tsxverifying that crew groups render whenPREVIEW_REMOTE_CREW_CHATis active with legacy preview off.ChatSidebar.machineGroups.test.tsx(14/14 passed)previewSurfaces.test.tsx(34/34 passed)ChatSidebar.instanceSessionsMerge.test.tsx&ChatSidebar.createMenu.test.tsx(54/54 passed)Manual verification
N/A — unit and component test coverage sufficient.
Related Issues
Closes #18750
Pattern harvest
Rule candidate: review-prompt
Pattern: interdependent feature previews where an ingress action gates on one flag while its navigation surface gates on another.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)