Skip to content

feat(side): run read-only shell tools in KAS side turns - #18917

Merged
chenmingwei23 merged 1 commit into
mainfrom
feat/kas-side-chat-readonly-tools
Oct 11, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
feat/kas-side-chat-readonly-tools

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A Side Chat turn on the KAS backend can run read-only shell lookups, as it can on kiro-cli.

On KAS, a Side Chat turn (and a crewmate thread reply) runs REJECT_ALL: no tools at all, and the footer says "Tools are unavailable here on this agent backend". On kiro-cli the same turn runs read-only tools under READ_ONLY. The only reason is membership: ACP_BACKENDS_SIDE_READONLY listed kiro-cli alone.

Why it matters

A KAS user asking the side panel "what's in this file" or "which branch am I on" gets a model that cannot look anything up, while the same question on kiro-cli is answered from the workspace. KAS is a first-class backend, so this is a visible parity gap.

Not a goal

  • read_file / grep_search parity on KAS. Those frames carry no _meta.kiro.toolName, so the gate cannot prove them as reads. Trusting the engine's toolId as a read identity changes the identity-proof layer and goes in its own PR with its own security review.
  • Any change to the READ_ONLY or HOOK_BASED gate logic.
  • Side-chat tools for any other backend (claude, codex, opencode, pi, deepseek).

What changed (motivation → approach → change)

Symptom → root cause: the set's own rule is that a harness joins when every tool call it serves reaches session/request_permission under the derived <agent>--readonly spec. KAS meets it. It takes the derived spec over the wire (acp/kas_agents projects it into _meta.kiro.customAgents), and derive_readonly_spec already empties permissions to {"rules": []} with the other grants. A live probe drove kiro-cli 2.29.0 acp --agent-engine v3 with that projection, answering every request with reject:

Tool call Asked permission Result
read_file yes failed
run_command ls -la yes failed
grep_search yes failed
fs_write yes failed, no file written

The projected agent carried no permissions rule, so nothing on KAS runs without asking the host gate.

A main-chat allow_always does not carry over either. Second probe, one KAS process: a normal session's touch and file write were answered allow_always; then the same calls were made from a --readonly side session, from a second normal session, and from a fresh process.

Session Answer given run_command asked fs_write asked
A, normal allow_always yes yes
B, side --readonly, same process reject yes yes
C, normal again, same process reject yes yes
D, side --readonly, new process reject yes yes

KAS keeps an allow_always for its own session only, so no main-chat grant reaches a side turn. Recorded in the backends.py membership comment and side.md.

Change:

  • ACP_BACKENDS_SIDE_READONLY = {kiro, kas}, with the measurement in the comment (agent_sdk/backends.py).
  • The Side Chat footer (SideChat.tsx) reads the server's own answer, the side_chat_tools line of the configured backend's card (GET /api/acp-backends, built from ACP_BACKENDS_SIDE_READONLY), so KAS shows "Read-only · Lookups work here" instead of "Tools are unavailable" and no frontend copy of the set exists.
  • The side and thread boundary prompts add one sentence: if a file-read, search or fetch tool is refused, use a read-only shell command (cat, grep, ls) instead of retrying it. True on every member backend, and it is what keeps a KAS turn from looping on a refused read_file.
  • Docstrings and side.md / harness-parity.md name KAS beside kiro-cli.

What a KAS side turn may now do: read-only shell commands, approved by the existing READ_ONLY classifier from the _meta.kiro.command the engine states (allow_once).

What it still may not do: file writes, modifying shell commands, deletes, exec (python3 -c ...), MCP tools. All are refused by the read_only_policy fallback, as before. read_file / grep_search are refused too (see Not a goal); the model can read through read-only shell (cat, grep, ls).

What did NOT change: llm_helpers READ_ONLY / HOOK_BASED logic, the hooks.py classifier, _dispatch.py identity parsing, kas_permissions.py, kas_agents.py, side_readonly_spec.py. Normal (main chat) turns on every backend keep the same gate and the same approval card.

Backwards compatibility

Compatible: the change only adds a backend to an allow set; every kiro-cli and non-KAS path is unchanged, and a KAS side turn gains read-only shell where it had nothing.

Removes nothing: no field, key, row or path is removed or narrowed.

Tests

  • test/test_side_readonly_kas.py (new): replays the captured KAS frames through the real parse_session_update + build_permission_event(kas_consent_meta=True) + provider conversion + real HookManager.
    • Side turn (READ_ONLY): ls -la approved; fs_write, touch, rm -rf, python3 -c refused; read_file, grep_search refused.
    • Normal turn (HOOK_BASED): fs_write, touch, python3 -V reach the approver and stay rejected when declined.
    • The derived spec projects no KAS allow rule.
  • test/test_side.py: the side-turn allowance test runs for kiro and kas (derives the spec, streams READ_ONLY).
  • test/test_backend_cards.py::test_the_default_harness_reads_as_the_most_capable: with /compact on KAS (feat(acp): serve manual /compact on KAS via its engine verb #18921) and side tools here, KAS ties kiro-cli at 8 available lines (each has two the other lacks). The test still pins kiro-cli at the top, pins the measured tie explicitly (kiro == kas == 8), and keeps kiro-cli strictly ahead of every other harness.
  • website/src/test/SideChat.footerBackend.test.tsx (new): footer reads "Lookups work" on kiro and kas, "Tools are unavailable" on claude, follows the server's side_chat_tools line rather than any frontend list, shows its own tools-unknown notice when only the backend card fails to load, and the config-unavailable notice only when the config itself fails.
  • SideChat.multiturn / SideChat.stop mocks serve the backend card the footer now reads.

Manual verification

  • Live KAS probe (kiro-cli 2.29.0, --agent-engine v3) with the derived spec, results in the table above.
  • python3 -m pytest on test_side_readonly_kas, test_side, test_side_context, test_side_readonly_spec, test_chat_threads, test_harness_parity, test_kas_permissions, test_llm_helpers_tool_gate: 461 passed.
  • vitest SideChat.footerBackend + SideChat.stop: 7 passed. black, isort, flake8, mypy, eslint, tsc, comment-history gate: clean.

Screenshots / video

Side panel footer, captured from the real SideChat with the config endpoint answering each backend (420px dock).

KAS before (main) → after:

before-kas-dark
after-kas-dark

When the backend card fails to load (config loaded, GET /api/acp-backends failing), the footer says only that the tools could not be checked:

after-cardfail-kas-dark
after-cardfail-kas-light

Light theme, kiro-cli (unchanged) and claude (unchanged)

before-kas-light
after-kas-light
after-kiro-dark
after-claude-dark

Related Issues

Refs #18914

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 10, 2026 19:30
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 10, 2026
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of 17a6aecb04d61fbfb188a6664b6b3c3fde376732 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The new "Couldn't check which tools" notice is red, offers no retry, and doesn't say the side chat still works, so it scares users off a usable panel.

Watch

  • The new notice makes a working panel look broken. context_only_tools_unknown renders through ErrorNotice in red, but this state only means the backend list failed to load. The comment in the diff says "The turn's own posture does not depend on this card", so the side turn still runs normally. The blind reader on shot-03: "no idea what it means for me… It makes me nervous to use the panel at all." Shot-03 and shot-04 also show it beside the "Gateway offline" placeholder, and the reader "can't tell if they are linked or which one matters." Severity is low-frequency × high-friction: users avoid a panel that works. Fix: render it in the neutral muted role="note" style, say what still works, and add a retry that refetches acpBackends.
  • The KAS footer, the PR's main visible change, was read correctly but only as "a guess". In shot-02 the reader understood "Read-only · Lookups work here, but changes don't" but "can't tell what a 'lookup' would be". Next to shot-01 they "can't tell what difference 'Context only' and 'Read-only' would make." Severity is every side-chat open × mild friction, once per user. Fix: name a concrete example in the string, e.g. "Read-only · Can read files and run lookups like ls or grep; can't make changes."

Suggestions

  • context_only_tools_unknown: drop "agent backend" (the reader didn't know the term) and the hand-off clause. Suggested text: "Couldn't confirm which tools Side Chat can use. Questions still send."

[UX-REVIEWED] 17a6aec

Description read

[DESCRIPTION-READ] 767543104b5cb999bcd2af73f26fe0121d58aeb4fd8a8bcc4b6e8f632c8474c4

That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 17a6aecb04d61fbfb188a6664b6b3c3fde376732 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check whether a pinned live probe or contract test keeps the "allow_always stays in its own KAS session" result true on future kiro-cli versions. Right now it was measured once, on 2.29.0.

[DESIGN-REVIEWED] 17a6aec

Description read

[DESCRIPTION-READ] 4231cad7ec858e9983b8b29b1cbc83244c35596973190ce8e92cfda187986d7b

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of 17a6aecb04d61fbfb188a6664b6b3c3fde376732 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The new "Couldn't check which tools…" footer state, with a key in all 15 locales, goes beyond the Goal. Without it the footer would simply stay silent.

Not justified as shipped

  • Item 4 — oversized: the Goal is "a Side Chat turn on the KAS backend can run read-only shell lookups". The cardError ? <ErrorNotice … context_only_tools_unknown …> branch adds a third failure state that the Goal doesn't need. If it were dropped, a failed GET /api/acp-backends would leave postureLoaded false and the footer would say nothing. That's the same silence the footer already has while config loads.
    Subtraction: delete the cardError branch, the side-chat-tools-unknown test, and the context_only_tools_unknown key from all 15 locale files.
    Clears when: the mechanism is removed, or a human amends the Goal.

What this change ships

Inventory (6 items) — 5 justified

Intent: let a KAS user's Side Chat look things up in the workspace through read-only shell commands, as kiro-cli users already can. This is an ADDITION (closing a parity gap).

  1. KAS Side Chat turns run read-only shell commands instead of no tools — justified
  2. KAS crewmate thread replies get the same read-only posture — justified
  3. The Side Chat footer reads the server's side_chat_tools card line instead of guessing kiro-only on the frontend — justified
  4. A new footer notice appears when the backend card fails to load — oversized: a failure state outside the Goal, in 15 locales
  5. The side and thread prompts tell the model to fall back to cat/grep/ls when a read tool is refused — justified
  6. The backend-card test now pins kiro-cli and KAS level at 8 instead of kiro-cli strictly ahead — justified

[FIRST-PRINCIPLES-REVIEWED] 17a6aec

Description read

[DESCRIPTION-READ] aa0c3f379d15a1024525e0e2ae0a85f44c87c869c54df442e5cd4106f7246fed

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 17a6aecb04d61fbfb188a6664b6b3c3fde376732 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 17a6aec

Verdict parsed from the review's SHA-scoped output markers for commit 17a6aecb04d61fbfb188a6664b6b3c3fde376732.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 17a6aecb04d61fbfb188a6664b6b3c3fde376732: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 17a6aecb04d61fbfb188a6664b6b3c3fde376732 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 17a6aec

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 17a6aecb04d61fbfb188a6664b6b3c3fde376732: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 10, 2026
@iamwhatever
iamwhatever force-pushed the feat/kas-side-chat-readonly-tools branch from 8169a3f to d876e9d Compare October 10, 2026 20:14
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 10, 2026
@iamwhatever
iamwhatever force-pushed the feat/kas-side-chat-readonly-tools branch from d876e9d to 7da48c5 Compare October 10, 2026 20:43
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 10, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Dispositions for the CONCERNS on d876e9d9e, both fixed in 7da48c528:

  • Design: the prompt promises tools KAS refuses. Fixed. The side and thread boundary prompts now say: if a file-read, search or fetch tool is refused, use a read-only shell command (cat, grep, ls) instead rather than retrying it. The sentence is true on kiro-cli and KAS alike, so no per-backend prompt is needed, and it steers a KAS turn to the path the gate approves.
  • Design suggestion / First Principles item 3: hand-copied SIDE_READONLY_BACKENDS. Fixed. The set is deleted. SideChat.tsx reads the configured backend's side_chat_tools line from GET /api/acp-backends (backend_cards.LINE_SIDE_CHAT_TOOLS, built from ACP_BACKENDS_SIDE_READONLY), so the footer and the gate share one answer. A card that cannot load shows the config-unavailable notice, and a missing line reads as no tools. SideChat.footerBackend.test.tsx pins that the footer follows the server line, not a frontend list.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 10, 2026
@iamwhatever
iamwhatever force-pushed the feat/kas-side-chat-readonly-tools branch from 7da48c5 to 5c09d73 Compare October 10, 2026 21:13
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Dispositions for 7da48c528, addressed in 5c09d737a:

  • UX Watch: the config-unavailable notice was wrong when only GET /api/acp-backends failed. Fixed. Only a config failure shows context_only_config_unavailable now (the turn then really runs with no tools). A backend-card failure shows no footer at all, so nothing false is claimed; the turn's posture does not depend on that endpoint. SideChat.footerBackend.test.tsx pins both cases.
  • UX suggestion: "Context only" vs "Read-only" read as synonyms. Deferred: the no-tools string is unchanged by this PR, and rewording it touches every locale. Worth doing the next time that string is edited.
  • First Principles item 3 (hand-copied set). That verdict names d876e9d9e; the set was deleted in 7da48c528 and the footer reads the side_chat_tools card line.
  • GPT 6.1 / Opus 5.5 red on 7da48c528. Infrastructure, not findings: GPT logged "No findings" and then failed to write its comment under the installation rate limit; Opus failed its permission check on the same limit.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 10, 2026
@iamwhatever
iamwhatever force-pushed the feat/kas-side-chat-readonly-tools branch from 5c09d73 to ae7851e Compare October 10, 2026 21:52
@iamwhatever

Copy link
Copy Markdown
Contributor Author

GPT 6.1 BLOCKING on 5c09d737a (SideChat.tsx:106, surface backend-card query failures): verified in code and fixed in ae7851e3d.

  • A failed GET /api/acp-backends now renders its own inline ErrorNotice (side-chat-tools-unknown): "Couldn't check which tools this agent backend allows here. Use the main chat to take action." The config-specific notice stays for a config failure only, so the UX lane's earlier point (that the config copy was false when only the card failed) still holds.
  • No agent hand-off on it, for the same reason as the config notice beside it: the composer still works and the turn's own posture does not depend on that endpoint.
  • New key pages.chat.sideChat.context_only_tools_unknown in en.manual.json and every locale; en-XA regenerated with npm run i18n:pseudo; i18n:check and the src/i18n suite pass.
  • SideChat.footerBackend.test.tsx pins both branches: card failure shows the tools-unknown notice and no config notice; config failure shows the config notice and not the tools-unknown one.

Backend Tests shard 4 (Linux and Windows) red on test/test_approval_decide_owner_bound.py is main-side: the same 3 tests fail on origin/main and on #18810's own merge commit, before this PR.

@iamwhatever
iamwhatever force-pushed the feat/kas-side-chat-readonly-tools branch from ae7851e to 20a909b Compare October 10, 2026 22:06
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Dispositions for ae7851e3d, addressed in 20a909be5 (rebased on main with #18944, which fixes the main-side approval-test red):

  • UX BLOCK: no screenshot of the tools-unknown footer. Fixed: the PR description now shows it in dark and light, captured from the real SideChat with the config loading and GET /api/acp-backends answering 503.
  • UX suggestion: "agent backend" is jargon in context_only_tools_unknown. Kept as is for now: the string matches the wording of its sibling context_only_tools_unavailable_backend ("on this agent backend"), and rewording only one of the pair would make the two footers read inconsistently. Rewording both is a copy change for a later PR.
  • Design Watch: the probe never tested a carried-over allow_always. Measured live on kiro-cli 2.29.0 --agent-engine v3, one process: a normal session's run_command and fs_write answered allow_always; then the same calls from a --readonly side session, a second normal session, and a fresh process each raised session/request_permission again (table in the PR description). KAS keeps the grant for its own session only. Recorded in the backends.py membership comment and side.md.
  • First Principles item 4: the tools-unknown branch and key are oversized. Kept. The branch exists because the GPT 6.1 lane upheld a blocking finding on 5c09d737a under the blocking errors-use-error-notice rule: a failed load in code this PR adds must show in the page. The alternative of showing the existing no-tools line was refused by the UX lane on 7da48c528, because it is false on kiro and KAS. So the smallest change that satisfies both is one notice with its own string.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 10, 2026
@iamwhatever
iamwhatever force-pushed the feat/kas-side-chat-readonly-tools branch from 7083101 to 3313d9c Compare October 10, 2026 22:42
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 10, 2026
@iamwhatever
iamwhatever force-pushed the feat/kas-side-chat-readonly-tools branch from 3313d9c to d62f251 Compare October 11, 2026 00:58
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 11, 2026
@iamwhatever
iamwhatever force-pushed the feat/kas-side-chat-readonly-tools branch from d62f251 to 902fca5 Compare October 11, 2026 03:18
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 11, 2026
KAS takes the derived <agent>--readonly spec as a projected custom agent
with its permissions emptied, so every tool call it serves reaches
session/request_permission. Add KAS to ACP_BACKENDS_SIDE_READONLY and
mirror the set in the Side Chat footer. The READ_ONLY gate is unchanged:
on KAS it approves read-only shell commands; read_file and grep_search
stay refused because their frames name no trusted tool.
@iamwhatever
iamwhatever force-pushed the feat/kas-side-chat-readonly-tools branch from 902fca5 to 17a6aec Compare October 11, 2026 03:31
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Dispositions for 902fca568, addressed in 17a6aecb0 (rebased on main d8185f12c):

  • GPT 6.1 BLOCKING (test_backend_cards.py:335, re-pin instead of exempting KAS). Fixed as suggested: the test now asserts counts[ACP_BACKEND_KIRO] == counts[ACP_BACKEND_KAS] == 8 and keeps the strict kiro > count comparison for every other backend. Any later change to either count has to re-pin it, so the ratchet stays tight.
  • UX Watch / First Principles item 3 (tools-unknown notice). Same points as on earlier heads, answered in the round-4 and round-5 dispositions above: the blocking errors-use-error-notice rule upheld on 5c09d737a requires the failed load to render through ErrorNotice, and silence was the state that rule refused. No change.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 11, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Self-review (crew-pr-reviewer, read-only): RECOMMEND APPROVE

This PR closes the Side Chat parity gap on KAS. A KAS side turn or thread reply used to run REJECT_ALL only because ACP_BACKENDS_SIDE_READONLY listed kiro-cli alone. Adding KAS (src/kiro_crew/agent_sdk/backends.py:2223) is the root-cause fix, because the derived <agent>--readonly spec already empties permissions, and the live probes in the body show every KAS tool call, fs_write included, still reaching session/request_permission. I read the full diff. The READ_ONLY/HOOK_BASED gate, the _dispatch.py KAS shell resolution and kas_permissions.py are unchanged, so writes, modifying shell, exec and MCP still go through the existing read_only_policy fallback. test/test_side_readonly_kas.py replays captured KAS frames through the real parse_session_update, build_permission_event and HookManager. It allows ls -la and refuses fs_write, touch, rm -rf, python3 -c, read_file and grep_search, and it would fail on base, where the side turn is REJECT_ALL. The footer now reads the server's side_chat_tools card line through the shared ['acpBackends'] query instead of keeping its own frontend copy of the set. The base is main, all checks are green, there are no change requests, and the GPT and Opus lanes have no findings on 17a6aec. Two advisory items on this head are still unanswered: UX CONCERNS says the new tools-unknown ErrorNotice is red although the panel still works, and First Principles item 4 repeats its earlier subtraction. Each should get a one-line disposition before merge. Reviewer note: membership rests on a measurement of kiro-cli 2.29.0, namely that the engine's _meta.kiro.command is the command KAS runs and that allow_always is session-scoped. The code owner should check that, and that a future KAS engine can't drift from it without a test noticing, because only replayed frames pin it today. — crew-pr-reviewer

@iamwhatever
iamwhatever enabled auto-merge (squash) October 11, 2026 05:16
@chenmingwei23
chenmingwei23 merged commit 9937f6a into main Oct 11, 2026
114 of 124 checks passed
@chenmingwei23
chenmingwei23 deleted the feat/kas-side-chat-readonly-tools branch October 11, 2026 05:44
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants