Repository navigation
feat(skills): surface waiting generated skills on the Skills rail row - #18972
Conversation
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The rail-footer failure notice adds a page-wide error surface the Goal never asked for; without it, a failed read just shows no pill, exactly as today. Not justified as shipped
What this change shipsInventory (6 items) — 4 justifiedIntent: let a user notice generated skills waiting for approval without opening the Skills tab. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 651264f Description read[DESCRIPTION-READ] f7795dc47872ad17e3be379f6167e6df92759635c368971a6c37077e9e075b6d That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that a failing [DESIGN-REVIEWED] 651264f Description read[DESCRIPTION-READ] 495d156f5085445b97ee7a4aad12e6938d3254094815c599f4c8adf695133d3b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The blind reader only guessed what the rail's "2" counts, and the failure notice shows the raw error "gateway unavailable" with nothing the user can do. Watch
Suggestions
[UX-REVIEWED] 651264f Description read[DESCRIPTION-READ] 4ff5bec60f0f339f7995142f85b8a81299aaf8cfa5d9cce51673523ad2a40f40 That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
14e393c to
f939375
Compare
f939375 to
f1d495f
Compare
f1d495f to
698a4e8
Compare
iamwhatever
left a comment
There was a problem hiding this comment.
This adds a count pill to the Agent Capabilities rail's Skills row showing how many generated skill candidates wait for approval, so they can be seen from any tab. It also adds a New badge beside the existing Update badge in the review queue. That solves the real gap: the queue only renders while the Skills tab is open, and the page often opens on another tab. I read the whole diff. The page uses the same ['skills-pending'] query key and api.skillsPending() fetcher as SkillsTab, so both read one cache entry, and the existing skills.pending_changed WebSocket invalidation refreshes both. The pill has the "Skills awaiting review (N)" accessible name and title, renders nothing at 0, and does not move the update dot. The backend handler catches its own errors and returns an empty list, so the red footer notice only shows on a transport failure, not in any normal configuration. Tests cover the pill from another tab, the zero case, the failure notice and the success case. Before/after screenshots are attached, all latest checks are green, and GPT/Opus/Design/First Principles have no findings. UX's CONCERNS (a bare number, and a failure notice with a raw error and no retry) are fair polish but have no disposition yet. I suggest the author answer them or file a follow-up, but they are advisory, not a defect. — crew-pr-reviewer (deep re-check)
698a4e8 to
658534b
Compare
Generated skill candidates wait in the Skills tab's review queue, which renders only while that tab is open. The Agent Capabilities rail's Skills row now carries a count pill of waiting candidates (accessible name says what it counts), and a candidate that adds a new skill is badged New beside the existing Update badge. Closes #5643
658534b to
651264f
Compare
|
Rebased on main. The ui-index regen commit was dropped because main now carries the same regen. One test-only change goes beyond the conflict: the new |
iamwhatever
left a comment
There was a problem hiding this comment.
This shows how many generated skill candidates wait for approval as a count pill on the Agent Capabilities rail's Skills row, visible from any tab, and adds a New badge beside the existing Update badge in the review queue, which solves the real gap that the queue only renders while the Skills tab is open. I read the whole diff on head 651264f: CapabilitiesPage uses the same ['skills-pending'] key and api.skillsPending() fetcher as SkillsTab, so both read one cache entry and the existing invalidations (approve, dismiss, the skills.pending_changed frame) refresh the pill too; the pill renders nothing at 0, carries the "Skills awaiting review (N)" accessible name, and does not disturb the update dot on either the desktop rail or the mobile list. The rebase since our dismissed review changed only a test wait (an explicit 5 s bound on findByText('New') for the two chained queries), no production code. Tests cover the pill from another tab, the zero case, the failure notice and the New badge, all checks are green, and no change request is open. The UX CONCERNS (a bare number whose meaning lives only in title/aria-label, and the raw error text in the footer notice) and the First Principles subtraction of the footer notice are reasonable polish with no disposition yet; I suggest the author answer them here or in a follow-up, but none is a defect. — crew-pr-reviewer (deep re-check)
Problem / Motivation
Goal: A user can see that generated skills are waiting for their approval without first opening the Skills tab, and can tell a brand-new skill from an update to an existing one.
Kiro Crew can draft skills from finished sessions and stage them in a review queue for approval. That queue renders only inside Agent Capabilities > Skills, and the page opens on Crewmates (or the last tab used). Nothing anywhere else on the page says a candidate is waiting, so generated skills sit unseen until the user happens to open the Skills tab. Inside the queue, an update proposal carries an "Update" badge, but a candidate that would add a new skill carries no marker at all.
Why it matters
A generated skill does nothing until a person approves it. If the user never notices the queue, the feature silently produces nothing, and candidates age out after the pending TTL without ever being seen.
Not a goal
What changed (motivation → approach → change)
Gap: the waiting count exists (the queue fetches it) but is only drawn inside the Skills tab. Approach: put the count where the user already looks for capabilities, on the Skills row of the Agent Capabilities rail, and mark new candidates in the queue.
Options considered:
Change:
SidePanelLayoutgains an optionalbadge: { count, label }on a tab. It renders a count pill (same look as the main rail's badge) in both the desktop rail and the mobile list, nothing at a count of 0, withrole="status"and the label as its accessible name so a screen reader hears what the number counts.CapabilitiesPagereads the pending queue with the same query key and fetcher as the Skills tab (['skills-pending']), so the two share one cache entry and the existingskills.pending_changedlive frame refreshes both.ErrorNotice("Couldn't check for skills awaiting review", with the failure underneath) instead of a silent 0 that would read as "nothing is waiting". The notice has no Ask-the-agent hand-off: the footer sits beside whichever tab is open, the hand-off navigates to chat, and the Skills editor keeps an in-progress edit only in local state with no leave guard, so the click would discard that draft.SkillsTabmarks a candidate that adds a skill with a "New"Badge(the shared status primitive); update proposals keep their "Update" badge.skills_awaiting_review,skills_awaiting_review_failedandnew_candidatein every locale catalog, with context notes for translators; the pseudolocale is regenerated.Backwards compatibility
Compatible:
badgeis a new optional field onSidePanelTab; every existing tab omits it and renders as before.Removes nothing: the diff only adds a pill, a badge, a failure notice, three strings and one read of an endpoint the page already calls.
Tests
CapabilitiesPage.pendingSkillsBadge.test.tsx(new): with two candidates waiting and the Crewmates tab open, the Skills row carries a pill reading 2 named "Skills awaiting review (2)"; an empty queue shows no pill and no failure notice; a failed read shows no pill and shows the failure notice with the error text and no hand-off.SkillsTabPendingUpdates.test.tsx: a plain new candidate is marked New; an update candidate is not.tsc, eslint on the touched files,i18n-check,lint:i18n,lint:theme-colors,lint:phantom-classesandlint:restyle-ratchetare clean;npm run gen:uiproduces no diff from this change.Manual verification
Rendered the real
CapabilitiesPagein a headless browser against stubbed API responses (two candidates: one new, one update; and a 503 from the queue endpoint), before and after the change, in dark and light themes. Screenshots below.Screenshots / video
Another tab open (Crewmates), two candidates waiting. Before: nothing on the Skills row. After: a count pill.
Skills tab. Before: the new candidate has no badge. After: New beside Update, and the row keeps its count.
The queue cannot be read (the endpoint answers 503): the rail footer says the check failed, and no count is shown.
Light theme
Related Issues
Closes #5643
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.