Repository navigation
docs(rfc): accept rfc-mate-landing-once, with the welcome-owed condition - #19064
Conversation
buluoray approved #18903 and asked for the status to be flipped. Folds in the one gap that review raised: a Mate whose welcome was never owed is refused before the marker claim, so "still coming" now means owed, unclaimed and no row; anything else gets the ordinary landing. Adds the "release the marker on failure" alternative to section 4.
|
@buluoray #18903 merged as draft, so this flips rfc-mate-landing-once to accepted as you asked. It also folds in the owed gap from your earlier review: 'still coming' = owed, marker unclaimed, no row; anything else (never owed, claimed, a row, or unreadable) gets the ordinary landing. §4 adds 'release the marker on failure' (rejected: a failing backend fails every retry, so the pin returns). §5 adds the no-owed-record test. Could you confirm the owed part here? #18904 implements it. |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that buluoray approves the added "owed" condition: their approval on #18903 came before this text was written, so it may not cover it. [DESIGN-REVIEWED] 2b2aa9c Description read[DESCRIPTION-READ] 2e8bbd1f8e4afdd9015d5d5df7dce50ad74776fc4a9185b5821f700b9f6d9cbb That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Record buluoray's acceptance of
rfc-mate-landing-once.mdon main, with the one condition their review asked for.#18903 merged with
status: draft. buluoray approved it (review) and asked for the status to be flipped toaccepted. Their prior review also found one gap: a Mate whose welcome is never owed is refusedNOT_OWEDbefore the marker claim, so under the merged text it stays "not sent yet" forever, the same pin through another path.Why it matters
The implementation, #18904, is a product-shape change. Its First Principles lane reads only a non-draft RFC on the base, so it stays blocked until this lands. Without the owed condition, an older Mate would still pin users.
Not a goal
What changed (motivation → approach → change)
docs/request-for-change/rfc-mate-landing-once.md:status: accepted; §2 "still coming" = owed, marker unclaimed, no row, and anything else (or unreadable) gets the ordinary landing; §4 adds "release the marker when the welcome fails" and why it is rejected; §5 adds the no-owed-record test. Claims checked ata84f616557.docs/request-for-change/README.md: row status and audit line.Backwards compatibility
Compatible: docs only.
Removes nothing: edits one RFC document and its index row.
Tests
N/A — docs only.
scripts/docs-lint.shpasses.Manual verification
N/A — docs only. Read at
a84f616557:maybe_start_first_greetingreturnsNOT_OWEDbeforeclaim_greeting_marker.Related Issues
Follows #18903. Implementation: #18904.
Checklist
Contribution License Agreement
Contributed under the project's Apache-2.0 license.