Skip to content

docs(rfc): accept rfc-mate-landing-once, with the welcome-owed condition - #19064

Merged
chenmingwei23 merged 1 commit into
mainfrom
docs/rfc-mate-landing-once-accept
Oct 11, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
docs/rfc-mate-landing-once-accept

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record buluoray's acceptance of rfc-mate-landing-once.md on main, with the one condition their review asked for.

#18903 merged with status: draft. buluoray approved it (review) and asked for the status to be flipped to accepted. Their prior review also found one gap: a Mate whose welcome is never owed is refused NOT_OWED before the marker claim, so under the merged text it stays "not sent yet" forever, the same pin through another path.

Why it matters

The implementation, #18904, is a product-shape change. Its First Principles lane reads only a non-draft RFC on the base, so it stays blocked until this lands. Without the owed condition, an older Mate would still pin users.

Not a goal

What changed (motivation → approach → change)

  • docs/request-for-change/rfc-mate-landing-once.md: status: accepted; §2 "still coming" = owed, marker unclaimed, no row, and anything else (or unreadable) gets the ordinary landing; §4 adds "release the marker when the welcome fails" and why it is rejected; §5 adds the no-owed-record test. Claims checked at a84f616557.
  • docs/request-for-change/README.md: row status and audit line.

Backwards compatibility

Compatible: docs only.

Removes nothing: edits one RFC document and its index row.

Tests

N/A — docs only. scripts/docs-lint.sh passes.

Manual verification

N/A — docs only. Read at a84f616557: maybe_start_first_greeting returns NOT_OWED before claim_greeting_marker.

Related Issues

Follows #18903. Implementation: #18904.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

buluoray approved #18903 and asked for the status to be flipped. Folds in
the one gap that review raised: a Mate whose welcome was never owed is
refused before the marker claim, so "still coming" now means owed,
unclaimed and no row; anything else gets the ordinary landing. Adds the
"release the marker on failure" alternative to section 4.
@iamwhatever

Copy link
Copy Markdown
Contributor Author

@buluoray #18903 merged as draft, so this flips rfc-mate-landing-once to accepted as you asked. It also folds in the owed gap from your earlier review: 'still coming' = owed, marker unclaimed, no row; anything else (never owed, claimed, a row, or unreadable) gets the ordinary landing. §4 adds 'release the marker on failure' (rejected: a failing backend fails every retry, so the pin returns). §5 adds the no-owed-record test. Could you confirm the owed part here? #18904 implements it.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 2b2aa9cdc12437bd2c6a7fbc3cd43defd4272425 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 2b2aa9cdc12437bd2c6a7fbc3cd43defd4272425 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 2b2aa9cdc12437bd2c6a7fbc3cd43defd4272425 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that buluoray approves the added "owed" condition: their approval on #18903 came before this text was written, so it may not cover it.

[DESIGN-REVIEWED] 2b2aa9c

Description read

[DESCRIPTION-READ] 2e8bbd1f8e4afdd9015d5d5df7dce50ad74776fc4a9185b5821f700b9f6d9cbb

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 2b2aa9cdc12437bd2c6a7fbc3cd43defd4272425 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 2b2aa9c

Verdict parsed from the review's SHA-scoped output markers for commit 2b2aa9cdc12437bd2c6a7fbc3cd43defd4272425.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2b2aa9cdc12437bd2c6a7fbc3cd43defd4272425: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 2b2aa9cdc12437bd2c6a7fbc3cd43defd4272425 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2b2aa9c

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2b2aa9cdc12437bd2c6a7fbc3cd43defd4272425: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 11, 2026
@chenmingwei23
chenmingwei23 merged commit 787c57d into main Oct 11, 2026
100 checks passed
@chenmingwei23
chenmingwei23 deleted the docs/rfc-mate-landing-once-accept branch October 11, 2026 08:53
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants