Repository navigation
feat(members): list unread crewmates under the switcher chip, unfold the pill - #19073
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that up to five floating pills covering the first rows at scroll-top still leave a short thread's opening message readable at 820 px. [DESIGN-REVIEWED] 074980a Description read[DESCRIPTION-READ] 558791e8972b022764e8d3cbf17e3faa3a2a0ada61ea68ac61359f3661b0a960 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that #19045 records the maintainers setting aside #18219's reason for the visible "Crewmates" label. Removing the label and count rests only on that thread. What this change shipsInventory (9 items) — 9 justifiedIntent: on a crewmate DM, the user sees which crewmates have unread messages and reaches each in one click, and can still tell whose thread is open. This is an ADDITION, plus two reversals that #19045 decided.
[FIRST-PRINCIPLES-REVIEWED] 074980a Description read[DESCRIPTION-READ] 74a3942f888698dfab5efdd917e26c41bc83dae1f1fd9e669e36fa7b5dab3973 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS At scroll-top the unread pills sit on top of the thread's opening text, and the blind reader read that as a broken page. Watch
Suggestions
[UX-REVIEWED] 074980a Description read[DESCRIPTION-READ] d2870d409106ef140482f13a82836a3c1568e6e9b83f0ae9f215850c76a589de That sha256 names everything this verdict read: the PR description, plus the 14 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsPlural forms (advisory): the "+N more" pill has the wrong grammar in some languages when N is 1. FINDING — website/src/pages/members/CrewmateSwitcher.tsx:1095 — the pill calls [OPUS-REVIEWED] 074980a Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
7ea5447 to
1981852
Compare
1981852 to
945be5b
Compare
945be5b to
dcc7291
Compare
dcc7291 to
456f668
Compare
…the pill The folded roster chip on a crewmate DM said "Crewmates 5": the page's own name and the roster size, neither of which is what a reader comes to that corner for. Users missed crewmate messages because the only unread cue was a dot inside the closed list. The chip is now the other crewmates' faces and a chevron; the roster word slides in on hover or focus and stays the accessible name. Under it hangs one small pill per crewmate with an unread message who is not the open one, named by the crewmate, opening that thread on click. Past four, the rest fold into one "+N" pill that opens the list, whose rows carry the same dot. No unread, no column. Each pill grows in from the row above when a reply lands and shrinks out when its thread is read. The column hangs from the header's bottom edge and adds nothing to its measured height: the conversation keeps scrolling up under the band, and under these pills, the way it scrolls under the identity pill. Desktop only, like the chip. The centre identity pill keeps face, name and activity line open at rest: folded to its face, nothing on the page said which crewmate the user was talking to. Its face gets a wider inset. The loop ring is unchanged. Spec, uiLocations registry (with the chip's desktop + open-crewmate placement conditions), 13 catalogs and the capture harnesses that read the chip's count follow. Closes #19045
456f668 to
074980a
Compare
Problem / Motivation
Goal: On a crewmate DM, a user sees at a glance which crewmates have said something they have not read, and reaches each in one click — while still being told which crewmate the open thread belongs to.
On a crewmate DM the folded roster chip (top-left of the thread header) read "Crewmates 5": the page's own name and the roster size. Neither is what a reader comes to that corner for. The only unread cue was a dot inside the closed list, so users missed crewmate messages (Zezhen, Slack, 2026-10-10: "我经常会 miss 消息"). Separately, #18549 folded the centre identity pill to its face at rest; with the name hidden the user could not tell which crewmate the page was talking to.
Why it matters
Crewmates work on their own and speak up unasked. A reply nobody notices is a question unanswered, an approval not given, a result not read. Today the page hides that signal one click away, and the one control that said whose thread is open hid its name too.
Not a goal
mc-unread-slots/signalsOf) — unchanged.What changed (motivation → approach → change)
Switcher chip (
CrewmateSwitcher.tsx)grid-cols-[0fr]→[1fr], cut under reduced motion) and stays the chip'saria-label./membersdropped into a thread" — was weighed and set aside by the maintainers in the Slack thread that opened Crewmate switcher chip: drop the label and count, list unread crewmates under it #19045 (Zezhen and Joe, 2026-10-10: "名字 Crewmates 和多少 mate 去掉"): the chevron marks the chip as a door, the word is one hover away, and the pills below (the thing the chip could never say) are now the chip's first-glance meaning. The decision is the issue's; this PR records it in the spec.openRequestcounter prop lets the page open the list from outside (the "+N" pill below).Unread column (
CrewmateUnreadColumn, same file; placed byMembersPage.tsx)"<crewmate>, Unread message"(fmtList), tooltipunread_message. Click →onPick, the same path as a list row; the page clears the unread and the pill leaves.+N morepill (switcher_more_unread, new key in 13 catalogs) that opens the chip's list — whose rows already carry the unread dot. A very long unread list is never more than five rows here; the list is where it scrolls.absolute left-3 top-full -mt-2), so it adds nothing to the header's measured height. The thread's top inset stays the chip row's and the conversation scrolls up under the band — and under these Glass pills — the way it already scrolls under the identity pill. At scroll-top, the first rows of a thread sit under the pills while those other threads stay unread (frames below show exactly that, wide and 820 px); they come clear as each pill is read away or on scroll.motion.divrow insideAnimatePresence. It grows in from the row above (height + opacity, 220 ms) when a crewmate's reply lands, and shrinks out the same way when its thread is read. Reduced motion cuts to the end state.Identity pill (
MembersPage.tsx)pl-3.5 pr-3.5). The solid loop ring from feat(crew): fold the crewmate header pill to its face, and draw the loop mark as a solid ring #18549 is unchanged.Also: spec (
crew-mode.md), uiLocations registry (members.switcher.unread,members.switcher.unread-more, both gated like the chip onviewport: desktop+crewmate_selected) + regenerated index, the two capture harnesses that read the removed count, new harnesscapture-switcher-unread-column.mjs(every frame below is asserted before it is written, including the geometry claims).Backwards compatibility
Compatible: frontend-only; no API, schema, storage key or config shape changes. The
crewmate-switcher-count/crewmate-switcher-labeltest ids keep their names where they survive; the one removed (member-pill-text) was introduced two days ago by #18549 and had no reader outside its own test.Tests
CrewmateSwitcher.test.tsx: no count; label folded at rest with the hover/focus/open classes;openRequestopens the list on a bump, not on mount;CrewmateUnreadColumn— one named pill per unread non-open crewmate in roster order, click reports the pick; nothing with nothing unread or for the open crewmate alone; hidden rows get no pill; cap at four ++2 morecallsonMore; each pill in its own clipped animated row.MembersPage.test.tsx: the switcher carries no count; the column slot is the header's absolutetop-fullchild (adds no height).MembersPage.loop.test.tsx: the fold-at-rest case is removed; the loop-ring cases stay.tsc,eslinton touched files,i18n-check(baseorigin/main),gen-ui-index --check,docs-lint, brand gate. Test suites run in CI.Manual verification
node website/scripts/capture-switcher-unread-column.mjs <out> <dist>against the built SPA: 97 assertions (chip has no count, label folded at rest and open on hover, pill counts and names, header height unchanged by the column, first message not pushed, click opens the named thread,+Nopens the list, a livechat_messageframe grows a pill in). Its frames are the section below.Screenshots / video
Real built SPA behind
serveDistwith fixtures, @2x, every scene at scroll-top. Unread seeded viamc-unread-slots, the way the websocket marker leaves it; the arrival GIF pushes a realchat_messageframe over the stubbed websocket.A crewmate replies in another thread — its pill grows in under the chip (light, dark):
No unread — chip is faces + chevron; identity pill shows name + activity at rest:
Two unread at scroll-top — pills float over the thread; the first message keeps its place (asserted: header bottom 101, first row y=130 with or without pills):
Worst case at scroll-top: six unread — four pills and
+2 more(uncropped) — over the first rows, wide and 820 px:Hovering a pill; clicking it opens that crewmate's thread and the pill goes:
+2 moreopens the list with every unread dot:The roster word sliding in on chip hover (same element, grows out of the chip):
Related Issues
Closes #19045. Reverses the at-rest fold of #18549 (pill) and the visible label of #18219 (chip), both as decided in #19045.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.