Skip to content

feat(members): list unread crewmates under the switcher chip, unfold the pill - #19073

Merged
CrysisDeu merged 1 commit into
mainfrom
feat/19045-switcher-unread-column
Oct 12, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
feat/19045-switcher-unread-column

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On a crewmate DM, a user sees at a glance which crewmates have said something they have not read, and reaches each in one click — while still being told which crewmate the open thread belongs to.

On a crewmate DM the folded roster chip (top-left of the thread header) read "Crewmates 5": the page's own name and the roster size. Neither is what a reader comes to that corner for. The only unread cue was a dot inside the closed list, so users missed crewmate messages (Zezhen, Slack, 2026-10-10: "我经常会 miss 消息"). Separately, #18549 folded the centre identity pill to its face at rest; with the name hidden the user could not tell which crewmate the page was talking to.

Why it matters

Crewmates work on their own and speak up unasked. A reply nobody notices is a question unanswered, an approval not given, a result not read. Today the page hides that signal one click away, and the one control that said whose thread is open hid its name too.

Not a goal

  • Changing which crewmates count as unread (mc-unread-slots / signalsOf) — unchanged.
  • The loop ring from feat(crew): fold the crewmate header pill to its face, and draw the loop mark as a solid ring #18549 (its second half) — unchanged.
  • A phone treatment of the unread column — the roster is the phone's unread surface (its rows carry the dots).
  • Growing the thread's top inset for the column: the owner rejected that revision ("不要把 chat 往下推,本来 chat 就是可以直接穿透到最上面的").

What changed (motivation → approach → change)

Switcher chip (CrewmateSwitcher.tsx)

  • At rest: the other crewmates' faces and a chevron. No "Crewmates" word, no count. The roster word slides in on hover / keyboard focus / while the list is open (grid-cols-[0fr] → [1fr], cut under reduced motion) and stays the chip's aria-label.
  • This reverses the visible label fix(members): name the folded crewmate switcher as the roster #18219 added. Its reason — "faces plus a number alone did not read as the crew list to a first-time visitor whom a bare /members dropped into a thread" — was weighed and set aside by the maintainers in the Slack thread that opened Crewmate switcher chip: drop the label and count, list unread crewmates under it #19045 (Zezhen and Joe, 2026-10-10: "名字 Crewmates 和多少 mate 去掉"): the chevron marks the chip as a door, the word is one hover away, and the pills below (the thing the chip could never say) are now the chip's first-glance meaning. The decision is the issue's; this PR records it in the spec.
  • An openRequest counter prop lets the page open the list from outside (the "+N" pill below).

Unread column (CrewmateUnreadColumn, same file; placed by MembersPage.tsx)

  • Chosen over two mockups (A: an unread count on the chip; C: the face stack showing only unread faces) because it names who and reaches them in one click.
  • One small Glass pill per crewmate with an unread message who is not the open one, roster order: face with the accent unread dot, then the display name. Button name is "<crewmate>, Unread message" (fmtList), tooltip unread_message. Click → onPick, the same path as a list row; the page clears the unread and the pill leaves.
  • Cap: four pills, then one +N more pill (switcher_more_unread, new key in 13 catalogs) that opens the chip's list — whose rows already carry the unread dot. A very long unread list is never more than five rows here; the list is where it scrolls.
  • Floats over the thread, never pushes it. The column hangs from the header's bottom edge, absolutely (absolute left-3 top-full -mt-2), so it adds nothing to the header's measured height. The thread's top inset stays the chip row's and the conversation scrolls up under the band — and under these Glass pills — the way it already scrolls under the identity pill. At scroll-top, the first rows of a thread sit under the pills while those other threads stay unread (frames below show exactly that, wide and 820 px); they come clear as each pill is read away or on scroll.
  • Animated: each pill is a motion.div row inside AnimatePresence. It grows in from the row above (height + opacity, 220 ms) when a crewmate's reply lands, and shrinks out the same way when its thread is read. Reduced motion cuts to the end state.
  • No unread → nothing drawn. Desktop only, like the chip; faded out with the chip while the roster column is pinned. The chip's corner dot stays reserved for needs-you.

Identity pill (MembersPage.tsx)

Also: spec (crew-mode.md), uiLocations registry (members.switcher.unread, members.switcher.unread-more, both gated like the chip on viewport: desktop + crewmate_selected) + regenerated index, the two capture harnesses that read the removed count, new harness capture-switcher-unread-column.mjs (every frame below is asserted before it is written, including the geometry claims).

Backwards compatibility

Compatible: frontend-only; no API, schema, storage key or config shape changes. The crewmate-switcher-count / crewmate-switcher-label test ids keep their names where they survive; the one removed (member-pill-text) was introduced two days ago by #18549 and had no reader outside its own test.

Tests

  • CrewmateSwitcher.test.tsx: no count; label folded at rest with the hover/focus/open classes; openRequest opens the list on a bump, not on mount; CrewmateUnreadColumn — one named pill per unread non-open crewmate in roster order, click reports the pick; nothing with nothing unread or for the open crewmate alone; hidden rows get no pill; cap at four + +2 more calls onMore; each pill in its own clipped animated row.
  • MembersPage.test.tsx: the switcher carries no count; the column slot is the header's absolute top-full child (adds no height). MembersPage.loop.test.tsx: the fold-at-rest case is removed; the loop-ring cases stay.
  • Static gates run locally: tsc, eslint on touched files, i18n-check (base origin/main), gen-ui-index --check, docs-lint, brand gate. Test suites run in CI.

Manual verification

node website/scripts/capture-switcher-unread-column.mjs <out> <dist> against the built SPA: 97 assertions (chip has no count, label folded at rest and open on hover, pill counts and names, header height unchanged by the column, first message not pushed, click opens the named thread, +N opens the list, a live chat_message frame grows a pill in). Its frames are the section below.

Screenshots / video

Real built SPA behind serveDist with fixtures, @2x, every scene at scroll-top. Unread seeded via mc-unread-slots, the way the websocket marker leaves it; the arrival GIF pushes a real chat_message frame over the stubbed websocket.

A crewmate replies in another thread — its pill grows in under the chip (light, dark):

a reply lands: the Build Watcher pill grows in, light
a reply lands: the Build Watcher pill grows in, dark

No unread — chip is faces + chevron; identity pill shows name + activity at rest:

no unread: faces + chevron, identity pill open

Two unread at scroll-top — pills float over the thread; the first message keeps its place (asserted: header bottom 101, first row y=130 with or without pills):

two unread pills floating over the thread, light
two unread pills floating over the thread, dark

Worst case at scroll-top: six unread — four pills and +2 more (uncropped) — over the first rows, wide and 820 px:

six unread at scroll-top, wide: four pills and +2 more over the first rows
six unread at scroll-top, 820 px pane

Hovering a pill; clicking it opens that crewmate's thread and the pill goes:

hover on the Build Watcher pill
after the click: Build Watcher is open, one pill left

+2 more opens the list with every unread dot:

+2 more opens the list

The roster word sliding in on chip hover (same element, grows out of the chip):

chip hover: Crewmates slides in

Related Issues

Closes #19045. Reverses the at-rest fold of #18549 (pill) and the visible label of #18219 (chip), both as decided in #19045.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners October 11, 2026 08:56
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 11, 2026
@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 074980a61a5142e1a83a2350f9ba090773288bb8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that up to five floating pills covering the first rows at scroll-top still leave a short thread's opening message readable at 820 px.

[DESIGN-REVIEWED] 074980a

Description read

[DESCRIPTION-READ] 558791e8972b022764e8d3cbf17e3faa3a2a0ada61ea68ac61359f3661b0a960

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 074980a61a5142e1a83a2350f9ba090773288bb8 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check that #19045 records the maintainers setting aside #18219's reason for the visible "Crewmates" label. Removing the label and count rests only on that thread.

What this change ships

Inventory (9 items) — 9 justified

Intent: on a crewmate DM, the user sees which crewmates have unread messages and reaches each in one click, and can still tell whose thread is open. This is an ADDITION, plus two reversals that #19045 decided.

  1. A column of unread-crewmate pills now hangs under the switcher chip (desktop, never the open crewmate) — justified
  2. Clicking a pill opens that crewmate's thread and the pill animates out — justified
  3. Past four unread, a "+N more" pill opens the switcher list — justified
  4. The pills float over the thread at scroll-top, so the header height stays the same — justified
  5. The chip at rest shows faces and a chevron only; the "Crewmates" word and the count are gone — justified
  6. The roster word slides in on hover, focus, or while the list is open — justified
  7. The identity pill shows the name and activity line at rest again (feat(crew): fold the crewmate header pill to its face, and draw the loop mark as a solid ring #18549's fold is reversed) — justified
  8. The identity pill has a wider inner inset — justified
  9. New switcher_more_unread string in 13 catalogs, plus two uiLocations entries — justified

[FIRST-PRINCIPLES-REVIEWED] 074980a

Description read

[DESCRIPTION-READ] 74a3942f888698dfab5efdd917e26c41bc83dae1f1fd9e669e36fa7b5dab3973

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of 074980a61a5142e1a83a2350f9ba090773288bb8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

At scroll-top the unread pills sit on top of the thread's opening text, and the blind reader read that as a broken page.

Watch

  • Pills hide the first message. Because the column is absolute left-3 top-full, it adds no height, so the pills sit over the first rows. At 820 px the blind reader said of shot-07: "This looks broken: I can't read the message… now reads '…ding ChatSidebar first'". This happens on every crewmate DM while another thread is unread, which is exactly when the feature is useful. The owner chose not to push the chat down, so the fix is a soft scrim behind the column or a scroll-top offset that clears the text.
  • Nothing says what the column is. The reader said "Nothing labels these pills, so I don't know why these two show and not others", and in shot-05 "The purple dot is harder to see on the dark background." The only words for it, "Unread message", are in a tooltip. This persists for first-time users. Raise the dot's contrast in dark mode.
  • The closed chip is hard to read cold. The reader said "when it's closed I wouldn't know what it is", and it still guessed correctly that a list drops down. This is a known, maintainer-decided trade-off. Recorded for humans.

Suggestions

  • Recapture shot-09 with the picked crewmate's own fixture thread. As shot, the header says Build Watcher over Mate's messages ("I can't tell whose conversation I'm looking at"), so the screenshot doesn't show the identity pill doing its job.

[UX-REVIEWED] 074980a

Description read

[DESCRIPTION-READ] d2870d409106ef140482f13a82836a3c1568e6e9b83f0ae9f215850c76a589de

That sha256 names everything this verdict read: the PR description, plus the 14 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 074980a61a5142e1a83a2350f9ba090773288bb8 — this comment is updated in place on each push.

Review details

Plural forms (advisory): the "+N more" pill has the wrong grammar in some languages when N is 1.

FINDING — website/src/pages/members/CrewmateSwitcher.tsx:1095 — the pill calls t('pages.membersPage.switcher_more_unread', { n: rest }) with n instead of count, so i18next never picks a plural form. With 5 unread crewmates (UNREAD_PILLS = 4), rest is 1, and the fixed strings come out as French "+1 autres", Italian "+1 altri" and German "+1 weitere". → Fix: pass { count: rest }, use {{count}} in the string, add _one/_other (plus each language's other CLDR forms) in every locale, and register the key in pluralKeys.json.

[OPUS-REVIEWED] 074980a

Verdict parsed from the review's SHA-scoped output markers for commit 074980a61a5142e1a83a2350f9ba090773288bb8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 074980a61a5142e1a83a2350f9ba090773288bb8: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 074980a61a5142e1a83a2350f9ba090773288bb8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 074980a

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 074980a61a5142e1a83a2350f9ba090773288bb8: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 11, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/19045-switcher-unread-column branch from 7ea5447 to 1981852 Compare October 11, 2026 09:57
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 11, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/19045-switcher-unread-column branch from 1981852 to 945be5b Compare October 11, 2026 23:46
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 11, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/19045-switcher-unread-column branch from 945be5b to dcc7291 Compare October 12, 2026 00:01
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 12, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/19045-switcher-unread-column branch from dcc7291 to 456f668 Compare October 12, 2026 00:31
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 12, 2026
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 12, 2026
…the pill

The folded roster chip on a crewmate DM said "Crewmates 5": the page's
own name and the roster size, neither of which is what a reader comes
to that corner for. Users missed crewmate messages because the only
unread cue was a dot inside the closed list.

The chip is now the other crewmates' faces and a chevron; the roster
word slides in on hover or focus and stays the accessible name. Under
it hangs one small pill per crewmate with an unread message who is not
the open one, named by the crewmate, opening that thread on click. Past
four, the rest fold into one "+N" pill that opens the list, whose rows
carry the same dot. No unread, no column. Each pill grows in from the
row above when a reply lands and shrinks out when its thread is read.
The column hangs from the header's bottom edge and adds nothing to its
measured height: the conversation keeps scrolling up under the band,
and under these pills, the way it scrolls under the identity pill.
Desktop only, like the chip.

The centre identity pill keeps face, name and activity line open at
rest: folded to its face, nothing on the page said which crewmate the
user was talking to. Its face gets a wider inset. The loop ring is
unchanged.

Spec, uiLocations registry (with the chip's desktop + open-crewmate
placement conditions), 13 catalogs and the capture harnesses that read
the chip's count follow.

Closes #19045
@CrysisDeu
CrysisDeu force-pushed the feat/19045-switcher-unread-column branch from 456f668 to 074980a Compare October 12, 2026 01:26
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 12, 2026
@CrysisDeu
CrysisDeu merged commit e75458b into main Oct 12, 2026
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crewmate switcher chip: drop the label and count, list unread crewmates under it

3 participants