Repository navigation
fix(ci): re-measure the App-chunk bundle ceiling that fails main - #19088
iamwhatever wants to merge 1 commit into
Conversation
The Per-chunk size gate fails on main's own tip: the analyze build emits the App chunk at 2,144,668 B against its 2094 KB (2,144,256 B) ceiling, 412 B over, so every PR that runs the gate on its merge ref inherits the red. Attribution is measured: the parent of #18651 builds App at 2,144,170 B (86 B under); #18651 adds +498 B and crosses the line. The ~103 KB since the last re-measure is eleven days of first-party chat-shell and sidebar features (451 -> 504 modules), no new library. Raise App to 2200 KB, ~5% over the current measurement, the convention every other entry follows. Closes #19077
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. [UX-REVIEWED] d6d27be Description read[DESCRIPTION-READ] 188a78c3554ea5d618108c0592e04be3d7ce09aad4b26c23d0264ea0591214e3 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. Suggestions
[DESIGN-REVIEWED] d6d27be Description read[DESCRIPTION-READ] d588ec9039715c9ab635bdaeb1c12a6da72e12dcb6739394fa07c09c5eb6d8e9 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
Superseded by #19089 (merged 2026-10-11), which re-measured the same App bundle-size ceiling. Closing as redundant. |
Problem / Motivation
Goal: Unblock CI by re-measuring the stale
App-chunk ceiling in the per-chunk bundle-size gate so it matches what main already builds.Bundle Size Gate(stepPer-chunk size gate) fails on main's own tip @f07162523a: theAppchunk builds to 2,144,668 B against its 2094 KB (2,144,256 B) ceiling inwebsite/scripts/check-bundle-size.mjs, 412 B over. Push CI on main skips this job, so the red shows only on PR merge refs: every PR touchingwebsite/fails the gate and PR Readiness (e.g. #19040, #19071, whose own diffs add nothing toApp).Why it matters
Bundle Size Gateis a required check. While main itself is over the ceiling, every frontend PR fails it through no fault of its own, blocking otherwise-green work until the ceiling is corrected.Not a goal
Appin this PR (see below for the one real shrink available).What changed (motivation → approach → change)
origin/main@f07162523awith CI's own steps (vite build --mode analyze, thennode scripts/check-bundle-size.mjs):FAIL assets/App-BdGEviK_.js: 2.05 MB exceeds its 2.04 MB budget by 412 B.67bc5c291^) buildsAppat 2,144,170 B, 86 B under; feat(crew): the crewmate greeting is a message in its chat, not a card #18651 adds +498 B and crosses the line. The ~103 KB since the last re-measure (fix(ci): re-measure the stale App-chunk bundle ceiling that fails main #15514, 2,041,857 B on 2026-09-30) is eleven days of first-party chat-shell and sidebar features, 451 -> 504 modules, no new library.App: 2094 * KB->App: 2200 * KB(2,252,800 B), ~5% over the current 2,144,668 B measurement, the same convention every other entry and the prior re-measure follow. A ceiling with less headroom fails again on the next feature PR, which is the recurrence the file's notes document.@xterm/xtermis ~372 KB (unminified) ofApp, pulled eagerly byApp.tsx->BottomTerminalPanel->CliPanel. It has been there since June, so it is not the new growth, and a lazy boundary there touches terminal lifecycle exports (disposeTerminalSession,useDeleteTerminalSession) thatBottomTerminalPanelimports statically.Backwards compatibility
Compatible: only a CI size ceiling is raised; no runtime code, contract or accepted input changes.
Removes nothing: the diff raises one budget number and adds a comment.
Tests
vitest run src/test/checkBundleSize.test.ts src/test/bundleReport.test.ts(Node 24): 39 passed. No test pins theAppnumber, so none moved.Manual verification
vite build --mode analyze+node scripts/check-bundle-size.mjson this branch:878 chunks within budget.node scripts/check-chunk-cycles.mjs: no cycles.67bc5c291^:App2,144,170 B, gate passes (attribution above).Related Issues
Closes #19077
Pattern harvest
Not generalizable: a size ceiling running out of headroom through ordinary growth is the gate working as designed; the recurring part (a stale ceiling only noticed on PR merge refs, because push CI on main skips this job) is already tracked in the file's notes.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.