Skip to content

fix(website): stub the batched path-kind probe in chip menu tests - #19298

Closed
cruisercohen wants to merge 1 commit into
mainfrom
fix/main-filepathmenu-inapp
Closed

cruisercohen wants to merge 1 commit into
mainfrom
fix/main-filepathmenu-inapp

Conversation

@cruisercohen

Copy link
Copy Markdown
Contributor

Summary

Repairs main after #19121 and #19215 landed together: Frontend Tests (4) has been red since then, with four "path chip menu threads the renderer handlers" cases in FilePathMenu.inApp.test.tsx timing out while waiting for a resolved path chip.

The cause is the test's stub, not the component. #19121's chip tests stubbed the old per-path probe (a GET answered with an X-Path-Kind header). #18734 had already moved chips to one batched POST /api/file-kinds request. #19121's head was pushed before #18734 merged, so its CI ran on a base without #18734. On main the batch request got no well-formed reply, every chip resolved to missing, and no chip ever appeared to right-click. #19215 only moved the "Open in editor" logic into a shared hook. It does not touch the probe or the chips.

The fix points the stub at the shared batch helper (stubPathKinds) that the other chip tests already use. A path:12 citation still resolves to the file plus its line, because the literal path:12 spelling is answered as missing. There is no product code change, and both behaviours stay covered: the in-app side-panel rows for remote chips (#19121) and the "Open in editor" row and session-document path button (#19215).

Testing

  • npx vitest run on FilePathMenu.inApp, FilePathMenu, SessionDocPath, editorOpenerParity, MarkdownRenderer.contextmenu and ArtifactsPage: 6 files, 112 tests pass. Before the fix, the 4 chip cases failed on current main.
  • eslint on the touched file: clean.
  • tsc -p tsconfig.app.json: clean.

The Backend Tests red on main (the app cron manifest test) is separate and is already being fixed in #19280. This PR does not touch it.

…hip tests

The path-chip cases in FilePathMenu.inApp.test.tsx stubbed the old
per-path probe (a GET answered by an X-Path-Kind header), but chips now
resolve through one batched POST /api/file-kinds request (#18734). The
stub never answered it, every chip stayed missing, and four cases timed
out on main once #19121 landed. Use the shared stubPathKinds helper the
other chip tests use. No product code changes.
@cruisercohen
cruisercohen requested review from a team and KiroCrewCaptain as code owners October 12, 2026 06:21
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 12, 2026
@cruisercohen cruisercohen changed the title fix(website): answer the batched path-kind probe in the in-app menu chip tests fix(website): stub the batched path-kind probe in chip menu tests Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 23f4d139384ced77c1251cda516ce04140b5534f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 23f4d13

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 23f4d139384ced77c1251cda516ce04140b5534f: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 23f4d139384ced77c1251cda516ce04140b5534f ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 23f4d139384ced77c1251cda516ce04140b5534f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 23f4d13

Description read

[DESCRIPTION-READ] 2685f5df6524d4a3145e34c35631b4746e5cf9b2cb8cd5a5e6a4594e4596ab03

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 23f4d139384ced77c1251cda516ce04140b5534f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Nothing to check.

[UX-REVIEWED] 23f4d13

Description read

[DESCRIPTION-READ] 8d8c78cd72f75532a461a05e0fe8589168bac11dd9daebb33a1cbf3f0ed04b63

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 23f4d139384ced77c1251cda516ce04140b5534f — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 23f4d13

Verdict parsed from the review's SHA-scoped output markers for commit 23f4d139384ced77c1251cda516ce04140b5534f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 23f4d139384ced77c1251cda516ce04140b5534f: <one-sentence reason>

@buluoray

Copy link
Copy Markdown
Contributor

This is the same fix as #19288 (switch stubKind to the shared stubPathKinds helper), which was opened earlier and is now approved with auto-merge queued. Suggest closing this one once #19288 lands.

@CrysisDeu

Copy link
Copy Markdown
Contributor

Heads-up: #19288 (opened 06:04Z, human-approved) carries the same one-hunk fix for this break and closes the tracking issue #19284. Leaving the choice of which to land to the maintainers; whichever merges first, the other can be closed as a duplicate.

@cruisercohen

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #19288, which carries the same fix and was opened first.

@cruisercohen
cruisercohen deleted the fix/main-filepathmenu-inapp branch October 12, 2026 07:12
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants