Repository navigation
fix(website): stub the batched path-kind probe in chip menu tests - #19298
cruisercohen wants to merge 1 commit into
Conversation
…hip tests The path-chip cases in FilePathMenu.inApp.test.tsx stubbed the old per-path probe (a GET answered by an X-Path-Kind header), but chips now resolve through one batched POST /api/file-kinds request (#18734). The stub never answered it, every chip stayed missing, and four cases timed out on main once #19121 landed. Use the shared stubPathKinds helper the other chip tests use. No product code changes.
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 23f4d13 Description read[DESCRIPTION-READ] 2685f5df6524d4a3145e34c35631b4746e5cf9b2cb8cd5a5e6a4594e4596ab03 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. [UX-REVIEWED] 23f4d13 Description read[DESCRIPTION-READ] 8d8c78cd72f75532a461a05e0fe8589168bac11dd9daebb33a1cbf3f0ed04b63 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
Closing as a duplicate of #19288, which carries the same fix and was opened first. |
Summary
Repairs main after #19121 and #19215 landed together: Frontend Tests (4) has been red since then, with four "path chip menu threads the renderer handlers" cases in
FilePathMenu.inApp.test.tsxtiming out while waiting for a resolved path chip.The cause is the test's stub, not the component. #19121's chip tests stubbed the old per-path probe (a GET answered with an
X-Path-Kindheader). #18734 had already moved chips to one batchedPOST /api/file-kindsrequest. #19121's head was pushed before #18734 merged, so its CI ran on a base without #18734. On main the batch request got no well-formed reply, every chip resolved tomissing, and no chip ever appeared to right-click. #19215 only moved the "Open in editor" logic into a shared hook. It does not touch the probe or the chips.The fix points the stub at the shared batch helper (
stubPathKinds) that the other chip tests already use. Apath:12citation still resolves to the file plus its line, because the literalpath:12spelling is answered as missing. There is no product code change, and both behaviours stay covered: the in-app side-panel rows for remote chips (#19121) and the "Open in editor" row and session-document path button (#19215).Testing
npx vitest runonFilePathMenu.inApp,FilePathMenu,SessionDocPath,editorOpenerParity,MarkdownRenderer.contextmenuandArtifactsPage: 6 files, 112 tests pass. Before the fix, the 4 chip cases failed on current main.eslinton the touched file: clean.tsc -p tsconfig.app.json: clean.The Backend Tests red on main (the app cron manifest test) is separate and is already being fixed in #19280. This PR does not touch it.