Skip to content

fix(sidebar): hide open session's row actions unless a guide points at them - #19312

Merged
bolichen97 merged 1 commit into
mainfrom
fix/sidebar-active-row-actions-hover
Oct 12, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/sidebar-active-row-actions-hover

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The open session's sidebar row shows its action group (⋯, fork, ✕) on hover like every other row, and stays shown only while a guide step points at it.

The open row's action group never hides. It sits over the row's title and time all the time, while every other row shows it only on hover.

Why it matters

Everyone who uses the sidebar sees it on the row they look at most. The open row looks cluttered and behaves unlike its siblings.

Not a goal

  • Changing which controls the row's action group holds, or how other rows behave.

What changed (motivation → approach → change)

The open row's group was forced visible. #18443 added isActive ? '!opacity-100' : '' so a guide could point at sessions.row-menu with no pointer on the row. That kept it visible all the time, not only during a guide.

Now the override needs two things: the row is open, and a guide step this tab is showing targets a sessions.row-* control. That covers a location step, a ui.find step whose opener is the row menu, and a ui.find step located on a row control (fork, ✕). A guide owned by another tab does not count. The check is guideStepOnRowControl in website/src/pages/chat-sidebar/rows.ts. The owning spec, docs/system-specs/modules/learn-cron-dashboard.md, says the same. ChatSidebar reads it once and passes it to rows through RowShell, so rows re-render only when it flips.

Backwards compatibility

Compatible: no API, setting or stored value changes; only when the open row's group is visible.

Reader: website/src/uiLocations/areas/sessions.ts:sessions.row-menu -- chat -- a guide step on it sets guideOnRowControl, so the open row keeps the group shown | rows.test.ts "guideStepOnRowControl"

Tests

  • rows.test.ts guideStepOnRowControl: false with no step; true for a sessions.row-menu location step, a ui.find step whose opener is it, and a ui.find step located on sessions.row-close; false for other controls.
  • npx vitest run src/test/ChatSidebar src/pages/chat-sidebar: 117 files, 1357 tests pass. tsc -p tsconfig.app.json and eslint pass.

Manual verification

Checked on the built SPA with a stubbed API (scripted Playwright). Each frame asserts the group's computed opacity first: 0 at rest, 1 on hover, 1 during a sessions.row-menu guide step with the pointer away.

Screenshots / video

Open row at rest, pointer away. The group is hidden:

open row at rest

Pointer on the open row. The group shows:

open row on hover

A guide step on "More options", pointer away. The group stays shown and the guide points at ⋯:

guide step on the row menu

Related Issues

Closes #19330

Pattern harvest

Rule candidate: review-prompt
Pattern: a hover-revealed control forced always visible so a guide can find it, instead of only while a guide step targets it.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 12, 2026 07:01
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of facdd4b35b9e3fe676ebe8d671a9f70110824c2b — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Before merging, check that tabbing to the open row still shows ⋯, fork and ✕. No screenshot shows the keyboard-focus state.

[UX-REVIEWED] facdd4b

Description read

[DESCRIPTION-READ] b31229aae10017a1f512c702c99b642d426ac37af887fa1a9d1dc7eafd71ff3a

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of facdd4b35b9e3fe676ebe8d671a9f70110824c2b — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that a target_missing recovery step aimed at sessions.row-* still un-hides the open row's ⋯. The gate passes when !needsEnter, which ignores leftStep and step status.

[DESIGN-REVIEWED] facdd4b

Description read

[DESCRIPTION-READ] a82d02f56a893eb16c4cf972e6d4f9dffb1279727bcc085836bb98af0e7c1030

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of facdd4b35b9e3fe676ebe8d671a9f70110824c2b — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check by hand that a guide step on fork or ✕ still shows the open row's actions; the tests cover only the predicate, not the rendered opacity.

What this change ships

Inventory (5 items) — 5 justified

Intent: the open session's sidebar row shows its actions only on hover, like every other row, and keeps them shown while a guide points at them. This is a FIX (Closes #19330).

  1. The open row's ⋯/fork/✕ group is hidden at rest and appears on hover, focus or an open menu — justified
  2. The group stays shown with no pointer while an entered guide step this tab owns targets a sessions.row-* control — justified
  3. A guide owned by another tab, or one not yet entered, no longer forces the group visible — justified
  4. RowShell.guideOnRowControl and the exported guideStepOnRowControl (one consumer, ChatSidebar.tsx) — justified
  5. The owning spec paragraph in learn-cron-dashboard.md is updated to the new rule — justified

[FIRST-PRINCIPLES-REVIEWED] facdd4b

Description read

[DESCRIPTION-READ] 8306e9ca8557ccb166b9ca6e074e6a04abc50767a79378282d243d3303e06c9d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of facdd4b35b9e3fe676ebe8d671a9f70110824c2b and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] facdd4b

False positive or not applicable? A repository writer can comment:
/ai-review override gpt facdd4b35b9e3fe676ebe8d671a9f70110824c2b: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed facdd4b35b9e3fe676ebe8d671a9f70110824c2b — this comment is updated in place on each push.

Review details

No findings to block on. One advisory finding.

FINDING — website/src/pages/chat-sidebar/rows.ts:938 — a ui.find sent with only a label (location_id is optional in both guide_catalog.py and resolveUiFind), such as "Close session", produces query without a location. So t.query.location is undefined and guideStepOnRowControl returns false. The open row's ✕ then stays opacity-0, but isDisplayed never checks opacity, so searchByName still matches it and the guide outlines a control the person cannot see until they hover the row. Before this PR, isActive ? '!opacity-100' kept that button visible. → Fix: also count a find step whose resolved match carries a sessions.row-* location, or keep the open row's actions shown during any entered find step.

[OPUS-REVIEWED] facdd4b

Verdict parsed from the review's SHA-scoped output markers for commit facdd4b35b9e3fe676ebe8d671a9f70110824c2b.

False positive or not applicable? A repository writer can comment:
/ai-review override fable facdd4b35b9e3fe676ebe8d671a9f70110824c2b: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 12, 2026
@iamwhatever
iamwhatever force-pushed the fix/sidebar-active-row-actions-hover branch from df1d01c to 048a342 Compare October 12, 2026 07:35
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 12, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: no

  • Cause: missing visual evidence for the default-visibility change span=3b7e5e9005e6

fixed in 048a342: three attached frames, each asserting the group's computed opacity first -- 0 at rest, 1 on hover, 1 during a sessions.row-menu guide step with the pointer away.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: no

  • Mechanism: evidence file listed 0 media span=0c7c569fe9aa

fixed in 048a342: three attached frames, each asserting the group's computed opacity first -- 0 at rest, 1 on hover, 1 during a sessions.row-menu guide step with the pointer away.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: no

  • Consequence: two things could not be judged span=bdd599d078f0

fixed in 048a342: three attached frames, each asserting the group's computed opacity first -- 0 at rest, 1 on hover, 1 during a sessions.row-menu guide step with the pointer away.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: no

  • Whether the open row reads correctly without its actions span=ec137580844b

fixed in 048a342: frame 01 shows the open row at rest; title and time read cleanly with the group hidden, same as sibling rows.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: no

  • Whether the guide spotlight lands on a visible ⋯ span=97954384a3ec

fixed in 048a342: frame 03 shows the guide arrow on ⋯ with the group at opacity 1 and the pointer away.
guideStepOnRowControl reads location.id and find-container.opener; rows.test.ts covers both.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: no

  • Fix: attach before/after captures span=4877af89497d

fixed in 048a342: three attached frames, each asserting the group's computed opacity first -- 0 at rest, 1 on hover, 1 during a sessions.row-menu guide step with the pointer away.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: no

  • useGuide() in memo'd SessionRow re-renders every row span=382573bce162

fixed in 048a342: useGuide() moved out of SessionRow into ChatSidebar; rows get one boolean via RowShell.guideOnRowControl, so rows re-render only when it flips.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: no

  • Clears when the row reads a narrow derived value span=0e37bd86cd73

fixed in 048a342: the row reads the narrow boolean RowShell.guideOnRowControl, computed once by guideStepOnRowControl in the parent.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: no

  • The open row's actions get harder to find span=b2d06f05d81c

rebutted: hiding the group at rest is the goal of this PR, and it is how every other row already behaves.
Frame 02 shows hover reveals it; keyboard focus and an open menu still reveal it through the unchanged group-focus-visible / has-[[data-state=open]] classes.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: no

  • guideOnRowControl misses a ui.find step whose opener is sessions.row-menu span=63c73dc89e22

fixed in 048a342: guideStepOnRowControl also matches a find-container target whose opener starts with sessions.row-.
rows.test.ts "is true for a ui.find step whose opener is the row menu" locks it in.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Not yet tried in a browser

fixed in 048a342: frame 03 runs a real sessions.row-menu guide on the built SPA; the open row's ⋯ stays shown and the guide arrow resolves to it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: yes

  • useGuide() in ChatSidebar re-renders the sidebar on guide-context updates

rebutted: the cost is bounded. GuideContext value is useMemo'd (GuideContext.tsx:736), and pending guides refetch only while one is live, every 30s (GuideContext.tsx:282).
Rows do not re-render on those updates: rowShell is memoized on the boolean guideOnRowControl, which flips only when the step moves on or off a sessions.row-* control, and SessionRow is memo'd.

@iamwhatever
iamwhatever force-pushed the fix/sidebar-active-row-actions-hover branch from 048a342 to bbdb3aa Compare October 12, 2026 07:53
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 12, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: yes

  • guideStepOnRowControl misses a ui.find step on sessions.row-duplicate / row-close span=d4188e25583a

fixed in bbdb3aa: guideStepOnRowControl also reads query.location of a find target.
rows.test.ts "is true for a ui.find step located on a row control" locks it in.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: yes

  • view.step is read even when this tab does not own the guide span=63c73dc89e22

fixed in bbdb3aa: the step counts only when view.ownedHere && !view.needsEnter, the same condition GuideLayer uses to draw a pointer.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 12, 2026
@iamwhatever
iamwhatever force-pushed the fix/sidebar-active-row-actions-hover branch from bbdb3aa to 2a90755 Compare October 12, 2026 15:30
@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: no

  • owning spec still says the open row keeps its actions shown span=c3b0cae4175d

fixed in 2a90755: docs/system-specs/modules/learn-cron-dashboard.md now states the open row shows its actions only while an entered, owned guide step targets a sessions.row-* control, and otherwise on hover, focus or an open menu.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • guide steps on sessions.row-duplicate (fork)

rebutted: fork takes the same path as ✕. guideStepOnRowControl matches the sessions.row- prefix for every target kind, and rows.test.ts covers that path with sessions.row-close and sessions.row-menu.
A separate fork case would repeat the same string test.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • a ui.find step on the open row resolves its target while the group is hidden

rebutted: the guide's target check (isDisplayed in website/src/guide/liveRegistry.ts) reads display, visibility, size, hidden and inert, never opacity, so the opacity-0 group still resolves.
Frame 03 shows a real sessions.row-menu guide resolving to ⋯ on the built SPA.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: guideStepOnRowControl matches row-control ids only

  • label-only ui.find on a row control returns false span=d4188e25583a

rebutted (disproportional): a label-only find names no control id, so the row cannot tell it targets its own group without matching free text against row labels -- a new mechanism beyond this PR's goal.
Every row control is a registered location (sessions.row-menu, row-duplicate, row-close), and those guides carry its id, which this check covers.
Worst case is cosmetic: the outline lands where ✕ sits and hover reveals it, as on every other row.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • a future sessions.row- id outside the action group would force the group shown*

rebutted: sessions.row-* is the namespace of the row's action group by construction (areas/sessions.ts), and the owning spec now states the rule, so a new id there is a row control by definition.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • a label-only ui.find for a row control returns false

rebutted (disproportional): see the opus disposition for span d4188e25583a -- a label-only find names no control, and matching labels to row controls is new scope; registered row controls carry their id and are covered.

@iamwhatever
iamwhatever force-pushed the fix/sidebar-active-row-actions-hover branch from 2a90755 to facdd4b Compare October 12, 2026 15:54
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/pages/ChatSidebar.tsx, website/src/pages/chat-sidebar/rows.ts, website/src/pages/chat-sidebar/rows.test.ts, website/src/pages/chat-sidebar/folderConductor.ts, website/src/pages/chat-sidebar/folderConductor.test.ts since this head went green (450aff6 -> 38eb463); CI re-running.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 12, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff: change matches its stated goal, tests cover the new behaviour, readiness passed at this head.

@bolichen97
bolichen97 merged commit 5c54c2e into main Oct 12, 2026
102 checks passed
@bolichen97
bolichen97 deleted the fix/sidebar-active-row-actions-hover branch October 12, 2026 18:07
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidebar: open session row keeps its action group visible without hover

2 participants