Repository navigation
fix(sidebar): hide open session's row actions unless a guide points at them - #19312
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Before merging, check that tabbing to the open row still shows ⋯, fork and ✕. No screenshot shows the keyboard-focus state. [UX-REVIEWED] facdd4b Description read[DESCRIPTION-READ] b31229aae10017a1f512c702c99b642d426ac37af887fa1a9d1dc7eafd71ff3a That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that a [DESIGN-REVIEWED] facdd4b Description read[DESCRIPTION-READ] a82d02f56a893eb16c4cf972e6d4f9dffb1279727bcc085836bb98af0e7c1030 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check by hand that a guide step on fork or ✕ still shows the open row's actions; the tests cover only the predicate, not the rendered opacity. What this change shipsInventory (5 items) — 5 justifiedIntent: the open session's sidebar row shows its actions only on hover, like every other row, and keeps them shown while a guide points at them. This is a FIX (Closes #19330).
[FIRST-PRINCIPLES-REVIEWED] facdd4b Description read[DESCRIPTION-READ] 8306e9ca8557ccb166b9ca6e074e6a04abc50767a79378282d243d3303e06c9d That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings to block on. One advisory finding. FINDING — website/src/pages/chat-sidebar/rows.ts:938 — a [OPUS-REVIEWED] facdd4b Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
df1d01c to
048a342
Compare
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
|
self-added: yes
|
048a342 to
bbdb3aa
Compare
|
self-added: yes
|
|
self-added: yes
|
bbdb3aa to
2a90755
Compare
|
self-added: no
|
|
|
|
self-added: yes
|
|
|
2a90755 to
facdd4b
Compare
|
Rebased: main moved in website/src/pages/ChatSidebar.tsx, website/src/pages/chat-sidebar/rows.ts, website/src/pages/chat-sidebar/rows.test.ts, website/src/pages/chat-sidebar/folderConductor.ts, website/src/pages/chat-sidebar/folderConductor.test.ts since this head went green (450aff6 -> 38eb463); CI re-running. |
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed the diff: change matches its stated goal, tests cover the new behaviour, readiness passed at this head.
Problem / Motivation
Goal: The open session's sidebar row shows its action group (⋯, fork, ✕) on hover like every other row, and stays shown only while a guide step points at it.
The open row's action group never hides. It sits over the row's title and time all the time, while every other row shows it only on hover.
Why it matters
Everyone who uses the sidebar sees it on the row they look at most. The open row looks cluttered and behaves unlike its siblings.
Not a goal
What changed (motivation → approach → change)
The open row's group was forced visible. #18443 added
isActive ? '!opacity-100' : ''so a guide could point atsessions.row-menuwith no pointer on the row. That kept it visible all the time, not only during a guide.Now the override needs two things: the row is open, and a guide step this tab is showing targets a
sessions.row-*control. That covers alocationstep, aui.findstep whose opener is the row menu, and aui.findstep located on a row control (fork, ✕). A guide owned by another tab does not count. The check isguideStepOnRowControlinwebsite/src/pages/chat-sidebar/rows.ts. The owning spec,docs/system-specs/modules/learn-cron-dashboard.md, says the same.ChatSidebarreads it once and passes it to rows throughRowShell, so rows re-render only when it flips.Backwards compatibility
Compatible: no API, setting or stored value changes; only when the open row's group is visible.
Reader: website/src/uiLocations/areas/sessions.ts:sessions.row-menu -- chat -- a guide step on it sets guideOnRowControl, so the open row keeps the group shown | rows.test.ts "guideStepOnRowControl"
Tests
rows.test.tsguideStepOnRowControl: false with no step; true for asessions.row-menulocation step, aui.findstep whose opener is it, and aui.findstep located onsessions.row-close; false for other controls.npx vitest run src/test/ChatSidebar src/pages/chat-sidebar: 117 files, 1357 tests pass.tsc -p tsconfig.app.jsonand eslint pass.Manual verification
Checked on the built SPA with a stubbed API (scripted Playwright). Each frame asserts the group's computed opacity first: 0 at rest, 1 on hover, 1 during a
sessions.row-menuguide step with the pointer away.Screenshots / video
Open row at rest, pointer away. The group is hidden:
Pointer on the open row. The group shows:
A guide step on "More options", pointer away. The group stays shown and the guide points at ⋯:
Related Issues
Closes #19330
Pattern harvest
Rule candidate: review-prompt
Pattern: a hover-revealed control forced always visible so a guide can find it, instead of only while a guide step targets it.
Checklist