Skip to content

fix(dashboard): card the sessions whose card the route serves - #19417

Merged
iamwhatever merged 2 commits into
mainfrom
fix/19403-root-only-dashboards
Oct 12, 2026
Merged

iamwhatever merged 2 commits into
mainfrom
fix/19403-root-only-dashboards

Conversation

@chenmingwei23

@chenmingwei23 chenmingwei23 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The All Dashboards page lists only the sessions that actually have a dashboard, so it never offers a page the gateway refuses.

/session-dashboards built its card list from every session node and applied no root test, so a session another session dispatched (created_by) or adopted (session-tree parent) got its own card, its own "Open session" link and a dashboard frame. Both other surfaces deny that session a dashboard: the chat side panel withholds the Overview, and GET /api/chat/slots/{slot}/dashboard answers 404 not_root_session.

Why it matters

The page contradicts the side panel for the same session. A user following a conductor and its workers sees every worker listed as a dashboard owner, opens one, and finds a surface that cannot exist. The page also spent a dashboard-card read per non-root session, each one refused.

Not a goal

  • No change to WHICH sessions own a dashboard. The rule is the gateway's and the side panel's already; this PR only makes the fleet page ask it.
  • No change to the Needs you inbox's scope. A dispatched worker's question is still answered from this page.
  • No new field, fold or request. The root test reads the slot rows the page already subscribes to.

What changed (motivation -> approach -> change)

Symptom: a dispatched worker appears under "All sessions" with its own card, on a page whose description promises dashboards.

Root cause: the page filtered on nothing, and the fault conflated two objects.

  • The dashboard PACKAGE is a root session's: GET .../dashboard answers 404 not_root_session (member_dashboard.py:257) and the side panel withholds its Overview. That denial is real and is what QA saw.
  • The derived CARD is another object on another route. GET .../dashboard-card has no root test; its gate is _derived_allowed (card_lifecycle.py:804), privacy and remoteness only, and publish_derived says a conductor dispatched by another session "is exactly the case that must still get its board". SessionStatusFrame fetches for exactly that session, and this page is its only mount.

So the bug was the CLAIM, not the listing: an entry offered to a session with no card at all (adopted, incognito, remote), described as a dashboard of its own.

Change: the page asks the card question through the one predicate the frame fetches on, canCarryCard in command-center/model.ts -- not private, not remote, no session-tree parent. The frame calls it too, so a list and its cards cannot disagree.

Then a second-order effect, found by @iamwhatever in review and not by me or the lanes: nodes now holds only card-eligible sessions, so a fleet of only incognito, remote or adopted sessions hit pages.sessionsPage.empty_title and read "All sessions 0 / No sessions" while those sessions were open and had been listed before this PR. The page told people their sessions were gone. Fixed as he described, plus the line the UX lane asked for:

  • a dedicated empty title when sessions are open but none has a card: "None of your open sessions has a status card."
  • a muted line under the list whenever any are withheld: "N sessions without a status card are not shown." That is the sentence that says the sessions still exist, which was the actual defect.
  • "No sessions" is kept for the one case where it is true: no open session at all.

Wording uses "status card", already the term here, and explains no predicate. The TITLE stays "All Dashboards": commandCenter.all_title is also the Sessions menu item and is wired into guidePlans.gen.ts and sessions.locations.test.ts, so renaming it is a separate product decision.

Backwards compatibility

Compatible. No API, payload or stored shape changes, and no session's own dashboard eligibility moves. What changes is which entries one page draws and what it says about them.

Entries are taken away (adopted, incognito, remote), so every reader of that list:

  • Reader: SessionDashboardsPage.tsx:SessionDashboardCard -- crew page -- cards come from dashboardNodes (canCarryCard); covered by the first test below.
  • Reader: SessionDashboardsPage.tsx:attention inbox -- crew page -- still reads sessionNodes, so an excluded session's title, task context and question all resolve; same test.
  • Reader: SessionDashboardsPage.tsx:EmptyState -- crew page -- three cases now, one string each; the new titles are the fix above.
  • Reader: SessionStatusFrame.tsx:eligible -- crew page -- same three terms, now canCarryCard(owner); its five tests pass unchanged.
  • Reader: CommandCenterPanel.tsx:root -- crew page -- untouched, inline as on main; 30 tests pass unchanged.
  • Reader: api.sessionSummary here -- crew page -- an entry carries a summary too, so a remote or incognito session's summary leaves THIS page. GET .../summary has no privacy gate (chat_handlers.py:1705), so that is a real narrowing; it stays in that session's own chat (SidePanel.tsx:570, SessionSummaryTab.tsx:286).
  • Reader: the four copy keys -- crew page -- 11 catalogs plus regenerated en-XA; commandCenter.cards_withheld is registered in i18n/pluralKeys.json, which the key gate requires for a plural base.

Tests

website/src/test/sessionDashboards.test.tsx

  • cards every session whose card the route serves, and only those: five slots -- root, dispatched conductor, adopted, incognito, remote. Exactly two cards, dashboardCard read for exactly those two, the adopted worker's question still in the inbox and counted, and the muted line reading "3 sessions without a status card are not shown."
  • says the open sessions have no card rather than that there are no sessions: an all-withheld fleet shows the dedicated title, no "No sessions", no card, and the count line.
  • still says there are no sessions when none is open, and counts one in the singular: "No sessions" survives for an empty fleet with no count line, and one withheld session reads "1 session without a status card is not shown."

Pin proven against the prior head's page file: all three fail. With the fix, 21/21 here and 62/62 with commandCenterPanel and dynamicDashboardCard.

Manual verification

website/scripts/capture-19403-card-eligible-dashboards.mjs runs the real built SPA and asserts before writing a frame: the card set, the exact dashboard-card reads, the board document's own text, the inbox, and in a second scene the empty title, the withheld count and that no card rendered.

Screenshots / video

R1 -- an entry only where there is a card to show

Before: "All sessions 5", the adopted and incognito sessions each getting an entry that says "Content generation is unavailable for this session."

Base behaviour: five entries, two with no card to show

After: "All sessions 2", plus the line accounting for the three that are not shown.

After: two entries and the withheld-session line

R2 -- a dispatched conductor keeps the board this page is the only mount for

The dispatched conductor's derived board, published and rendering

R3 -- an excluded session's decision is still answered here

Needs you inbox carrying the adopted worker's question

R4 -- @iamwhatever's case: every open session is one with no card

"None of your open sessions has a status card", the count of what is not shown, and the question still answerable above it. Before this push the same fleet read "No sessions".

All-withheld fleet: the dedicated empty title and the withheld count

Related Issues

Fixes #19403

Pattern harvest

Rule candidate: review-prompt
Pattern: narrowing a list by a predicate leaves the EMPTY state saying the wrong thing, because its message was written when the list could only be empty for one reason. When a filter is added, every "nothing here" message under it needs re-reading.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@chenmingwei23
chenmingwei23 requested review from a team and KiroCrewCaptain as code owners October 12, 2026 12:14
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of 531835716011b9638a704365b54532e5b8b8d55d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The page now says "status card" but never explains it, and the line about hidden sessions doesn't say where to find them.

Watch

  • "Status card" doesn't match what the reader can see. The new line "3 sessions without a status card are not shown." says sessions are hidden for lacking a status card. But shot-02 still shows "Release the dashboard fix", which only reads "Content will appear after this session's next activity." The blind reader: "no idea why it counts as having a status card." Users can't predict which sessions will disappear. This shows on every visit with a mixed fleet, so it's friction, not a task failure. Fix: name the reason in the user's terms, or define the term once in all_description.
  • The line hides sessions and gives no way to reach them. The reader on the withheld line: "nothing on it lets me show them." The page counts something it then gives no next step for. Severity is moderate: the sessions are still in the sidebar, but the page doesn't say so. Fix: make "N sessions" a link that opens the Sessions list (or a filtered view of those sessions).
  • Shot-05 seems to contradict itself. "None of your open sessions has a status card." sits right under a "Needs you" card for an open session. It also repeats the count line above it, so the same fact is said twice. The reader: "a session that needs me is shown right above it." This only happens with an all-withheld fleet, so it's rare but confusing. Fix: when withheld === sessionNodes.length, render only the empty state and drop the separate count line. Make that one empty-state string carry both facts, e.g. "Your 3 open sessions have no status card yet."

[UX-REVIEWED] 5318357

Description read

[DESCRIPTION-READ] a19d7e467021d0d6843350056cd3e0906fc2f84fc88892cd50b887b9e3710fcd

That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — 🟡 CONCERNS

Design-level review of 531835716011b9638a704365b54532e5b8b8d55d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

Ordinary dispatched workers still each get an entry. canCarryCard lets every created_by session through, but only a conductor has a derived board to serve.

Watch

  • The stated scenario survives the fix. The PR's case is "A user following a conductor and its workers sees every worker listed as a dashboard owner". canCarryCard is !private && !remote && !parent, so a worker a conductor dispatched (created_by, no session-tree parent) still gets an entry. On the backend, _eligible refuses such a worker a model card (is_root_session), and only a conductor that published a typed board has a derived one. So each fan-out worker still shows a frame reading "unavailable/waiting", which is the R1 "before" symptom, and still costs one dashboard-card read. The predicate stands in for "the route can serve something" when the real question is "this session has a board". Those two differ for every non-conductor worker, and the frontend cannot tell them apart from slot rows alone.
    Clears when: the page leaves out dispatched sessions that have no derived board, using a signal the gateway already owns (for example a per-slot has_board on the slot row, or dropping entries whose card answers unavailable). Or the PR shows a test or screenshot proving that a fleet with a conductor plus plain dispatched workers renders the workers with no entry.
  • The card rule now lives in two places. canCarryCard re-spells the backend's _derived_allowed on the client and adds the parent term, which the backend applies only on the model path. card_lifecycle.py deliberately composes its predicates so that "a new condition reach[es] both by construction". The client copy breaks that guarantee: a privacy term added to _derived_allowed later will not reach this list.
    Clears when: the gateway sends card eligibility as a slot field the page reads, or a cross-surface test pins canCarryCard against _derived_allowed.

[DESIGN-REVIEWED] 5318357

Description read

[DESCRIPTION-READ] db54464f89fbd6b30b22c8860ac871d68086e6183cbc0e26e5609c2f31ab27d0

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 531835716011b9638a704365b54532e5b8b8d55d — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

One thing to check: the Goal says the page "never offers a page the gateway refuses", but dispatched sessions keep their entries, and GET .../dashboard still answers 404 for them.

What this change ships

Inventory (8 items) — 8 justified

Intent: the All Dashboards page should list only sessions that have a card to show, and it must not claim a dashboard the gateway refuses. This is a FIX.

  1. Adopted, incognito and remote sessions no longer get an entry, card or "Open session" link on /session-dashboards. Dispatched sessions keep theirs. — justified
  2. One shared predicate, canCarryCard in command-center/model.ts, decides who has a card. Its 2 consumers are the gallery and SessionStatusFrame, and it replaces the frame's inline test. — justified
  3. A muted line under the list counts the open sessions shown without a card. — justified
  4. A new empty-state title for the case where sessions are open but none has a card. "No sessions" now shows only when no session is open. — justified
  5. The page description changes from "Dashboards for…" to "Saved summaries and status cards for…". — justified
  6. The Needs you inbox, search and attention filter still cover every open session, carded or not. — justified
  7. A capture script for All Dashboards page lists dispatched (non-root) sessions that have no dashboard #19403 (website/scripts already holds 733 capture-* scripts). — justified
  8. Updates to the spec and feature map (session-summary.md, feature-map/README.md), plus a comment in CommandCenterPanel.tsx saying how the root test differs from the card test. — justified

[FIRST-PRINCIPLES-REVIEWED] 5318357

Description read

[DESCRIPTION-READ] 6e70c0f2b2853b0a2a1db210b506de763f157dcb7a2595e293c36e678135733e

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 531835716011b9638a704365b54532e5b8b8d55d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 5318357

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 531835716011b9638a704365b54532e5b8b8d55d: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 531835716011b9638a704365b54532e5b8b8d55d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 5318357

Verdict parsed from the review's SHA-scoped output markers for commit 531835716011b9638a704365b54532e5b8b8d55d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 531835716011b9638a704365b54532e5b8b8d55d: <one-sentence reason>

@chenmingwei23
chenmingwei23 force-pushed the fix/19403-root-only-dashboards branch from 0652c4d to 82f4f08 Compare October 12, 2026 12:30
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Correction and disposition for the four lane findings, on head 82f4f08.

GPT 6.1 F1 / Opus 5.5 (blocking, same finding) -- fixed. The inbox and the Needs you (1) count now wait on their own source: await within(inbox).findByText(...) and await screen.findByRole('button', { name: 'Needs you (1)' }). The summary query no longer stands in for the questions query.

Correction to this PR's "Why it matters" section. That section is frozen, so the fix goes here: its claim that each non-root dashboard-card read was "refused" is wrong, and the Design and First Principles lanes are right to reject it. The root test lives on GET /api/chat/slots/{slot}/dashboard (member_dashboard.py:257, 404 not_root_session). GET .../dashboard-card has no root test: it answers unavailable for a worker with no board, and CardLifecycle.read serves a DERIVED board before any root gate, which publish_derived documents as deliberate ("a conductor dispatched by another session is exactly the case that must still get its board"). "What changed" and "Backwards compatibility" now say this, and the test comment that named the wrong route is gone.

Design / First Principles: a dispatched conductor's derived board. Confirmed as a real take-away, and measured rather than argued:

  • A card's content comes from SessionStatusFrame, gated on privacy plus !parent, not on this root test.
  • _attach_slot_parents (dashboard/state.py:489) fills parent from the crew-log session tree, and that tree carries the birth-time edge as well, so a dispatched session normally already has parent and that frame already withheld its read. For those sessions the card was the "Content generation is unavailable for this session" card visible in the before screenshot.
  • The gap is therefore narrower than "every spawned conductor": it is a dispatched pipeline conductor whose row carries no session-tree parent, i.e. crew log off or the tree not yet seeded. is_root_session refuses that reading on purpose ("the answer is 'not root yet'").
  • I cannot name another surface where that board stays reachable: grep -rn SessionStatusFrame website/src returns this page alone, since feat: root session side panel shows its own Dynamic Dashboard #18105 left the side panel rendering CrewDynamicDashboard behind its own root gate.

So the honest options are the issue's rule or the frame's rule, and they disagree:

  1. Root-only, as shipped. All Dashboards page lists dispatched (non-root) sessions that have no dashboard #19403 states "Done when: only root sessions appear on /session-dashboards", and the page then agrees with the side panel and with the session-dashboard route. Cost: in that one configuration a dispatched pipeline conductor's board leaves the gallery with nowhere else to go.
  2. !parent only, matching SessionStatusFrame's own eligibility. Keeps that board. Cost: a dispatched worker keeps a card on a page about dashboards, which is the reported fault, so All Dashboards page lists dispatched (non-root) sessions that have no dashboard #19403 would have to be amended instead of closed.

This PR ships 1 and says so in "Backwards compatibility" rather than claiming nothing was taken away. Choosing 2 is a change to the issue's own done-condition, so it is the maintainer's call; I will switch the filter in one line if that is the ruling.

UX (advisory), both points acknowledged, not taken in this PR. The "All sessions" heading and commandCenter.all_description do over-promise once the list is root-only, and a search that matches only workers now shows their question above a no_matches cards section. Both fixes are copy: a new heading key and a new empty-state string across 12 locale catalogs, which is wider than this T1 filter fix and would be a separate change. Raised so it is on the record rather than lost.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 12, 2026
@chenmingwei23
chenmingwei23 force-pushed the fix/19403-root-only-dashboards branch from 82f4f08 to c9d4120 Compare October 12, 2026 13:35
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 12, 2026
@chenmingwei23 chenmingwei23 changed the title fix(dashboard): list only root sessions on the All Dashboards page fix(dashboard): card the sessions whose card the route serves Oct 12, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Reworked on the maintainer's ruling. New head c9d4120.

What was wrong with the previous head. It filtered the card list on isRootSlot, the side panel's test. That test gates the dashboard PACKAGE, and this page lists derived CARDS. Those are different objects on different routes, so the filter removed every dispatched conductor's board from the only surface that mounts one. The Design and First Principles lanes called this on head 0652c4d and they were right.

What the page does now. It asks the card question through canCarryCard, the single predicate SessionStatusFrame fetches on: not private, not remote, no session-tree parent. The frame calls the same function, so a list of cards and the card itself cannot disagree about who has a board. An adopted, incognito or remote session loses its entry. A dispatched conductor keeps its board, and the screenshot now shows that board rendering its own data rather than an empty card.

Correction to the frozen top of this description. Per the template those three sections are not mine to edit, so:

  • "Why it matters" says the page "spent a dashboard-card read per non-root session, each one refused". Wrong. GET .../dashboard-card has no root test. Its gate is _derived_allowed (card_lifecycle.py:804), privacy and remoteness only, and publish_derived serves a dispatched conductor its board deliberately. The route that refuses is GET .../dashboard with 404 not_root_session (member_dashboard.py:257), which serves the package.
  • "Problem / Motivation" frames the fault as the listing of a non-root session. The fault is the CLAIM: an entry offered to a session with no card at all, under a description promising each entry a dashboard of its own. The Goal line still holds as written -- only the sessions that actually have a dashboard are listed -- because "actually have" is now measured on the right route.
  • "Not a goal" bullets 1 and 3 call the filter "the root test". It is the card test. The bullets' substance is unchanged: no session's own eligibility moves, and no new field or request was added.

On QA row 44. Its expected value, "root sessions only", was written from the panel's and the gateway's behaviour, both of which are about the package. It is not a specification for this page, and I should not have treated it as a bar. A dispatched worker carrying a derived card is honest, because the backend really does serve it one. What row 44 saw and got right is the contradiction a user meets; the rule it inferred is what this rework replaces.

Evidence. website/scripts/capture-19403-card-eligible-dashboards.mjs asserts the card set, the exact dashboard-card reads, the board document's own rendered text and the inbox contents before writing a frame; it passes here and reports cards are [chat-12,chat-10,chat-11,chat-13,chat-14], expected [chat-10,chat-11] with the base page file in place. The new test case fails on base with length of 2 but got 5.

The copy change touches commandCenter.all_description only, in all 11 catalogs plus the regenerated pseudolocale. commandCenter.all_title is left alone because the Sessions menu item and the generated guide plans share it.

@chenmingwei23
chenmingwei23 force-pushed the fix/19403-root-only-dashboards branch from c9d4120 to a0725b6 Compare October 12, 2026 13:56
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Both BLOCKs on head c9d4120 are answered on the new head a0725b6.

First Principles, isRootSlot rides along -- accepted and subtracted. It had one consumer and changed no behaviour. The helper and its doc comment are deleted from model.ts, and CommandCenterPanel.tsx keeps its own inline root expression, byte-identical to main. The distinction the extraction was meant to protect is kept as prose where each reader needs it: canCarryCard's doc comment names the package test it must not be confused with, and the panel's comment points at canCarryCard for cards. grep -rn isRootSlot website/src docs now returns nothing.

Design, missing screenshot evidence. The description carried four user-attachments images when I checked it just now, so the capture that reported attachments downloaded and typed as images: 0 ran against the description as it stood before the body edit landed, a few seconds after the push. The four images are: the base-behaviour gallery (five entries), the after gallery (two), the dispatched conductor's board rendering its own data, and the Needs you inbox holding the adopted worker's question. This push re-runs the lane against the current description. The harness path in the blocker text is also stale: it is temp-screenshots/19403-card-eligible now.

Design watch, remote and incognito root sessions lose their saved summary here. Confirmed as real, and it follows from the ruled predicate rather than being an oversight. An entry carries a summary as well as a card, and GET .../summary has no privacy or remoteness gate of its own (chat_handlers.py:1705), so a remote or incognito root session's summary is no longer on this page. It stays where a session's summary is primarily read: that session's own chat, pages/chat/SidePanel.tsx:570 and pages/chat/SessionSummaryTab.tsx:286. Added as a Reader line in Backwards compatibility.

Design watch, the frozen Goal. Its lane asks for a human to record the ruling, which is not mine to post. The ruling is that this page must filter on the card predicate (not private, not remote, no parent), because the page lists derived cards and the root test gates the package; the Goal's "sessions that actually have a dashboard" is now measured on the card route. A maintainer comment confirming that is what the lane is waiting for.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Maintainer ruling on the filter predicate, recorded here so the frozen Goal is read correctly.

The Goal says "root sessions only". That phrasing came from the dashboard PACKAGE route, which is root-gated: member_dashboard.py:257 answers 404 not_root_session. This page lists derived CARDS, which come from a different route whose gate is _derived_allowed (card_lifecycle.py:804), and that predicate is about privacy and remoteness only, not root-ness. SessionStatusFrame.tsx:35-39 says in its own comment that a spawned conductor with created_by set still owns a derived board and must therefore be fetched for.

So the Goal is to be read as: the page offers an entry wherever there is a card to show. Filtering on root-ness was an over-correction, and it removed every dispatched conductor's board from the only surface that mounts one. canCarryCard, shared with the frame so the list and the card cannot disagree, is the predicate I asked for.

QA row 44's expected value of "root sessions only" was derived from package-route behaviour. It is not a specification for this page.

The page title is unchanged on purpose. Renaming user-visible copy is a separate decision and not part of a bug fix.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 12, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filters the All Dashboards card list through canCarryCard (not private, not remote, no session-tree parent), the same predicate SessionStatusFrame fetches on. A list entry and its card can no longer disagree, and dispatched conductors keep their board, which matches the maintainer's ruling. The inbox still covers every session. The predicate change is correct, but it introduces a wrong message the UX lane raised on this head, and nobody has answered it. In SessionDashboardsPage.tsx the empty state is t(nodes.length ? 'commandCenter.no_matches' : 'pages.sessionsPage.empty_title'), and nodes now holds only card-eligible sessions. So a user whose open sessions are all incognito, remote or adopted sees "All sessions 0" and "No sessions" while those sessions are open. Before this PR they were listed. Risk is low but user-facing: the page tells people their sessions are gone. Fix: when sessionNodes is non-empty and dashboardNodes is empty, render a dedicated empty title, for example "None of your open sessions has a status card". Optionally add the muted "N sessions without a status card are not shown" line the UX lane suggests. Then post the target=ux disposition for this head. Keeping the "All sessions" title is a product decision the PR already explains, and it is not part of this ask. — crew-pr-reviewer (deep re-check)

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 12, 2026
@chenmingwei23
chenmingwei23 force-pushed the fix/19403-root-only-dashboards branch from a0725b6 to af4e19f Compare October 12, 2026 19:32
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

@iamwhatever thank you, this is yours and it was a real defect. Fixed as you described, on head af4e19f.

You were right about the mechanism and about where it came from: nodes holds only card-eligible sessions after my change, so t(nodes.length ? 'commandCenter.no_matches' : 'pages.sessionsPage.empty_title') fell through to "No sessions" for a fleet that was entirely incognito, remote or adopted. Those sessions were open and had entries before this PR, so the page told the user they were gone. Neither I nor the lanes connected the UX watch to a concrete fleet that hits it.

What the page does now, in the three cases that were one case before:

  • sessions open, cards hidden by the search or the attention filter: commandCenter.no_matches, unchanged.
  • sessions open, none of them with a card: commandCenter.no_cards, "None of your open sessions has a status card." Your wording.
  • no open session at all: pages.sessionsPage.empty_title, "No sessions". The only case where it is true.

I also took the muted line the UX lane suggested, because that is the sentence that says the sessions still exist: commandCenter.cards_withheld, "N sessions without a status card are not shown.", under the list whenever any are withheld, with a singular form at one. It uses "status card", the term already on this surface, and says nothing about the predicate.

Three new strings in all 11 catalogs plus the regenerated pseudolocale, and commandCenter.cards_withheld registered in i18n/pluralKeys.json because the key-reference gate resolves a plural base from that registry rather than from a suffix scan.

Three tests pin it, each failing against the previous head's page file: the all-withheld fleet shows the dedicated title and no "No sessions"; an empty fleet still shows "No sessions" with no count line; and one withheld session reads in the singular. R4 in the description is the frame, asserted by the harness before it is written.

The title stays as you said, and the description already records that as a product decision rather than a finding.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author
  • The empty state can claim the user has no sessions. span=15b52a88a40c

Outcome: fixed on head af4e19f.
The empty state now has three cases instead of one. Sessions open with cards
filtered out keeps commandCenter.no_matches. Sessions open with no card between
them gets a dedicated title, commandCenter.no_cards, "None of your open sessions
has a status card." No open session at all keeps pages.sessionsPage.empty_title,
"No sessions", which is the only case where that sentence is true.
The suggested muted line is in too, as commandCenter.cards_withheld: "N sessions
without a status card are not shown.", under the list whenever any are withheld,
singular at one. That is the sentence that tells the user the sessions still exist,
which was the defect under the wrong title.
Both strings use "status card", the term already on this surface, and neither
explains the predicate to the user. Three new strings in all 11 catalogs plus the
regenerated en-XA, with the plural base registered in i18n/pluralKeys.json.
Pinned by three tests in website/src/test/sessionDashboards.test.tsx, each failing
against the previous head's page file. R4 in the description is the rendered frame,
asserted by the capture harness before it is written.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author
  • nodes holds only card-eligible sessions, so an all-withheld fleet reads "No sessions" span=65ac46a77cd2

Outcome: fixed on head af4e19f, same change as the
UX finding this shares a defect with.
SessionDashboardsPage.tsx now picks the empty title from three cases: cards filtered
out, sessions open with no card between them, and no open session at all. Only the
last one says "No sessions". A muted line counts the withheld sessions whenever there
are any, so a session leaving the list is accounted for on screen.
Pinned by says the open sessions have no card rather than that there are no sessions and still says there are no sessions when none is open, and counts one in the singular, both failing against the previous head's page file.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 12, 2026
@chenmingwei23
chenmingwei23 force-pushed the fix/19403-root-only-dashboards branch from af4e19f to 2a5e300 Compare October 12, 2026 19:59
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

@iamwhatever ready for your re-review on head 2a5e300.

Since your review: the empty-state fix you asked for is in (dedicated title when sessions are open but none has a card, plus the muted withheld count, three tests pinning all three cases), the target=ux disposition is posted, and the branch is rebased onto main 65df088 so the PR is mergeable again. The lanes are re-running on this head now.

One thing worth knowing for the fleet, since it cost this PR a wave: while the PR was CONFLICTING, GitHub dispatched no pull_request runs at all, so the five review lanes could not start. Measured on this PR, by event: clean head 23, dirty head 0, with only pull_request_target runs there. A rebase was the prerequisite for any verdict, not something to fold in later.

Your CHANGES_REQUESTED is the only human gate left here, and it stays until you clear it.

The All Dashboards page built its list from every session node with no
eligibility test, so it offered an entry to a session that has no card to
show, under wording that promised each entry a dashboard of its own.

Two different objects were conflated. The dashboard PACKAGE is a root
session's: `GET /api/chat/slots/{slot}/dashboard` answers 404
`not_root_session` for anything else, and the side panel withholds its
Overview. The derived CARD is served to any slot that is not private, not
remote and not adopted, dispatched conductors included -- `publish_derived`
calls that "exactly the case that must still get its board".

So the page now asks the card question, through the same `canCarryCard`
predicate `SessionStatusFrame` fetches on, and the two cannot disagree about
who has a board. An adopted, incognito or remote session is dropped; a
dispatched conductor keeps the board this page is the only mount for. The
page description names what an entry carries instead of claiming a package
for every one of them.

Fixes #19403
Both places that describe the page now say the gallery cards the sessions
whose card the route serves, keep the package rule separate, and note that
the Needs you inbox still covers every open session.

Adds the screenshot harness. It seeds a root, a dispatched conductor with a
published derived board, an adopted worker, an incognito session and a
remote one, then asserts the card set, the exact dashboard-card reads, the
board document's own text and the inbox contents, so the frames cannot claim
more than the page does.
@chenmingwei23
chenmingwei23 force-pushed the fix/19403-root-only-dashboards branch from 2a5e300 to 5318357 Compare October 12, 2026 20:25
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 12, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filters the All Dashboards card list through one shared predicate, canCarryCard in command-center/model.ts (not private, not remote, no session-tree parent), which SessionStatusFrame now uses too, so the list and the frame can no longer disagree. The page description stops promising each session a dashboard of its own, which fixes the real fault: an entry offered to adopted, incognito or remote sessions that have no card. I re-checked our change request from a0725b6 on head 5318357, and it is met. The empty state now has three cases (no_matches when filtered, the new no_cards when sessions are open but none has a card, and "No sessions" only for an empty fleet). The muted "N sessions without a status card are not shown" line keeps withheld sessions accounted for, with the plural registered in pluralKeys.json. Three tests pin these cases, and the ux disposition is posted. I tried to break it. The inbox, its search and its Needs you filter still read every session, so an adopted worker's question is never stranded. An unknown slot still answers true, as the frame always did. Only eligible sessions trigger a dashboard-card read, so the change only removes requests. The current-head Design watch is real but advisory: a plain dispatched worker with no board still gets an entry showing a waiting frame, the same as main. That follows the maintainer's ruling that dispatched sessions keep their entries, so it is follow-up material rather than a regression. Please still post the target=design and target=ux dispositions for 5318357, since the last ones name a0725b6. Checks are green and the base is main, so this replaces our earlier change request. — crew-pr-reviewer (deep re-check)

@iamwhatever
iamwhatever enabled auto-merge (squash) October 12, 2026 23:54
@iamwhatever
iamwhatever merged commit 9d2a399 into main Oct 12, 2026
102 checks passed
@iamwhatever
iamwhatever deleted the fix/19403-root-only-dashboards branch October 12, 2026 23:55
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All Dashboards page lists dispatched (non-root) sessions that have no dashboard

2 participants