Skip to content

fix(members): finish the phone crewmates single top bar - #19629

Merged
iamwhatever merged 1 commit into
mainfrom
fix/crewmates-phone-bar-followups
Oct 25, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/crewmates-phone-bar-followups

Conversation

@buluoray

@buluoray buluoray commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On a phone, the Crewmates page's single top bar always holds the right controls: a visible update notice, a way to the navigation while a crewmate is still loading, and controls that look like the Sessions bar's.

#19503 gave the phone Crewmates page the Sessions page's single top bar. Its review found gaps, tracked in #19589:

  1. The bar had no update notice. An available update, and its download progress, were not shown on this page.
  2. While a crewmate was still being read, the bar held only the bell. The navigation was reachable only by a swipe the user could not see.
  3. The left drawer toggle and right panel toggle were Glass chips, while the Sessions bar uses bare icons.

The fourth gap in #19589 (crewmate controls left in the bar over the in-place create pane) no longer exists: #20476 made New crewmate a modal over the visible chat.

Why it matters

Gap 1 hides an update and its progress from every phone user on this page. Gap 2 leaves a slow or failed load with no visible way out. Gap 3 makes the two phone bars look like different products.

Not a goal

  • The desktop Crewmates header. Over the pane on a wide window the controls stay Glass chips.
  • A shared drawer-history hook for the Sessions and Crewmates pages.
  • A timed fallback from the single bar to the logo row while a crewmate is read. That was tried in feat(members): phone Crewmates shares the single top bar #19503 and rejected because it looks like a bug.

What changed (motivation → approach → change)

Gap Change
Update notice UpdatePill sits before the bell in the trailing cell on /members (shell/topbar/shellHeader.tsx), with its text shown (showLabel), in a pill capped at 88px that truncates, so a long label or locale never crowds out the crewmate header on a 320px bar. Still two controls.
Leaving with a draft UpdatePill routes its Settings › About navigation through useGuardedLeave, so a tap asks the page first and an unsaved New crewmate draft gets the discard confirm.
Still reading While the page reports pending, the shell (shell/appShell.tsx) puts a nav-drawer toggle in #mobile-topbar-slot, with the logo row's Menu glyph so one icon never opens two drawers. Once the page reports open its header replaces it.
Bare icons pages/members/HeaderControl.tsx renders the drawer toggle and panel toggle as a Glass chip over the pane and a bare p-2 icon in the shell bar, at the bar's 18px. It forwards its ref, so the uiLocation markers still register.

website/docs/narrow-viewport.md, the Crew Members row of docs/feature-map/README.md and the MobileRosterBarContext doc comment (components/MobileNavRailContext.ts) describe the nav toggle, the bare icons and the update pill.

Backwards compatibility

Compatible: only the phone Crewmates bar and the update pill's click change; the context's three states and every other page are unchanged.

Removes nothing: no control, key or record is removed.

Tests

  • test/UpdatePill.test.tsx: the pill and the overflow-menu row ask the leave guard and stay put when the page keeps its draft; they leave once it agrees; showLabel keeps the text in a capped, truncating pill with the full label in its title.
  • test/App.mobileSingleTopbar.test.tsx: the bar holds the nav toggle while the page reads and before it reports, the toggle opens the nav drawer, it is gone once a crewmate is open, and the update pill with its text sits beside the bell.
  • pages/members/MembersPage.narrow.test.tsx: both header controls are bare buttons with an 18px glyph in the shell bar.
  • uiLocations/uiIndex.test.ts: HeaderControl puts the marker on its button in both forms.

Reverting the leave-guard call turns the two guard tests red. Related frontend run: 64 files, 1374 tests pass; tsc -b and eslint pass.

Proof: PROVEN test/UpdatePill.test.tsx (head c14bda1)

Manual verification

Not yet done on this head. This host has no browser libraries, so no screenshots could be taken.

Screenshots / video

Needed on this head, at a 390px phone width with an update available:

  1. A crewmate open: bare drawer toggle, identity pill, bare panel toggle, the "Update available" pill with text, the bell.
  2. The roster read still out: the Menu nav toggle, the update pill, the bell.
  3. That nav toggle tapped: the nav drawer open.
  4. A New crewmate draft with a name typed, then the update pill tapped: the discard confirm.

Related Issues

Closes #19589. Follows #19503.

Sibling sweep

Siblings: none -- every top-bar update entry (desktop pill, phone chat overflow row, this bar's pill) is the one UpdatePill component, guarded here.

Pattern harvest

Not generalizable: each gap is a control the Sessions bar adds for itself that this page's share of the same bar had not added yet.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners October 13, 2026 00:28
@buluoray
buluoray requested a review from mbriones98 October 13, 2026 00:28
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 13, 2026
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

Design-level review of c14bda1eabfac15c71249b77674daaf3a8f6cfbe — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

cannot evaluate: missing screenshots of the phone Crewmates top bar at this head. The PR changes that bar under website/src/ and attaches no rendered evidence.

Blockers

No rendered evidence for a reshaped phone top bar
Trigger: the diff adds UpdatePill "before the bell in the trailing cell on /members" (shellHeader.tsx), adds a "nav-drawer toggle in #mobile-topbar-slot" while the page reports pending (appShell.tsx), and changes HeaderControl from Glass chips to "a bare p-2 icon in the shell bar". The description says "no screenshots could be taken", and the evidence list names 0 images and 0 recordings.
Outcome: the bar's shape can't be judged → whether a pill capped at 88px, the identity pill, two bare toggles and the bell fit a 320–390px bar without crowding, and whether the bare icons match the Sessions bar, can't be checked → a cramped or mismatched bar could ship on every phone.
Fix: on a machine with a browser, take the four captures the description lists, at 390px and at this head, and attach them.
Clears when: the description carries user-attachments screenshots at a 390px width for (1) a crewmate open, with the update pill and both bare toggles, (2) the pending state, with the Menu nav toggle, (3) the nav drawer opened from that toggle, and (4) the discard confirm after tapping the update pill with a draft open.

[DESIGN-REVIEWED] c14bda1

Description read

[DESCRIPTION-READ] 0e05b301277694002573e9a2a0f142cfda9289125593ac3ce9eb605faca6dec9

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of c14bda1eabfac15c71249b77674daaf3a8f6cfbe — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Each gap traces to #19589, the leave guard reuses the existing useGuardedLeave, and the one new prop has a real consumer.

Notes

  • Item 4 — inherited (symmetry): its only stated harm is "makes the two phone bars look like different products". That is a match to the Sessions bar, not a reported user failure.

What this change ships

Inventory (6 items) — 5 justified

Intent: on a phone, the Crewmates top bar always shows the update notice, a way to the navigation, and controls that look like the Sessions bar's. This is a FIX.

  1. An "Update available" pill with its text now sits before the bell on the phone Crewmates bar. — justified
  2. Tapping the update pill or its menu row on any page now asks the leave guard first, so an unsaved draft gets the discard confirm. — justified
  3. While a crewmate is still loading, the phone bar shows a Menu toggle that opens the navigation drawer. — justified
  4. The roster-drawer and side-panel toggles are bare 18px icons in the phone bar, no longer Glass chips. — inherited: its only support is matching the Sessions bar
  5. New HeaderControl component: a Glass chip over the pane, a bare button in the bar. It has 2 consumers. — justified
  6. With showLabel, the pill is capped at 88px, truncates its text, and shows the full label as its tooltip. — justified

[FIRST-PRINCIPLES-REVIEWED] c14bda1

Description read

[DESCRIPTION-READ] 2f32791223194c873dae544644b95c3df5952a321c824bc121e837642551b950

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of c14bda1eabfac15c71249b77674daaf3a8f6cfbe — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the phone Crewmates top bar. The PR supplies no image, so the blind read was not performed and none of the four changed bar states has been seen by anyone.

Evidence gaps

  • UpdatePill showLabel beside the bell on /members (88px-capped, truncating). This needs a 390px and a 320px screenshot with an update available, showing how much of "Update available" survives the 88px cap next to the crewmate identity pill.
  • The Menu nav toggle (mobile-topbar-nav-toggle) while the roster is still loading (pending). This needs a screenshot of the bar in that state, plus one showing the nav drawer open after the toggle is tapped.
  • HeaderControl drawer and panel toggles as bare icons in the bar. This needs a screenshot with a crewmate open, ideally next to the Sessions bar for comparison.
  • Update pill tapped with an unsaved New crewmate draft. This needs a screenshot of the discard confirm that useGuardedLeave now raises.

Notes

  • max-w-[88px] on the pill leaves about 55px for text after the padding and icon, so "Update available" will likely show as "Updat…". The full label only appears in the title tooltip, which a phone user can't hover. A one-word string such as "Update" would fit; check the capture before shipping.

[UX-REVIEWED] c14bda1

Description read

[DESCRIPTION-READ] 79b921c62884610d3d917e77f7b4df2d1f8915387a53ea9ff20d4f9056f23539

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed c14bda1eabfac15c71249b77674daaf3a8f6cfbe — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] c14bda1

Verdict parsed from the review's SHA-scoped output markers for commit c14bda1eabfac15c71249b77674daaf3a8f6cfbe.

False positive or not applicable? A repository writer can comment:
/ai-review override fable c14bda1eabfac15c71249b77674daaf3a8f6cfbe false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of c14bda1eabfac15c71249b77674daaf3a8f6cfbe and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c14bda1

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c14bda1eabfac15c71249b77674daaf3a8f6cfbe false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 13, 2026
@dodgeblaster

Copy link
Copy Markdown
Contributor

Stewarding review for #19589 (phone Crewmates single top bar follow-ups).

The change is well-scoped and maps cleanly onto all four follow-ups from #19589, each with a test that pins it and phone screenshots for open / create / pending states. I verified the test↔follow-up mapping and the diff touches only the phone-bar surface (App.tsx, MembersPage.tsx, MobileNavRailContext.ts, narrow-viewport.md, two test files). Not approving yet — three things stand between this and merge:

1. Real blocking finding (verified) — the update pill can silently discard a crewmate draft.
GPT 6.1 flagged, and Opus 5.5 upheld (UPHOLD-FENCED F1), a data-loss path that follow-up #2 introduces. UpdatePill.tsx:75 and :94 call navigate(settingsPath({ tab: 'about' })) directly, bypassing the draft leave-guard. MeetCrewmatesFlow.tsx:665 registers its draft via useGuardedLeave, and NavigationLeaveGuard.tsx:36-54 confirms there is no router-level blocker — a draft is only protected when the link opts into the guard. Since this PR places <UpdatePill /> on the phone Crewmates bar (App.tsx:2353) whenever an update is pending, an ordinary tap while a New-crewmate draft is open loses the entered name/goal with no confirmation and nothing to restore it. This is genuine; please route the pill's settings navigation through useGuardedLeave before navigate (and add a test that a pending draft survives/confirms a pill tap). It is not a false positive, so the /ai-review override gpt path is not the right remedy here.

2. The branch conflicts with main. mergeable=CONFLICTING / mergeStateStatus=DIRTY, and the head is ~1391 commits behind current origin/main (last CI run 2026-10-13). It needs a rebase onto current main. As the stewarding worker I'm deliberately not pushing a rebase onto your branch — that's yours.

3. Stale-base CI reds that should re-green after the rebase. Frontend Tests (1) fails only in uiLocations/uiIndex.test.ts ("every real render site…"), a registry/manifest test that drifts against a week-old base; Backend Tests (3.12, 4) is unrelated to this frontend diff; UX Review is a could not evaluate attachment-download transport error (re-run clears it); Coverage/Readiness are the usual fail-closed cascade off those. These are consistent with staleness, not defects in the four changes — the rebase + a fresh run should clear them. The GPT finding in (1) is the one real code item.

Suggested path: fix the leave-guard bypass, rebase onto current main, push, and let CI re-green; then it's ready for a maintainer approve + merge.

@iamwhatever
iamwhatever force-pushed the fix/crewmates-phone-bar-followups branch from 52e8997 to 721be90 Compare October 25, 2026 04:23
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 25, 2026
On a phone the Crewmates single bar keeps a way to the navigation while a
crewmate is read, shows the update notice with its text, and wears bare
icons like the Sessions bar. The update pill asks the page before it
leaves, so a New crewmate draft is not dropped.

Closes #19589
@iamwhatever
iamwhatever force-pushed the fix/crewmates-phone-bar-followups branch from 721be90 to c14bda1 Compare October 25, 2026 04:39
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 25, 2026

@cruisercohen cruisercohen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed c14bda1eab. This is a comment, not an approval, only because the Screenshot Evidence check is red on this head: the description has no screenshot or recording. PR Readiness is still pending behind it.

The code looks right to me:

  • The earlier stewarding finding is fixed. UpdatePill now routes both the pill and the menu-item path through useGuardedLeave before it calls navigate to Settings › About, so tapping it while a New crewmate draft is open now asks for confirmation instead of discarding the draft. UpdatePill.test.tsx covers this.
  • The nav-drawer toggle appears in the phone bar only while the Crewmates page reports pending, which is before a crewmate's drawer is bound. It uses the Menu glyph, so one icon never opens two different drawers.
  • HeaderControl renders the bare bar button or the Glass chip from a single inBar flag and forwards the ref and remaining props, so the uiLocation markers still land on the element that is tapped.

I did not run vitest locally. On this head, Frontend Tests, Frontend Lint & Type Check and the AI review lanes are green.

@iamwhatever
iamwhatever merged commit a6150d5 into main Oct 25, 2026
106 of 108 checks passed
@iamwhatever
iamwhatever deleted the fix/crewmates-phone-bar-followups branch October 25, 2026 06:31
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 25, 2026
bolichen97 added a commit that referenced this pull request Oct 29, 2026
Cherry-picks these main commits onto release/0.11.0, in merge order:

- fix(schedule): return focus to the cron folder toggle after rename (#23907)
  (cherry picked from commit a5b78da)
- fix(probes): declare an undated duplicate check's conservative bucket on the reading (#23912)
  (cherry picked from commit 95640ac)
- fix(skill-projection): coalesce end prunes so a fan-out cannot hold the start queue (#23913)
  (cherry picked from commit 47e0b8f)
- fix(optimizer): keep the user's ask and add no requirements or solutions (#23915)
  (cherry picked from commit 1f0e872)
- fix(sqlite): retry the WAL switch when another opener holds a lock (#22865) (#23920)
  (cherry picked from commit 03f3b2a)
- fix(slack): post a quiet nudge cycle's outcome to the linked thread (#23911)
  (cherry picked from commit 32faa11)
- feat(crew): run each crewmate's worker in its own git worktree (#23563)
  (cherry picked from commit 6b21419)
- fix(members): finish the phone crewmates single top bar (#19629)
  (cherry picked from commit a6150d5)
- fix(channels): stop Discord, Teams and Webex re-announcing while held (#23916)
  (cherry picked from commit 1f3210d)
- fix(subagent): macOS spawn floor reads host_available_mib (#23914)
  (cherry picked from commit ed83ad2)
- feat(crew): run a crewmate's worker on claude as well as KAS (#23538)
  (cherry picked from commit 32362f8)
- fix(dashboard): read every body integer through body_int (#22502) (#23921)
  (cherry picked from commit dad46e9)
iamwhatever pushed a commit that referenced this pull request Oct 29, 2026
Cherry-picks these main commits onto release/0.11.0, in merge order:

- fix(schedule): return focus to the cron folder toggle after rename (#23907)
  (cherry picked from commit a5b78da)
- fix(probes): declare an undated duplicate check's conservative bucket on the reading (#23912)
  (cherry picked from commit 95640ac)
- fix(skill-projection): coalesce end prunes so a fan-out cannot hold the start queue (#23913)
  (cherry picked from commit 47e0b8f)
- fix(optimizer): keep the user's ask and add no requirements or solutions (#23915)
  (cherry picked from commit 1f0e872)
- fix(sqlite): retry the WAL switch when another opener holds a lock (#22865) (#23920)
  (cherry picked from commit 03f3b2a)
- fix(slack): post a quiet nudge cycle's outcome to the linked thread (#23911)
  (cherry picked from commit 32faa11)
- feat(crew): run each crewmate's worker in its own git worktree (#23563)
  (cherry picked from commit 6b21419)
- fix(members): finish the phone crewmates single top bar (#19629)
  (cherry picked from commit a6150d5)
- fix(channels): stop Discord, Teams and Webex re-announcing while held (#23916)
  (cherry picked from commit 1f3210d)
- fix(subagent): macOS spawn floor reads host_available_mib (#23914)
  (cherry picked from commit ed83ad2)
- feat(crew): run a crewmate's worker on claude as well as KAS (#23538)
  (cherry picked from commit 32362f8)
- fix(dashboard): read every body integer through body_int (#22502) (#23921)
  (cherry picked from commit dad46e9)
bolichen97 added a commit that referenced this pull request Oct 31, 2026
…/0.11.0 (#26594)

Backports these main PRs to release/0.11.0 after #26487, in pick order.
Each was a `git cherry-pick -x` of its squash commit on main:

- fix(memory): keep the shared -wal on close when the driver has no setconfig (#26486) (cherry picked from commit ad856ad)
- fix(crew): blink a working icon's eyes and seat it flush in the crew stack (#25381) (cherry picked from commit d180166)
- fix(crew): counter-scale a working icon's frame in the face flight (#25020) (cherry picked from commit 94de6c6)
- fix(terminal): keep a newly opened terminal above the iPhone keyboard (#25370) (cherry picked from commit 670ab7d)
- fix(hooks): run agent spec hooks by kiro-cli's rules on KAS (#26428) (cherry picked from commit 314ea38)

Conflict resolved by hand:
- #26428: src/kiro_crew/hook_runtime/script_hooks.py keeps 0.11.0's
  extra_hooks_cwd branch (main passes **extra_run, which 0.11.0 lacks)
  and sets result.from_spec on both branches.

Left out (see the PR body): #19629, #23916, #23911 already on
release/0.11.0; #26001, #25419, #25142 need files only main has;
#26084 and #25483 use props and APIs only main has; #24634, #24635 and
#25364 conflict widely with code main changed after the cut; #26397
needs #26152's route; #26144 needs sandbox_launch_mark; #26456 not merged.

Co-authored-by: w <w@k.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phone Crewmates single top bar: follow-ups from #19503

4 participants