Repository navigation
fix(members): finish the phone crewmates single top bar - #19629
Conversation
Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)Design-level review of Design-Verdict: PASS cannot evaluate: missing screenshots of the phone Crewmates top bar at this head. The PR changes that bar under BlockersNo rendered evidence for a reshaped phone top bar [DESIGN-REVIEWED] c14bda1 Description read[DESCRIPTION-READ] 0e05b301277694002573e9a2a0f142cfda9289125593ac3ce9eb605faca6dec9 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Each gap traces to #19589, the leave guard reuses the existing Notes
What this change shipsInventory (6 items) — 5 justifiedIntent: on a phone, the Crewmates top bar always shows the update notice, a way to the navigation, and controls that look like the Sessions bar's. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] c14bda1 Description read[DESCRIPTION-READ] 2f32791223194c873dae544644b95c3df5952a321c824bc121e837642551b950 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing screenshots of the phone Crewmates top bar. The PR supplies no image, so the blind read was not performed and none of the four changed bar states has been seen by anyone. Evidence gaps
Notes
[UX-REVIEWED] c14bda1 Description read[DESCRIPTION-READ] 79b921c62884610d3d917e77f7b4df2d1f8915387a53ea9ff20d4f9056f23539 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Stewarding review for #19589 (phone Crewmates single top bar follow-ups). The change is well-scoped and maps cleanly onto all four follow-ups from #19589, each with a test that pins it and phone screenshots for open / create / pending states. I verified the test↔follow-up mapping and the diff touches only the phone-bar surface ( 1. Real blocking finding (verified) — the update pill can silently discard a crewmate draft. 2. The branch conflicts with main. 3. Stale-base CI reds that should re-green after the rebase. Suggested path: fix the leave-guard bypass, rebase onto current main, push, and let CI re-green; then it's ready for a maintainer approve + merge. |
52e8997 to
721be90
Compare
On a phone the Crewmates single bar keeps a way to the navigation while a crewmate is read, shows the update notice with its text, and wears bare icons like the Sessions bar. The update pill asks the page before it leaves, so a New crewmate draft is not dropped. Closes #19589
721be90 to
c14bda1
Compare
cruisercohen
left a comment
There was a problem hiding this comment.
Reviewed c14bda1eab. This is a comment, not an approval, only because the Screenshot Evidence check is red on this head: the description has no screenshot or recording. PR Readiness is still pending behind it.
The code looks right to me:
- The earlier stewarding finding is fixed.
UpdatePillnow routes both the pill and the menu-item path throughuseGuardedLeavebefore it callsnavigateto Settings › About, so tapping it while a New crewmate draft is open now asks for confirmation instead of discarding the draft.UpdatePill.test.tsxcovers this. - The nav-drawer toggle appears in the phone bar only while the Crewmates page reports
pending, which is before a crewmate's drawer is bound. It uses theMenuglyph, so one icon never opens two different drawers. HeaderControlrenders the bare bar button or the Glass chip from a singleinBarflag and forwards the ref and remaining props, so theuiLocationmarkers still land on the element that is tapped.
I did not run vitest locally. On this head, Frontend Tests, Frontend Lint & Type Check and the AI review lanes are green.
Cherry-picks these main commits onto release/0.11.0, in merge order: - fix(schedule): return focus to the cron folder toggle after rename (#23907) (cherry picked from commit a5b78da) - fix(probes): declare an undated duplicate check's conservative bucket on the reading (#23912) (cherry picked from commit 95640ac) - fix(skill-projection): coalesce end prunes so a fan-out cannot hold the start queue (#23913) (cherry picked from commit 47e0b8f) - fix(optimizer): keep the user's ask and add no requirements or solutions (#23915) (cherry picked from commit 1f0e872) - fix(sqlite): retry the WAL switch when another opener holds a lock (#22865) (#23920) (cherry picked from commit 03f3b2a) - fix(slack): post a quiet nudge cycle's outcome to the linked thread (#23911) (cherry picked from commit 32faa11) - feat(crew): run each crewmate's worker in its own git worktree (#23563) (cherry picked from commit 6b21419) - fix(members): finish the phone crewmates single top bar (#19629) (cherry picked from commit a6150d5) - fix(channels): stop Discord, Teams and Webex re-announcing while held (#23916) (cherry picked from commit 1f3210d) - fix(subagent): macOS spawn floor reads host_available_mib (#23914) (cherry picked from commit ed83ad2) - feat(crew): run a crewmate's worker on claude as well as KAS (#23538) (cherry picked from commit 32362f8) - fix(dashboard): read every body integer through body_int (#22502) (#23921) (cherry picked from commit dad46e9)
Cherry-picks these main commits onto release/0.11.0, in merge order: - fix(schedule): return focus to the cron folder toggle after rename (#23907) (cherry picked from commit a5b78da) - fix(probes): declare an undated duplicate check's conservative bucket on the reading (#23912) (cherry picked from commit 95640ac) - fix(skill-projection): coalesce end prunes so a fan-out cannot hold the start queue (#23913) (cherry picked from commit 47e0b8f) - fix(optimizer): keep the user's ask and add no requirements or solutions (#23915) (cherry picked from commit 1f0e872) - fix(sqlite): retry the WAL switch when another opener holds a lock (#22865) (#23920) (cherry picked from commit 03f3b2a) - fix(slack): post a quiet nudge cycle's outcome to the linked thread (#23911) (cherry picked from commit 32faa11) - feat(crew): run each crewmate's worker in its own git worktree (#23563) (cherry picked from commit 6b21419) - fix(members): finish the phone crewmates single top bar (#19629) (cherry picked from commit a6150d5) - fix(channels): stop Discord, Teams and Webex re-announcing while held (#23916) (cherry picked from commit 1f3210d) - fix(subagent): macOS spawn floor reads host_available_mib (#23914) (cherry picked from commit ed83ad2) - feat(crew): run a crewmate's worker on claude as well as KAS (#23538) (cherry picked from commit 32362f8) - fix(dashboard): read every body integer through body_int (#22502) (#23921) (cherry picked from commit dad46e9)
…/0.11.0 (#26594) Backports these main PRs to release/0.11.0 after #26487, in pick order. Each was a `git cherry-pick -x` of its squash commit on main: - fix(memory): keep the shared -wal on close when the driver has no setconfig (#26486) (cherry picked from commit ad856ad) - fix(crew): blink a working icon's eyes and seat it flush in the crew stack (#25381) (cherry picked from commit d180166) - fix(crew): counter-scale a working icon's frame in the face flight (#25020) (cherry picked from commit 94de6c6) - fix(terminal): keep a newly opened terminal above the iPhone keyboard (#25370) (cherry picked from commit 670ab7d) - fix(hooks): run agent spec hooks by kiro-cli's rules on KAS (#26428) (cherry picked from commit 314ea38) Conflict resolved by hand: - #26428: src/kiro_crew/hook_runtime/script_hooks.py keeps 0.11.0's extra_hooks_cwd branch (main passes **extra_run, which 0.11.0 lacks) and sets result.from_spec on both branches. Left out (see the PR body): #19629, #23916, #23911 already on release/0.11.0; #26001, #25419, #25142 need files only main has; #26084 and #25483 use props and APIs only main has; #24634, #24635 and #25364 conflict widely with code main changed after the cut; #26397 needs #26152's route; #26144 needs sandbox_launch_mark; #26456 not merged. Co-authored-by: w <w@k.local>
Problem / Motivation
Goal: On a phone, the Crewmates page's single top bar always holds the right controls: a visible update notice, a way to the navigation while a crewmate is still loading, and controls that look like the Sessions bar's.
#19503 gave the phone Crewmates page the Sessions page's single top bar. Its review found gaps, tracked in #19589:
The fourth gap in #19589 (crewmate controls left in the bar over the in-place create pane) no longer exists: #20476 made New crewmate a modal over the visible chat.
Why it matters
Gap 1 hides an update and its progress from every phone user on this page. Gap 2 leaves a slow or failed load with no visible way out. Gap 3 makes the two phone bars look like different products.
Not a goal
What changed (motivation → approach → change)
UpdatePillsits before the bell in the trailing cell on/members(shell/topbar/shellHeader.tsx), with its text shown (showLabel), in a pill capped at 88px that truncates, so a long label or locale never crowds out the crewmate header on a 320px bar. Still two controls.UpdatePillroutes its Settings › About navigation throughuseGuardedLeave, so a tap asks the page first and an unsaved New crewmate draft gets the discard confirm.pending, the shell (shell/appShell.tsx) puts a nav-drawer toggle in#mobile-topbar-slot, with the logo row'sMenuglyph so one icon never opens two drawers. Once the page reportsopenits header replaces it.pages/members/HeaderControl.tsxrenders the drawer toggle and panel toggle as a Glass chip over the pane and a barep-2icon in the shell bar, at the bar's 18px. It forwards its ref, so theuiLocationmarkers still register.website/docs/narrow-viewport.md, the Crew Members row ofdocs/feature-map/README.mdand theMobileRosterBarContextdoc comment (components/MobileNavRailContext.ts) describe the nav toggle, the bare icons and the update pill.Backwards compatibility
Compatible: only the phone Crewmates bar and the update pill's click change; the context's three states and every other page are unchanged.
Removes nothing: no control, key or record is removed.
Tests
test/UpdatePill.test.tsx: the pill and the overflow-menu row ask the leave guard and stay put when the page keeps its draft; they leave once it agrees;showLabelkeeps the text in a capped, truncating pill with the full label in its title.test/App.mobileSingleTopbar.test.tsx: the bar holds the nav toggle while the page reads and before it reports, the toggle opens the nav drawer, it is gone once a crewmate is open, and the update pill with its text sits beside the bell.pages/members/MembersPage.narrow.test.tsx: both header controls are bare buttons with an 18px glyph in the shell bar.uiLocations/uiIndex.test.ts:HeaderControlputs the marker on its button in both forms.Reverting the leave-guard call turns the two guard tests red. Related frontend run: 64 files, 1374 tests pass;
tsc -band eslint pass.Proof: PROVEN test/UpdatePill.test.tsx (head c14bda1)
Manual verification
Not yet done on this head. This host has no browser libraries, so no screenshots could be taken.
Screenshots / video
Needed on this head, at a 390px phone width with an update available:
Menunav toggle, the update pill, the bell.Related Issues
Closes #19589. Follows #19503.
Sibling sweep
Siblings: none -- every top-bar update entry (desktop pill, phone chat overflow row, this bar's pill) is the one
UpdatePillcomponent, guarded here.Pattern harvest
Not generalizable: each gap is a control the Sessions bar adds for itself that this page's share of the same bar had not added yet.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)