Repository navigation
feat(dashboard): remove the Dynamic Dashboard preview flag - #19659
Conversation
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that [DESIGN-REVIEWED] 41e6ef7 Description read[DESCRIPTION-READ] 740ffa361fed74821c494a9b89d0229602e53da0551ca542c2df67448c479248 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The non-owner sees a red error with no way forward: the blind reader "doesn't know who the owner is or how to become one." Watch
Suggestions
[UX-REVIEWED] 41e6ef7 Description read[DESCRIPTION-READ] 4a216af1ec54df6c1c18e4d9ae55e539d79bf3567c8509afb5a14e284454c202 That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check before merge: people who are not the crewmate's owner now see only an owner-only notice, while the RFC's Decision 1 says "every reader gets the dynamic dashboard". What this change shipsInventory (10 items) — 10 justifiedIntent: every reader sees the Dynamic Dashboard in the Dashboard tab, with no hidden switch. This is an ADDITION done by removal, covered by base RFC
[FIRST-PRINCIPLES-REVIEWED] 41e6ef7 Description read[DESCRIPTION-READ] 7454da0ea8459a0ee7b458f9d0fd7c00253e743fdabb53d10ecb1c6c366d1bfa That sha256 names the PR description this verdict read. Recompute it with |
d513046 to
dc717f5
Compare
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
dc717f5 to
fe7246d
Compare
|
rebutted span=5543de17b894 (Automatic cards placement)
|
|
rebutted span=ff6a1aa48df7 (the word "Dashboard")
|
|
rebutted span=946ef13671e0 (default page copy)
|
|
rebutted span=9f27d3f2b8d2 (cost said twice)
|
2c52b4d to
f5428c0
Compare
|
rebutted span=0f50bd5bc9c0 (owner notice has no next step)
|
|
rebutted span=769083830fd7 ("Dashboard" names two things)
|
|
rebutted span=17c5cab1a55a (Automatic cards under Developer Tools)
|
|
needs-a-decision (non-owner callers)
|
f5428c0 to
f686e5d
Compare
The Dynamic Dashboard is on for every reader. The PREVIEW_DASHBOARD flag and its six gates go, along with the Feature Previews card and its copy. - Automatic cards for all sessions moves to its own card on Settings > Developer. Setting id and config key are unchanged; default stays off. - The published-panel frontend left with no caller is deleted: CrewWebview.tsx, CrewDashboardEmpty.tsx, api.memberPanel, the member-panel invalidation, their tests and capture harnesses. - panel_published invalidates the member-dashboard query. - Flag sentences leave mcp_panel.py, the [DASHBOARD] turn block, the member prompt and three skills. - New guard: no built-in dashboard page may use an HTML sink.
|
rebutted span=c48a2be1f55a (name the owner)
|
|
rebutted (keep
|
|
needs-a-decision (non-owner callers)
|
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
… open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865
…refresh (#19866) * fix(members): show the suggestions page for an unadopted crewmate and open Dashboard on refresh A crewmate with no adopted page drew the default project-report template in its Dashboard tab. The suggestions page from #18613 (the crewmate's face, a first-person bubble and three prompts that fill its chat box) was deleted with the published-panel frame in #19659. It is ported onto CrewDynamicDashboard: a live member read answering state empty shows CrewDashboardEmpty and never promotes the default the gateway composed. An adopted page, a staged preview and a root session's Overview are unchanged. A refresh of /members reopened whichever side-panel tab was focused last. It now opens the Dashboard tab, once per crewmate and strip bucket per page load (dashboardOnLoad.ts), so a tab picked afterwards or on an in-app return stays. Closes #19865 * fix(members): answer review on the suggestions page; i18n register A crewmate a shipped page is named for (kirocrew-conductor, #19706) keeps that page; only the generic project-report default stands down, and a bound package with nothing applied keeps its own empty state. The prompts read as the person's: a visible "You could ask <name>" heading and right-aligned, dashed draft bubbles under the crewmate's bubble. The bubble says "Once we set one up" instead of pointing at a picker this surface does not have. fr gets U+202F before double punctuation; ru, bn and hi address the reader informally (ты, তুমি, तुम), per src/i18n/style. The [DASHBOARD] turn block tells an unadopted crewmate on the generic default that its tab shows the suggestions page; adopted and slug-named pages keep the plain block. While the tab shows the suggestions page the block lists no fields and no upkeep pointer, so visibility and writes agree. The decision is made once (dashboard_agentic.shows_suggestions) and sent on the read as `suggestions`; the tab, the turn block and the profile's upkeep view all follow it, with the route's own package lookup and lock rule. The prompts use the shared Btn with no trailing glyph, a click reveals the composer, and the copy says "dashboard layouts". Draft dashes show at rest (border-border-strong); the lead line drops its dangling "Or" in every locale; the spec states dashboard_fields and dashboard_write are unchanged while the suggestions page shows. --------- Co-authored-by: cixuuz <26782336+cixuuz@users.noreply.github.com>
Problem / Motivation
Goal: Every reader sees the Dynamic Dashboard, with no switch to turn on.
The Dynamic Dashboard sat behind a "Dynamic Dashboard" Feature Preview. It was off by default. So most people saw an older published view in the Dashboard tab. The decision to drop the switch is recorded in rfc-crewmate-dynamic-dashboard.md, "Amendment 2026-10-12 (second)", Decision 1.
Why it matters
One crewmate showed one page or another depending on a switch the reader could not see. Agents were told to send people to that switch. The old view also kept about 3,000 lines of frontend alive.
Not a goal
panel_publish, its route, store or fold. It keeps accepting.project-report.What changed (motivation → approach → change)
The flag decided which page the Dashboard tab drew. With the flag gone, the tab always draws the Dynamic Dashboard. The old published-view code then has no caller, so it goes too.
The
PREVIEW_DASHBOARDflag and its six gates are gone. The side panel's Dashboard view, a saved Dashboard tab, the "All dashboards" menu item and the Profile card's lock switch now show for everyone. The Feature Previews card and its text in every language are gone. The settings registry, the UI index and the guide plans are regenerated."Automatic cards for all sessions" moves to its own card on Settings > Developer. Its setting id and config key stay the same. It still starts off. Its line now says the cards show on the All Dashboards page, which the Sessions list's ⋮ menu opens, and that they use model credits.
The unused published-view frontend is deleted:
CrewWebview.tsx,CrewDashboardEmpty.tsx,api.memberPanel, and their tests and capture scripts. Apanel_publishedmessage now refreshes only the Dashboard tab.Agents no longer hear about the switch. The flag sentences leave
mcp_panel.py, the[DASHBOARD]turn block, the member prompt and three skills. The text calls the surface "the Dashboard tab".A new test checks every built-in dashboard page. No page may put text into the page as HTML. This matters more now, because every reader runs these pages.
website/src/utils/previewFlags.tswebsite/src/i18n/locales/*.json,website/src/i18n/en.context.json;website/src/i18n/dashboardFlagCopy.test.tsdeletedwebsite/src/components/commandPalette/settingsRegistry.gen.ts,src/kiro_crew/docs/settings-registry.generated.json,src/kiro_crew/docs/ui-index.generated.jsonwebsite/src/api/client.ts,website/src/api/client/agents.tssrc/kiro_crew/mcp_panel.py,src/kiro_crew/dashboard_agentic.py,src/kiro_crew/context_assembly/member.pysrc/kiro_crew/builtin_skills/dashboard/SKILL.md,src/kiro_crew/builtin_skills/goal-conductor/SKILL.md,src/kiro_crew/builtin_skills/pipeline-conductor/SKILL.mdDay 1, on any install:
Merge order: this lands after the default-page PR #19657, which is merged; this branch is rebased onto it. If #18851, #19335 or #18755 land first, whichever lands second rebases.
Backwards compatibility
Breaking: the
mc-preview-dashboardswitch no longer does anything, and the tab no longer draws thepanel_publishview. Writer sweep on origin/main @ 7ca644d: no code reads the key any more (git grep PREVIEW_DASHBOARDis empty);panel_publishstill writes its record and fold.Breaking: a dashboard caller who is not the crewmate's owner no longer sees a page in its Dashboard tab. The tab reads
GET /api/members/{slug}/dashboard, which is owner-only because it carries the crewmate's task titles; the deleted view read the any-callerGET /api/members/{slug}/panel. The RFC decision closes the fallback to the published view, and that route still answers any caller. Such a caller now sees one notice saying the page is the owner's, with no Retry.Reader:
website/src/pages/members/MembersPage.tsx:dashboardBody -- crew page -- drawsCrewDashboardTabfor everyone;MembersPage.test.tsxstaged-preview casesReader:
website/src/pages/chat/SidePanel.tsx:hiddenViews -- chat -- no longer withholdscommand-center;sidePanelAddMenu.test.tsxReader:
website/src/hooks/useWebSocket.ts:panel_published -- crew page -- invalidatesmember-dashboard;useWebSocket.frameTrace.test.tsReader:
src/kiro_crew/dashboard/handlers/agent_panel.py:GET /api/members/{slug}/panel-- app -- route unchanged;test_agent_panel_routes.pyReader:
src/kiro_crew/mcp_panel.py:panel_publish -- chat -- tool unchanged, reply text only;test_dashboard_tools.pyTests
test/test_dashboard_template_sink_ban.py(new): no built-intemplate.htmlusesinnerHTML,outerHTML,insertAdjacentHTML,document.writeor a similar sink. Checked by adding a sink to one page: the test failed, then passed once the page was put back.test/test_dashboard_tools.py: no panel reply or tool text names a Feature Preview.CrewDynamicDashboard.test.tsx: a non-owner's 403owner_onlyshows the owner notice throughErrorNotice, with no Retry.test/DeveloperPanel.test.tsx: Automatic cards has its own card, outside Feature Previews, off by default.commandCenterRetired.test.tsis unchanged.Manual verification
Built the SPA and loaded it against stub APIs. The Dashboard tab drew the default page with
mc-preview-dashboardunset; its body came from the real backend render ofproject-report. Automatic cards shows in its own card, off. No Dynamic Dashboard card is listed.Screenshots / video
Crewmate Dashboard tab with no flag set, on the default page (light and dark):
What a dashboard user who is not the crewmate's owner sees in the tab (an ErrorNotice, no Retry):
Every reader now gets these entries with no flag set: the side panel's + menu offers Dashboard, the Sessions ⋮ menu offers All Dashboards, and the Profile card shows the lock switch:
Settings > Developer: Automatic cards in its own card, naming where the cards show and that they use model credits. No Dynamic Dashboard preview:
Related Issues
Part of #18642.
Checklist