Skip to content

fix(conductor): skip the intro card when a Dashboard tab exists - #19850

Merged
iamwhatever merged 1 commit into
mainfrom
fix/conductor-skip-intro-with-dashboard
Oct 15, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/conductor-skip-intro-with-dashboard

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A Conductor that has a Dashboard tab stops opening its first reply with a redundant "Your Conductor" intro card.

The Conductor prompt makes its first reply open with an intro widget ("I'm your Conductor", the tasks on the table, what it can do). A Conductor now has its own Dashboard tab, which already shows who it is and what is on the table, so the card repeats the tab.

Why it matters

Crew Mode users see the same information twice on every new Conductor chat, and the widget costs output tokens on every first reply.

Not a goal

What changed (motivation → approach → change)

Symptom: redundant intro card → cause: the intro rule in _CONDUCTOR_SYSTEM_PROMPT has no Dashboard-tab exception → change: one new paragraph in "Talking to the person" (src/kiro_crew/agent.py): when the [RUNTIME] line names the KiroCrew dashboard AND a [DASHBOARD] block says the Dashboard tab shows a template — any template — skip the introduction and get to work. A messaging channel (Slack, DM) keeps its short plain-text intro even when a [DASHBOARD] block is present, because it cannot see the tab.

Same shape as #18608, which keys the in-chat board off the same [DASHBOARD] block. The intro keys on any tab because every Dashboard tab identifies the crewmate; the board rule stays keyed on board pages because only those draw the tasks.

Decision record: adds docs/decisions/2026-10-13-conductor-with-a-dashboard-tab-skips-its-intro-card.md, superseding 2026-10-10-conductor-board-tab-replaces-the-in-chat-board.md (which said every Conductor chat introduces itself). The decision is recorded on this PR: #19850 (comment). The superseded entry is untouched.

Backwards compatibility

Compatible: prompt text only; chats without a Dashboard tab behave as before.

Removes nothing: no code path, key, record or function is removed; only the intro widget is omitted from the reply when a Dashboard tab exists.

Tests

  • test/test_agent_refactor_contracts.py: _CONDUCTOR_SYSTEM_PROMPT digest updated.
  • test/test_agent_refactor_spec_bytes.py: kirocrew-conductor.json / kirocrew-ledger-conductor.json digests regenerated (both embed the prompt).
  • Local: those two files plus the conductor/agent suites (459 passed); pytest -k decision (2364 passed); DECISIONS_BASE_REF=origin/main scripts/check_decisions_history.py OK.

Manual verification

N/A — prompt-text change; the digest tests pin the shipped text.

Related Issues

Closes #19849

Pattern harvest

Not generalizable: a prompt rule that predates the Dashboard tab, not a code defect class.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 13, 2026 17:20
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 13, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Decision (relayed by the Kiro agent from @iamwhatever's dashboard instruction; Joe, please confirm or correct here): when a Conductor's session has a Dashboard tab, its first reply skips the "Your Conductor" intro card. Chats with no Dashboard tab keep the intro. This supersedes the intro part of docs/decisions/2026-10-10-conductor-board-tab-replaces-the-in-chat-board.md.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 97f94d1d917d105ffdefde24acbd0488afcd1320 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@iamwhatever overrode this lane for 97f94d1d917d105ffdefde24acbd0488afcd1320 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 97f94d1d917d105ffdefde24acbd0488afcd1320 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that the Dashboard tab really shows when a Conductor has never chosen a page. _read_page falls back to default_instance, so those chats get a [DASHBOARD] block too.

[DESIGN-REVIEWED] 97f94d1

Description read

[DESCRIPTION-READ] 9a1ead33299702c1e98fbaa860007bfd0e3887556a493367a0a89995a956c248

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ human override accepted

Reviewed 97f94d1d917d105ffdefde24acbd0488afcd1320 — this comment is updated in place on each push.

Human judgment by @iamwhatever overrides the Opus 5.5 finding for 97f94d1d917d105ffdefde24acbd0488afcd1320; the recorded reason is authoritative for this commit.

[OPUS-OVERRIDE] 97f94d1

Verdict recorded from an authorized human decision for commit 97f94d1d917d105ffdefde24acbd0488afcd1320.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 97f94d1d917d105ffdefde24acbd0488afcd1320: <one-sentence reason>

@iamwhatever
iamwhatever force-pushed the fix/conductor-skip-intro-with-dashboard branch from a070b55 to f530538 Compare October 13, 2026 17:45
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 97f94d1d917d105ffdefde24acbd0488afcd1320 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 97f94d1

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 97f94d1d917d105ffdefde24acbd0488afcd1320: <one-sentence reason>

@iamwhatever
iamwhatever force-pushed the fix/conductor-skip-intro-with-dashboard branch 2 times, most recently from 8a3c05a to eb88f85 Compare October 13, 2026 18:17
@iamwhatever

Copy link
Copy Markdown
Contributor Author

fixed (eb88f85)

The skip rule now comes first, and the intro rule opens with "Otherwise, your first reply...", so no unconditional intro rule comes before the exception. Same order as the #18608 board rule.

@iamwhatever

iamwhatever commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor Author

span=d5e49b1ee283
needs-a-decision

@iamwhatever: this needs a maintainer ruling, and an agent cannot give one. The user chose to drop the intro card when a Dashboard tab exists (relayed decision: #19850 (comment 6151461095)). The base RFC still says the intro is "Unchanged". Clear it with /ai-review override first-principles <head-sha>: <decision>, or by merging an RFC amendment first.

@iamwhatever

iamwhatever commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor Author

span=1086b45a2ac5
needs-a-decision

@iamwhatever: this is the same product-shape ruling as the other First Principles item. This PR cannot ship its own RFC: one shipped in the PR does not count. A maintainer override, or an RFC amendment merged first, clears it.

@iamwhatever

iamwhatever commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor Author

span=b2c5fd541979
needs-a-decision

A superseding decision entry needs a maintainer's on-record statement, per docs/decisions/README.md rule 3. The user decided, and the agent posted that decision as a relay comment. @iamwhatever, please confirm it in your own words, or override.

@iamwhatever

iamwhatever commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor Author

span=791908773805
needs-a-decision

Superseding a recorded decision needs a maintainer override; an agent cannot give one. @iamwhatever, please confirm the relayed decision (comment 6151461095) and override, or ask me to drop the decision entry.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 13, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

fixed (2989221)

The skip rule now requires both: the [RUNTIME] line names the KiroCrew dashboard AND a [DASHBOARD] block names a template. A messaging-channel or DM turn keeps its short plain-text intro even when the block is present. The decision entry and PR description say the same.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 46c0210: Maintainer decision: when a Dashboard tab exists, that tab carries the board, so the Conductor should skip the duplicate in-chat intro card; the new decision entry records and supersedes the old always-introduce shape.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override fable 46c0210: Maintainer approves this recorded behavior change and its Supersedes entry: when the Dashboard tab carries the board, the Conductor omits the duplicate in-chat intro card.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 46c02106603fb8057f2d92984a243b10e66f3e57.

Maintainer decision: when a Dashboard tab exists, that tab carries the board, so the Conductor should skip the duplicate in-chat intro card; the new decision entry records and supersedes the old always-introduce shape.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever marked the fable AI finding as false positive, not applicable, or explicitly accepted for 46c02106603fb8057f2d92984a243b10e66f3e57.

Maintainer approves this recorded behavior change and its Supersedes entry: when the Dashboard tab carries the board, the Conductor omits the duplicate in-chat intro card.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 14, 2026
@iamwhatever
iamwhatever force-pushed the fix/conductor-skip-intro-with-dashboard branch from 46c0210 to 97f94d1 Compare October 14, 2026 15:36
@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 97f94d1: Maintainer decision (same as on 46c0210; this head only squashes and rebases): when a Dashboard tab exists, that tab carries the board, so the Conductor skips the duplicate in-chat intro card; the new decision entry records and supersedes the old always-introduce shape.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override fable 97f94d1: Maintainer approves this recorded behavior change and its Supersedes entry (same as on 46c0210; this head only squashes and rebases): when the Dashboard tab carries the board, the Conductor omits the duplicate in-chat intro card.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 97f94d1d917d105ffdefde24acbd0488afcd1320.

Maintainer decision (same as on 46c0210; this head only squashes and rebases): when a Dashboard tab exists, that tab carries the board, so the Conductor skips the duplicate in-chat intro card; the new decision entry records and supersedes the old always-introduce shape.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever marked the fable AI finding as false positive, not applicable, or explicitly accepted for 97f94d1d917d105ffdefde24acbd0488afcd1320.

Maintainer approves this recorded behavior change and its Supersedes entry (same as on 46c0210; this head only squashes and rebases): when the Dashboard tab carries the board, the Conductor omits the duplicate in-chat intro card.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Oct 15, 2026

@mbriones98 mbriones98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks green and readiness passed at 97f94d1; no behavior change.

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at head 97f94d1.

What it fixes

A Conductor whose session has a Dashboard tab opened every first reply with a "Your Conductor" intro card that only repeats what the tab already shows. The prompt now skips the intro when the [RUNTIME] line names the dashboard and a [DASHBOARD] block names a template; chats with no tab keep the card, and messaging channels keep their plain-text intro.

Verified against source

  • src/kiro_crew/agent.py:5385-5395: the new paragraph sits ahead of the existing intro rule, now prefixed "Otherwise", and the board rule (goal-board / work-kanban, #18608) below it is untouched.
  • The "no tab keeps the intro" branch is real, not theoretical: the [DASHBOARD] block is only emitted from the member-desk assembly (src/kiro_crew/context_assembly/member.py:577, via dashboard_agentic.turn_block), and turn_block returns "" when no page is in force (src/kiro_crew/dashboard_agentic.py:888-903). An ordinary Crew Mode Conductor chat therefore carries no block and keeps the card; a Conductor crewmate desk resolves its default page (dashboard_templates/instance.py default_instance) and gets the block, so it skips the card. That matches the PR's "any template" scoping.
  • Decision record: the 2026-10-13 entry supersedes 2026-10-10, restates the unchanged board rule, and the evidence comment (issuecomment-6151461095) is posted by @iamwhatever. scripts/check_decisions_history.py against origin/main: OK (18 entries intact). The superseded entry is unchanged.
  • No system-spec prose describes the intro rule, so nothing stale was left behind; the RFC that mentions the intro being "unchanged" is a historical proposal.

Mutation

Reverting only the agent.py hunk reddens test/test_agent_refactor_contracts.py::test_every_pre_split_name_resolves_with_its_pre_split_shape and all eight test/test_agent_refactor_spec_bytes.py::test_every_written_spec_matches_the_pre_split_bytes[*] cases. With the change: 74 passed in those two files. These are digest pins on the shipped text, which is the right level for a prompt-only change; no test exercises the model's behaviour, as expected.

Fail-open / fail-closed

No error path is added. If a [DASHBOARD] block cannot be built, turn_block returns "" and the Conductor falls back to the intro card, which is the safe pre-existing behaviour.

Non-blocking follow-ups

  • The new paragraph says the [RUNTIME] line names "the Kiro Crew dashboard", while the runtime string is "KiroCrew dashboard" (context_assembly/sections.py:30) and the neighbouring paragraph just says "names the dashboard". The model will match either way; aligning on the neighbour's wording would keep it consistent.

Not verified

The model's actual first reply on a desk with a Dashboard tab was not run; the review covers the prompt text and the conditions under which the block appears.

@iamwhatever
iamwhatever merged commit b4439b3 into main Oct 15, 2026
103 of 105 checks passed
@iamwhatever
iamwhatever deleted the fix/conductor-skip-intro-with-dashboard branch October 15, 2026 07:13
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conductor draws a redundant intro card when it has a Dashboard tab

4 participants