Repository navigation
fix(conductor): skip the intro card when a Dashboard tab exists - #19850
Conversation
|
Decision (relayed by the Kiro agent from @iamwhatever's dashboard instruction; Joe, please confirm or correct here): when a Conductor's session has a Dashboard tab, its first reply skips the "Your Conductor" intro card. Chats with no Dashboard tab keep the intro. This supersedes the intro part of docs/decisions/2026-10-10-conductor-board-tab-replaces-the-in-chat-board.md. |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ✅ human override accepted@iamwhatever overrode this lane for |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the Dashboard tab really shows when a Conductor has never chosen a page. [DESIGN-REVIEWED] 97f94d1 Description read[DESCRIPTION-READ] 9a1ead33299702c1e98fbaa860007bfd0e3887556a493367a0a89995a956c248 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ human override acceptedReviewed Human judgment by @iamwhatever overrides the Opus 5.5 finding for [OPUS-OVERRIDE] 97f94d1 Verdict recorded from an authorized human decision for commit False positive or not applicable? A repository writer can comment: |
a070b55 to
f530538
Compare
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
8a3c05a to
eb88f85
Compare
|
span=d5e49b1ee283
|
|
span=1086b45a2ac5
|
|
span=b2c5fd541979
|
|
span=791908773805
|
|
fixed (2989221)
|
|
/ai-review override first-principles 46c0210: Maintainer decision: when a Dashboard tab exists, that tab carries the board, so the Conductor should skip the duplicate in-chat intro card; the new decision entry records and supersedes the old always-introduce shape. |
|
/ai-review override fable 46c0210: Maintainer approves this recorded behavior change and its Supersedes entry: when the Dashboard tab carries the board, the Conductor omits the duplicate in-chat intro card. |
Human judgment recorded@iamwhatever marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@iamwhatever marked the fable AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
46c0210 to
97f94d1
Compare
|
/ai-review override first-principles 97f94d1: Maintainer decision (same as on 46c0210; this head only squashes and rebases): when a Dashboard tab exists, that tab carries the board, so the Conductor skips the duplicate in-chat intro card; the new decision entry records and supersedes the old always-introduce shape. |
Human judgment recorded@iamwhatever marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@iamwhatever marked the fable AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
mbriones98
left a comment
There was a problem hiding this comment.
Checks green and readiness passed at 97f94d1; no behavior change.
buluoray
left a comment
There was a problem hiding this comment.
Reviewed at head 97f94d1.
What it fixes
A Conductor whose session has a Dashboard tab opened every first reply with a "Your Conductor" intro card that only repeats what the tab already shows. The prompt now skips the intro when the [RUNTIME] line names the dashboard and a [DASHBOARD] block names a template; chats with no tab keep the card, and messaging channels keep their plain-text intro.
Verified against source
src/kiro_crew/agent.py:5385-5395: the new paragraph sits ahead of the existing intro rule, now prefixed "Otherwise", and the board rule (goal-board/work-kanban, #18608) below it is untouched.- The "no tab keeps the intro" branch is real, not theoretical: the
[DASHBOARD]block is only emitted from the member-desk assembly (src/kiro_crew/context_assembly/member.py:577, viadashboard_agentic.turn_block), andturn_blockreturns""when no page is in force (src/kiro_crew/dashboard_agentic.py:888-903). An ordinary Crew Mode Conductor chat therefore carries no block and keeps the card; a Conductor crewmate desk resolves its default page (dashboard_templates/instance.pydefault_instance) and gets the block, so it skips the card. That matches the PR's "any template" scoping. - Decision record: the 2026-10-13 entry supersedes 2026-10-10, restates the unchanged board rule, and the evidence comment (issuecomment-6151461095) is posted by @iamwhatever.
scripts/check_decisions_history.pyagainstorigin/main: OK (18 entries intact). The superseded entry is unchanged. - No system-spec prose describes the intro rule, so nothing stale was left behind; the RFC that mentions the intro being "unchanged" is a historical proposal.
Mutation
Reverting only the agent.py hunk reddens test/test_agent_refactor_contracts.py::test_every_pre_split_name_resolves_with_its_pre_split_shape and all eight test/test_agent_refactor_spec_bytes.py::test_every_written_spec_matches_the_pre_split_bytes[*] cases. With the change: 74 passed in those two files. These are digest pins on the shipped text, which is the right level for a prompt-only change; no test exercises the model's behaviour, as expected.
Fail-open / fail-closed
No error path is added. If a [DASHBOARD] block cannot be built, turn_block returns "" and the Conductor falls back to the intro card, which is the safe pre-existing behaviour.
Non-blocking follow-ups
- The new paragraph says the
[RUNTIME]line names "the Kiro Crew dashboard", while the runtime string is "KiroCrew dashboard" (context_assembly/sections.py:30) and the neighbouring paragraph just says "names the dashboard". The model will match either way; aligning on the neighbour's wording would keep it consistent.
Not verified
The model's actual first reply on a desk with a Dashboard tab was not run; the review covers the prompt text and the conditions under which the block appears.
Problem / Motivation
Goal: A Conductor that has a Dashboard tab stops opening its first reply with a redundant "Your Conductor" intro card.
The Conductor prompt makes its first reply open with an intro widget ("I'm your Conductor", the tasks on the table, what it can do). A Conductor now has its own Dashboard tab, which already shows who it is and what is on the table, so the card repeats the tab.
Why it matters
Crew Mode users see the same information twice on every new Conductor chat, and the widget costs output tokens on every first reply.
Not a goal
goal-board/work-kanban).What changed (motivation → approach → change)
Symptom: redundant intro card → cause: the intro rule in
_CONDUCTOR_SYSTEM_PROMPThas no Dashboard-tab exception → change: one new paragraph in "Talking to the person" (src/kiro_crew/agent.py): when the[RUNTIME]line names the KiroCrew dashboard AND a[DASHBOARD]block says the Dashboard tab shows a template — any template — skip the introduction and get to work. A messaging channel (Slack, DM) keeps its short plain-text intro even when a[DASHBOARD]block is present, because it cannot see the tab.Same shape as #18608, which keys the in-chat board off the same
[DASHBOARD]block. The intro keys on any tab because every Dashboard tab identifies the crewmate; the board rule stays keyed on board pages because only those draw the tasks.Decision record: adds
docs/decisions/2026-10-13-conductor-with-a-dashboard-tab-skips-its-intro-card.md, superseding2026-10-10-conductor-board-tab-replaces-the-in-chat-board.md(which said every Conductor chat introduces itself). The decision is recorded on this PR: #19850 (comment). The superseded entry is untouched.Backwards compatibility
Compatible: prompt text only; chats without a Dashboard tab behave as before.
Removes nothing: no code path, key, record or function is removed; only the intro widget is omitted from the reply when a Dashboard tab exists.
Tests
test/test_agent_refactor_contracts.py:_CONDUCTOR_SYSTEM_PROMPTdigest updated.test/test_agent_refactor_spec_bytes.py:kirocrew-conductor.json/kirocrew-ledger-conductor.jsondigests regenerated (both embed the prompt).pytest -k decision(2364 passed);DECISIONS_BASE_REF=origin/main scripts/check_decisions_history.pyOK.Manual verification
N/A — prompt-text change; the digest tests pin the shipped text.
Related Issues
Closes #19849
Pattern harvest
Not generalizable: a prompt rule that predates the Dashboard tab, not a code defect class.
Checklist
Contribution License Agreement
Contributed under the project's Apache-2.0 license.