Repository navigation
docs(rfc): dispatch arms a patrol on session_create and bind - #19862
iamwhatever wants to merge 1 commit into
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that a maintainer confirms the 2026-10-13 product-owner ruling. It is quoted from a conductor session, and this document alone is what unblocks #19742. [DESIGN-REVIEWED] 7f51654 Description read[DESCRIPTION-READ] a9d6f571811df3fc6cbc0fca5aa5e2476b022f4fd94d347902c96850f213ec36 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
24fa0e8 to
131ce3b
Compare
|
|
|
Records the product owner's decision of 2026-10-13: dispatch means monitor. A non-dry-run session_create from a caller that holds a work ledger arms the same default patrol a bind arms; a caller with no ledger gets a note; a crew- or member-mode caller stays refused. A bind or a create replaces any loop the system stopped, a blocked outcome included, not only the gateway's own default; a loop a person stopped stays stopped and the arm answers refused (user-stopped). Every dispatch reply carries patrol and patrol_reason. The new document amends rfc-conductor-default-patrol.md by reference, so that implemented document is not edited. Adds its row to the RFC index. Part of #19741
131ce3b to
7f51654
Compare
|
Head 7f51654: the bind note in decision 2 is no longer credited to the product owner. docs/request-for-change/rfc-dispatch-arms-patrol.md:19-21 says it was added at the Design review's request, and the index row (docs/request-for-change/README.md:39) moves it out of the ruling sentence. Nothing else changed; rebased onto aaffa10. Maintainer review requested; auto-merge (squash) is armed. |
|
Pull request was closed
Problem / Motivation
Goal: Record the product owner's decision that a dispatch arms a patrol (
session_createarms the default patrol, and a dispatch replaces any loop the system stopped), so its implementation can land.The implementation PR #19742 changes what
session_createand a bind do by default. Its First Principles lane reads the decision off the base branch and blocks until an RFC on main covers it, so this document lands first.Why it matters
Without a recorded decision on main, #19742 stays blocked. A conductor whose own loop finished one round keeps dispatching the next round with nobody reading its workers, and the tool reply hides it.
Not a goal
rfc-conductor-default-patrol.md. This document amends it by reference; docs(rfc): conductor default patrol on a crew- or member-mode conductor #18699 and fix(conductor-patrol): admit the gateway patrol on a crew/member slot #18592 work on that file.What changed (motivation → approach → change)
Adds
docs/request-for-change/rfc-dispatch-arms-patrol.md, statusaccepted, with the product owner's ruling of 2026-10-13 quoted in its header. The rule is "dispatch means monitor":session_create(not a dry run), caller holds a work ledgersession_create, caller holds no work ledgerblockedoutcome includedrefused (user-stopped)Every dispatch reply carries
patrolandpatrol_reason. The bind note in the first row is not part of the ruling; the Design review asked for it, and the document says so. The document amendsrfc-conductor-default-patrol.md§2, §3 and §8 by reference, so that implemented document is not edited. Its row is added todocs/request-for-change/README.md.Backwards compatibility
Compatible: documentation only.
Removes nothing: adds one document and one index row.
Tests
N/A — docs only;
scripts/docs-lint.shpasses.Manual verification
N/A — docs only.
Related Issues
Part of #19741
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)