Skip to content

docs(rfc): dispatch arms a patrol on session_create and bind - #19862

Closed
iamwhatever wants to merge 1 commit into
mainfrom
docs/rfc-dispatch-arms-patrol
Closed

iamwhatever wants to merge 1 commit into
mainfrom
docs/rfc-dispatch-arms-patrol

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the product owner's decision that a dispatch arms a patrol (session_create arms the default patrol, and a dispatch replaces any loop the system stopped), so its implementation can land.

The implementation PR #19742 changes what session_create and a bind do by default. Its First Principles lane reads the decision off the base branch and blocks until an RFC on main covers it, so this document lands first.

Why it matters

Without a recorded decision on main, #19742 stays blocked. A conductor whose own loop finished one round keeps dispatching the next round with nobody reading its workers, and the tool reply hides it.

Not a goal

What changed (motivation → approach → change)

Adds docs/request-for-change/rfc-dispatch-arms-patrol.md, status accepted, with the product owner's ruling of 2026-10-13 quoted in its header. The rule is "dispatch means monitor":

Dispatch Decision
session_create (not a dry run), caller holds a work ledger arms the same default patrol a bind arms; the reply tells it to bind the session it opened, because the patrol reads only the ledger
session_create, caller holds no work ledger arms nothing; the reply carries a note
crew- or member-mode caller, either route refused, as a bind is refused today
bind or create over a loop the system stopped replaced, whoever armed it, a blocked outcome included
bind or create over a loop a person stopped kept; the reply says refused (user-stopped)

Every dispatch reply carries patrol and patrol_reason. The bind note in the first row is not part of the ruling; the Design review asked for it, and the document says so. The document amends rfc-conductor-default-patrol.md §2, §3 and §8 by reference, so that implemented document is not edited. Its row is added to docs/request-for-change/README.md.

Backwards compatibility

Compatible: documentation only.

Removes nothing: adds one document and one index row.

Tests

N/A — docs only; scripts/docs-lint.sh passes.

Manual verification

N/A — docs only.

Related Issues

Part of #19741

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 13, 2026 18:07
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 13, 2026
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 7f5165460b33d28e05749abe62c7a42201bc8d93 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 7f5165460b33d28e05749abe62c7a42201bc8d93 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 7f5165460b33d28e05749abe62c7a42201bc8d93 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that a maintainer confirms the 2026-10-13 product-owner ruling. It is quoted from a conductor session, and this document alone is what unblocks #19742.

[DESIGN-REVIEWED] 7f51654

Description read

[DESCRIPTION-READ] a9d6f571811df3fc6cbc0fca5aa5e2476b022f4fd94d347902c96850f213ec36

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 7f5165460b33d28e05749abe62c7a42201bc8d93 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 7f51654

Verdict parsed from the review's SHA-scoped output markers for commit 7f5165460b33d28e05749abe62c7a42201bc8d93.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 7f5165460b33d28e05749abe62c7a42201bc8d93: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 7f5165460b33d28e05749abe62c7a42201bc8d93 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 7f51654

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 7f5165460b33d28e05749abe62c7a42201bc8d93: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 13, 2026
dodgeblaster
dodgeblaster previously approved these changes Oct 13, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The armed reply on a create can be false span=8527ae5cbf55

fixed in 131ce3b: decision 2 makes every create reply from a ledger holder carry a bind note, whatever the patrol outcome: bind the session with work_ledger_record before you seed it, or read it with session_read_message. The patrol reads only the ledger, so the reply no longer implies the opened session is read.
Decision 6 says the same. §8 rejects relying on a bind always following a create, because nothing enforces it. §10 pins a test: a ledger holder's create carries the bind note whether the patrol was armed, already active or refused.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • session-cannot-host-loop appears under both refused and unsupported span=cd55de9d0832

fixed in 131ce3b: each reason in the §2 table has one trigger. refused (session-cannot-host-loop) is the authorizer's 403 (an incognito or temporary session, or a channel user outside its allowlist). A session key that maps to no loop slot answers unsupported (no-loop-slot). §10 pins both.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 13, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Confirm the product owner gave the quoted 2026-10-13 ruling

needs-a-decision: the ruling is quoted as the conductor session relayed it from the product owner's chat at 2026-10-13 17:34 UTC ("#19742 写 RFC,默认开巡查": write the RFC; a dispatch arms the patrol by default).
Auto-merge is not armed on this PR. The maintainer who merges it confirms that ruling by merging, before #19742 rebases onto it.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 13, 2026
Records the product owner's decision of 2026-10-13: dispatch means
monitor. A non-dry-run session_create from a caller that holds a work
ledger arms the same default patrol a bind arms; a caller with no ledger
gets a note; a crew- or member-mode caller stays refused. A bind or a
create replaces any loop the system stopped, a blocked outcome included,
not only the gateway's own default; a loop a person stopped stays
stopped and the arm answers refused (user-stopped). Every dispatch reply
carries patrol and patrol_reason.

The new document amends rfc-conductor-default-patrol.md by reference, so
that implemented document is not edited. Adds its row to the RFC index.

Part of #19741
@iamwhatever
iamwhatever force-pushed the docs/rfc-dispatch-arms-patrol branch from 131ce3b to 7f51654 Compare October 13, 2026 21:00
@iamwhatever
iamwhatever requested a review from buluoray October 13, 2026 21:01
@iamwhatever
iamwhatever enabled auto-merge (squash) October 13, 2026 21:01
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 13, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Head 7f51654: the bind note in decision 2 is no longer credited to the product owner. docs/request-for-change/rfc-dispatch-arms-patrol.md:19-21 says it was added at the Design review's request, and the index row (docs/request-for-change/README.md:39) moves it out of the ruling sentence. Nothing else changed; rebased onto aaffa10. Maintainer review requested; auto-merge (squash) is armed.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • A maintainer confirms the 2026-10-13 product-owner ruling

needs-a-decision: the ruling is quoted as the conductor session relayed it from the product owner's chat at 2026-10-13 17:34 UTC. A maintainer review is requested (buluoray), and the merge waits for that approval: auto-merge is armed, and GitHub lands nothing without it.
The bind note in decision 2 is credited to the Design review, not to the ruling (header and index row), so the approval covers it explicitly.

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 13, 2026
@github-actions github-actions Bot added the readiness: passed Eligible automated validation passed for the current revision label Oct 13, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #19893, which amends rfc-conductor-default-patrol.md in place (the RFC the First Principles lane on #19742 named). The decisions recorded here are carried in #19893 section 9.

auto-merge was automatically disabled October 13, 2026 22:51

Pull request was closed

@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 13, 2026
@bolichen97
bolichen97 deleted the docs/rfc-dispatch-arms-patrol branch November 6, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants