Skip to content

fix(shell-walk): read a heredoc body as commands only when its consumer can run it - #19892

Closed
mbriones98 wants to merge 3 commits into
mainfrom
fix/shell-walk-heredoc-home-19588
Closed

mbriones98 wants to merge 3 commits into
mainfrom
fix/shell-walk-heredoc-home-19588

Conversation

@mbriones98

@mbriones98 mbriones98 commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make the shared shell reader treat a heredoc body the way bash does and bound its descent on structure, so every argv floor reads the same, correct command shape.

security/shell_normalizer._shell_payload_walk is the one reader every argv floor goes through. It has two readings that do not match what the shell runs:

  1. A heredoc body is read as commands whatever consumes it. The walk folds a newline into ;, so it cannot tell bash <<EOF (runs the body) from cat <<EOF or git commit -F - <<EOF (reads it as data). A commit message, PR body or spec bullet that only names a flagged command is then read as that command.
  2. A nested payload that grows past its parent after $HOME expansion is not read. The walk descends a payload only while it is shorter than its parent's text, but $HOME is expanded per token before that comparison, so on a host with a long home path a payload exceeds the line and is skipped.

Why it matters

The first reading produces false refusals of ordinary data (a commit message, a file written through a heredoc). The second makes a correctness bound depend on a value outside the command, so the same command reads differently on two hosts. Both live in the one reader, so every floor inherits them.

Not a goal

  • No floor's deny matrix changes shape; this is the shared reader only.
  • No new command spelling is added to any catalog row.
  • Multi-heredoc and other non-simple shapes keep the fail-closed reading rather than gaining new attribution.

What changed (motivation → approach → change)

The reader (security/shell_normalizer.py) folds a heredoc body into the frame as ;-separated commands, which is why a data consumer's body is scanned as if it ran. The fix attributes a body to its consumer with a positive allow-list over the whole command: the body is set aside as data only when, with it removed, every command of every frame is a listed data consumer -- a bare cat/tee/head/grep-style program, or git/gh followed directly by a message subcommand (git commit/tag/notes, gh pr/issue/release). Any other program anywhere keeps every body: a shell or evaluator, xargs, a pipe into an unlisted program, a path such as ./f, a leading assignment, an operator glued inside a word, a process substitution, or git/gh with an option before the subcommand. The opener line must also end its command at the newline: a trailing backslash or an open quote keeps the body. Only the one-heredoc, one-opener-line shape is attributed. The frame's source drops the body together with its tokens, so token readers and source readers see the same command.

The descent bound is measured with the home path discounted, so a payload that lives inside one token of its parent stays shorter than the parent whatever the home path's length. The bound stays structural and no longer varies with $HOME.

The module spec entry for the reader is updated to describe both, and states the heredoc attribution as the one reading the reader sets aside, with why it lives in the reader. The package line budget rises for the added helpers.

This unblocks the parked chmod floor work in #19563, which can drop its local heredoc workaround and rely on the reader once this lands. #14993 rewrites the same walk for performance and will need a rebase against whichever lands first.

Backwards compatibility

Compatible: no command that is refused today becomes allowed unless every command in it is a listed data consumer; the only behaviour that changes is that a provably-inert data body is no longer read as commands, which removes false refusals. The frames the walk returns for every runner shape are the same.

Removes nothing: no reader, record, key or public function is removed; the walk's return type and callers are unchanged.

Tests

test/test_shell_walk_heredoc_and_home_bound.py locks the walk's behaviour on neutral commands: a data-consumer body is set aside (and absent from the frame source); a body any unlisted program, path, assignment, glued operator, process substitution, unlisted git/gh subcommand or -c option could run is read; a backslash-continued opener line and multi-heredoc shapes keep their body; a substitution inside a data body is still its own frame; and a nested payload is descended for both a short and a long home path, with the walk terminating on deep nesting.

test/test_security_gate_liveness.py raises the package line budget to match the added helpers.

Manual verification

N/A — unit coverage sufficient; the change is in a pure text reader exercised directly by the new tests and the existing shell-normalizer / argv-floor / denied-command suites.

Related Issues

Closes #19588

Pattern harvest

Rule candidate: review-prompt
Pattern: a text reader that folds a data region into executable structure refuses data that merely names a flagged command; attribute the region to its consumer through a positive allow-list over the whole command, so an unrecognised program keeps the region as commands.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@mbriones98
mbriones98 requested review from a team and KiroCrewCaptain as code owners October 13, 2026 19:08
@mbriones98
mbriones98 requested a review from CrysisDeu October 13, 2026 19:08
@mbriones98
mbriones98 enabled auto-merge (squash) October 13, 2026 19:09
@mbriones98 mbriones98 changed the title fix(security): read a heredoc body as commands only when its consumer can run it fix(shell-walk): read a heredoc body as commands only when its consumer can run it Oct 13, 2026
@mbriones98
mbriones98 force-pushed the fix/shell-walk-heredoc-home-19588 branch from 86f8116 to 2db1858 Compare October 13, 2026 19:32
@mbriones98

Copy link
Copy Markdown
Contributor Author

Rebased onto current main (43cc6d3), new head 2db1858. The one new base commit touches an adjacent import only; the shell-walk, argv-floor, denied-rule and spawn test sets pass locally on the new head.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/security/shell_normalizer.py

  • @mbriones98 posted a complete reasoning template for df249d4.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision df249d41fb4b38e46951545087bc02defc7a585f touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of df249d41fb4b38e46951545087bc02defc7a585f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Before merge, confirm the existing denied-command and argv-floor suites pass unchanged. None of them should expect a cat/tee/git commit heredoc body to be refused.

[DESIGN-REVIEWED] df249d4

Description read

[DESCRIPTION-READ] bcdedf309b1ac1a807a4c48ec3330f173976b16b1895ccee2a54671152e2180c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of df249d41fb4b38e46951545087bc02defc7a585f — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The data-consumer allow-list sets heredoc bodies aside for 15 programs and 4 subcommands that no reported defect or test calls for.

Not justified as shipped

  • Item 3 — inherited: the description justifies the list only as "a bare cat/tee/head/grep-style program". The new tests exercise only cat, tee, git commit and gh pr. The other 15 entries in _HEREDOC_DATA_PROGRAMS (tac through sha256sum) and git tag/notes and gh issue/release each narrow a reader the spec says "deliberately over-approximates". None of them names a false refusal that it removes.
    Subtraction: shrink _HEREDOC_DATA_PROGRAMS to {"cat", "tee"} and _HEREDOC_DATA_SUBCOMMANDS to {"git": {"commit"}, "gh": {"pr"}}, which is the set the tests pin.
    Clears when: each remaining entry is cited by Shared shell walk: heredoc bodies read as commands; HOME expansion can skip a nested payload #19588 or by a reproduced false refusal, or the entries are removed.

What this change ships

Inventory (7 items) — 6 justified

Intent: stop the shared shell reader refusing commit messages and heredoc-written files that only name a refused command, and make its descent bound the same on every host. This is a FIX.

  1. A cat/tee heredoc body is no longer read as commands — justified
  2. A heredoc message to git commit or gh pr is no longer read as commands — justified
  3. 15 more programs and git tag/notes, gh issue/release also set their bodies aside — inherited, no defect or test for these
  4. A set-aside body is also dropped from the frame source — justified
  5. A nested payload is descended whatever the length of $HOME — justified
  6. The package line budget is raised — justified
  7. The security spec's reader entry is updated — justified

[FIRST-PRINCIPLES-REVIEWED] df249d4

Description read

[DESCRIPTION-READ] 28fdcad5a6b26ffb20d90bfb5feda1e25de104d9c4bcf28ae2a21eac0a6a0fc2

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 13, 2026
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — 🔴 changes requested (blocking)

Reviewed df249d41fb4b38e46951545087bc02defc7a585f — this comment is updated in place on each push.

Blocking: two easy-to-write shapes of shell text now hide a git push to a protected branch from the push floor, which this repo's own comment calls "the SOLE enforcement for pushes".

BLOCKING — src/kiro_crew/security/shell_normalizer.py:3590
openers = [i for i, token in enumerate(tokens) if _HEREDOC_OPEN_RE.search(token)] / if len(openers) != 1 or len(_HEREDOC_OPEN_RE.findall(source)) != 1:
A quoted or escaped << is not a heredoc to bash, but this code treats it as one. Input cat "<<eof"\ngit push origin main\neof (also cat '<<eof', cat \<<eof, grep -c "<<x" f\n…\nx) goes is_denied → _shell_payload_sources → _shell_payload_walk → _without_inert_heredoc_bodies, which strips the push line. is_denied returns None on this head; base aaffa10 returns git-publish-push-protected-branch-name.
Fix: find the opener on the raw source with the quote-aware scanner, and return None whenever a << in the raw text is not an active, unquoted and unescaped operator.

BLOCKING — src/kiro_crew/security/shell_normalizer.py:3565
tag = re.split(r"[;&|]", marker)[0] … stripped = "\n".join(lines[: opener_line + 1] + rest)
A redirect glued to the tag makes the code read the wrong tag. Input cat <<eof>/dev/null\nhi\neof\ngit push --force origin main yields tag eof>/dev/null. No line matches it, so rest stays [] and everything after the opener is dropped, but bash ends the body at eof and runs the push. is_denied returns None on this head and blocks on base.
Fix: end the tag at every shell metacharacter ([;&|<>()\s]), and return None (keep the body) when no line matches the computed tag, instead of running the body to the end of the text.

[BLOCK-MERGE] df249d4
[OPUS-REVIEWED] df249d4

Verdict parsed from the review's SHA-scoped output markers for commit df249d41fb4b38e46951545087bc02defc7a585f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable df249d41fb4b38e46951545087bc02defc7a585f: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — 🔴 changes requested (blocking)

GPT 6.1 found at least one blocking issue that must be resolved before merging 2db1858d999c0686bbadcc8ecf23f7c1983c72c4. 2 of 2 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands.

This comment is updated in place on each push.

BLOCKING -- src/kiro_crew/security/shell_normalizer.py:3569 -- Quoted literal text deletes subsequent executable commands
openers = [i for i, token in enumerate(tokens) if _HEREDOC_OPEN_RE.search(token)]
true\necho "<<eof"\n/usr/bin/p[k]ill -f kirocrew -> the reader mistakes quoted text for a heredoc and drops the kill command -> is_denied allows both the raw command and its Running: title; the sandbox permits the targeted signal, allowing gateway termination.
Anchor: residual/security
Fix: Identify active redirects and quote-remove delimiters from quote-aware source; retain frames when heredoc boundaries cannot be established correctly.

BLOCKING -- src/kiro_crew/security/shell_normalizer.py:3606 -- Literal runner membership drops heredoc bodies that execute
if _program_basename(token) in _PRINTED_TEXT_RUNNERS:
true\ncat <<eof | sed e\n/usr/bin/p[k]ill -f kirocrew\neof -> _can_run_printed_text declares the body inert and removes it -> is_denied allows both raw command and title although sed e executes the gateway-killing command; awk '{system($0)}' and /bin/ba[s]h reproduce the bypass.
Anchor: residual/security
Fix: Consult the existing execution-grammar and glob-aware shell helpers before declaring printed text inert, retaining bodies for these executable consumers.

[BLOCK-MERGE] 2db1858
[GPT-REVIEWED] 2db1858

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

F1 — security-class (unbounded). I confirmed the conditions. shell_normalizer.py:3569 matches << inside any token, quoted ones included. :3570 only checks that there is one opener and one << in the source. :3579-3586 then drops every line after the opener up to the tag, or to the end of the input if no tag line appears. So echo "<<eof" followed by a command on the next line makes that command disappear. Nothing in this path recovers it. Any attacker-shaped command line can produce this.

F2 — security-class (unbounded). I confirmed the conditions. :3606 only treats a token as a runner if its name is in _PRINTED_TEXT_RUNNERS (:3529: shells, eval verbs, xargs). A sed script argument like e, or an awk system() program, matches neither the runner names nor _EXPANSION_LEAD_RE (:3538). So the reader calls the heredoc body inert and :3628-3632 removes it, even though the consumer can execute it. The inputs are ordinary and nothing about them is extreme.

[ADJUDICATION] 2db1858d999c0686bbadcc8ecf23f7c1983c72c4 total=0 uphold=0 downgrade=0
[GPT-ADJUDICATED] 2db1858d999c0686bbadcc8ecf23f7c1983c72c4

[ADJUDICATION-FENCED] 2db1858d999c0686bbadcc8ecf23f7c1983c72c4 fenced=2 flagged=0
UPHOLD-FENCED F1 src/kiro_crew/security/shell_normalizer.py:3569 -- A quoted `<<` counts as a heredoc opener with no quote check, so later command lines are dropped from the deny scan using ordinary, easy-to-write input.
UPHOLD-FENCED F2 src/kiro_crew/security/shell_normalizer.py:3606 -- The runner check only matches program names, so `sed e` and `awk system()` consumers get their executable heredoc body removed as inert data using common inputs.
[GPT-ADJUDICATED-FENCED] 2db1858d999c0686bbadcc8ecf23f7c1983c72c4

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2db1858d999c0686bbadcc8ecf23f7c1983c72c4: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 13, 2026
…y reads it

Read the body as data only when, with it removed, every command of every
frame is a listed data consumer, and the opener line ends its command at the
newline. git and gh qualify only through a message subcommand right after the
program. The frame source drops the body along with its tokens.
@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=78886e91ad58 Narrowing in the reader vs the spec rule

Fixed in 844efd8. The spec entry now states the heredoc attribution as the one reading the reader sets aside, and why it lives there (a folded body is mis-read by every floor at once). It is now a positive allow-list over the whole command: a body is set aside only when every command of every frame is a listed data consumer, so any unlisted program anywhere keeps every body.

@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=029710f5f2d0 git/gh subcommand never checked

Fixed in 844efd8. git and gh now qualify only when the word right after the program is a listed message subcommand (git commit/tag/notes, gh pr/issue/release); any global option before it, or any other subcommand, keeps the body. New neutral test rows: git x <<eof, gh x <<eof.

@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=c6a480acaa23 arguments of a data program never examined (git -c alias)

Fixed in 844efd8. git -c ... puts an option before the subcommand, so it no longer qualifies and the body is kept. The same row is a new test case, and the shape is refused end to end through is_denied again.

@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=c94578a4e989 Clears-when conditions

Both met in 844efd8: the spec entry explicitly states the exception and its reason, git/gh are admitted only through a positive subcommand allow-list, and a test pins that a -c alias configuration keeps the body.

@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=97062eb88627 split the home-length bound into its own PR

Kept together: the linked issue asks for both readings in one change, and the parked follow-up pins both answers in one test file that flips together. The bound change is a few lines and isolated in its own helper, so it can be reviewed on its own here.

@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=c6fead24b81e source keeps the body while tokens drop it

Fixed in 844efd8. The walk now returns the stripped source together with the stripped tokens, so every reader of the frame, including the source-based ones, sees the same command shape. A new test pins that the set-aside body appears in no frame source.

@mbriones98

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 844efd8
  • What rule changed: the shared shell reader sets a heredoc body aside as data only when, with it removed, every command of every frame is a listed data consumer (bare cat/tee/head/grep-style program, or git/gh with a message subcommand right after the program) and the opener line ends at its newline. Its descent bound is measured with the home path discounted.
  • Before -> after (what was allowed/blocked, now): before, any heredoc body was read as commands, so a commit message or file body that only names a refused command was refused. After, that data body is allowed. Any other program, path, assignment, glued operator, process substitution, continued opener line or multi-heredoc shape keeps the body read as commands, as before. A nested payload under a long home path is now read where before it was skipped.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): a body that does run is read as data, so a floor misses a command in it. The allow-list is limited to programs with no option that starts another program, and the decision is over the whole command, so one unlisted program anywhere restores the old reading.
  • Evidence checked (which sandbox result proves it): the reviewer's continued-line, | fish, ./f, and git -c alias shapes are refused end to end through is_denied on this head. A plain git commit -F - message is allowed.
  • No regression:
    • Tools still work (which tools/commands were run, result): git commit -F - heredoc, cat > file <<eof, tee, and gh pr create --body "$(cat <<eof ...)" read as data. Shells, xargs and evaluators still read the body.
    • Backward compatible (old config / old data / old callers still work, how checked): the walk's return type and callers are unchanged. 8,070 tests across the shell-normalizer, argv-floor, denied-rule, floor, heredoc and security suites pass locally.
    • Existing tests (which suites passed on this head): test_security*.py, test_shell*.py, test_*argv*.py, test_*denied*.py, test_*floor*.py, test_*perm_verb*.py, test_shell_walk_heredoc_and_home_bound.py. test_security_conductor_* fails identically locally without this change (environment), and CI runs it.
  • How to undo: revert the squash commit. The reader goes back to reading every heredoc body as commands.

…c-home-19588

# Conflicts:
#	test/test_security_gate_liveness.py
@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=c65544f87915 shell_normalizer.py:3582 opener line continued onto the next line

Fixed in 844efd8. The body is set aside only when the opener line ends its command at the newline: a trailing backslash or an open quote keeps the body. The continued-line shape from this finding is refused end to end again, and a neutral test row pins the reading.

@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=c65544f87915 shell_normalizer.py:3529 short list of runners treated as complete

Fixed in 844efd8. The test is inverted to a positive list: a body is set aside only when every command of every frame is a bare listed data consumer (cat, tee, grep-style filters) or git/gh with a message subcommand right after the program. fish, sort, a path such as ./f, a leading assignment, a glued operator, or a process substitution all keep the body. Each of the three cited shapes is refused end to end again and has a neutral test row; git/gh with -c no longer qualify.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 13, 2026
@mbriones98

Copy link
Copy Markdown
Contributor Author

Merged current main (aaffa10) into the branch, new head df249d4. The only conflict was the package line budget, which both sides raised; it now carries both entries and the measured total. The shell-walk, argv-floor, denied-rule, floor and security test sets pass locally on the new head.

@mbriones98

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: df249d4
  • What rule changed: the shared shell reader sets a heredoc body aside as data only when, with it removed, every command of every frame is a listed data consumer (bare cat/tee/head/grep-style program, or git/gh with a message subcommand right after the program) and the opener line ends at its newline. Its descent bound is measured with the home path discounted.
  • Before -> after (what was allowed/blocked, now): before, any heredoc body was read as commands, so a commit message or file body that only names a refused command was refused. After, that data body is allowed. Any other program, path, assignment, glued operator, process substitution, continued opener line or multi-heredoc shape keeps the body read as commands, as before. A nested payload under a long home path is now read where before it was skipped.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): a body that does run is read as data, so a floor misses a command in it. The allow-list is limited to programs with no option that starts another program, and the decision is over the whole command, so one unlisted program anywhere restores the old reading.
  • Evidence checked (which sandbox result proves it): the reviewer's continued-line, | fish, ./f, and git -c alias shapes are refused end to end through is_denied on this head. A plain git commit -F - message is allowed.
  • No regression:
    • Tools still work (which tools/commands were run, result): git commit -F - heredoc, cat > file <<eof, tee, and gh pr create --body "$(cat <<eof ...)" read as data. Shells, xargs and evaluators still read the body.
    • Backward compatible (old config / old data / old callers still work, how checked): the walk's return type and callers are unchanged. 8,130 tests across the shell-normalizer, argv-floor, denied-rule, floor, heredoc and security suites pass locally.
    • Existing tests (which suites passed on this head): test_security*.py, test_shell*.py, test_*argv*.py, test_*denied*.py, test_*floor*.py, test_*perm_verb*.py, test_shell_walk_heredoc_and_home_bound.py. test_security_conductor_* fails identically locally without this change (environment), and CI runs it.
  • How to undo: revert the squash commit. The reader goes back to reading every heredoc body as commands.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Security Scope Review -- 🔴 could not complete (fails closed)

No scope verdict for 2db1858d999c0686bbadcc8ecf23f7c1983c72c4 (the review produced no [SCOPE-REVIEWED] marker for this head). This lane fails CLOSED: an unmeasured tightening must not read as "nothing newly refused". See the job logs, then re-run -- or record /ai-review override scope 2db1858d999c0686bbadcc8ecf23f7c1983c72c4: <reason> if a human has judged the scope by hand.

@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=4de88fe5b78f allow-list entries not each cited by the issue or a test

Kept as shipped, with reasoning. Every entry is a program whose only use of stdin is to read, print, count, filter or hash it, and none has an option that starts another program; each is a member of the existing data-consumer vocabulary, minus the members that can spawn (sed, awk, pagers, sort, jq). A heredoc into any of them is the same shape as the cat case the issue reports, so the narrowing per entry is the cat reading, not a new one. git tag -F - and git notes add -F - take a message from stdin exactly as git commit -F - does. Whole-command gating means one unlisted program anywhere keeps every body. If a maintainer prefers the minimal list (cat, tee, git commit, gh pr), dropping the rest is a one-line change with no test impact.

@mbriones98

Copy link
Copy Markdown
Contributor Author

Confirmed on this head: the existing denied-command, argv-floor, floor, perm-verb, shell-normalizer and security suites pass unchanged locally (8,130 passed). No existing test expected a cat, tee or git commit heredoc body to be refused, and no existing assertion was edited; the only test edits are the new walk tests and the package line budget.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 13, 2026
@mbriones98

Copy link
Copy Markdown
Contributor Author

Superseded by #19951 (same change, recut as a single commit on current main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shared shell walk: heredoc bodies read as commands; HOME expansion can skip a nested payload

1 participant