Repository navigation
fix(dashboard): the conductor page counts the tasks the work fold forgot - #19902
Conversation
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The pull request (PR) fixes the conductor meter, but the same undercount is still live in Not justified as shipped
What this change shipsInventory (4 items) — 3 justifiedIntent: the conductor's default page shows true done and total counts on a long goal. FIX.
[FIRST-PRINCIPLES-REVIEWED] b036774 Description read[DESCRIPTION-READ] 58da5ddadcef383618f1045f0d3287b99963b5a44028f35201850f8021b5d0c5 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The meter now says "9 of 13" above only two cards, and nothing on the page explains where the other 11 tasks went. Watch
Suggestions
[UX-REVIEWED] b036774 Description read[DESCRIPTION-READ] 4140105fd3ed3ffb832731edf809702cc13210cf8d1f822389e49c103a1a6637 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] b036774 Description read[DESCRIPTION-READ] 8f10b50e5404c9eb3a5a5493d0e27fdfd00a69d54b442b3a9f35ea7695b7a74b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
96cf2e0 to
c958ce0
Compare
c958ce0 to
ab0228b
Compare
ab0228b to
b036774
Compare
|
span=0d3060dd15a6
|
|
span=4c6ae75862e8
|
|
span=19deb628ce4f
|
Problem / Motivation
Goal: The conductor's default dashboard page shows true done and total counts on a long goal.
The builtin
kirocrew-conductorpage (#19706) counts done and total from the work fold'sitemsonly. Since #19068 the work fold forgets closed items past its window: they leaveitemsand are counted inwork.forgotten. So once old tasks are forgotten, the page's meter undercounts both numbers.goal-boardalready readsforgotten; this page does not.Why it matters
Every conductor crewmate opens this page by default. On a goal with more closed tasks than the fold keeps, the meter says far less is done than really is.
Not a goal
goal-boardor any other builtin page.itemsholds.What changed (motivation → approach → change)
Symptom: done and total shrink once the fold forgets closed tasks. Cause: the page never bound
work.forgotten. Change:src/kiro_crew/dashboard_templates/builtin/kirocrew-conductor/manifest.jsonbinds{"fold": "work", "path": "forgotten"}the waygoal-boarddoes, and the meter in itstemplate.htmladds it in the waygoal-board(drawLoop) andpipeline_board_contract.pycount a board, so one goal reads the same total on every page:forgotten.acceptedforgotten.items(rejected and abandoned tasks stay in, as before this PR)The total no longer adds
omitted: that counter counts dropped log entries, not tasks (pipeline_board_contract.pysays the same and leaves it out), so adding it made a total no other page shows. The truncation line under the cards still readsomitted. A missing or oddforgotten(an older gateway) reads as zeros. The manifestversionstays 1, as #19068 leftgoal-board's.Backwards compatibility
Compatible: the new field is read-only and optional; a gateway without
forgottengives zeros. The one visible change on such a gateway is that a board withomitted > 0no longer adds those entries to its total, matchinggoal-board.Removes nothing: the change only adds a bound field and adds counts to the meter.
Tests
website/src/test/conductorBoardPage.test.ts: a forgotten-heavy fixture (2 listed, 11 forgotten) reads "9 of 13", the same totalgoal-boardgives, with matching progressbar ARIA values; a listed rejected task stays in the total and is not counted as working;omittedentries stay out of the total; missing, null, string, array and negativeforgottenvalues read as zeros.test/test_dashboard_template_kirocrew-conductor.py:forgottenis bound exactly asgoal-boardbinds it, and the meter readsforgotten.itemsandforgotten.accepted.test/test_dashboard_templates_builtin.py(unchanged) stays green: the new path resolves in the captured work fold with the declared type.Determinism: the new vitest cases are pure DOM over a fixed field bag; the file ran green 3 times in a row and in shuffled order.
Manual verification
Rendered the page before and after in headless Chromium on the same forgotten-heavy field bag (sample data; the host's own field fill is not simulated, so the goal reads "-").
Screenshots / video
Rendered in headless Chromium on the forgotten-heavy fixture (2 listed, 11 forgotten), dark theme.
Before (main): "1 of 2 accepted by the conductor", bar at 50%.
After: "9 of 13 accepted by the conductor · 1 working", bar at 69%.
The cards and the rest of the page are unchanged.
Related Issues
Closes #19886
Follow-up to #19706 and #19068.
Pattern harvest
Rule candidate: review-prompt
Pattern: a builtin page that draws a whole-board count from
work.itemswithout addingwork.forgotten. Known sibling left open:flow's "accepted … of N" tile (#20023).Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)