Skip to content

feat(chat): fork with history from the message menu when tail-only fork is on - #19963

Closed
javenciu wants to merge 1 commit into
mainfrom
fix/18611-explicit-fork-direction-entries
Closed

javenciu wants to merge 1 commit into
mainfrom
fix/18611-explicit-fork-direction-entries

Conversation

@javenciu

@javenciu javenciu commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Let a user who keeps Tail-only Fork on take a full-history fork from the message menu at the moment they fork, instead of flipping the global setting first.

"Fork conversation from here" follows one global setting, Tail-only Fork (tail_fork_enabled). Off, the fork copies the transcript up to the chosen message. On, it keeps only the messages after that point. The setting applies to every session at once, so a user who wants a full-history fork for one piece of work and a tail-only fork to split a thread out of a long session has to open Settings before each fork, and a toggle left in the wrong position silently changes what the next fork produces (#18611).

Why it matters

Both modes are in daily use by the same person, for different jobs, so the setting is flipped repeatedly and the wrong-mode fork is easy to produce without noticing. The fork request already carries a direction on the wire; only the menu keeps the user from choosing it.

Not a goal

  • Changing the server. src/kiro_crew/dashboard/chat_fork.py still answers a tail request with a head-fork while Tail-only Fork is off, and this PR leaves that gate as it is.
  • Making the entry available while Tail-only Fork is off. They would fork with history there, which is the behaviour the issue complains about. Letting the server honour an explicit tail request is a separate decision about a documented, default-off gate.
  • A mode chooser inside a dialog, or any new component.
  • The whole-session fork actions in SessionGridView.tsx and useSessionActions.ts. They fork with no fork point (api.forkChatSlot(slot)), so a tail does not apply.
  • The fork button a row draws in place of the menu entry (forkRow in AssistantMessage.tsx: a fork point with no message id the server can resolve). It sits in a row capped at two controls and opens no menu, so there is no place for a second choice; with Tail-only Fork on it still forks the tail, as it does on main. Offering history there means a new control on that row, which is a layout decision for a surface this change does not touch.

What changed (motivation → approach → change)

Symptom. One setting decides the direction of every fork (handleFork in useForkSession, website/src/pages/useChatPageSlotSwitches.ts, read tail_fork_enabled and picked 'tail' or 'head'), and the message menu offered one fork entry.

Approach. One entry beside the plain one, "Fork with earlier messages", shown while Tail-only Fork is on. In that state the plain entry forks the tail (explicitDirection ?? (resolvedCfg?.tail_fork_enabled ? 'tail' : 'head') in handleFork), so the fork the menu lacked is the one with history, and the entry names head itself instead of reading the setting. With the setting off the plain entry already forks with history, so a second entry would repeat it and the menu stays as it is today.

Telling the pair apart. While both entries are listed the plain entry forks only the messages after the clicked one, so it reads "Fork with later messages only", which names what the new chat holds, beside "Fork with earlier messages". Both draw the GitFork icon, and the labels carry the difference. With the setting off, or before the fork point resolves (the plain entry then only pages earlier history), the plain entry keeps "Fork conversation from here". Under its label each of the two entries carries one line saying what the new chat holds and that this chat is left as it was ("Starts a new chat with this message and the ones before it. This chat is not changed." and "Starts a new chat with only the messages after this one, not this message. This chat is not changed.", so each says which messages the new chat holds and whether the clicked one is among them); the menu's "Copy as rich text" entry already has a line of this kind (copy_as_rich_text_hint). On the newest message nothing follows and the server refuses a tail fork (chat_fork.py, no_messages_after_fork_point), so there "Fork with later messages only" is held and its line reads "No messages after this one yet."; "Fork with earlier messages" still forks. The menu is capped at the viewport width and at 20rem and keeps 8 px from the screen edges, so both lines wrap at 390 and 320 px instead of running past the edge. While a fork runs both entries are dimmed and held, and in the one that started it the spinner takes the icon's place, so its label keeps its column.

One premise to correct. The issue says the backend already takes the direction per request. That holds on the wire, but chat_fork.py:378 downgrades a tail request to head while dashboard.tail_fork_enabled is false, the default, and docs/system-specs/modules/history.md documents that fallback as the contract. A "Fork tail only" entry could only repeat the plain entry (setting on) or fork with history under a tail label (setting off), so none is shipped, and the direction a menu entry can name is typed 'head'.

Changed since earlier revisions. The first revision also added "Fork tail only"; review showed it repeated the plain entry in the only state it was shown, so it is removed with its fork_tail_only key and tests (the "Not a goal" bullet that says "the two entries" now means the one that remains). The second revision left the plain entry reading "Fork conversation from here" with the same icon as "Fork with earlier messages", and a first-time reader could not tell which one drops earlier messages. The paragraph above is the fix. The branch is now one commit on the current main; the review rounds' fixes (the spinner on the chosen entry, both entries dimmed while a fork runs, the mirrored wording) are folded into it. A later round renamed the added entry from "Fork with history" to "Fork with earlier messages", so the two entries read as one choice. The latest round adds the line under each entry and keeps the icon beside the in-flight spinner, both from the UX review. This round renames the plain entry from "Fork without earlier messages" to "Fork with later messages only", because the old name implied that only earlier messages were left out while the clicked message is left out too; it gives both entries the fork icon, puts the spinner in the icon's place, and holds the plain entry on the newest message.

Change.

  • website/src/pages/chat/AssistantMessage.tsx: a forkDirectionChoice prop and one DropdownMenuItem (fork-with-history) in the More menu's fork block. runForkAction takes an optional direction; the plain entry still calls onFork(i) or onFork(i, mid), and only this entry adds a third argument, 'head'. The entry appears once the fork point resolves and is held, and dimmed, while a fork runs. plainForkLabel picks the plain entry's label, and each entry gets a description line (fork-hint, fork-with-history-hint, tied to its entry by aria-describedby). A forkNothingAfter prop holds the plain entry while it forks the tail and no message follows, with "No messages after this one yet." as its line. Both entries draw GitFork, and in each the spinner takes the icon's place while its fork runs, as the lone plain entry already did. The More menu carries max-w-[min(20rem,calc(100vw_-_1rem))] and collisionPadding={8}, and the second entry lays out its two rows on an inner span it owns, not on the item, which keeps the file at its restyle-ratchet baseline.
  • website/src/pages/useChatPageSlotSwitches.ts: in useForkSession, handleFork takes an optional explicitDirection ('head'), and the hook also returns forkDirectionChoice, which is forkCfg?.tail_fork_enabled === true, from the query handleFork already uses. Absent or false, nothing changes, as shareEnabled fails closed. main moved handleFork out of ChatPage.tsx into this hook, so the change lives here.
  • website/src/pages/ChatPage.tsx: reads forkDirectionChoice from useForkSession and passes it to useTranscriptRendering.
  • website/src/pages/chat/page/transcriptRendering.tsx: the transcript row render hands forkDirectionChoice to AssistantMessage (added to the hook's options and its dependency list), and forkNothingAfter when the row is the last user or assistant message, the same roles the server counts; handleFork's option type gains the optional third argument. main moved the row render out of ChatPage.tsx into this file, so the pass-through lives here. The option is optional, so existing callers and test fixtures need no change.
  • Keys pages.chat.assistantMessage.fork_with_history, fork_later_messages_only, the description lines fork_with_history_hint and fork_later_messages_only_hint, and the newest-message line fork_no_later_messages in en.manual.json (where this menu's other hand-written labels live, copy_as_rich_text_hint among them), the 11 translated catalogs and en-XA.json via npm run i18n:pseudo, and a translator note for each new key in en.context.json; fork_conversation_from_here is untouched. The two labels in Bengali and Hindi use the informal imperative their style guides require (style/bn.md section 5, style/hi.md section 4); the description lines there are statements, not commands.
  • docs/system-specs/modules/history.md: one sentence at the tail-fork gate.
  • website/scripts/capture-18611-fork-menu.mjs and its page website/capture/fork-menu.{html,tsx}: the real-browser capture behind the stills below, at 760, 390 and 320 px.

Rejected.

  • "Fork tail only" (first revision): it repeats the plain entry.
  • Always-visible entries: a tail entry forks with history by default; with a refusal notice instead, a dead control for every default user and a second copy of a rule the server owns.
  • Making the server honour an explicit tail request: the right layer for "tail whatever the setting says", but it changes a documented, tested gate, so it is a maintainer decision and a separate change.
  • Renaming the pair "New chat with / without earlier messages" (the review's example): "without earlier messages" is the name this round drops, since the plain entry leaves out the clicked message too; "Fork with later messages only" names what that new chat holds, and the line under each entry says the rest without lengthening the labels.
  • A description line under the plain "Fork conversation from here" entry while Tail-only Fork is off: it would change the default menu for every user who never turns the setting on, which this change keeps as it is. That entry forks with history there, as it does on main.

Tests added.

  • AssistantMessage.test.tsx, fork with history entry: the direction each entry sends; the label, order and icon of each entry; the plain label with the choice off and before the fork point resolves; no entry without the prop, before the fork point resolves, or on a row that keeps its fork as the row button; both entries held and dimmed, with their description lines, while a fork runs; the description line under each entry and the aria-describedby that ties it to the entry; no description line with the choice off or before the fork point resolves; both entries drawing the fork icon, and the spinner taking the icon's place in the entry whose fork runs; the plain entry held on the newest message with its "No messages after this one yet." line while "Fork with earlier messages" still forks, and the lone plain entry not held there; and keeps the menu inside a 320 or 390 px viewport and lets both description lines wrap (the menu's width cap, and no ancestor of a description line that forces one row).
  • ChatPageMoreCoverage.test.tsx: handleFork with a named head and with the plain entry, for both values of the setting; forkDirectionChoice for both; forkNothingAfter true on the newest reply and false on a reply with a later message.
  • ChatPage.handleFork.test.tsx: its mirror of handleFork's direction expression gains explicitDirection and one case where a named head wins. It tests its own copy, so it cannot fail on the old useChatPageSlotSwitches.ts; the ChatPageMoreCoverage.test.tsx cases can.
  • bnStyle.test.ts and hiStyle.test.ts ([changed-values]) read the values this branch writes; no new test.

Backwards compatibility

Compatible: nothing that works today stops working. The new prop is optional and absent means no change, the plain entry calls onFork with the same arguments as before, and handleFork's new third parameter is optional. The catalog keys are additions in every catalog.

Reader: while Tail-only Fork is on and "Fork with earlier messages" is listed, the plain entry reads "Fork with later messages only" instead of "Fork conversation from here". Its action is unchanged, except that on the newest message, where the server refuses a tail fork, it is held with a line saying no messages follow yet; with the setting off its label and its action are unchanged. While the second entry is listed, both entries also carry a short description line, and in the entry that starts a fork the spinner takes the icon's place. With the setting off too, the plain entry now dims, besides showing its spinner, while its own fork runs; on main it was dimmed only while the fork point was unresolved.

Removes nothing: no entry, key, prop, route or request field is removed or hidden.

Tests

In short: the menu gains "Fork with earlier messages" while Tail-only Fork is on, the plain entry then reads "Fork with later messages only", each entry carries a line saying what the new chat holds, and the new tests fail on the old source and pass on this one: 210 of 210 in each of three runs of the three touched files.

Red on the previous revision's source, this revision's tests: with only AssistantMessage.tsx put back, AssistantMessage.test.tsx fails 6 of 125 (the label, both fork icons, the held entry on the newest message, the spinner in the icon's place for each entry, and the renamed line key); with only transcriptRendering.tsx put back, the two new forkNothingAfter cases in ChatPageMoreCoverage.test.tsx fail. The earlier measurements below were taken on earlier revisions.

Red on the base source, measured on an earlier revision, before the 320 and 390 px test was added (AssistantMessage.tsx, useChatPageSlotSwitches.ts, ChatPage.tsx and transcriptRendering.tsx put back to the merge base, tests as in this PR), three runs of AssistantMessage.test.tsx and ChatPageMoreCoverage.test.tsx: 10 failed, 177 passed of 187 in each, the same ten every time. The failures are the assertions this change adds: Unable to find an element by: [data-testid="fork-with-history"] (4), Unable to find an element by: [data-testid="fork-with-history-hint"] (1), expect(received).toBeInTheDocument() for the plain entry's icon beside its spinner (1), forkDirectionChoice undefined where false is expected (2) or true is expected (1), and forkChatSlot called with the setting's direction where the entry named head (1). The other 177 pass on both sides: they pin the plain entry, the row-button fork and the Share menu, and the cell where the setting is off and the entry names head coincides with what the old handler picks.

Red on an earlier revision's source (only AssistantMessage.tsx put back), three runs of AssistantMessage.test.tsx: 3 failed, 119 passed of 122 in each. The three were that revision's: the history entry has no svg.lucide-history while its fork runs and the plain entry no svg.lucide-git-fork beside its spinner (both expect(received).toBeInTheDocument()), and Unable to find an element by: [data-testid="fork-with-history-hint"]. The tests that pin the unchanged cases (no line with the choice off or before the fork point resolves, and the lone plain entry still swapping its icon for the spinner) pass on both sides, as they should.

Green with this change, three runs of the three touched test files: 210 of 210 each. On an earlier revision vitest related over the four changed source files (AssistantMessage.tsx, useChatPageSlotSwitches.ts, ChatPage.tsx, transcriptRendering.tsx) ran 456 test files and 6460 tests, all passing, and the 69 test files that render AssistantMessage or touch the fork path, including website/integration/ForkSession.integration.test.tsx, passed together (1246 tests). On this revision the locale style tests under src/i18n/style (12 files, 121 tests), including the Bengali and Hindi register gates bnStyle.test.ts and hiStyle.test.ts, pass with origin/main as I18N_BASE_REF.

Measured on an earlier revision, before this round changed the icons and where the spinner sits: twenty-three one-line breaks of the shipped code each fail one to three of the tests that pin the broken line (AssistantMessage.test.tsx for the entry, ChatPageMoreCoverage.test.tsx for the handler and the pass-through). Against the labels, icons, dimming and description lines: the plain label never switching (1 test), the label ignoring the fork point (1), the label always switched (3, including the existing unavailable-item test), the history entry reusing the fork icon (2), the held entry never dimmed (1) and always dimmed (1), the plain entry's description line dropped (2), shown on the lone entry (2) or not dimmed with its entry (1), the history entry's description line reading the wrong key (1) or lacking its aria-describedby (1), the History icon swapped for the spinner again (1), and the plain entry's icon not kept beside its spinner while both entries are listed (1) or kept when it is alone (1). Against the entry and handler: the entry sending no direction (2), the fork-point guard dropped (2), the forkDirectionChoice prop ignored (3), the entry not held while a fork runs (2), the forkItemsInMenu guard dropped so that a row that keeps its fork as the row button would list the entry in its Share menu (1), the handler ignoring a named direction (1), an absent setting read as on (1), the transcript renderer not passing the prop (3) and ChatPage.tsx not handing it to the renderer (3). A twenty-fourth, dropping forkDirectionChoice from the transcript renderer's dependency list, passes every test (187 of 187) and is caught by eslint --max-warnings 0 (react-hooks/exhaustive-deps, a warning that fails the gate), with the unmutated file passing as the control.

tsc -p tsconfig.app.json, eslint --max-warnings 0 on the touched source, test and capture-script files, npm run lint:restyle-ratchet (every file matches the baseline, restyle-baseline.json unchanged), npm run lint:phantom-classes, npm run lint:theme-colors, npm run lint:i18n and npm run i18n:check all exit 0 on this revision. jscpd ., scripts/docs-lint.sh, and scripts/check_comment_history.py and scripts/check_brand_name.py with their base ref set to the merge base were last run on an earlier revision, all exit 0.

Manual verification

Run in Chromium, not against a live gateway: website/scripts/capture-18611-fork-menu.mjs renders the real AssistantMessage with the props the transcript renderer (website/src/pages/chat/page/transcriptRendering.tsx) passes for a reply whose fork point resolved on the server (forkIndex, forkMessageId), with onFork recording its calls and fetch for /api/ answered with empty fixtures. It asserts, with real pointer clicks at the item's centre (first checking with elementFromPoint that the item is what the pointer lands on):

  • Tail-only Fork on: the fork entries read "Fork with later messages only", then "Fork with earlier messages", both with the fork icon and their labels in one column, each with its line saying what the new chat holds, and neither is held.
  • Tail-only Fork off: the plain entry only, still reading "Fork conversation from here" with the fork icon, with no description line and no "Fork with earlier messages".
  • "Fork with earlier messages" calls onFork(1, 'm2', 'head') and the plain entry calls onFork(1, 'm2').
  • With a fork started from "Fork with earlier messages" pending, both entries carry aria-disabled="true" and render, with their lines, at half opacity; a click on either starts no second fork; in "Fork with earlier messages" the spinner takes the icon's place, the labels stay in one column, and the plain entry shows no spinner.
  • On the newest message (no later message drawn, forkNothingAfter as the transcript renderer passes it there): "Fork with later messages only" carries aria-disabled="true", is dimmed, reads "No messages after this one yet." under its label and starts no fork when clicked; "Fork with earlier messages" is not held.
  • With Tail-only Fork off, at 320, 390 and 760 px and with Read aloud and Share in the menu: every label row is 20.1 px tall at a 20.15 px line height and the one line under Copy as rich text 16.0 px at 16 px, so the width cap wraps no entry.
  • At 390 and 320 px wide, with Tail-only Fork on: the menu spans 8 to 328 px and 8 to 312 px (on the previous revision it spanned 0 to 508 px in both), keeps 8 px from both screen edges and has no horizontal overflow; the description line under the plain entry takes three rows and the one under the history entry two, each ending inside the menu; both entries are what a pointer lands on.

Not exercised: the gateway's reply to the head fork, which is the existing chat_fork.py path and is unchanged. The dashboard still has to be driven against a gateway with Tail-only Fork on and then off to see the menu end to end.

Screenshots / video

The More menu of an assistant reply, rendered in Chromium by the real AssistantMessage with the props the transcript renderer passes.

Tail-only Fork on. The plain entry forks the tail and says the new chat holds only the later messages; "Fork with earlier messages" says it keeps them. Both draw the fork icon. Under each label a line says what the new chat holds and that this chat is not changed.

More menu with Tail-only Fork on: Fork with later messages only, then Fork with earlier messages, each with a line saying what the new chat holds

Tail-only Fork off, the default. The menu is unchanged: the plain entry only, with its short label.

More menu with Tail-only Fork off: the plain fork entry only

A fork in flight. A fork started from "Fork with earlier messages" is pending and the menu is open again. In that entry the spinner takes the icon's place, so both labels stay in one column, and both entries and their lines are dimmed. Both ignore clicks, so a second click starts no second fork.

More menu while a fork is in flight: in Fork with earlier messages the spinner takes the icon's place, both entries are dimmed and both ignore clicks

The newest message. Nothing follows it, so "Fork with later messages only" is held and its line says so; "Fork with earlier messages" still forks.

More menu on the newest message: Fork with later messages only is dimmed with the line No messages after this one yet, and Fork with earlier messages is available

Narrow screens. The same menu in a 390 px and a 320 px wide viewport: it stays inside the screen, keeps 8 px from both edges, and both description lines wrap.

More menu in a 390 px wide viewport: the menu stays inside the screen and both description lines wrap

More menu in a 320 px wide viewport: the menu stays inside the screen and both description lines wrap

A first-time reader's questions. Can they tell the two entries apart? The labels name what each new chat holds, earlier messages or later messages only, and the line under each says whether the clicked message is in it. Does the plain label say what it does in this state? With the setting on it names what the new chat holds, and on the newest message, where there is nothing to hold, it is held with that reason; with the setting off the plain entry forks with history, so its short label is true there. Does the menu say what a fork does to the chat they are in? With the setting on, the line under each entry says the new chat is a copy and this chat is not changed. A number beside other numbers? There is none. A failure state? A failed fork still goes through the existing showActionError path, which this change leaves as it is.

Related Issues

Part of #18611

With Tail-only Fork turned on once, the menu offers both directions per fork: the plain entry forks the tail and "Fork with earlier messages" forks with history. A per-fork tail choice while the setting is off needs the server to honour an explicit tail request, which changes the gate documented in docs/system-specs/modules/history.md, so the issue stays open for that decision.

Pattern harvest

Not generalizable: a new menu capability, not a defect fix; the one general point, that a UI control must not offer a choice the server silently overrides, is specific to this gate.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners October 13, 2026 21:41
@javenciu
javenciu requested a review from mbriones98 October 13, 2026 21:41
@javenciu

Copy link
Copy Markdown
Contributor Author

Closing and reopening right after opening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683).

@javenciu javenciu closed this Oct 13, 2026
@javenciu javenciu reopened this Oct 13, 2026
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 13, 2026
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of cc3e451bb7613e58ef1a10ce001d6d8ddcb5a90e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

While a fork runs, the only sign is a bare spinner on a dimmed entry, and the blind reader could not tell if it was busy, blocked or broken.

Watch

  • In-flight state has no words. busyAction === 'fork-with-history' swaps GitFork for Loader2 and dims both entries with opacity-50. The label and hint text do not change. On shot-01 the reader said: "no idea whether it is busy, already running, or switched off… I would not click." This happens on every fork, for as long as the fork request takes. The cost is small, but the user gets no closure on the main action. Fix: while busy, change the running entry's label to "Forking…" (or its hint to "Starting the new chat…").
  • The held "later messages only" entry gives no reason while a fork runs. In shot-01 it is grey but still shows its normal hint. The reader said: "It is grey and nothing tells me why." The same fix covers it: while busyAction !== null, change the non-running entry's hint to "Another fork is starting."

Suggestions

  • fork_later_messages_only_hint: put the exclusion first, e.g. "Only the messages after this one go to a new chat. This chat is not changed." The reader saw that "later" leaves out the clicked message "only [from] the small print."

[UX-REVIEWED] cc3e451

Description read

[DESCRIPTION-READ] 9f27d9c7aad48c36ec09ca17a643e1926d9fa69f22a42aabc8124944b5c03b21

That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed cc3e451bb7613e58ef1a10ce001d6d8ddcb5a90e — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] cc3e451

Verdict parsed from the review's SHA-scoped output markers for commit cc3e451bb7613e58ef1a10ce001d6d8ddcb5a90e.

False positive or not applicable? A repository writer can comment:
/ai-review override fable cc3e451bb7613e58ef1a10ce001d6d8ddcb5a90e: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of cc3e451bb7613e58ef1a10ce001d6d8ddcb5a90e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that the previous reply's "Fork with later messages only" becomes clickable once a newer message arrives. forkNothingAfter is read from visibleIndexMapRef inside memoized renderers.

[DESIGN-REVIEWED] cc3e451

Description read

[DESCRIPTION-READ] 57030d31b2c33a37fb299be5732134cf5c565e7c030442a078b2a326264f6fcc

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of cc3e451bb7613e58ef1a10ce001d6d8ddcb5a90e — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check that holding "Fork with later messages only" on the newest reply only happens in the case where chat_fork.py:956 refuses with no_messages_after_fork_point.

What this change ships

Inventory (8 items) — 6 justified

Intent: let someone who keeps Tail-only Fork on take a full-history fork from the message menu without changing the setting first (#18611). ADDITION.

  1. With Tail-only Fork on, the message menu adds a "Fork with earlier messages" entry that sends direction="head". — justified
  2. With the setting on, the plain entry is renamed "Fork with later messages only". With it off, nothing changes. — justified
  3. Each of the two entries gets a one-line hint saying what the new chat holds. — justified
  4. On the newest message, "later messages only" is held and reads "No messages after this one yet." — rides along: a fix for a server refusal, not the Goal
  5. The More menu is capped at 20rem or the viewport width and keeps 8px from screen edges. — rides along: wraps the hint lines on narrow screens
  6. While a fork runs, both entries are dimmed and held, and the spinner takes the icon's place. — justified
  7. The history.md spec gains a paragraph on the second entry. — justified
  8. The PR commits screenshots under temp-screenshots/ plus a capture page and script. — justified

[FIRST-PRINCIPLES-REVIEWED] cc3e451

Description read

[DESCRIPTION-READ] fe179a58ed9ced0b844350ee965dbbc7b548ac87faf5f7dc2c4561743d1446b8

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of cc3e451bb7613e58ef1a10ce001d6d8ddcb5a90e and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] cc3e451

False positive or not applicable? A repository writer can comment:
/ai-review override gpt cc3e451bb7613e58ef1a10ce001d6d8ddcb5a90e: <one-sentence reason>

@javenciu
javenciu force-pushed the fix/18611-explicit-fork-direction-entries branch from c0929a4 to ce82d5b Compare October 14, 2026 01:24
@javenciu

Copy link
Copy Markdown
Contributor Author

Round 2 on c0929a4855, fixed in ce82d5bdaf. The branch is also rebased onto the current main.

  1. Subtraction. "Fork tail only" is removed: its menu item, the fork-tail-only test id, the fork_tail_only key in all 13 catalogs and the tail half of the explicit-direction tests. While Tail-only Fork is on, the plain entry already forks the tail (ChatPage.tsx:1718), so the entry repeated it in the only state it was shown (ChatPage.tsx:1701). One explicit entry remains, "Fork with history". It is shown only while the setting is on: with the setting off the plain entry already forks with history, so a second entry would repeat it and the menu stays as it is today. The direction a menu entry can name is now typed 'head'.
    The "Not a goal" bullet that says "the two entries" is frozen; it now means the one entry that remains.

  2. Bengali and Hindi register. bnStyle.test.ts > bn register (style/bn.md §5) > [changed-values] addresses the reader as তুমি, never আপনি failed on fork_with_history and fork_tail_only, which both ended in করুন. fork_tail_only is gone with item 1 and fork_with_history now reads ইতিহাস সহ ফর্ক করো. Frontend Tests (3) failed the same kind of gate for Hindi, hiStyle.test.ts > hi register (style/hi.md §4) > [changed-values] addresses the reader as तुम, never आप, on फ़ोर्क करें; it now reads फ़ोर्क करो. Both gates pass with I18N_BASE_REF set to the base, and so does every other test under src/i18n.

  3. Captures. The description now carries three stills of the More menu, rendered in Chromium by the real AssistantMessage with the props ChatPage.tsx passes: Tail-only Fork on (the plain entry, then "Fork with history"), Tail-only Fork off (the menu unchanged) and a fork in flight (both fork entries ignore clicks, so a second click starts no second fork). A held entry is not dimmed: the plain entry did not dim while a fork ran before this change either, and its spinner is the in-flight cue.

@javenciu

Copy link
Copy Markdown
Contributor Author

span=539a7b63e79f

fixed in ce82d5b: the ['tail', 'fork-tail-only', ...] tuple, the fork_tail_only key in all 13 catalogs and the tail half of the explicit-direction tests are deleted, and forkChoices became one fork-with-history item (website/src/pages/chat/AssistantMessage.tsx).
git grep -n -E 'fork_tail_only|fork-tail-only|Fork tail only' prints nothing at ce82d5b. The three touched test files pass 190 of 190 in each of 3 runs; with origin/main's two source files put back, the same tests in AssistantMessage.test.tsx and ChatPageMoreCoverage.test.tsx fail 8 of 182 in each of 3 runs.

@javenciu

Copy link
Copy Markdown
Contributor Author

span=a0772d1dad4d

fixed in ce82d5b: with the tail entry removed, the entry that forkDirectionChoice (ChatPage.tsx:1701) gates no longer repeats the plain entry. While the setting is on the plain entry forks the tail and "Fork with history" forks with history; with the setting off the gate hides it, because the plain entry already forks with history.
website/src/test/ChatPageMoreCoverage.test.tsx pins both ends: forkDirectionChoice is true while Tail-only Fork is on and false while it is off.

@javenciu

Copy link
Copy Markdown
Contributor Author

span=113ddf77d26a

fixed in ce82d5b: that line (ChatPage.tsx:1718) is why a tail entry repeated the plain one, and it is why none is shipped. The explicit direction the line now accepts is typed 'head', so only "Fork with history" uses it and no entry can name tail.
website/src/test/ChatPageMoreCoverage.test.tsx: a named head forks with history for both values of the setting, and the plain entry follows the setting for both values.

@javenciu

Copy link
Copy Markdown
Contributor Author

span=81ce4ba27a52

fixed in ce82d5b: the "Fork tail only" label is removed with its entry, so the menu no longer contains the word "tail". The one entry this change adds is "Fork with history".
git grep -n -E 'fork_tail_only|fork-tail-only|Fork tail only' prints nothing at ce82d5b. The Settings label "Tail-only Fork" is unchanged and is where a reader meets the word.

@javenciu

Copy link
Copy Markdown
Contributor Author

span=b5ff891338a0

fixed in ce82d5b: the menu has two fork entries now and they do different things. While Tail-only Fork is on, "Fork conversation from here" forks the tail and "Fork with history" forks with history; with the setting off only the plain entry shows, and it forks with history. The pair that did the same thing is gone with the "Fork tail only" entry.
The plain entry's label does not say that it follows the setting. That is the existing behaviour of Tail-only Fork and is unchanged here.

@javenciu

Copy link
Copy Markdown
Contributor Author

span=cd9f31b6db2d

rebutted: the first half renames fork_tail_only, which is removed. The second half would rename fork_with_history to "Fork with earlier messages". The same menu already says "history" for the earlier part of the conversation (pages.chat.assistantMessage.needs_earlier_history, "Select to load the next page of earlier history", in website/src/i18n/locales/en.manual.json), and the rename re-translates the key in 13 catalogs for a wording preference.
With the duplicate gone, "Fork with history" sits beside one entry that forks the tail, which is what the label contrasts with. If the lane reads it as ambiguous on the new head, the rename is a one-key change.

@javenciu

Copy link
Copy Markdown
Contributor Author

span=cfad3be4759b

fixed in ce82d5b: the description carries three stills of this revision's More menu, rendered in Chromium by the real AssistantMessage with the props ChatPage.tsx passes: Tail-only Fork on (the plain entry, then "Fork with history"), Tail-only Fork off (the menu unchanged) and a fork in flight.
Manual verification now says what was run: pointer clicks at the item centre, onFork(1, 'm2', 'head') for the new entry and onFork(1, 'm2') for the plain one, and aria-disabled on both entries with no second fork started while one is pending.

@javenciu

Copy link
Copy Markdown
Contributor Author

span=23762c65cab0

fixed in ce82d5b: "Fork tail only" is removed, so the menu offers only a direction that differs from the plain entry: "Fork with history" while the setting is on, and nothing extra while it is off.
The other half of the finding stands: the setting has to be on first. With it off the server turns a tail request into a history fork (chat_fork.py:339), so a per-fork tail choice needs a server change. "Not a goal" names that change and Part of #18611 leaves the issue open for it.

@javenciu

Copy link
Copy Markdown
Contributor Author

Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683).

@javenciu javenciu closed this Oct 14, 2026
@javenciu javenciu reopened this Oct 14, 2026
@javenciu javenciu changed the title feat(chat): fork with history or tail only from the message menu ## Problem / Motivation Oct 14, 2026
@javenciu javenciu changed the title ## Problem / Motivation feat(chat): fork with history from the message menu when tail-only fork is on Oct 14, 2026
@javenciu
javenciu force-pushed the fix/18611-explicit-fork-direction-entries branch from ce82d5b to 291f5ce Compare October 14, 2026 03:33
@javenciu

Copy link
Copy Markdown
Contributor Author

Round 3 on ce82d5bdaf, fixed in 291f5ce008.

  1. The two fork entries read as the same action. While Tail-only Fork is on, the plain entry forks the tail (ChatPage.tsx:1718) but its label said "Fork conversation from here", and both entries used the GitFork icon, so a reader could not tell which one drops the earlier messages. In that state, and only then, the plain entry now reads "Fork without earlier messages" (AssistantMessage.tsx:164, new key pages.chat.assistantMessage.fork_without_earlier_messages in all 13 catalogs) and "Fork with history" draws the History icon (AssistantMessage.tsx:607), already used elsewhere in the dashboard, beside the plain entry's GitFork. With the setting off, or before the fork point resolves (the plain entry then only pages earlier history, and its reason line asks for that history), the plain entry keeps "Fork conversation from here" and the fork_conversation_from_here value is unchanged. The held "Fork with history" is also dimmed while a fork runs (AssistantMessage.tsx:606), which answers the in-flight Watch. The description has three new stills, rendered by website/scripts/capture-18611-fork-menu.mjs and website/capture/fork-menu.tsx (both added here), and the "Backwards compatibility" section gains a Reader: line for the relabel.

@javenciu

Copy link
Copy Markdown
Contributor Author

span=52b6736aee5d

  • The two fork entries read as the same action. fixed 291f5ce: while Tail-only Fork is on (the only state in which both entries are listed), the plain entry now reads "Fork without earlier messages" (the lane's own wording; new key pages.chat.assistantMessage.fork_without_earlier_messages in all 13 catalogs, the Bengali value in the register bnStyle.test.ts enforces) and "Fork with history" draws the History icon, so label and icon both tell them apart; with the setting off the plain entry's label is unchanged. The held state of the new entry while a fork runs is now dimmed like the plain entry's (the Watch item). Pinned in website/src/test/AssistantMessage.test.tsx (the "fork with history entry" cases: 3 red on ce82d5b, green on the fix; 196 passed across the four touched suites). The three stills were re-shot from the committed website/scripts/capture-18611-fork-menu.mjs and replaced under temp-screenshots/fork-menu/.

@javenciu

Copy link
Copy Markdown
Contributor Author

span=be92a370b7c4

  • The review stills are committed to the repository. kept: the stills are the description's evidence for a visual change, and website/scripts/capture-18611-fork-menu.mjs re-shoots all of them from the current menu (this revision re-shot the three existing stills and added the 390 and 320 px ones, five files under temp-screenshots/fork-menu/). A merge lands committed review media on main, and the merging maintainer drops it in a follow-up chore(evidence) change (docs/ci/ci-and-reviews.md:2814), so the stills do not become permanent. The capture page and script are the repo's usual shape for this evidence (website/capture/ pages driven by a website/scripts/capture-*.mjs script).

@javenciu

Copy link
Copy Markdown
Contributor Author
  • Before dashboardConfig loads, the menu shows "Fork conversation from here", which forks the tail. kept: checked in the code, and the click does not act on a guess. forkDirectionChoice is forkCfg?.tail_fork_enabled === true (website/src/pages/useChatPageSlotSwitches.ts:35), so until the query resolves it is false: forkWithHistory is false (website/src/pages/chat/AssistantMessage.tsx:157) and the menu is main's single entry with its old label (:159), pinned by leaves the menu as it was while the host does not offer the choice (website/src/test/AssistantMessage.test.tsx:745). That entry reads the setting when it is chosen, not when the menu was drawn: handleFork runs forkCfg ?? await api.dashboardConfig() before it picks a direction (useChatPageSlotSwitches.ts:51-53), so a click in that window waits for the config and forks the tail only when the setting is on, which is what the same entry does on main. The window is the config request ChatPage starts on mount (useForkSession, website/src/pages/ChatPage.tsx:468). Making the entry wait for the config would need a visible pending state and a new string in 13 catalogs for a gap that changes no outcome, so it is not part of this change.

@javenciu

Copy link
Copy Markdown
Contributor Author
  • Check that the tail hint matches what chat_fork.py keeps at the fork point for a tail fork. kept: checked in the code and it matches, and the wording is now exact about the clicked message. For direction="tail", src/kiro_crew/dashboard/chat_fork.py:950-951 keeps visible[: at_index + 1] in the parent as the archived head and gives the new chat visible[at_index + 1 :]: the messages after the clicked one, not the clicked one. A head fork keeps visible[: at_index + 1] (:961). The tail hint therefore reads "Starts a new chat with only the messages after this one, not this message. This chat is not changed." and the head hint "Starts a new chat with this message and the ones before it. This chat is not changed." (website/src/i18n/locales/en.manual.json:4946-4947), the same slice docs/system-specs/modules/history.md documents for the tail fork (visible[at_index+1:]).

@javenciu

Copy link
Copy Markdown
Contributor Author

Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683).

@javenciu javenciu closed this Oct 16, 2026
@javenciu javenciu reopened this Oct 16, 2026
…rk is on

The message menu forked in the direction of one global setting, so a
user who wants both kinds of fork in a day had to flip Tail-only Fork
in Settings before each one (#18611).

While the setting is on, the plain "Fork conversation from here" entry
forks the tail, so the menu now also lists "Fork with earlier
messages". It sends direction head itself instead of reading the
setting. With the setting off the plain entry already forks with
history, so the menu is unchanged.

While both entries are listed the plain one reads "Fork with later
messages only", which names what the new chat holds: the messages after
this one, not this message. Both entries draw the fork icon. Each
carries a short line under its label that opens "Starts a new chat
with", says which messages the new chat holds, and says that the
current chat is left as it was. On the newest message nothing follows,
and the server refuses a tail fork there (no_messages_after_fork_point),
so the transcript renderer passes forkNothingAfter and the entry is held
with "No messages after this one yet." in place of its line; "Fork with
earlier messages" still forks. The menu is capped at the viewport width
(and 20rem) and keeps 8 px from the screen edges, so both lines wrap at
390 and 320 px instead of running past the edge. Only the entry that
was chosen shows the spinner while its fork runs, in its icon's place so
its label keeps its column; the other one dims and ignores clicks. The
new entry lays out its two rows on an element inside the item, not on
the menu item itself. The catalog key fork_with_history keeps its older
name. Its value, the new fork_later_messages_only, the two *_hint keys
and fork_no_later_messages are in all 13 catalogs, Bengali and Hindi in
the register their style guides require.

useForkSession (pages/useChatPageSlotSwitches.ts) takes an optional
explicit direction in handleFork and returns forkDirectionChoice,
which comes from the query handleFork already reads; ChatPage hands it
to the transcript renderer, which passes it to AssistantMessage. An
absent prop leaves the menu as it was.

Add the capture page and script that render the menu states in
Chromium at 760, 390 and 320 px, and the stills they produce.
@javenciu
javenciu force-pushed the fix/18611-explicit-fork-direction-entries branch from 74ef91f to cc3e451 Compare October 17, 2026 00:43
@javenciu

Copy link
Copy Markdown
Contributor Author

span=8f43560ebdab

  • The pair's names imply only earlier history differs. fixed: the plain entry now reads "Fork with later messages only" (website/src/i18n/locales/en.manual.json:4970, picked at website/src/pages/chat/AssistantMessage.tsx:159), so its label names what the new chat holds, the messages after this one, and no longer reads as "this message plus the later ones". Its line is unchanged and now agrees with the label: "Starts a new chat with only the messages after this one, not this message. This chat is not changed." (en.manual.json:4972). Beside it "Fork with earlier messages" keeps its name, so the pair still reads as one choice: earlier messages, or later messages only. All 13 catalogs carry the new key fork_later_messages_only; the locale style tests pass with I18N_BASE_REF=origin/main (12 files, 121 tests, no skipped line). Pinned by labels each entry by what the new chat holds and lists the history entry second (website/src/test/AssistantMessage.test.tsx:725) and the capture script's [on] the plain entry names what the new chat holds check.

@javenciu

Copy link
Copy Markdown
Contributor Author

span=119bb156ff5b

  • The in-flight state reads as ambiguous, and the label moves. fixed: the spinner now takes the icon's place in both entries instead of drawing beside it (website/src/pages/chat/AssistantMessage.tsx:588 for the plain entry, :613 for "Fork with earlier messages"), so the chosen entry is the one whose icon turned into a spinner and its label stays in the column of its neighbours. Both entries are still held and dimmed while the fork runs (:571, :586), as the maintainer's review asked. In Chromium the capture script checks [inflight] the spinner takes the chosen entry's icon slot and [inflight] both labels still start in one column (label left edges within 1 px), both OK, and the in-flight still is re-captured; AssistantMessage.test.tsx:810 and :844 pin the swap for each entry.

@javenciu

Copy link
Copy Markdown
Contributor Author

span=00ecf9fe4a89

  • Both primary entries are understood, but only as "a guess". fixed: "Fork with earlier messages" now draws the same GitFork icon as the plain entry (website/src/pages/chat/AssistantMessage.tsx:613), and the History icon and its import are gone, so both fork entries look like fork actions and the labels carry the difference. Pinned by draws both entries with the fork icon (website/src/test/AssistantMessage.test.tsx:734) and the capture script's [on] both entries draw the fork icon check; the setting-on still is re-captured.

@javenciu

Copy link
Copy Markdown
Contributor Author

span=0db562180cbf

  • Say on the latest reply that there are no later messages yet. fixed: on the newest message a tail fork has nothing to copy and the server refuses it (src/kiro_crew/dashboard/chat_fork.py:951-958, no_messages_after_fork_point), so the entry is held there instead of failing after the click. The transcript renderer passes forkNothingAfter when the row is the last user or assistant message (website/src/pages/chat/page/transcriptRendering.tsx:332; it counts the same roles as the server's list, transcriptRendering.tsx:143-154 and chat_fork.py:889). The entry then carries aria-disabled, ignores the click and shows "No messages after this one yet." in place of its line, still as its aria-describedby (website/src/pages/chat/AssistantMessage.tsx:161, :571, :577, :595; new key fork_no_later_messages in all 13 catalogs). "Fork with earlier messages" still forks there, and the lone plain entry with the setting off is unchanged. Pinned by AssistantMessage.test.tsx:743 and :760, and by the capture script's [newest] checks with a new still, fork-menu-newest-reply.png.

@javenciu

Copy link
Copy Markdown
Contributor Author
  • Check what a cached tail_fork_enabled up to 30 s old does while the server decides the direction. kept: a stale value can give a fork with history under the later-messages label, and it cannot lose or change anything. The menu and the plain entry's direction read the same query value (website/src/pages/useChatPageSlotSwitches.ts:31, staleTime: 30_000; forkDirectionChoice from it, and direction = explicitDirection ?? (resolvedCfg?.tail_fork_enabled ? 'tail' : 'head') at :53 with resolvedCfg = forkCfg ?? ... at :51), so what the menu shows and what the plain entry sends never disagree inside this tab. If the setting was turned off in another tab, the plain entry still sends tail and the server downgrades it to a head fork (src/kiro_crew/dashboard/chat_fork.py:378-392, audited as allowed): the new chat then holds this message and the earlier ones although the label said later messages only, and the source chat is untouched either way (docs/system-specs/modules/history.md:1071). "Fork with earlier messages" sends head, which the server honours in both states. If the setting was turned on elsewhere, the menu still shows the lone "Fork conversation from here", which sends head and gets a fork with history, as that label means today. The mismatch lasts until the query refetches. The server owns the gate, so a client-side re-read before each fork would add a request to every fork to narrow a window the server already makes safe; the change does not add one.

@javenciu

Copy link
Copy Markdown
Contributor Author
  • Check that the max-w-[min(20rem,…)] cap on the More menu wraps no existing entry when Tail-only Fork is off. kept: measured, no entry wraps. The capture script now opens the menu with the setting off at 320 px, 390 px and 760 px, with Read aloud and Share added so every entry the menu can list beside the fork entry is present, and measures each label row and each muted line on its own (website/scripts/capture-18611-fork-menu.mjs, the [off-w...] block). At all three widths every label row (Quote message, Copy as rich text, Copy link to message, Pin message, Show raw markdown, Read aloud, Share as image, Fork conversation from here) is 20.1 px tall at a 20.15 px line height, and the one muted line, under Copy as rich text, is 16.0 px at 16 px: one line each. The run printed no entry's label or line wraps => OK for all three widths and ended all checks OK. The cap is 304 px at 320 px (calc(100vw - 1rem)) and 320 px (20rem) from a 336 px viewport up, above the menu's min-w-[210px] floor (website/src/pages/chat/AssistantMessage.tsx:477).

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 17, 2026
@javenciu

Copy link
Copy Markdown
Contributor Author

Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683).

@javenciu javenciu closed this Oct 17, 2026
@javenciu javenciu reopened this Oct 17, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 17, 2026
@javenciu
javenciu enabled auto-merge (squash) October 17, 2026 09:11
@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at cc3e451. The fix for our earlier request is in: each fork entry now shows its own spinner (AssistantMessage.tsx L163 and L613). This head still has AI findings with no reply:

  • UX Review CONCERNS: the running entry has no words while busy, the held entry gives no reason, and the hint suggestion.
  • Design Review punchline: forkNothingAfter is read from visibleIndexMapRef inside memoized renderers (transcriptRendering.tsx L332). Please show that the older reply's 'Fork with later messages only' re-enables when a new message arrives, ideally with a test.
  • First Principles punchline: the hold should match exactly where chat_fork.py returns no_messages_after_fork_point.
    Post a head=cc3e451 disposition for each item (fix or rebut). CI is green; Sensitive Change Review is still queued. I did not run a browser or tests. — crew-pr-reviewer (r109)

@javenciu
javenciu disabled auto-merge October 18, 2026 05:31
@javenciu

Copy link
Copy Markdown
Contributor Author

Closing without merging, to keep my open PRs to the ones close to landing.

The Oct 17 hold on this head (cc3e451) still has three open items: the UX concerns about the busy and held entries, the Design question of whether an older reply's "Fork with later messages only" re-enables once a newer message arrives, and matching the hold to where chat_fork.py returns no_messages_after_fork_point.

The direction entries aren't on main as of 2e50054, and #18611 stays open. I've deleted the branch; it can be restored from this page at cc3e451.

@javenciu javenciu closed this Oct 18, 2026
@javenciu
javenciu deleted the fix/18611-explicit-fork-direction-entries branch October 18, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants