Repository navigation
fix: list custom agents before crewmates in the chat agent picker - #19989
Conversation
9c85db0 to
93a3690
Compare
|
Goal / Not a goal edited at the author's explicit request (Zezhen, dashboard chat, 2026-10-13): keep only the first sentence of the custom-agents hint ("A custom agent is a reusable agent setup."). Folded into this PR as the same picker surface; the i18n value changes in every locale ride the same commit. |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the Crewmates group can still be found when the list is long: the screenshot cuts it off at the pop-up's edge, and the fix is deferred to #20227. [DESIGN-REVIEWED] c2e0dc6 Description read[DESCRIPTION-READ] 5c5b6bfc7a5701e6732f90a98b94e9c95a3f252711105b1958e1d6a9826eaa79 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS Putting custom agents first pushes the Crewmates group below the pop-up's edge, and the shorter hint no longer says how the two groups differ. Watch
Suggestions
[UX-REVIEWED] c2e0dc6 Description read[DESCRIPTION-READ] ba756a72cfa4388845371d669b232280921902fed2334002382ed6dddf63f2f0 That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The shorter hint drops the workspace and memory fact, which a deleted test pin called "the one fact a first-time picker needs". Only the author's account of a maintainer chat supports dropping it. Not justified as shipped
What this change shipsInventory (5 items) — 4 justifiedIntent: with the crewmates flag on, the chat agent picker opens on the custom-agents group, where the default ★ row sits. This is a FIX (#19987).
[FIRST-PRINCIPLES-REVIEWED] c2e0dc6 Description read[DESCRIPTION-READ] f3d338679e5a5b2e84bdd9e29d9d8be6484bc4fd90a48f607c531f30076db1fe That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
93a3690 to
6de4111
Compare
|
Re UX Review (advisory) on 93a3690:
Re Design / Opus / First Principles on 93a3690: the shared key leak is fixed on 6de4111 — the chat picker now reads its own key |
iamwhatever
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES at 6de4111. The author reply explicitly defers the below-fold Crewmates/scroll-cue item. Please fix it here or link its follow-up issue. The description currently links only #19987. Please also answer the current-head UX and Design copy findings. If the maintainer chose the exact hint, record that decision clearly. Align the feature-map wording with any intended display-order claim. I am not treating a slash-separated list alone as a product bug. No frontend tests or screenshots were executed locally. — crew-pr-reviewer (r99)
6de4111 to
c379df5
Compare
|
@iamwhatever re r99 on 6de4111, addressed on c379df5:
|
c379df5 to
0ba26c1
Compare
|
Re the 0ba26c1 round:
|
0ba26c1 to
eb4a0b3
Compare
The grouped chat agent pop-up drew the Crewmates group above Custom agents. A session created without a crewmate runs the default template, so the template group is the one holding the way back from any switch; it now leads and Crewmates follows. The hint under that group reads one sentence, what a custom agent is, on its own key (group_templates_hint) in every locale; the schedule form keeps the shared key and its wording. The AgentSelector picker and the flat list are unchanged. Closes #19987
eb4a0b3 to
c2e0dc6
Compare
mbriones98
left a comment
There was a problem hiding this comment.
Checks green and readiness passed at c2e0dc6; no behavior change.
iamwhatever
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES at c2e0dc6.
The reorder itself is fine: AgentDropdownList.tsx:324 flips the group order, the chat picker reads its own group_templates_hint key, the schedule form's hint is unchanged, the feature-map and spec rows match, and every check on this head is green.
What blocks approval:
- The deferred below-the-fold item has no live tracking issue. The description links #20227 as the follow-up, but #20227 was closed as completed on 2026-10-14 with no comment and no fix on main. Please reopen it, or open a new issue for it and link that in the description. If you would rather fix it here, the UX lane suggests capping the template group's height or adding a scroll-edge fade.
- The First Principles CONCERNS on this head clears only when the maintainer asks for the one-sentence hint on this PR in their own words, or the key is reverted. A relayed quote does not clear it. The UX lane's 'groups look the same' concern depends on the same ruling. Please get that comment from the maintainer, then post
target=first-principlesandtarget=uxdispositions for c2e0dc6.
I read the diff and CI; I did not run the frontend tests or the capture script.
— crew-pr-reviewer (r101)
Problem / Motivation
Goal: In the chat agent picker, the Custom agents group is listed first with a one-sentence hint, and the Crewmates group follows it.
The grouped chat agent pop-up (visible with
dashboard.crewmates_in_agent_pickeron) drew Crewmates above Custom agents. A session created without a crewmate runs the default template, so the group that holds the way back from any switch sat under the crewmate rows. Its hint also ran to two sentences about workspace and memory that the pick itself does not need.Why it matters
The templates group is where a plain chat's default lives (the ★ badge). Reading it first makes the picker open on the row most sessions run, with crewmates as the second choice below it.
Not a goal
AgentSelector(groupByKind) order.useAgentsoffers (withoutCoveredCrewmates) or the ★ default semantics.What changed (motivation → approach → change)
Symptom: Crewmates header above Custom agents in the chat picker. Cause:
AgentDropdownList.tsxiterates the literal['member', 'template']. Change: the literal is now['template', 'member']with a one-line comment on why templates lead; the chat picker's hint moves to its own key,components.agentDropdownList.group_templates_hint, holding one sentence ("A custom agent is a reusable agent setup.") inen.manual.jsonand every shipped locale, each the first sentence of that locale's existing hint;en-XA.jsonis regenerated withnpm run i18n:pseudo. The shared keygroup_templates_hint_default_workspaceand its value are untouched, so the schedule form'sAgentSelectorhint reads exactly as before. The one-sentence hint is the maintainer's explicit request (Zezhen, 2026-10-13), recorded in the PR comment on the Goal edit. The spec sentence indocs/system-specs/modules/crew-mode.mdand the feature-map row indocs/feature-map/README.mdthat name the order are updated in the same commit. A screenshot harness (website/scripts/capture-agent-picker-templates-first.mjs) asserts the group order and the hint before writing the frames below.Backwards compatibility
Compatible: render order of two existing groups and one added i18n key; no existing key, prop, route or type changes.
Removes nothing: both groups, every row and the hint still render; only their vertical order changes.
Tests
website/src/test/AgentDropdownList.test.tsx— the grouped-view test now asserts['Custom agents', 'Crewmates']as therole="group"order; the option-index tests (select kind, avatar, aria-selected) follow the new row order; the hint assertions match the one-sentence hint.website/src/test/JobForm.agentGroups.test.tsx— unchanged and still passing: the schedule form's hint text did not change.Manual verification
Real built SPA behind the shared stub (
node scripts/capture-agent-picker-templates-first.mjs) withcrewmates_in_agent_picker: trueand a mixed catalog: the harness asserts the two group labels in the new order and the shortened hint under the first group, then writes the frames below in light and dark.Screenshots / video
Light:
Dark:
Full chat page, light
Related Issues
Closes #19987
Follow-up (deferred, out of this PR's goal): #20227 — the Crewmates group can sit below the pop-up's visible edge once templates lead; height or scroll cue.
Hint wording: the one-sentence hint was chosen by the maintainer (Zezhen, 2026-10-13, dashboard chat; restated by the author in the Goal-edit comment on this PR). A
docs/decisions/entry needs the maintainer's own on-record comment (decisions README rule 4) and is not part of this PR.Pattern harvest
Not generalizable: a deliberate ordering choice of two UI groups, not a defect class.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.